Compare commits

4 Commits

Author SHA1 Message Date
e1d514d905 Merge pull request 'Don't break on icon size "any"' (#5) from bugfix/size_any into master
All checks were successful
continuous-integration/drone/push Build is passing
Reviewed-on: #5
2024-08-14 13:52:04 +00:00
339508bf41 Don't break on icon size "any"
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
... and any other strings failing to match the "sizes" number format
for that matter
2024-08-14 15:46:58 +02:00
45a43ce73d Update lockfile
All checks were successful
continuous-integration/drone/push Build is passing
2024-08-14 15:46:35 +02:00
f31800a2d4 Ignore build files
All checks were successful
continuous-integration/drone/push Build is passing
2024-02-02 17:50:54 +02:00
4 changed files with 4 additions and 2 deletions

1
.gitignore vendored
View File

@@ -7,3 +7,4 @@
/spec/reports/
/tmp/
.rspec_status
*.gem

View File

@@ -1,7 +1,7 @@
PATH
remote: .
specs:
manifique (1.0.0)
manifique (1.0.1)
faraday (~> 2.9.0)
faraday-follow_redirects (= 0.3.0)
nokogiri (~> 1.16.0)

View File

@@ -47,7 +47,7 @@ module Manifique
end
if options[:sizes]
results.reject! { |r| r["sizes"].nil? }
results.reject! { |r| r["sizes"].nil? || r["sizes"].match(/(\d+)x/).nil? }
results.sort! { |a, b| sizes_to_i(b["sizes"]) <=> sizes_to_i(a["sizes"]) }
if icon = select_exact_size(results, options[:sizes])

View File

@@ -105,6 +105,7 @@ def icon_fixtures
{"src"=>"/application_icon_x228.png", "sizes"=>"228x228", "type"=>"image/png"},
{"src"=>"/application_icon_x196.png", "sizes"=>"196x196", "type"=>"image/png"},
{"src"=>"/application_icon_x192.png", "sizes"=>"192x192", "type"=>"image/png"},
{"src"=>"/icon-maskable.svg", "type"=>"image/svg+xml", "sizes"=>"any", "purpose"=>"maskable"},
{"purpose"=>"apple-touch-icon", "src"=>"/apple-touch-icon.png", "sizes"=>"180x180", "type"=>"image/png" },
{"purpose"=>"apple-touch-icon", "src"=>"/apple-touch-icon-57px.png", "sizes"=>"57x57", "type"=>"image/png"},
{"purpose"=>"mask-icon", "src"=>"/mask-icon.svg", "type"=>"image/svg", "color"=>"#2b90d9"}