Test table view notifications for deselectAll. Verify absence of CPTableViewSelectionIsChangingNotification when changing programmatically.

AppKit/CPOutlineView.j

@@ -836,29 +836,24 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
                           name:CPOutlineViewSelectionIsChangingNotification
                         object:self];
 
-
-
         if ([_outlineViewDelegate respondsToSelector:@selector(outlineViewItemWillExpand:)])
             [defaultCenter
                 removeObserver:_outlineViewDelegate
                           name:CPOutlineViewItemWillExpandNotification
                         object:self];
 
-
         if ([_outlineViewDelegate respondsToSelector:@selector(outlineViewItemDidExpand:)])
             [defaultCenter
                 removeObserver:_outlineViewDelegate
                           name:CPOutlineViewItemDidExpandNotification
                         object:self];
 
-
         if ([_outlineViewDelegate respondsToSelector:@selector(outlineViewItemWillCollapse:)])
             [defaultCenter
                 removeObserver:_outlineViewDelegate
                           name:CPOutlineViewItemWillCollapseNotification
                         object:self];
 
-
         if ([_outlineViewDelegate respondsToSelector:@selector(outlineViewItemDidCollapse:)])
             [defaultCenter
                 removeObserver:_outlineViewDelegate
@@ -935,7 +930,6 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
             name:CPOutlineViewSelectionIsChangingNotification
             object:self];
 
-
     if ([_outlineViewDelegate respondsToSelector:@selector(outlineViewItemWillExpand:)])
         [defaultCenter
             addObserver:_outlineViewDelegate

AppKit/CPTableView.j

@@ -3989,7 +3989,7 @@ Your delegate can implement this method to avoid subclassing the tableview to ad
 {
     var row = [self rowAtPoint:aPoint];
 
-    //if the user clicks outside a row then deselect everything
+    // If the user clicks outside a row then deselect everything.
     if (row < 0 && _allowsEmptySelection)
         [self selectRowIndexes:[CPIndexSet indexSet] byExtendingSelection:NO];
 

Tests/AppKit/CPTableViewTest.j

@@ -6,6 +6,7 @@
     CPTableColumn   tableColumn;
 
     BOOL            doubleActionReceived;
+    int             selectionIsChangingNotificationsReceived;
     int             selectionDidChangeNotificationsReceived;
 }
 
@@ -51,20 +52,28 @@
     [tableView setDataSource:dataSource];
 
 
+    selectionIsChangingNotificationsReceived = 0;
     selectionDidChangeNotificationsReceived = 0;
+    [[CPNotificationCenter defaultCenter] addObserver:self
+                                             selector:@selector(selectionIsChanging:)
+                                                 name:CPTableViewSelectionIsChangingNotification
+                                               object:tableView];
+
     [[CPNotificationCenter defaultCenter] addObserver:self
                                              selector:@selector(selectionDidChange:)
                                                  name:CPTableViewSelectionDidChangeNotification
                                                object:tableView];
 
     [tableView selectRowIndexes:[CPIndexSet indexSetWithIndex:2] byExtendingSelection:NO];
-    [self assert:selectionDidChangeNotificationsReceived equals:1 message:"CPTableViewSelectionDidChangeNotification expected when selecting rows"];
+    [self assert:0 equals:selectionIsChangingNotificationsReceived message:"no isChanging notifications when programmatically selecting rows"];
+    [self assert:1 equals:selectionDidChangeNotificationsReceived message:"didChange notifications when selecting rows"];
 
     // If we remove the last row, the selection should change and we should be notified.
     [[dataSource tableEntries] removeObjectAtIndex:2];
     [tableView reloadData];
 
-    [self assert:selectionDidChangeNotificationsReceived equals:2  message:"CPTableViewSelectionDidChangeNotification when selected rows go away"];
+    [self assert:0 equals:selectionIsChangingNotificationsReceived message:"no isChanging notifications when selected rows disappear"];
+    [self assert:2 equals:selectionDidChangeNotificationsReceived message:"didChange notifications when selected rows disappear"];
 
     [tableView selectRowIndexes:[CPIndexSet indexSetWithIndex:0] byExtendingSelection:NO];
     [self assert:selectionDidChangeNotificationsReceived equals:3 message:"CPTableViewSelectionDidChangeNotification expected when selecting rows"];
@@ -72,6 +81,26 @@
     [tableView reloadData];
 
     [self assert:selectionDidChangeNotificationsReceived equals:3 message:"no CPTableViewSelectionDidChangeNotification expected when removing a row which does not change the selection"];
+
+    // Reset everything.
+    [dataSource setTableEntries:["A", "B", "C"]];
+    [tableView reloadData];
+    [tableView deselectAll];
+    selectionIsChangingNotificationsReceived = 0;
+    selectionDidChangeNotificationsReceived = 0;
+    [tableView selectRowIndexes:[CPIndexSet indexSetWithIndex:0] byExtendingSelection:NO];
+    [tableView selectRowIndexes:[CPIndexSet indexSetWithIndex:2] byExtendingSelection:NO];
+    [self assert:2 equals:selectionDidChangeNotificationsReceived message:"notification for select row 0, 2"];
+
+    selectionIsChangingNotificationsReceived = 0;
+    selectionDidChangeNotificationsReceived = 0;
+    [tableView deselectAll];
+    [self assert:selectionDidChangeNotificationsReceived equals:2 message:"notification for deselect all"];
+}
+
+- (void)selectionIsChanging:(CPNotification)aNotification
+{
+    selectionIsChangingNotificationsReceived++;
 }
 
 - (void)selectionDidChange:(CPNotification)aNotification