colby/cappuccino
1
0
Fork 0
mirror of https://github.com/cappuccino/cappuccino.git synced 2026-08-25 04:57:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed: - CPTextField deleteBackward: required selection.

Browse Source 
According to the spec, deleteBackward: should remove the element before the insertion point if there is no selection (e.g. actually delete backwards).
This commit is contained in:
Alexander Ljungberg
2013-08-19 22:31:21 +01:00
parent 168738fb93
commit 9d43a559fe
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
AppKit/CPTextField.j
+8 -3
View File
@@ -1506,10 +1506,15 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
var selectedRange = [self selectedRange];
// FIXME Is deleteBackward: meant to delete the character before the caret if there's no
// selection? There's no official documentation on deleteBackward: in Cocoa.
if (selectedRange.length < 1)
return;
{
if (selectedRange.location < 1)
return;
// Delete a single element backward from the insertion point if there's no selection.
selectedRange.location -= 1;
selectedRange.length += 1;
}
var newValue = [_stringValue stringByReplacingCharactersInRange:selectedRange withString:""];