Fixed: attached sheet shadow had extra width, was too dark

Previously the attached sheet shadow (that appears below the title bar of the window a sheet is attached to) was 9x8, and it was quite dark.

With this commit the width has been reduced to 1 (to reduce the image size) and it has been lightened up.

Also changed "height-shadow" theme attribute to "shadow-height".
This commit is contained in:
Aparajita Fishman committed 2013-03-12 10:20:13 -04:00
1 parent 2dca00c4a0
commit f208ff52fd
6 files changed
+11 -16

No files matched your search

+3 -3
View File
@@ -38,7 +38,7 @@
{
return @{
@"body-color": [CPColor whiteColor],
@"height-shadow": 8,
@"shadow-height": 8,
};
}
@@ -68,7 +68,7 @@
[self addSubview:_bodyView];
_shadowView = [[CPView alloc] initWithFrame:CGRectMake(0, 0, _CGRectGetWidth(bounds), [self valueForThemeAttribute:@"height-shadow"])];
_shadowView = [[CPView alloc] initWithFrame:CGRectMake(0, 0, _CGRectGetWidth(bounds), [self valueForThemeAttribute:@"shadow-height"])];
[_shadowView setAutoresizingMask:CPViewWidthSizable];
[self addSubview:_shadowView];
}
@@ -99,7 +99,7 @@
[_bodyView setBackgroundColor:[self valueForThemeAttribute:@"body-color"]];
[_shadowView setFrame:CGRectMake(0,0, _CGRectGetWidth(bounds), [self valueForThemeAttribute:@"height-shadow"])];
[_shadowView setFrame:CGRectMake(0, 0, _CGRectGetWidth(bounds), [self valueForThemeAttribute:@"shadow-height"])];
[_shadowView setBackgroundColor:[self valueForThemeAttribute:@"attached-sheet-shadow-color"]];
}
Binary file not shown.

Before

Width:  |  Height:  |  Size: 106 B

After

Width:  |  Height:  |  Size: 616 B

+5 -5
View File
@@ -2327,7 +2327,7 @@ var themedButtonValues = nil,
{
var windowView = [[_CPWindowView alloc] initWithFrame:CGRectMakeZero()],
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 9, 8),
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 1, 8),
resizeIndicator = PatternImage(@"window-resize-indicator.png", 12, 12),
shadowColor = PatternColor(
@@ -2457,7 +2457,7 @@ var themedButtonValues = nil,
minimizeButtonImage = PatternImage(@"window-standard-minimize-button.png",16, 16),
minimizeButtonImageHighlighted = PatternImage(@"window-standard-minimize-button-highlighted.png",16, 16),
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 9, 8),
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 1, 8),
resizeIndicator = PatternImage(@"window-resize-indicator.png", 12, 12),
themeValues =
@@ -2503,7 +2503,7 @@ var themedButtonValues = nil,
+ (_CPDocModalWindowView)themedDocModalWindowView
{
var docModalWindowView = [[_CPDocModalWindowView alloc] initWithFrame:CGRectMake(0,0,200,200) styleMask:nil],
var docModalWindowView = [[_CPDocModalWindowView alloc] initWithFrame:CGRectMake(0, 0, 200, 200) styleMask:nil],
bezelColor = PatternColor(
[
@@ -2518,12 +2518,12 @@ var themedButtonValues = nil,
[@"window-standard-bottom-right.png", 2.0, 2.0]
]),
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 9, 8),
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 1, 8),
themeValues =
[
[@"body-color", bezelColor],
[@"height-shadow", 8],
[@"shadow-height", 8],
[@"attached-sheet-shadow-color", sheetShadow]
];
Binary file not shown.

Before

Width:  |  Height:  |  Size: 106 B

After

Width:  |  Height:  |  Size: 616 B

+3 -8
View File
@@ -1773,7 +1773,7 @@ var themedButtonValues = nil,
{
var windowView = [[_CPWindowView alloc] initWithFrame:CGRectMakeZero(0.0, 0.0, 200, 200)],
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 9, 8),
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 1, 8),
resizeIndicator = PatternImage(@"window-resize-indicator.png", 12, 12),
shadowColor = PatternColor(
@@ -1890,7 +1890,6 @@ var themedButtonValues = nil,
minimizeButtonImage = PatternImage(@"window-standard-minimize-button.png", 16, 16),
minimizeButtonImageHighlighted = PatternImage(@"window-standard-minimize-button-highlighted.png", 16, 16),
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 9, 8),
resizeIndicator = PatternImage(@"window-resize-indicator.png", 12, 12),
themeValues =
@@ -1930,7 +1929,6 @@ var themedButtonValues = nil,
[@"close-image-origin", CGPointMake(8.0, 10.0)],
[@"resize-indicator", resizeIndicator],
[@"attached-sheet-shadow-color", sheetShadow],
[@"size-indicator", CGSizeMake(12, 12)]
];
@@ -1951,13 +1949,10 @@ var themedButtonValues = nil,
height: 5.0
}),
sheetShadow = PatternColor(@"window-attached-sheet-shadow.png", 9, 8),
themeValues =
[
[@"body-color", bezelColor],
[@"height-shadow", 8],
[@"attached-sheet-shadow-color", sheetShadow]
[@"body-color", bezelColor],
[@"shadow-height", 8]
];
[self registerThemeValues:themeValues forView:docModalWindowView inherit:themedWindowViewValues];