colby/cappuccino
1
0
Fork 0
mirror of https://github.com/cappuccino/cappuccino.git synced 2026-08-30 23:43:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

New: Allow lazy loading control for combined observer key paths (#2854)

Browse Source 
This pull request adds a kvoValueForKey: method used by _CPKVOForwardingObserver for getting values.
The default action is to just return the valueForKey value.
Override this method if you want any other behavior.
It can be used to just return nil if you are implementing a lazy load behavior on a class.
It can allow a combined binding to observe this object without trigger any lazy loading.
This commit is contained in:
Martin Carlberg
2019-11-28 09:38:55 +01:00
committed by GitHub
parent aaed1a934e
commit fed0703ecf
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Foundation/CPKeyValueObserving.j
+15 -3
View File
@@ -224,6 +224,18 @@
}
}
/*!
This valueForKey method is used by _CPKVOForwardingObserver when getting values.
The default action is to just return the valueForKey value.
Override this method if you want any other behavior.
It can be used to just return nil if you are implementing a lazy load behaviour on a class.
It can allow a combined binding to observe this object without trigger any lazy loading.
*/
- (id)kvoValueForKey:(CPString)aKey
{
return [self valueForKey:aKey];
}
@end
@implementation CPDictionary (KeyValueObserving)
@@ -1287,7 +1299,7 @@ var kvoNewAndOld = CPKeyValueObservingOptionNew | CPKeyValueObservingOpti
[_object addObserver:self forKeyPath:_firstPart options:_options context:nil];
//the current value of a (not the value of a.b)
_value = [_object valueForKey:_firstPart];
_value = [_object kvoValueForKey:_firstPart];
if (_value)
[_value addObserver:self forKeyPath:_secondPart options:_options context:nil]; //we're observing b on current a
@@ -1314,7 +1326,7 @@ var kvoNewAndOld = CPKeyValueObservingOptionNew | CPKeyValueObservingOpti
if (!isBeforeFlag && (_options & CPKeyValueObservingOptionNew))
{
var newValue = [_object valueForKeyPath:_firstPart + "." + _secondPart];
var newValue = [[_object kvoValueForKey:_firstPart] valueForKeyPath:_secondPart];
[pathChanges setObject:newValue != null ? newValue : [CPNull null] forKey:CPKeyValueChangeNewKey];
}
@@ -1327,7 +1339,7 @@ var kvoNewAndOld = CPKeyValueObservingOptionNew | CPKeyValueObservingOpti
if (_value)
[_value removeObserver:self forKeyPath:_secondPart];
_value = [_object valueForKey:_firstPart];
_value = [_object kvoValueForKey:_firstPart];
if (_value)
[_value addObserver:self forKeyPath:_secondPart options:_options context:nil];