colby/cappuccino
1
0 Fork 0
mirror of https://github.com/cappuccino/cappuccino.git synced 2026-10-07 17:38:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,150 Commits 13 Branches 92 Tags
698f2fe77ffc9b7f0dbcdcdcb01e257b4fc4bab6
Commit Graph
3150 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Aparajita Fishman 698f2fe77f Call to NS_initWithCoder MUST be first, later code relies on a properly constructed object. 2010-08-21 19:39:02 -04:00
Aparajita Fishman e9607dc764 Ensure CPControl -performClick unhighlights the button if the action throws. 2010-08-21 11:31:31 -04:00
Aparajita Fishman 28b0242eb1 For consistency with Cocoa, -setKeyEquivalent should be sent to set the theme state of the button, regardless of whether it ends up being the default button or not. 2010-08-21 10:07:40 -04:00
Aparajita Fishman 0b2a3b4ade Test app for default button fixes 2010-08-21 09:54:32 -04:00
Aparajita Fishman 0fe41e8b86 Default button fixes... 
- CPButton -setKeyEquivalent was sending CPWindow -setDefaultButton. This is not Cocoa behavior, but more importantly it was causing an infinite loop, because CPWindow -setDefaultButton does (and is supposed to) send CPButton -setKeyEquivalent.

- CPButton -viewWillMoveToWindow should do nothing if the window is the same or the new window is nil. Otherwise, if the new window is nil and the button is the default button, -setDefaultButton ends up erasing the button's key equivalent. When awakening from a cib, this causes the button to never become the default, because during cib awakening -viewWillMoveToWindow is sent 3 times, the second time to a nil window. If a button does not belong to any window, there is no harm in keeping its key equivalent, and setting the default button is supposed to be an explicit operation.

- NSButton -initWithCoder should not send -setKeyEquivalent because it has side effects.

- CPWindow -setDefaultButton should check for a key equivalent of CPNewlineCharacter as well for consistency with CPButton.
 2010-08-21 09:52:59 -04:00
Aparajita Fishman 56b9e792e0 Merge remote branch 'refs/remotes/280north/master' into my_master 
Conflicts:
	AppKit/CPBox.j
 2010-08-12 19:10:10 -04:00
Randall Luecke ee9da8e31e Only call drawRect: is the view is visible. 2010-08-12 16:03:24 -05:00
cacaodev 23e9fd927c CPBox: Made CPBezelType the default type instead of none. 
Slighly grayed stroke color for bezel type & fillColor for all types to better match cocoa
       Fix contentView autoresizingMask
 2010-08-12 15:16:20 -05:00
Randall Luecke 22c481ff27 Implemented allKeysForObject: in CPDictionary with tests. 2010-08-12 14:18:45 -05:00
Randall Luecke 14fb769582 Removed ambiguity in CPDictionary keys type. Closes #700 2010-08-12 13:29:17 -05:00
Randall Luecke da0af13142 Added basic suppport for CPOutlineView in the nib2cib tool 
Conflicts:

	AppKit/CPOutlineView.j
 2010-08-12 13:11:41 -05:00
Aparajita Fishman 026c9ae6e3 Whitespace fixes :), added missed initialization of loop var, added encodeWithCoder, in some cases it is invoked 2010-08-12 11:11:33 -04:00
Aparajita Fishman 1d21dc8b95 Merge branch 'master' of http://github.com/280north/cappuccino into my_master 
Conflicts:
	AppKit/CPGraphics.j
	AppKit/CPScrollView.j
	AppKit/CPTableView.j
	AppKit/CPTextField.j
 2010-08-12 10:35:56 -04:00
Aparajita Fishman ca9d09134f Multiple fixes... 
1. CPRadio should not draw its background color by default when created from a nib.

2. Substituted named constants for magic number bit flags.

3. Don't set the matrix view background color unless the nib said to draw its background.

4. NIB_CONNECTION_EQUIVALENCY_TABLE wants UIDs, changed self -> [self UID].
 2010-08-12 01:12:21 -04:00
Aparajita Fishman 29c857b1e9 Have to send -reloadData to force the dataview frames to be recalculated. 2010-08-12 00:54:30 -04:00
Aparajita Fishman 44fb4a9b83 -setIntercellSpacing should update the header as well as the table, per Cocoa (and common sense) 2010-08-11 23:21:30 -05:00
Randall Luecke 1e6f6879ff Run CPArrayPerformanceTest with jake test. 2010-08-11 23:17:38 -05:00
Alexander Ljungberg ba33bb56d0 Moved the visual table test for borders into the TableTest folder. 2010-08-12 00:08:43 -04:00
Aparajita Fishman ab5e2dd774 Fix for issue #816 (NSTableView/CPTableView do not read selection highlight style and column resizing style) 2010-08-12 00:06:52 -04:00
Aparajita Fishman 0b1b1bbe0b Fix for issue #817 (Support for alignment and line break mode in NSTextField/CPTextField) 2010-08-11 23:53:34 -04:00
Alexander Ljungberg 1aebc8942d Merge branch 'master' of github.com:280north/cappuccino 2010-08-11 23:35:26 -04:00
Alexander Ljungberg 233df3bdab Fixed: the "fix for column reordering with hidden columns" sometimes caused the table view to try to remove nonexistent data views and crash. The fix is to consider a nonexistent data view already removed and just move on. 2010-08-11 23:33:21 -04:00
Randall Luecke dd9c085ae3 Fix for new sort being unstable with a huge thanks to Shon Frazier. Reviewed by Me and Alexander Ljungberg. 2010-08-11 22:33:14 -05:00
Alexander Ljungberg 1fed798120 Fixed: CPGraphics.j was not imported anywhere so the CPScrollView borders changes didn't work. Also minor code cleanup. 2010-08-11 23:07:05 -04:00
Aparajita Fishman fcf9c0bc84 Full support for all NSScrollView border types, beginnings of a new tableview tester that shows dynamic changing of border type. 2010-08-11 22:49:37 -04:00
Aparajita Fishman fd9a753170 Port of NSGraphics 2010-08-11 22:49:31 -04:00
Aparajita Fishman d5dc03fb2f -setIntercellSpacing should update the header as well as the table, per Cocoa (and common sense) 2010-08-11 22:39:57 -04:00
Randall Luecke 2a5f4b98ed Merge branch 'master' of git://github.com/280north/cappuccino 2010-08-11 20:30:17 -05:00
David Hess ad33d1648c Patch to CPSlider to invert its value in vertical mode so that max value is represented at the top of the track instead of the bottom. 2010-08-11 20:29:46 -05:00
Alexander Ljungberg 1f784f46c7 Merge branch 'master' of github.com:280north/cappuccino 2010-08-11 20:24:29 -04:00
Randall Luecke ed52b44f8b Removed redundent methods in the tableview. Closes #822 2010-08-11 19:07:13 -05:00
Randall Luecke 4b8cc3e6d1 Table column drag view should draw lines the same color as the parent tableview. 2010-08-11 18:39:16 -05:00
Alexander Ljungberg 6b8e10cb2e Whitespace cleanup of CPShadowView. 2010-08-11 19:20:10 -04:00
Aparajita Fishman 952bb4bb7c added CPShadow shadowViewEnclosingView 2010-08-11 19:18:52 -04:00
Aparajita Fishman a0bcae2404 The Cocoa default is always to draw column lines, this wasn't being set in CPTableColumnView. 2010-08-11 18:16:48 -05:00
Aparajita Fishman cbdfc1add9 The Cocoa default is always to draw column lines, this wasn't being set in CPTableColumnView. 2010-08-11 19:00:44 -04:00
Aparajita Fishman f6d09557af Revert this change, it breaks text labels >12pt 2010-08-11 18:37:39 -04:00
Randall Luecke 567f54c9f9 Fix global from error in previous mergre. 2010-08-11 17:32:50 -05:00
Aparajita Fishman 66f84ede6e Fix for issue #799 (NSFont replaces LucidaGrande-Bold 13 with the theme font) 2010-08-11 17:16:44 -05:00
Aparajita Fishman 5b1ca8a7f9 Fix for issue #807 (NSTextField sets text color unconditionally, which causes theme lookup failure later) 2010-08-11 17:07:51 -05:00
Aparajita Fishman 4fc894e430 Fix for issue #820 (horizontal grid drawn incorrectly with no rows) 2010-08-11 16:58:05 -05:00
cacaodev 15356b617b DrawRowTest that was announced in the previous commit 2010-08-11 16:32:26 -05:00
cacaodev c8f6e12586 CPTableView: Implement -drawRow:clipRect: . The method is called only when a tableview subclass implements it for performance reasons. 
DrawRowTest demonstrating the feature.

Conflicts:

	AppKit/CPTableView.j
 2010-08-11 16:32:01 -05:00
Randall Luecke 102cc92991 Merge branch 'master' of git://github.com/280north/cappuccino 2010-08-11 16:12:43 -05:00
Randall Luecke 1e490f1796 Fix for column reordering with hidden columns. Closes #637 2010-08-11 15:59:04 -05:00
Aparajita Fishman 8dfdf63c65 Reverting to original 2010-08-11 16:38:13 -04:00
Aparajita Fishman 8a835c287f Fix for issue #820 (horizontal grid drawn incorrectly with no rows) 2010-08-11 15:29:28 -04:00
Aparajita Fishman 088a5c7166 Remove extra call to _init in -initWithCoder: 2010-08-11 12:23:47 -04:00
Aparajita Fishman 1e3958652a Merge branch 'refs/heads/master' into my_master 
Conflicts:
	AppKit/CPSearchField.j
	AppKit/CPTableView.j
	AppKit/CPTextField.j
	Jakefile
	Tools/nib2cib/NSTableView.j
 2010-08-11 10:27:35 -04:00
Randall Luecke 5837533678 Use a default TableView. 2010-08-10 20:58:04 -05:00