Commit Graph
1704 Commits
Author SHA1 Message Date
Aparajita Fishman e9607dc764 Ensure CPControl -performClick unhighlights the button if the action throws. 2010-08-21 11:31:31 -04:00
Aparajita Fishman 0fe41e8b86 Default button fixes...
- CPButton -setKeyEquivalent was sending CPWindow -setDefaultButton. This is not Cocoa behavior, but more importantly it was causing an infinite loop, because CPWindow -setDefaultButton does (and is supposed to) send CPButton -setKeyEquivalent.

- CPButton -viewWillMoveToWindow should do nothing if the window is the same or the new window is nil. Otherwise, if the new window is nil and the button is the default button, -setDefaultButton ends up erasing the button's key equivalent. When awakening from a cib, this causes the button to never become the default, because during cib awakening -viewWillMoveToWindow is sent 3 times, the second time to a nil window. If a button does not belong to any window, there is no harm in keeping its key equivalent, and setting the default button is supposed to be an explicit operation.

- NSButton -initWithCoder should not send -setKeyEquivalent because it has side effects.

- CPWindow -setDefaultButton should check for a key equivalent of CPNewlineCharacter as well for consistency with CPButton.
2010-08-21 09:52:59 -04:00
Aparajita Fishman 56b9e792e0 Merge remote branch 'refs/remotes/280north/master' into my_master
Conflicts:
	AppKit/CPBox.j
2010-08-12 19:10:10 -04:00
Randall Luecke ee9da8e31e Only call drawRect: is the view is visible. 2010-08-12 16:03:24 -05:00
cacaodev 23e9fd927c CPBox: Made CPBezelType the default type instead of none.
Slighly grayed stroke color for bezel type & fillColor for all types to better match cocoa
       Fix contentView autoresizingMask
2010-08-12 15:16:20 -05:00
Randall Luecke da0af13142 Added basic suppport for CPOutlineView in the nib2cib tool
Conflicts:

	AppKit/CPOutlineView.j
2010-08-12 13:11:41 -05:00
Aparajita Fishman 1d21dc8b95 Merge branch 'master' of http://github.com/280north/cappuccino into my_master
Conflicts:
	AppKit/CPGraphics.j
	AppKit/CPScrollView.j
	AppKit/CPTableView.j
	AppKit/CPTextField.j
2010-08-12 10:35:56 -04:00
Aparajita Fishman 29c857b1e9 Have to send -reloadData to force the dataview frames to be recalculated. 2010-08-12 00:54:30 -04:00
Aparajita Fishman 44fb4a9b83 -setIntercellSpacing should update the header as well as the table, per Cocoa (and common sense) 2010-08-11 23:21:30 -05:00
Aparajita Fishman ab5e2dd774 Fix for issue #816 (NSTableView/CPTableView do not read selection highlight style and column resizing style) 2010-08-12 00:06:52 -04:00
Aparajita Fishman 0b1b1bbe0b Fix for issue #817 (Support for alignment and line break mode in NSTextField/CPTextField) 2010-08-11 23:53:34 -04:00
Alexander Ljungberg 233df3bdab Fixed: the "fix for column reordering with hidden columns" sometimes caused the table view to try to remove nonexistent data views and crash. The fix is to consider a nonexistent data view already removed and just move on. 2010-08-11 23:33:21 -04:00
Alexander Ljungberg 1fed798120 Fixed: CPGraphics.j was not imported anywhere so the CPScrollView borders changes didn't work. Also minor code cleanup. 2010-08-11 23:07:05 -04:00
Aparajita Fishman fcf9c0bc84 Full support for all NSScrollView border types, beginnings of a new tableview tester that shows dynamic changing of border type. 2010-08-11 22:49:37 -04:00
Aparajita Fishman fd9a753170 Port of NSGraphics 2010-08-11 22:49:31 -04:00
Aparajita Fishman d5dc03fb2f -setIntercellSpacing should update the header as well as the table, per Cocoa (and common sense) 2010-08-11 22:39:57 -04:00
Randall Luecke 2a5f4b98ed Merge branch 'master' of git://github.com/280north/cappuccino 2010-08-11 20:30:17 -05:00
David Hess ad33d1648c Patch to CPSlider to invert its value in vertical mode so that max value is represented at the top of the track instead of the bottom. 2010-08-11 20:29:46 -05:00
Alexander Ljungberg 1f784f46c7 Merge branch 'master' of github.com:280north/cappuccino 2010-08-11 20:24:29 -04:00
Randall Luecke ed52b44f8b Removed redundent methods in the tableview. Closes #822 2010-08-11 19:07:13 -05:00
Randall Luecke 4b8cc3e6d1 Table column drag view should draw lines the same color as the parent tableview. 2010-08-11 18:39:16 -05:00
Alexander Ljungberg 6b8e10cb2e Whitespace cleanup of CPShadowView. 2010-08-11 19:20:10 -04:00
Aparajita Fishman 952bb4bb7c added CPShadow shadowViewEnclosingView 2010-08-11 19:18:52 -04:00
Randall Luecke 567f54c9f9 Fix global from error in previous mergre. 2010-08-11 17:32:50 -05:00
Aparajita Fishman 4fc894e430 Fix for issue #820 (horizontal grid drawn incorrectly with no rows) 2010-08-11 16:58:05 -05:00
cacaodev c8f6e12586 CPTableView: Implement -drawRow:clipRect: . The method is called only when a tableview subclass implements it for performance reasons.
DrawRowTest demonstrating the feature.

Conflicts:

	AppKit/CPTableView.j
2010-08-11 16:32:01 -05:00
Randall Luecke 102cc92991 Merge branch 'master' of git://github.com/280north/cappuccino 2010-08-11 16:12:43 -05:00
Randall Luecke 1e490f1796 Fix for column reordering with hidden columns. Closes #637 2010-08-11 15:59:04 -05:00
Aparajita Fishman 8dfdf63c65 Reverting to original 2010-08-11 16:38:13 -04:00
Aparajita Fishman 8a835c287f Fix for issue #820 (horizontal grid drawn incorrectly with no rows) 2010-08-11 15:29:28 -04:00
Aparajita Fishman 088a5c7166 Remove extra call to _init in -initWithCoder: 2010-08-11 12:23:47 -04:00
Aparajita Fishman 1e3958652a Merge branch 'refs/heads/master' into my_master
Conflicts:
	AppKit/CPSearchField.j
	AppKit/CPTableView.j
	AppKit/CPTextField.j
	Jakefile
	Tools/nib2cib/NSTableView.j
2010-08-11 10:27:35 -04:00
Randall Luecke 33e4a082d6 Some visual changes to column dragging to make it a bit more like cocoa. 2010-08-09 18:43:11 -05:00
Randall Luecke 13b2a886f3 Changed CPRect and CPPoint functions to _CG 2010-08-09 17:36:33 -05:00
Randall Luecke 96958d26c7 Accidental globals. 2010-08-09 17:22:14 -05:00
Alexander Ljungberg 0b21b8bab1 Merge branch 'master' of github.com:280north/cappuccino 2010-08-09 17:54:30 -04:00
Alexander Ljungberg 271bb00147 Marginally faster filter and sort in CPArrayController's arrangeObjects (4% in the performance tester.) Reduced memory usage when both a filter and a sort order are applied. Cleanup of the tester and a filter only test run. 2010-08-09 17:31:36 -04:00
Randall Luecke b346d761d8 Fix bug so we can drag items below the last child index in the outlineView. 2010-08-09 14:13:04 -05:00
Randall Luecke 21614e15b2 Draw column header lines by default. 2010-08-09 14:05:58 -05:00
Aparajita Fishman dc6e7aefe4 Fix for issue #817 (Support for alignment and line break mode in NSTextField/CPTextField) 2010-08-09 10:16:36 -04:00
Aparajita Fishman 0adfd30ea3 Fix for issue #816 (NSTableView/CPTableView do not read selection highlight style and column resizing style) 2010-08-09 09:59:57 -04:00
Aparajita Fishman 6e24bba8a3 Made the new theming mechanism generic (see ecbbe57) 2010-08-03 15:58:37 -04:00
Alexander Ljungberg 8c13204afa Save some memory and time in CPTableViewFirstColumnOnlyAutoresizingStyle mode. 2010-08-02 23:28:40 -04:00
Alexander Ljungberg e4c79d2101 Closes #809. End editing of a text field if it is disabled or made uneditable. Manual test included. 2010-08-02 23:13:06 -04:00
Aparajita Fishman ecbbe57709 Radically simplified the whole theming mechanism. Theming can now be done declaratively with less typing, better readability, easier maintenance.
Also fixed some oversights in the existing themes: text was not dimmed in disabled state for segmented controls, text was not dimmed for default buttons in disabled state in HUD (IIRC).
2010-08-02 18:17:02 -04:00
Randall Luecke 4b9c5e0d64 Removed gradient stuff that has been moved to the theme. 2010-08-02 12:40:46 -04:00
Alexander Ljungberg 2d6f343098 Closes #806. Fixed: if a selected row was removed from a table view, the selection remained and would show up again if a new row was later added. 2010-08-02 12:40:40 -04:00
Alexander Ljungberg a35a67e7f7 Switch to the standard macros in _resizeAllColumnUniformlyWithOldSize as originally intended by Randy Luecke. 2010-08-02 12:40:34 -04:00
Alexander Ljungberg efa2d30737 Eliminated some accidental globals in uniform table column resizing. 2010-08-02 12:40:28 -04:00
Alexander Ljungberg 372ce1e37a Fixed: after the intercell spacing commit, table column auto resizing on the first or last column would result in a total column width wider than the scroll width of the table. This would appear as the rightmost column sticking out and the table showing a horizontal scrollbar. 2010-08-02 12:40:15 -04:00