colby/cappuccino
1
0 Fork 0
mirror of https://github.com/cappuccino/cappuccino.git synced 2026-10-06 17:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,150 Commits 13 Branches 92 Tags
698f2fe77ffc9b7f0dbcdcdcb01e257b4fc4bab6
Commit Graph
51 Commits
Author SHA1 Message Date
Aparajita Fishman 0fe41e8b86 Default button fixes... 
- CPButton -setKeyEquivalent was sending CPWindow -setDefaultButton. This is not Cocoa behavior, but more importantly it was causing an infinite loop, because CPWindow -setDefaultButton does (and is supposed to) send CPButton -setKeyEquivalent.

- CPButton -viewWillMoveToWindow should do nothing if the window is the same or the new window is nil. Otherwise, if the new window is nil and the button is the default button, -setDefaultButton ends up erasing the button's key equivalent. When awakening from a cib, this causes the button to never become the default, because during cib awakening -viewWillMoveToWindow is sent 3 times, the second time to a nil window. If a button does not belong to any window, there is no harm in keeping its key equivalent, and setting the default button is supposed to be an explicit operation.

- NSButton -initWithCoder should not send -setKeyEquivalent because it has side effects.

- CPWindow -setDefaultButton should check for a key equivalent of CPNewlineCharacter as well for consistency with CPButton.
 2010-08-21 09:52:59 -04:00
Randall Luecke 444e48dbf8 some fixes to default buttons to make them more cocoa compliant... 2010-08-02 12:37:10 -04:00
Alexander Ljungberg 4d1baac4db Fixed: first clearing a \r keqyEquivalent from one button and then setting it on another would result in an exception. 2010-07-21 14:57:52 -07:00
Klaas Pieter Annema f40fc321fe Make the window perform it's defaults button's key equivalent after the default keyDown messages are handled 2010-06-16 14:17:58 +02:00
Alexander Ljungberg 44555ac724 UTF compatible CFData base64 string encoder and decoder. Use it for CPButton key equivalent archiving. Also ordered CPText.j constants by value and removed the empty CPText class definition as it caused errors with nib2cib. Fixed: the key equivalent for forward delete (CPDeleteFunctionKey, \uF728) was transformed to '(' (\u0028) when archived and unarchived. 2010-06-11 09:39:19 -07:00
Ross Boucher 421ae6b316 Make CPButton archive its key equivalents, and make nib2cib support the feature. 2010-06-10 10:41:15 -07:00
Alexander Ljungberg c26ebe0bd2 Added support for menu key equivalents such as Escape or Cmd-Delete. Refactored code to recognize key equivalents for reuse between CPMenu and CPButton. Added unit tests for CPMenu key equivalents. 2010-06-07 19:09:15 -04:00
Alexander Ljungberg 381a44148e Special keys such as backspace and escape can now be used as key equivalents through checking for their unicode representations in [CPEvent characters]. This replaces the earlier raw key code approach. 2010-06-07 19:09:10 -04:00
Alexander Ljungberg 44f5086600 Key equivalents for CPButton. 2010-06-07 19:08:44 -04:00
Alexander Ljungberg 3c5dab1f34 Implemented CPCoding for CPButton imageDimsWhenDisabled. Fixed a problem where setImageDimsWhenDisabled:NO would not cause a redraw even if the image was previously dimmed. 2010-05-24 11:17:25 -07:00
Klaas Pieter Annema ee2f361425 Reimplemented setImageDimsWhenDisabled: on CPButton to only dim the image instead of the entire button 2010-05-12 16:51:28 -07:00
Scott Kyle b0d355a71c Some somewhat minor style fixes 2010-03-24 19:46:38 -07:00
Ross Boucher e759c5343b Add a missing import in CPButton, and a test to ensure you can create one on the command line. 2010-02-22 11:07:11 -08:00
Ross Boucher 91681d7846 Move more constants to CPControl.j 2010-02-17 17:06:09 -08:00
Francisco Ryan Tolmasky I bc53288fca Fix for failing CPAttributedString test. 
Reviewed by me.
 2010-02-13 16:14:18 -08:00
Ross Boucher 9a7484e57d Fix Typo. Closes #463. 2010-02-13 12:06:52 -08:00
Francisco Ryan Tolmasky I 4d7f5a8a09 Fix for fixing state after turning setAllowsMixedState to NO. 
Reviewed by me.
 2009-11-17 19:17:58 -08:00
lowell vizon 377f331b47 Documentation Edits: Replaced <code> and <pre> tags with \c; this allows monospaced text to be displayed with formatted text without needing a new line. See AppKit/CPView after generating documentation for examples. Also added - and + signs to the above changes when referring to either an -instanceMethod or a +classMethod. --lowell@cocoastep 
Signed-off-by: Francisco Ryan Tolmasky I <francisco@280north.com>
 2009-08-08 03:50:50 +08:00
Francisco Ryan Tolmasky I 0235076fb6 Fix for typos in CPButton.j. 
Closes #139.

Reviewed by me.
 2009-05-24 14:20:18 -07:00
Francisco Ryan Tolmasky I 4758154014 Fix for mis-sized sizeToFit in CPButton. 
Reviewed by me.
 2009-05-19 12:22:15 -07:00
Francisco Ryan Tolmasky I 6d8e1705b8 Cleaned up button's sizeToFit. 
Reviewed by me.
 2009-05-19 12:02:10 -07:00
Ross Boucher 850125b8ab Add documentation groups 2009-05-18 15:43:36 -07:00
Francisco Tolmasky 94f83a92b7 Added Radio and checkbox classes. 
Remaining works:
- Fix artwork issue
- nib2cib support

Closes #77.

Reviewed by me.
 2009-05-16 15:53:49 -07:00
Francisco Tolmasky 8c1f6f3014 CPButton cleanup from residual pre-theme code. 
Reviewed by me.
 2009-05-15 21:40:11 -07:00
Francisco Tolmasky 862af9cbae First stab at fixing Themeing API. 
Reviewed by me.
 2009-05-10 13:04:02 -07:00
Ross Boucher ae8fd0c2d4 add size to fit for buttons. Closes #34. 2009-05-05 22:10:00 -07:00
Ross Boucher acb1929b49 Add default button style 2009-04-14 01:32:14 -07:00
Ross Boucher 0c63a5aba4 Add defaultButton to CPWindow, set up default key bindings 2009-04-13 21:22:32 -07:00
Francisco Tolmasky e5ea6b242d Fixed Aristo affecting unbordered pop up buttons. 
Reviewed by me.
 2009-03-22 12:40:06 -07:00
Francisco Tolmasky 51ad4b2b06 Further work on CPTextField. 
Reviewed by me.
 2009-02-18 13:06:56 -08:00
Francisco Tolmasky 6ad037e469 Fix for major theme state bug. 
Reviewed by me.
 2009-02-18 02:22:10 -08:00
Francisco Tolmasky 50baf5fd50 Further improvements. 
Reviewed by me.
 2009-02-10 01:12:34 -08:00
Francisco Tolmasky a30e91052e Removed themability from title and image in CPButton. 
Reviewed by me.
 2009-02-07 20:21:03 -08:00
Francisco Tolmasky abd86c676b Theming for CPScroller. 
Reviewed by me.
 2009-02-07 18:38:34 -08:00
Francisco Tolmasky df5f6c692f Additional theme changes. 
Reviewed by me.
 2009-02-05 21:17:59 -08:00
Francisco Ryan Tolmasky I e4b2988864 Added more customizability. 
Reviewed by me.
 2009-02-03 22:47:02 -08:00
Francisco Ryan Tolmasky I c8101d481e Fix spacing issues in CPPopUpButton. 
Reviewed by me.
 2009-01-28 17:20:29 -08:00
Francisco Ryan Tolmasky I d0db80335b Fixed bug where buttons wouldn't shrink after sizeToFitting. 
Reviewed by me.
 2009-01-28 12:38:55 -08:00
Francisco Ryan Tolmasky I f28f2c6e8c Performance improvements to pop up menus. 
Reviewed by me.
 2009-01-27 16:57:46 -08:00
Francisco Ryan Tolmasky I 10b34965bd Added support for cross-browser text shadows in _CPImageAndTextView. 
Reviewed by me.
 2009-01-27 15:41:32 -08:00
Francisco Ryan Tolmasky I 9e7fd7f74f Began integrating new imageandtextview into CPButton. 
Reviewed by me.
 2009-01-27 01:06:21 -08:00
Francisco Ryan Tolmasky I b0d5ca2830 Added vertical alignment support to _CPImageAndTextView. 
Reviewed by me.
 2009-01-26 22:35:01 -08:00
Francisco Ryan Tolmasky I 9e9266712a Changed _CPImageAndTitleView to _CPImageAndTextView. 
Reviewed by me.
 2009-01-23 18:01:05 -08:00
Francisco Ryan Tolmasky I 8de321c780 Final fix for buttons not working when disabled. 
[#188 state:resolved]

Reviewed by me.
 2009-01-21 11:43:45 -08:00
Thomas Balthazar 99f6492f29 work in progress 
Signed-off-by: Francisco Ryan Tolmasky I <francisco@280north.com>
 2009-01-22 00:59:35 +08:00
Francisco Ryan Tolmasky I d92fc8c4d0 Cleaned up old deprecated documentation stuff and added documentation to deploy. 
Reviewed by me.
 2008-12-10 15:57:31 -08:00
Thomas Robinson c992b61ca2 Fixed _imageScaling typos 2008-12-05 19:38:18 -08:00
Francisco Ryan Tolmasky I 5144a5a579 Added @accessor support, @import, and fixed spacing bug with @selector. 
Reviewed by ross.
 2008-10-26 00:48:49 -07:00
Ross Boucher f228934e54 Initial conversion to Doxygen style comments. 2008-10-12 15:57:01 -07:00
Ross Boucher a40fbd7961 Add the first draft of documentation inline. 2008-09-10 15:11:37 -07:00