cacaodev and GitHub
e043b6a8c5
Merge pull request #2978 from daboe01/nib2cib-update
...
fixed: some cib files have been outdated
2021-05-22 10:48:30 +02:00
cacaodev and GitHub
c8cdda0c18
Merge pull request #2962 from mrcarlberg/cptextview_more_ib_options
...
Fixed: CPTextView now handles more options from Interface Builder
2021-03-07 08:48:50 +01:00
cacaodev and GitHub
607e84c052
Merge pull request #2964 from mrcarlberg/compiler_remove_unused
...
Fixed: Removed unused variables and statements in compiler
2020-12-23 07:36:29 +01:00
cacaodev and GitHub
c80504efae
Merge pull request #2960 from mrcarlberg/cptextview_exposedrect
...
Fixed: Prevent crash in CPTextView when _exposedRect is nil
2020-12-19 15:19:19 +01:00
cacaodev and GitHub
2589033523
Merge pull request #2961 from mrcarlberg/radio_multiple_value_bindings_test
...
New: Unit test to illustrate multiple value bindings on radio buttons
2020-12-19 15:18:27 +01:00
cacaodev and GitHub
1e1e6456cd
Merge pull request #2902 from daboe01/test-attributedString-replacing
...
new: unittest for replaceOccurrencesOfString:withString:options:range:
2020-09-02 18:26:14 +02:00
cacaodev and GitHub
6c46bb4756
Merge pull request #2940 from didierkorthoudt/031-CPViewAnimator-fix
...
FIXED: This PR fixes correct parameter type in CPViewAnimator -setAlphaValue
2020-09-02 18:21:45 +02:00
cacaodev and GitHub
89c8f8e80f
Merge pull request #2895 from mrcarlberg/bad_merge
...
Fixed: Removed old unused line from a bad manual merge
2020-05-05 08:38:05 +02:00
cacaodev and GitHub
b7aff28b5e
Merge pull request #2884 from daboe01/documentation-for-attributedStringWithAttachment
...
fixed: documentation for attributedStringWithAttachment: was missing
2020-02-04 13:14:45 +01:00
cacaodev and GitHub
f0897ffdf8
Merge pull request #2885 from mrcarlberg/predicate_not_equal_nil
...
Fixed: CPPredicate does never evaluate to true for 'something != nil'
2020-02-04 13:06:37 +01:00
cacaodev and GitHub
2d96b06d4c
Merge pull request #2878 from didierkorthoudt/CPButton-continous-bug
...
FIXED: Before this PR, disabled buttons that were continuous responded to mouse clicks
2019-12-17 13:27:06 +01:00
cacaodev and GitHub
0c706cfed2
Merge pull request #2866 from mrcarlberg/cpset_enumerator_use_stop_variable
...
Fixed: CPSet enumerateObjectsUsingBlock: will honor the stop variable
2019-12-16 11:27:37 +01:00
cacaodev and Martin Carlberg
623ad2b1dc
Fixed: Previoulsly, clearsFilterPredicateOnInsertion was applied (removes filter predicate) when setting content or on content binding. ( #2860 )
...
With Tests: Foundation unit test.
Solves #2791
2019-11-12 14:02:35 +01:00
cacaodev and GitHub
78cbc3871e
Merge pull request #2852 from mrcarlberg/msg_send_return_undefined_when_receiver_is_undefined
...
New: msgSend will return undefined instead of nil when the receiver is undefined.
2019-08-31 11:28:17 +02:00
cacaodev and GitHub
87fc6bde1d
Merge pull request #2853 from mrcarlberg/optimize_table_column_bindings_with_long_key_paths
...
Fixed: Optimization for bindings with longer key paths in table views.
2019-08-17 18:33:33 +02:00
cacaodev
96793b39ba
Revert "Fixed: Define header-view-height attribute in ThemeDescriptors. ( #2764 )"
...
This reverts commit 9ad44e6dc2 .
2018-08-30 16:02:48 +02:00
cacaodev and Martin Carlberg
9ad44e6dc2
Fixed: Define header-view-height attribute in ThemeDescriptors. ( #2764 )
...
This is a better solution for problem introduced by #2758
2018-08-29 14:28:02 +02:00
cacaodev and Martin Carlberg
f02d0ab1dd
STYLE: refactoring using CPCharacterSet ( #2762 )
2018-08-22 09:18:21 +02:00
cacaodev and Martin Carlberg
fd3acc456d
FIXED: Before this commit, CPScrollerView was not correctly differentiating the scroller-width attribute ( #2740 )
...
between the vertical scroller and the horizontal scroller.
The scroller width was picked from a common CPScroller instance cached in CPScroller.
The bug was not visible because the method -_adjustScrollerSize was correcting the size repeatidly in the layout pass.
This was causing unnecessary calls to setFrame: in a performance sensitive method (triggered by scroll events).
The ScrollView is now picking the right width from the theme and a setFrame: call is skipped.
Tests: Manual/CPScrollView2/
TODO : The _adjustScrollerSize method should be enabled with a flag only when a width change is explicitely requested.
2018-08-20 10:36:59 +02:00
cacaodev and GitHub
a8a9ec0023
Fix typo in CPPredicateEditorTest
...
Fixes #2714
2018-06-02 08:18:01 +02:00
cacaodev
0a542f9be9
Revert "FIXED: _CPTableColumnHeaderView was using hard coded values instead of theme values ( #2703 )"
...
This reverts commit e27bb4de50 .
2018-05-17 05:48:59 +02:00
cacaodev and GitHub
93b12eb14f
Revert "FIXED: click to key window in the background did not bring it forward" ( #2702 )
...
Fixes #2700
2018-05-06 14:07:25 +02:00
cacaodev and GitHub
ecc82b5b51
Fixed: Typo CGSizZero() -> CGSizeMakeZero()
...
In BadgedOutlineView.j from SmartFoldersDemo test application.
2018-05-02 19:38:37 +02:00
cacaodev and Martin Carlberg
b8b48b533b
Previously, animating frame origin was not working on recent versions of Gecko (Firefox). The format for the matrix value of the transform property was matrix(a,b,c,d,tx,ty) and tx and ty had the "px" suffix. According to this page, tx and ty were accept ( #2677 )
...
ed (in my understanding not required) to have this suffix before FireFox
16.
All parameters are now numbers without suffix and this code will work
for all FireFox versions supporting css animations.
2018-04-12 11:25:43 +02:00
cacaodev and GitHub
0404ac0395
Merge pull request #2602 from daboe01/issue2545
...
FIXED: click to key window in the background did not bring it forward
2018-04-12 09:11:57 +02:00
cacaodev and GitHub
5d3b918339
Merge pull request #2624 from bedalton/formatting-add-semi-colon-cparraycontroller
...
Formatting: add semi-colon CPArrayController
2018-04-07 06:53:38 +02:00
cacaodev and GitHub
eba0091764
Merge pull request #2623 from bedalton/formatting-add-semi-colon-cpapplication
...
Formatting: add semi-colon CPApplication
2018-04-07 06:53:13 +02:00
cacaodev and GitHub
7999cbbea3
Merge pull request #2622 from bedalton/formatting-add-semi-colon-cppopoverwindow
...
Formatting: add semi-colon CPPopoverWindow.j
2018-04-07 06:52:57 +02:00
cacaodev and GitHub
cee7987b35
Merge pull request #2621 from bedalton/formatting-add-semi-colon-cptooltip
...
Formatting: add semi-colon to CPToolTip.j
2018-04-07 06:52:40 +02:00
cacaodev and GitHub
d475c08024
Merge pull request #2620 from bedalton/formatting-add-semi-colon-cpdatepickerclock
...
Formatting: add semi colon CPDatePickerClock.j
2018-04-07 06:52:26 +02:00
cacaodev and GitHub
d78f83ae49
Merge pull request #2619 from bedalton/formatting-move-redeclared-variable-in-cgpath
...
Formatting: remove redeclared variables in CGPath.j
2018-04-07 06:52:12 +02:00
cacaodev and GitHub
df694f01e7
Merge pull request #2618 from bedalton/add-semi-colons-to-cgcontextvml
...
Formatting: add semi-colon to CGContextVML.j
2018-04-07 06:51:55 +02:00
cacaodev and GitHub
f5d9cbb11b
Merge pull request #2615 from bedalton/add-missing-semi-colon-to-cpkeyvaluebinding
...
Formatting : add missing semi-colon to CPKeyValueBinding.j
2018-04-07 06:51:35 +02:00
cacaodev and GitHub
d802588abe
Merge pull request #2617 from bedalton/add-missing-semi-colons-cgcontextcanvas
...
Formatting: Add missing semi-colons to CGContextCanvas.j
2018-04-07 06:51:01 +02:00
cacaodev and GitHub
f6d892023e
Merge pull request #2604 from bedalton/overshadowing-variable-in-_CPCibObjectData
...
Fixed: Variable in if statement overshadows variable in enclosing block
2018-04-03 07:54:11 +02:00
cacaodev and GitHub
e246a2753b
Merge pull request #2610 from daboe01/issue2605
...
fixed: wrong method invocation to delegate of CALayer (displayLayer:)
2018-03-31 12:35:33 +02:00
cacaodev and GitHub
5f94d0a5c2
Typo: remove extra semi-colon
2018-02-28 15:33:16 +01:00
cacaodev and GitHub
618e6a1604
Merge pull request #2591 from daboe01/_CPFunctionExpression.j-missing-if
...
fixed: fromObject:(id)object index:(id)anIndex failed to raise if arg…
2018-02-27 15:59:19 +01:00
cacaodev and GitHub
cef294513a
Merge pull request #2590 from daboe01/CPKeyValueObserving-fix-CPKeyValueChangeReplacement
...
FIXED: Typo in call to replaceObjectsAtIndexes in CPKeyValueObserving
2018-02-27 15:58:13 +01:00
cacaodev and GitHub
5d63865ae5
Merge pull request #2546 from cacaodev/CPSplitView
...
CPSplitView -trackDivider: performance
2017-11-08 18:53:22 +01:00
cacaodev and GitHub
700207d29b
Merge pull request #2554 from cacaodev/cptableview-issue#2549
...
CPTableView: fix invisible dragged rows
2017-08-30 08:35:40 +02:00
cacaodev
f5eb1158db
Fix issue 2549: table rows where invisible when dragging.
2017-07-28 21:35:24 +02:00
cacaodev
81916d0f45
FIXED: A grouping context does not inherit the completion handler ...
...
… from the current context.
Also removed CPAnimationContext -copy method. CPAnimationContext is not
CPCopying compliant.
TEST: CPAnimationContextTest ->
testCompletionHandlerWithoutAnimatorWithGrouping2
2017-07-25 12:04:58 +02:00
cacaodev
03dccbe613
Add a manual test for the previous fixes.
...
The tests must be run independently because animations are launched at
the end of the current run loop.
2017-06-30 12:26:15 +02:00
cacaodev
1ccec65619
Add debug information
2017-06-30 12:03:29 +02:00
cacaodev
b78e9062a1
CompletionHandlerAgent fire() is a one shot.
2017-06-30 12:03:09 +02:00
cacaodev
dc87354702
CPAnimationContext setCompletionHandler: add an equality check
2017-06-30 12:00:08 +02:00
cacaodev
bb2d860807
CPViewAnimator: guard in the frame updater function
...
… in case the transform property value is ‘none’.
2017-06-12 12:46:05 +02:00
cacaodev
6f1c0fa4a8
FIXED: CPAnimationContext completionHandler was not called
...
Previously, if a context group was not generating any animation (no
calls to animator or non implemented method in the animator proxy), the
completionHandler was not called.
If the end value (frame, frameorigin, frameSize) was equal to the start
value, the completionHandler was not called neither.
This commit makes sure that the completionHandlerAgent counter is
incremented by the count of animations that actually start.
2017-06-12 12:46:05 +02:00
cacaodev
35808e7bde
FIXED: uninitialized ivar
2017-06-02 11:15:23 +02:00
cacaodev
1b4eeb35b3
Add a manual test CPWindowLiveResizeTest
2017-06-02 09:44:42 +02:00
cacaodev
cee032bbc9
FIXED: send live resize notifications when the window animates
...
Like in cocoa, these notifications are not sent when a sheet is
displayed.
2017-06-02 09:42:59 +02:00
cacaodev and GitHub
9547b70743
Merge pull request #2542 from FrankReh/pullreq/cleanup/fix/unused/cachedSearchResults
...
Removed an unused variable: cachedSearchResults.
2017-05-30 19:29:14 +02:00
cacaodev and GitHub
5df8939d84
Merge pull request #2541 from FrankReh/pullreq/cleanup/fix/syntax/protocol_list
...
Fix aClass.protocol_list syntax
2017-05-30 19:27:53 +02:00
cacaodev and GitHub
0b9c689273
Merge pull request #2540 from FrankReh/pullreq/cleanup/fix/syntax/global-var-key
...
Make variable local: key
2017-05-30 19:25:25 +02:00
cacaodev
ac193cd97a
Test: Add liveResize testing in CPWindowResizeStyle manual test
...
The window title changes during live resize.
2017-05-30 19:06:50 +02:00
cacaodev
7355a60f16
Call _setupDOMDivider when necessary only
...
Previoulsy, the backgroundColor and url css properties where set at
each drawing pass.
2017-05-30 18:33:08 +02:00
cacaodev
fb6f6325b5
CPSplitView: refactor trackDivider: using _dividerAtPoint:
...
instead of a for loop.
2017-05-23 08:17:16 +02:00
cacaodev
0f767d9dfc
CPWindow: add CPWindowWillStartLiveResizeNotification and CPWindowDidEndLiveResizeNotification
...
Also fixed CPView -(BOOL)inLiveResize
If a view is added during a live resize, it will not receive a
willStart notif.
If a view is removed during a live resize it will not receive a Didend
notif.
2017-05-20 13:52:50 +02:00
cacaodev
d1addcab91
CPSplitView: do not track events outside of a divider.
...
Added private method -_dividerAtIndex:
2017-05-13 19:46:39 +02:00
cacaodev
7a02cd794b
Properly catch single-click, double-click, dragging on a divider
...
Previously, a double-click was also catched as a single-click on mouse
up,
dragging was handled is mouse down before tracking actually begins.
Manual test: added collapse capabilities to all split views.
2017-05-12 11:09:08 +02:00
cacaodev
258cd9209f
CPSplitView: exit a loop when the current divider is found
2017-05-12 10:28:47 +02:00
cacaodev and GitHub
f18074bf49
Merge pull request #2532 from cacaodev/CPWindowAnimator
...
New: Optional declarative layout for use in CoreAnimation (css animations).
Code refactor.
2017-03-13 08:34:01 +01:00
cacaodev and GitHub
3f64b74453
Merge pull request #2533 from cacaodev/CPCompatibility-SetFeature
...
NEW: CPCompatibility: add a function to set a feature externally.
```CPSetPlatformFeature(aFeature, aBool)```
2017-03-13 08:28:51 +01:00
cacaodev
1c86256f83
Add CPCSSAnimationFeature to CPCompatibility constants
2017-03-02 11:21:57 +01:00
cacaodev
98105ad4dc
Merge branch 'CPCompatibility-SetFeature' into CPWindowAnimator-copy
2017-03-02 10:57:23 +01:00
cacaodev
6bf2d6c1ab
Move css animation creation & frame updaters to CPViewAnimator
...
Reason: • consistency : animations handled by animator.
• Views can now animate several DOM elements. For example
a view with a nine part image need to animate its sub divs.
• Do not create any css animation when the start and end values are
equal and there is no intermediate values.
+ This commit adds an optional method to CPView
- (CGRect)frameRectOfView:(CPView)aView inSuperviewSize:(CGSize)aSize
Returns the frame of a view given its superview frame. This will allow
views implementing -layoutSubviews to gain an optional declarative
layout. The animation system will use this method to compute the end
value of an animation.
2017-03-02 10:30:09 +01:00
cacaodev
cebd51aac1
reduce the number of args in a private method
2017-03-02 10:30:08 +01:00
cacaodev
42b8b3aa75
Ask the animator if periodic frame updates are needed
2017-03-02 10:30:08 +01:00
cacaodev
c0eaf79d25
Remove jshashtable.js in favor of Map()
2017-03-02 10:30:07 +01:00
cacaodev
fb2fe3eb63
Enable forced frame updates in CPViewAnimator
2017-03-02 10:30:07 +01:00
cacaodev
184d63f7eb
Move the FrameUpdater function to CPViewAnimator
2017-03-02 10:30:07 +01:00
cacaodev
14ebd58c96
Move CFRunLoopObserver to CPRunLoop.j as a global function
2017-03-02 10:30:05 +01:00
cacaodev
3edddb8e91
Add CSSAnimation.description() function
2017-03-02 10:30:05 +01:00
cacaodev
d2340dff1a
Style, whitespace
2017-03-02 10:30:04 +01:00
cacaodev
d30c6aec7d
Fix label in demo (AutoSize checkbox)
2017-03-02 09:56:47 +01:00
cacaodev
4854b3e08f
Fix typo
2017-03-02 09:48:12 +01:00
cacaodev
facc748090
NEW: CPCompatibility add a function to set a feature externally.
...
CPSetPlatformFeature(aFeature, aBool)
2017-03-01 19:10:00 +01:00
cacaodev and GitHub
5c71612e34
Typo
2017-02-10 20:01:57 +01:00
cacaodev and GitHub
f00a5fbaf4
Merge pull request #2531 from cacaodev/cptableview-diddragcolumn
...
FIXED: tableView:didDragTableColumn: was never sent
With tests.
Fixes #2530
2017-02-03 08:13:46 +01:00
cacaodev
34769da9cc
FIXED: tableview:didDragTableColumn: was never sent
...
With manual test.
2017-02-02 09:36:48 +01:00
cacaodev
458e6ed531
FiXED: CPTableColumn description
2017-02-02 09:34:17 +01:00
cacaodev
d42562fdcb
New: Allow a text based control to stay on a single line when wrapping
...
A private flag have been added in _CPImageAndTextView. It must be set
to YES when it does not make sense for a control to hold multiline text.
This is now the case for all CPSegmentedControl.
Test: In CPSegmentedControlTest, hit « Add Segment with flexible
width » button. The new label should be vertically centered.
2016-12-02 09:10:39 +01:00
cacaodev
8d403f579c
FIxed: IB connections in CPTabViewNibTest
2016-11-14 22:03:51 +01:00
cacaodev
5da8728d6c
New: CPObject instancesImplementSelector:(SEL)aSelector
...
Tests if instances of given class implement a selector.
With test.
Note: The naming is from cocoa where this method is semi-public.
2016-11-12 18:30:02 +01:00
cacaodev
947d552509
Fix merging
2016-11-07 22:57:33 +01:00
cacaodev
037bc4ea2b
Test: demonstrate the new wantsPeriodicFrameUpdates animator property
...
In Tests/Manual/CPAnimatablePropertyContainerTest/
2016-11-07 22:26:30 +01:00
cacaodev
cfbef141d8
CPAnimationContext: Inhibit DOM updates during size animation
...
Previously, during frame updates, we were writing the css values we
just read before.
Canvas sizing is preserved as it is needed when the view has custom
drawing.
2016-11-07 22:26:30 +01:00
cacaodev
410ad0dc09
Style: print debug logs in debug mode only
2016-11-07 22:26:29 +01:00
cacaodev
3d9b42f0c2
Style: CSSAnimation.j linting
...
Using default eslint config for js
2016-11-07 22:26:29 +01:00
cacaodev
dda81b12da
Revert "nib2cib: discard warnings in the nib file."
...
This reverts commit 4e11152e76 .
2016-10-22 08:40:38 +02:00
cacaodev
095864de39
Fixed: CPTabView should not allow empty selection
...
Before this commit, a tab view could have an empty selection with the
following circumstances:
- The tab view was not created in IB
- the Tab View selection had not binding management
With test.
2016-10-21 10:13:47 +02:00
cacaodev and GitHub
0eb196e852
CPTabView: load tab view items asynchronously when possible ( #2479 )
...
When an item created with +tabViewItemWithViewController:, the view is loaded asynchronously
Manual test CPTabViewNib have been modified to show a tab view item
managed by a view controller. Any setup happens in
-viewDidAppear: because we cannot use any more the
tabView:didSelectTabViewItem: delegate method.
2016-10-20 17:24:18 +02:00
cacaodev and GitHub
62e5d8d841
Fixed: type declaration
2016-10-20 08:48:01 +02:00
cacaodev and GitHub
2f82fb842d
Merge pull request #2495 from daboe01/fixed--typo-in-CPControl-comment
...
Fixed: typo in CPControl comment
2016-10-19 08:37:27 +02:00
cacaodev and GitHub
4b55a69150
Merge pull request #2447 from cacaodev/CPAnimationContext-fixes
...
Fixed: The animation was reverting back to its initial position.
Fixed: custom layout and custom drawing was not animated in Chrome and Firefox.
2016-10-17 22:01:15 +02:00
cacaodev
4e11152e76
nib2cib: discard warnings in the nib file.
2016-09-26 09:44:23 +02:00
cacaodev and GitHub
dd62c08b09
FIXED: Fix a build error in XcodeCapp ( #2480 )
2016-09-09 21:03:17 +02:00
cacaodev and GitHub
6061323c36
Test CPSegmentedControl enabled state ( #2481 )
2016-09-07 20:56:49 +02:00
cacaodev
17da8b04bf
Remove references to CPAnimationTriggerOrderIn
2016-09-05 21:43:54 +02:00