Randall Luecke
90a45dca29
some fixes to default buttons to make them more cocoa compliant...
2010-08-01 20:19:26 -05:00
Alexander Ljungberg
bcff25b959
Merge branch 'master' of github.com:280north/cappuccino
2010-08-01 19:15:52 -04:00
Alexander Ljungberg
dff6203fb3
Closes #806 . Fixed: if a selected row was removed from a table view, the selection remained and would show up again if a new row was later added.
2010-08-01 19:10:22 -04:00
Alexander Ljungberg
b4dd6b670b
Switch to the standard macros in _resizeAllColumnUniformlyWithOldSize as originally intended by Randy Luecke.
2010-08-01 19:06:57 -04:00
Randall Luecke
f028533c07
Removed gradient stuff that has been moved to the theme.
2010-08-01 17:50:19 -05:00
Alexander Ljungberg
dac61a14cd
Eliminated some accidental globals in uniform table column resizing.
2010-08-01 18:10:27 -04:00
Alexander Ljungberg
6884f93d76
Fixed: after the intercell spacing commit, table column auto resizing on the first or last column would result in a total column width wider than the scroll width of the table. This would appear as the rightmost column sticking out and the table showing a horizontal scrollbar.
2010-08-01 18:06:18 -04:00
Alexander Ljungberg
17cc77e816
Clean up code in table column resizing paths in preparation for fixing it.
2010-08-01 17:14:59 -04:00
Randall Luecke
7ac59dd142
Sheets should be assigned to the platform window of the window it is attached to.
2010-07-31 20:20:18 -05:00
Alexander Ljungberg
c277ae7f68
Fixed: calling CPTabView setTabViewType:CPNoTabsNoBorder before the first insertTabViewItem would cause an error. Fixed: if a tab item was added in CPNoTabsNoBorder mode, and the mode was later switched to CPTopTabsBezelBorder, that previously added tab item would have no label/tab. The solution is to maintain _labelsView in either mode; since in CPNoTabsNoBorder mode _labelsView is not in the view hierarchy anyhow the performance impact should be minimal.
2010-07-30 21:03:00 -04:00
Alexander Ljungberg
7c78753865
Fixed with CPTabView: don't remove the content and auxiliary views if the new views are the same as the old ones. This prevents flickering and needless redraws when the currently selected tab is reselected.
2010-07-30 21:02:50 -04:00
Alexander Ljungberg
9fc07ac622
Implemented NSView viewDidHide and viewDidUnhide.
2010-07-30 20:52:26 -04:00
Aparajita Fishman and Ross Boucher
364a11491d
Full support for intercell spacing (issue #797 )
2010-07-30 16:14:53 -07:00
Aparajita Fishman and Ross Boucher
0a26288d88
Fix for issue #804 (doxygen fails to generate class references), also did a bit of formatting cleanup in CPColor.j
2010-07-30 15:48:06 -07:00
Aparajita Fishman and Ross Boucher
dcfb916d30
Fix for issue #803 (jake docs doesn't use Doxygen.app on Mac OS X)
2010-07-30 15:47:56 -07:00
Alexander Ljungberg
d1c7dab356
If a CPSplitView view is collapsed through means of double click and then later restored in the same manner, preserve the original position of the divider. If the view was collapsed through dragging, double clicking to expand still positions the divider in the center of its available space.
2010-07-29 23:23:00 -04:00
Alexander Ljungberg
0e5b5c844c
Split view cursor improvements. If a split view divider is at its minimum position but a collapse is possible, show that a smaller size is possible through the cursor. If a split view has a collapsed view and the cursor moves over the divider, show a 'larger size is possible' cursor.
2010-07-29 23:22:45 -04:00
Aparajita Fishman and Ross Boucher
3eea14abe4
For the methods that don't have context: in their signature, the predicate will receive undefined in the context parameter instead of nil.
2010-07-29 14:08:04 -07:00
Ross Boucher
a7ca917abf
Better method of expressing this condition.
2010-07-29 11:26:13 -07:00
Aparajita Fishman and Ross Boucher
9ca80df67a
Cleaned up the state indicator (it was a little uneven) and centered it more horizontally in the state column.
2010-07-29 11:24:06 -07:00
Aparajita Fishman and Ross Boucher
48a89fd828
frame parameter is not being used in _initWithFrame, might as well leave it out, fixed typo in comment
2010-07-29 09:56:55 -07:00
Aparajita Fishman and Ross Boucher
1002f80617
Another fix for issue #782 , uses class variable for the empty image placeholder.
2010-07-28 16:27:56 -07:00
Aparajita Fishman and Ross Boucher
fc51bead8e
Another try at fixing issue #782
2010-07-28 16:27:56 -07:00
Francisco Ryan Tolmasky I
cea663f4eb
Fix for isEqual: not being implemented in CPIndexSet.
...
Closes #785 .
Reviewed by rossco.
2010-07-28 16:17:54 -07:00
Aparajita Fishman and Ross Boucher
8ecac8d03c
Fix and test case for issue #746
2010-07-28 16:12:02 -07:00
Ross Boucher
f26d2f4ebf
Merge remote branch 'klaaspieter/fix-751-cpwindow-center'
2010-07-28 16:03:48 -07:00
Aparajita Fishman and Ross Boucher
cb7f60aba8
Added -indexOfObjectPassingTest: and related methods
2010-07-28 15:57:47 -07:00
Ross Boucher
b4dbe422ff
Revert to addObject if there are no sort descriptors in insert...sortedby.
...
Closes #764 .
2010-07-28 15:48:25 -07:00
Andreas and Ross Boucher
aea19c5cd0
Add modal stylemask in nib2cib
2010-07-28 15:33:45 -07:00
Aparajita Fishman and Ross Boucher
edc5542ee6
Fix for issue #748
2010-07-28 15:24:37 -07:00
Aparajita Fishman and Ross Boucher
eb99b7d7ca
CPSearchField fixes/enhancements to commit 5b763928fe:
...
- Added more documentation for -defaultSearchTemplate.
- Capitalized the text of the menu items in the default template.
- Adding a separator before no recents menu item if there are items before it.
- Updated the test app to use the default template and then modify it.
- Updated the test app to maintain the state of the custom items.
2010-07-28 15:16:04 -07:00
Aparajita Fishman and Ross Boucher
006f709d37
Fixes to commit 69273259a5:
...
- No longer setting the search menu template to the default, but -defaultSearchMenuTemplate was made public.
- Action and target for clear recents item is always set to CPSearchField -_searchFieldClearRecents: since that is a built-in type.
- Action and target for recents item is always set to CPSearchField -_searchFieldSearch: since that is a built-in type.
- Template menu items are copied via CPMenuItem -copy (which is now implemented), so all state is maintained.
2010-07-28 15:15:47 -07:00
Ross Boucher
f5322b39bc
Fix a debug mode bug in IE. Closes #768 .
2010-07-28 15:13:21 -07:00
Aparajita Fishman and Ross Boucher
8702b1421f
Fix for issue #777 , also fixed a declared type while I was at it
2010-07-28 15:09:02 -07:00
Nicholas Small
3070634aab
Make -center on a bridge window into a no-op.
2010-07-28 18:06:08 -04:00
Nicholas Small
b65041a780
Merge branch 'master' of github.com:280north/cappuccino
2010-07-28 18:05:23 -04:00
Aparajita Fishman and Ross Boucher
6426c8aee2
Fix for issue #778
2010-07-28 15:04:40 -07:00
Nicholas Small
16b6753f1d
Merge branch 'master' of github.com:280north/cappuccino
2010-07-28 18:03:12 -04:00
Nicholas Small
b96db40e3d
Merge branch 'master' of github.com:280north/cappuccino
2010-07-28 17:56:45 -04:00
Ross Boucher
7caf5fe20a
Must return from this method.
2010-07-28 14:54:07 -07:00
Aparajita Fishman and Ross Boucher
44a958d3f8
-hitTest was always returning self, which did not allow any other views to receive a mouse down
2010-07-28 14:53:13 -07:00
Aparajita Fishman and Ross Boucher
4c562048dc
More fixes to CPSearchField (Cocoa compliance and bugs):
...
- Added the ability to specify a separator in the template by using the tag CPSearchFieldSeparatorMenuItemTag.
- _recentSearches was not being initialized by -initWithCoder, moved that code into -_init.
- -setSearchMenuTemplate was not being invoked. Since having a recents menu is the default behavior in Cocoa, it should probably be the default behavior in cappuccino. To turn it off, set _maximumRecents to >= 254.
- -searchTextRectForBounds was using the wrong rect for -searchButtonRectForBounds and -cancelButtonRectForBounds, resulting in a rect that was too narrow and did not fill the space.
- Tightened up the spacing between the magnifying glass and the text to exactly Cocoa distance.
- Overhauled -
updateSearchMenu to fix some logic bugs.
- Made sure the search field becomes first responder after closing the search menu.
- Cleared the search string when clearing recent searches, this is what Safari does.
- Removed redundant invoking of -setDelegate in -initWithCoder.
- -_init has to be called last in _initWithCoder.
2010-07-28 14:53:04 -07:00
Aparajita Fishman and Ross Boucher
f3b92c7445
Fixes to cacaodev/searchfield/ffb8f99603d96b903b6bb39bc4dcb15ad09465be...
...
- Replaced CG functions with inline _CG functions
- _canResignFirstResponder was not being initialized to YES
- -resignFirstResponder has to call super if _canResignFirstResponder == YES
2010-07-28 14:51:57 -07:00
cacaodev and Ross Boucher
675e9829bd
CPSearchField: Fixes (per cocoa)
...
- Do not override search button action, catch mouse events in mouseDown: instead.
- Do not resign first responder on searchfield when showing the context menu
- Give more space between search button and insertion point
- Do not add search string to recents searches when typing and sendsWholeString == NO, only on enter.
- Select all text when showing the menu or after selecting a recent search in the menu
- Support custom search/cancel buttons and custom layout
- Allow images in template menu items
- Updated Test App with custom buttons
2010-07-28 14:49:02 -07:00
Ross Boucher
4c0dbda558
Merge remote branch 'klaaspieter/fix/789-observeablearray-removeobjectatindex'
2010-07-28 14:22:14 -07:00
Ross Boucher
e586273a3f
Fix accidental global.
2010-07-28 14:13:12 -07:00
Ross Boucher
d4a0f0cd21
Merge remote branch 'klaaspieter/fix/787-cptablecolumn-editability'
2010-07-28 14:12:49 -07:00
Klaas Pieter Annema and Ross Boucher
8cfba4c242
only offset a nib2cib'ed textfield if it has a bezel
2010-07-28 14:09:11 -07:00
Aparajita Fishman and Ross Boucher
cce13b4b45
NSMenuItem is not reading the tag for some reason
2010-07-28 14:07:45 -07:00
Alexander Ljungberg and Ross Boucher
05e435633f
Fixed: if a custom CPTableView header view was used for a column, such as a CPImageView, sorting by that column would cause an exception as CPTableView tried to send _setIndicatorImage: to the view. The fix is to only send the message if the view supports it.
2010-07-28 13:57:49 -07:00
