Fixed: menus not closing on left click.

Previously, clicking outside a menu on a control would not close the menu. Also clicking on the menu header again would open a second menu.

This error was caused by the control receiving the click and starting its own tracking, depriving the menu of the mouse up event it was awaiting.

The behaviour to wait for the mouse up was wrong to begin with. Menus should close on mouse down.

This fix closes the menu on left mouse down anywhere but the menu, while still allowing the click to pass through to any control underneath the cursor.

Fixes #1833.

.gitignore

@@ -11,6 +11,5 @@ xcuserdata/
 !*.xcodeproj/project.pbxproj
 *.xCodeSupport/
 *.XcodeSupport/
-*XcodeSupport/
 *.sublime-project
 *.sublime-workspace

AppKit/AppKit.j

@@ -55,7 +55,6 @@
 @import "CPController.j"
 @import "CPCookie.j"
 @import "CPCursor.j"
-@import "CPDatePicker.j"
 @import "CPDocument.j"
 @import "CPDocumentController.j"
 @import "CPEvent.j"

AppKit/CPAccordionView.j

@@ -106,7 +106,7 @@ var secondItem = [[CPAccordionViewItem alloc] initWithIdentifier:@"secondSection
         _itemViews = [];
         _expandedItemIndexes = [CPIndexSet indexSet];
 
-        [self setItemHeaderPrototype:[[CPButton alloc] initWithFrame:CGRectMake(0.0, 0.0, 100.0, 24.0)]];
+        [self setItemHeaderPrototype:[[CPButton alloc] initWithFrame:_CGRectMake(0.0, 0.0, 100.0, 24.0)]];
     }
 
     return self;
@@ -258,18 +258,18 @@ var secondItem = [[CPAccordionViewItem alloc] initWithIdentifier:@"secondSection
 
 - (void)setFrameSize:(CGSize)aSize
 {
-    var width = CGRectGetWidth([self frame]);
+    var width = _CGRectGetWidth([self frame]);
 
     [super setFrameSize:aSize];
 
-    if (width !== CGRectGetWidth([self frame]))
+    if (width !== _CGRectGetWidth([self frame]))
         [self _invalidateItemsStartingAtIndex:0];
 }
 
 - (void)layoutSubviews
 {
     if (_items.length <= 0)
-        return [self setFrameSize:CGSizeMake(CGRectGetWidth([self frame]), 0.0)];
+        return [self setFrameSize:_CGSizeMake(_CGRectGetWidth([self frame]), 0.0)];
 
     if (_dirtyItemIndex === CPNotFound)
         return;
@@ -278,7 +278,7 @@ var secondItem = [[CPAccordionViewItem alloc] initWithIdentifier:@"secondSection
 
     var index = _dirtyItemIndex,
         count = _itemViews.length,
-        width = CGRectGetWidth([self bounds]),
+        width = _CGRectGetWidth([self bounds]),
         y = index > 0 ? CGRectGetMaxY([_itemViews[index - 1] frame]) : 0.0;
 
     // Do this now (instead of after looping), so that if we are made dirty again in the middle we don't blow this value away.
@@ -293,7 +293,7 @@ var secondItem = [[CPAccordionViewItem alloc] initWithIdentifier:@"secondSection
         y = CGRectGetMaxY([itemView frame]);
     }
 
-    [self setFrameSize:CGSizeMake(CGRectGetWidth([self frame]), y)];
+    [self setFrameSize:_CGSizeMake(_CGRectGetWidth([self frame]), y)];
 }
 
 @end
@@ -310,7 +310,7 @@ var secondItem = [[CPAccordionViewItem alloc] initWithIdentifier:@"secondSection
 
 - (id)initWithAccordionView:(CPAccordionView)anAccordionView
 {
-    self = [super initWithFrame:CGRectMakeZero()];
+    self = [super initWithFrame:_CGRectMakeZero()];
 
     if (self)
     {
@@ -376,21 +376,21 @@ var secondItem = [[CPAccordionViewItem alloc] initWithIdentifier:@"secondSection
 
 - (void)setFrameY:(float)aY width:(float)aWidth
 {
-    var headerHeight = CGRectGetHeight([_headerView frame]);
+    var headerHeight = _CGRectGetHeight([_headerView frame]);
 
     // Size to fit or something?
-    [_headerView setFrameSize:CGSizeMake(aWidth, headerHeight)];
-    [_contentView setFrameOrigin:CGPointMake(0.0, headerHeight)];
+    [_headerView setFrameSize:_CGSizeMake(aWidth, headerHeight)];
+    [_contentView setFrameOrigin:_CGPointMake(0.0, headerHeight)];
 
     if ([self isCollapsed])
-        [self setFrame:CGRectMake(0.0, aY, aWidth, headerHeight)];
+        [self setFrame:_CGRectMake(0.0, aY, aWidth, headerHeight)];
 
     else
     {
-        var contentHeight = CGRectGetHeight([_contentView frame]);
+        var contentHeight = _CGRectGetHeight([_contentView frame]);
 
-        [_contentView setFrameSize:CGSizeMake(aWidth, contentHeight)];
-        [self setFrame:CGRectMake(0.0, aY, aWidth, contentHeight + headerHeight)];
+        [_contentView setFrameSize:_CGSizeMake(aWidth, contentHeight)];
+        [self setFrame:_CGRectMake(0.0, aY, aWidth, contentHeight + headerHeight)];
     }
 }
 

AppKit/CPAlert.j

@@ -642,7 +642,6 @@ var bottomHeight = 71;
 
     _window = [[CPPanel alloc] initWithContentRect:frame styleMask:forceStyle || _defaultWindowStyle];
     [_window setLevel:CPStatusWindowLevel];
-    [_window setPlatformWindow:[[CPApp keyWindow] platformWindow]];
 
     if (_title)
         [_window setTitle:_title];

AppKit/CPApplication.j

@@ -20,6 +20,8 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#import "../Foundation/CPRange.h"
+
 @import <Foundation/CPBundle.j>
 
 @import "CPCompatibility.j"
@@ -34,7 +36,6 @@
 @import "CPPanel.j"
 @import "CPPlatform.j"
 @import "CPWindowController.j"
-@import "_CPPopoverWindow.j"
 
 var CPMainCibFile               = @"CPMainCibFile",
     CPMainCibFileHumanFriendly  = @"Main cib file base name",
@@ -372,32 +373,22 @@ CPRunContinuesResponse  = -1002;
             applicationVersion = [options objectForKey:@"ApplicationVersion"] || [mainInfo objectForKey:@"CPBundleShortVersionString"],
             copyright = [options objectForKey:@"Copyright"] || [mainInfo objectForKey:@"CPHumanReadableCopyright"];
 
-        var windowWidth = 275,
-            windowHeight = 223,
-            imgWidth = 100,
-            imgHeight = 100,
-            interField = 8,
-            aboutPanel = [[CPWindow alloc] initWithContentRect:CGRectMake(0, 0, windowWidth, windowHeight) styleMask:CPClosableWindowMask],
-            imageView = [[CPImageView alloc] initWithFrame:CGRectMake((windowWidth / 2) - (imgWidth / 2), interField, imgWidth, imgHeight)],
-            applicationLabel = [[CPTextField alloc] initWithFrame:CGRectMake(17, imgHeight + 16, windowWidth - 34, 24)],
-            versionLabel = [[CPTextField alloc] initWithFrame:CGRectMake(17, imgHeight + 48, windowWidth - 34, 16)],
-            copyrightLabel = [[CPTextField alloc] initWithFrame:CGRectMake(17, imgHeight + 72, windowWidth - 34, 32)],
-            contentView = [aboutPanel contentView];
+        var aboutPanelPath = [[CPBundle bundleForClass:[CPWindowController class]] pathForResource:@"AboutPanel.cib"],
+            aboutPanelController = [CPWindowController alloc],
+            aboutPanelController = [aboutPanelController initWithWindowCibPath:aboutPanelPath owner:aboutPanelController],
+            aboutPanel = [aboutPanelController window],
+            contentView = [aboutPanel contentView],
+            imageView = [contentView viewWithTag:1],
+            applicationLabel = [contentView viewWithTag:2],
+            versionLabel = [contentView viewWithTag:3],
+            copyrightLabel = [contentView viewWithTag:4],
+            standardPath = [[CPBundle bundleForClass:[self class]] pathForResource:@"standardApplicationIcon.png"];
 
+        // FIXME move this into the CIB eventually
         [applicationLabel setFont:[CPFont boldSystemFontOfSize:[CPFont systemFontSize] + 2]];
         [applicationLabel setAlignment:CPCenterTextAlignment];
-        [versionLabel setFont:[CPFont systemFontOfSize:[CPFont systemFontSize] - 1]];
         [versionLabel setAlignment:CPCenterTextAlignment];
-        [copyrightLabel setFont:[CPFont systemFontOfSize:[CPFont systemFontSize] - 1]];
         [copyrightLabel setAlignment:CPCenterTextAlignment];
-        [copyrightLabel setLineBreakMode:CPLineBreakByWordWrapping];
-
-        [contentView addSubview:imageView];
-        [contentView addSubview:applicationLabel];
-        [contentView addSubview:versionLabel];
-        [contentView addSubview:copyrightLabel];
-
-        var standardPath = [[CPBundle bundleForClass:[self class]] pathForResource:@"standardApplicationIcon.png"];
 
         [imageView setImage:applicationIcon || [[CPImage alloc] initWithContentsOfFile:standardPath
                                                                                   size:CGSizeMake(256, 256)]];
@@ -411,7 +402,7 @@ CPRunContinuesResponse  = -1002;
         else
             [versionLabel setStringValue:@""];
 
-        [copyrightLabel setStringValue:copyright || @""];
+        [copyrightLabel setStringValue:copyright || ""];
         [aboutPanel center];
 
         _aboutPanel = aboutPanel;
@@ -639,10 +630,10 @@ CPRunContinuesResponse  = -1002;
     }
 
     /*
-        Event listeners are processed from back to front so that newer event listeners normally take
-        precedence. If during the execution of a callback a new event listener is added, it should
-        be inserted after the current callback but before any higher priority callbacks. This makes
-        repeating event listeners (those that reinsert themselves) stable relative to each other.
+    Event listeners are processed from back to front so that newer event listeners normally take
+    precedence. If during the execution of a callback a new event listener is added, it should
+    be inserted after the current callback but before any higher priority callbacks. This makes
+    repeating event listeners (those that reinsert themselves) stable relative to each other.
     */
     for (var i = _eventListeners.length - 1; i >= 0; i--)
     {
@@ -663,7 +654,6 @@ CPRunContinuesResponse  = -1002;
             }
         }
     }
-
     _eventListenerInsertionIndex = _eventListeners.length;
 
     if (theWindow)
@@ -716,7 +706,7 @@ CPRunContinuesResponse  = -1002;
 - (CPArray)windows
 {
     // Return all windows, but not the CPNull placeholder in _windows[0].
-    return [_windows subarrayWithRange:CPMakeRange(1, [_windows count] - 1)];
+    return [_windows subarrayWithRange:_CPMakeRange(1, [_windows count] - 1)];
 }
 
 /*!
@@ -999,10 +989,10 @@ CPRunContinuesResponse  = -1002;
     @param aSheet the window to display as a sheet
     @param aWindow the window that will hold the sheet as a child
     @param aModalDelegate
-    @param didEndSelector
-    @param contextInfo
+    @param aDidEndSelector
+    @param aContextInfo
 */
-- (void)beginSheet:(CPWindow)aSheet modalForWindow:(CPWindow)aWindow modalDelegate:(id)aModalDelegate didEndSelector:(SEL)didEndSelector contextInfo:(id)contextInfo
+- (void)beginSheet:(CPWindow)aSheet modalForWindow:(CPWindow)aWindow modalDelegate:(id)aModalDelegate didEndSelector:(SEL)aDidEndSelector contextInfo:(id)aContextInfo
 {
     if ([aWindow isSheet])
     {
@@ -1010,8 +1000,17 @@ CPRunContinuesResponse  = -1002;
         return;
     }
 
-    [aSheet._windowView _enableSheet:YES inWindow:aWindow];
-    [aWindow _attachSheet:aSheet modalDelegate:aModalDelegate didEndSelector:didEndSelector contextInfo:contextInfo];
+    [aSheet._windowView _enableSheet:YES];
+
+    // -dw- if a sheet is already visible, we skip this since it serves no purpose and causes
+    // orderOut: to be called on the sheet, which is not what we want.
+    if (![aWindow isVisible])
+    {
+        [aWindow orderFront:self];
+        [aSheet setPlatformWindow:[aWindow platformWindow]];
+    }
+
+    [aWindow _attachSheet:aSheet modalDelegate:aModalDelegate didEndSelector:aDidEndSelector contextInfo:aContextInfo];
 }
 
 /*!
@@ -1036,7 +1035,7 @@ CPRunContinuesResponse  = -1002;
         var aWindow = [_windows objectAtIndex:count],
             context = aWindow._sheetContext;
 
-        if (context && context["sheet"] === sheet)
+        if (context != nil && context["sheet"] === sheet)
         {
             context["returnCode"] = returnCode;
             [aWindow _endSheet];

AppKit/CPArrayController.j

@@ -65,51 +65,51 @@
 
 + (CPSet)keyPathsForValuesAffectingContentArray
 {
-    return [CPSet setWithObjects:@"content"];
+    return [CPSet setWithObjects:"content"];
 }
 
 + (CPSet)keyPathsForValuesAffectingArrangedObjects
 {
     // Also depends on "filterPredicate" but we'll handle that manually.
-    return [CPSet setWithObjects:@"content", @"sortDescriptors"];
+    return [CPSet setWithObjects:"content", "sortDescriptors"];
 }
 
 + (CPSet)keyPathsForValuesAffectingSelection
 {
-    return [CPSet setWithObjects:@"selectionIndexes"];
+    return [CPSet setWithObjects:"selectionIndexes"];
 }
 
 + (CPSet)keyPathsForValuesAffectingSelectionIndex
 {
-    return [CPSet setWithObjects:@"selectionIndexes"];
+    return [CPSet setWithObjects:"selectionIndexes"];
 }
 
 + (CPSet)keyPathsForValuesAffectingSelectionIndexes
 {
     // When the arranged objects change, selection preservation may cause the indexes
     // to change.
-    return [CPSet setWithObjects:@"arrangedObjects"];
+    return [CPSet setWithObjects:"arrangedObjects"];
 }
 
 + (CPSet)keyPathsForValuesAffectingSelectedObjects
 {
     // Don't need to depend on arrangedObjects here because selectionIndexes already does.
-    return [CPSet setWithObjects:@"selectionIndexes"];
+    return [CPSet setWithObjects:"selectionIndexes"];
 }
 
 + (CPSet)keyPathsForValuesAffectingCanRemove
 {
-    return [CPSet setWithObjects:@"selectionIndexes"];
+    return [CPSet setWithObjects:"selectionIndexes"];
 }
 
 + (CPSet)keyPathsForValuesAffectingCanSelectNext
 {
-    return [CPSet setWithObjects:@"selectionIndexes"];
+    return [CPSet setWithObjects:"selectionIndexes"];
 }
 
 + (CPSet)keyPathsForValuesAffectingCanSelectPrevious
 {
-    return [CPSet setWithObjects:@"selectionIndexes"];
+    return [CPSet setWithObjects:"selectionIndexes"];
 }
 
 
@@ -744,7 +744,6 @@
         return;
 
     var willClearPredicate = NO;
-
     if (_clearsFilterPredicateOnInsertion && _filterPredicate)
     {
         [self willChangeValueForKey:@"filterPredicate"];
@@ -793,18 +792,10 @@
     // not appear in arrangedObjects and we do not have to update at all.
     */
 
-    // TODO: Remove these lines when granular notifications are implemented
-    var proxy = [_CPKVOProxy proxyForObject:self];
-    [proxy setAdding:YES];
-
-    // This will also send notifications for arrangedObjects.
+    // This will also send notificaitons for arrangedObjects.
     [self didChangeValueForKey:@"content"];
-
     if (willClearPredicate)
         [self didChangeValueForKey:@"filterPredicate"];
-
-    // TODO: Remove this line when granular notifications are implemented
-    [proxy setAdding:NO];
 }
 
 /*!
@@ -820,7 +811,6 @@
         return;
 
     var willClearPredicate = NO;
-
     if (_clearsFilterPredicateOnInsertion && _filterPredicate)
     {
         [self willChangeValueForKey:@"filterPredicate"];
@@ -858,15 +848,9 @@
     if ([self avoidsEmptySelection] && [[self selectionIndexes] count] <= 0 && [_contentObject count] > 0)
         [self __setSelectionIndexes:[CPIndexSet indexSetWithIndex:0]];
 
-    var proxy = [_CPKVOProxy proxyForObject:self];
-    [proxy setAdding:YES];
-
     [self didChangeValueForKey:@"content"];
-
     if (willClearPredicate)
         [self didChangeValueForKey:@"filterPredicate"];
-
-    [proxy setAdding:NO];
 }
 
 /*!
@@ -930,10 +914,11 @@
     var newObject = [self automaticallyPreparesContent] ? [self newObject] : [self _defaultNewObject],
         lastSelectedIndex = [_selectionIndexes lastIndex];
 
-    if (lastSelectedIndex !== CPNotFound)
+    if (lastSelectedIndex)
         [self insertObject:newObject atArrangedObjectIndex:lastSelectedIndex];
     else
         [self addObject:newObject];
+
 }
 
 /*!

AppKit/CPBezierPath.j

@@ -48,8 +48,6 @@ var DefaultLineWidth = 1.0;
 {
     CGPath  _path;
     float   _lineWidth;
-    CPArray _lineDashes;
-    float   _lineDashesPhase;
 }
 
 /*!
@@ -207,7 +205,6 @@ var DefaultLineWidth = 1.0;
     CGContextBeginPath(ctx);
     CGContextAddPath(ctx, _path);
     CGContextSetLineWidth(ctx, [self lineWidth]);
-    CGContextSetLineDash(ctx, _lineDashesPhase, _lineDashes);
     CGContextStrokePath(ctx);
 }
 
@@ -221,50 +218,10 @@ var DefaultLineWidth = 1.0;
     CGContextBeginPath(ctx);
     CGContextAddPath(ctx, _path);
     CGContextSetLineWidth(ctx, [self lineWidth]);
-    CGContextSetLineDash(ctx, _lineDashesPhase, _lineDashes);
     CGContextClosePath(ctx);
     CGContextFillPath(ctx);
 }
 
-/*!
-    Cocoa compatibility.
-*/
-- (void)getLineDash:(CPArrayRef)patternRef count:(NSInteger)count phase:(CGFloatRef)phaseRef
-{
-    return [self getLineDash:patternRef phase:phaseRef];
-}
-
-/*!
-    Retrieve the line dash pattern and phase and write them into the provided references.
-*/
-- (void)getLineDash:(CPArrayRef)patternRef phase:(CGFloatRef)phaseRef
-{
-    if (patternRef)
-        @deref(patternRef) = [_lineDashes copy];
-    if (phaseRef)
-        @deref(phaseRef) = _lineDashesPhase;
-}
-
-/*!
-    Cocoa compatibility.
-*/
-- (void)setLineDash:(CPArray)aPattern count:(NSInteger)count phase:(CGFloat)aPhase
-{
-    [self setLineDash:aPattern phase:aPhase];
-}
-
-/*!
-    Set stroke line dash pattern.
-
-    @param aPattern an array of stroke-skip lengths such as [2, 2, 4, 4]
-    @param aPhase amount of shift for the starting position of the first stroke
-*/
-- (void)setLineDash:(CPArray)aPattern phase:(CGFloat)aPhase
-{
-    _lineDashes = aPattern;
-    _lineDashesPhase = aPhase;
-}
-
 /*!
     Get the line width.
 */

AppKit/CPBox.j

@@ -444,9 +444,9 @@ CPBelowBottom = 6;
         case CPBoxSeparator:
             // NSBox does not include a horizontal flag for the separator type. We have to determine
             // the type of separator to draw by the width and height of the frame.
-            if (CGRectGetWidth(bounds) === 5.0)
+            if (_CGRectGetWidth(bounds) === 5.0)
                 return [self _drawVerticalSeparatorInRect:bounds];
-            else if (CGRectGetHeight(bounds) === 5.0)
+            else if (_CGRectGetHeight(bounds) === 5.0)
                 return [self _drawHorizontalSeparatorInRect:bounds];
 
             break;
@@ -493,8 +493,8 @@ CPBelowBottom = 6;
     CGContextSetStrokeColor(context, [self borderColor]);
     CGContextSetLineWidth(context, 1.0);
 
-    CGContextMoveToPoint(context, CGRectGetMinX(aRect), CGRectGetMidY(aRect));
-    CGContextAddLineToPoint(context, CGRectGetWidth(aRect), CGRectGetMidY(aRect));
+    CGContextMoveToPoint(context, _CGRectGetMinX(aRect), _CGRectGetMidY(aRect));
+    CGContextAddLineToPoint(context, _CGRectGetWidth(aRect), _CGRectGetMidY(aRect));
     CGContextStrokePath(context);
 }
 
@@ -505,8 +505,8 @@ CPBelowBottom = 6;
     CGContextSetStrokeColor(context, [self borderColor]);
     CGContextSetLineWidth(context, 1.0);
 
-    CGContextMoveToPoint(context, CGRectGetMidX(aRect), CGRectGetMinY(aRect));
-    CGContextAddLineToPoint(context, CGRectGetMidX(aRect), CGRectGetHeight(aRect));
+    CGContextMoveToPoint(context, _CGRectGetMidX(aRect), _CGRectGetMinY(aRect));
+    CGContextAddLineToPoint(context, _CGRectGetMidX(aRect), _CGRectGetHeight(aRect));
     CGContextStrokePath(context);
 }
 

AppKit/CPBrowser.j

@@ -179,11 +179,6 @@
     var oldValue = _tableViews.length - 1,
         indexPlusOne = columnIndex + 1; // unloads all later columns.
 
-    if (columnIndex > 0)
-        [_tableViews[columnIndex - 1] setNeedsDisplay:YES];
-        
-    [_tableViews[columnIndex] setNeedsDisplay:YES];
-
     [[_tableViews.slice(indexPlusOne) valueForKey:"enclosingScrollView"]
       makeObjectsPerformSelector:@selector(removeFromSuperview)];
 
@@ -825,14 +820,6 @@
     return _browser;
 }
 
-/*!
-    @ignore
-*/
-- (BOOL)_isFocused
-{
-    return ([super _isFocused] || [_browser tableViewInColumn:[_browser selectedColumn]] === self);
-}
-
 - (BOOL)canDragRowsWithIndexes:(CPIndexSet)rowIndexes atPoint:(CGPoint)mouseDownPoint
 {
     return [_browser canDragRowsWithIndexes:rowIndexes inColumn:[_browser columnOfTableView:self] withEvent:[CPApp currentEvent]];

AppKit/CPButton.j

@@ -154,8 +154,8 @@ CPButtonImageOffset   = 3.0;
     return @{
             @"image": [CPNull null],
             @"image-offset": 0.0,
-            @"bezel-inset": CGInsetMakeZero(),
-            @"content-inset": CGInsetMakeZero(),
+            @"bezel-inset": _CGInsetMakeZero(),
+            @"content-inset": _CGInsetMakeZero(),
             @"bezel-color": [CPNull null],
         };
 }
@@ -596,7 +596,7 @@ CPButtonImageOffset   = 3.0;
 {
     var contentInset = [self currentValueForThemeAttribute:@"content-inset"];
 
-    return CGRectInsetByInset(bounds, contentInset);
+    return _CGRectInsetByInset(bounds, contentInset);
 }
 
 - (CGRect)bezelRectForBounds:(CGRect)bounds
@@ -607,7 +607,7 @@ CPButtonImageOffset   = 3.0;
 
     var bezelInset = [self currentValueForThemeAttribute:@"bezel-inset"];
 
-    return CGRectInsetByInset(bounds, bezelInset);
+    return _CGRectInsetByInset(bounds, bezelInset);
 }
 
 - (CGSize)_minimumFrameSize
@@ -667,14 +667,14 @@ CPButtonImageOffset   = 3.0;
 {
     if (aName === "bezel-view")
     {
-        var view = [[CPView alloc] initWithFrame:CGRectMakeZero()];
+        var view = [[CPView alloc] initWithFrame:_CGRectMakeZero()];
 
         [view setHitTests:NO];
 
         return view;
     }
     else
-        return [[_CPImageAndTextView alloc] initWithFrame:CGRectMakeZero()];
+        return [[_CPImageAndTextView alloc] initWithFrame:_CGRectMakeZero()];
 }
 
 - (void)layoutSubviews

AppKit/CPClipView.j

@@ -108,19 +108,19 @@
 - (CGPoint)constrainScrollPoint:(CGPoint)aPoint
 {
     if (!_documentView)
-        return CGPointMakeZero();
+        return _CGPointMakeZero();
 
     var documentFrame = [_documentView frame];
 
-    aPoint.x = MAX(0.0, MIN(aPoint.x, MAX(CGRectGetWidth(documentFrame) - CGRectGetWidth(_bounds), 0.0)));
-    aPoint.y = MAX(0.0, MIN(aPoint.y, MAX(CGRectGetHeight(documentFrame) - CGRectGetHeight(_bounds), 0.0)));
+    aPoint.x = MAX(0.0, MIN(aPoint.x, MAX(_CGRectGetWidth(documentFrame) - _CGRectGetWidth(_bounds), 0.0)));
+    aPoint.y = MAX(0.0, MIN(aPoint.y, MAX(_CGRectGetHeight(documentFrame) - _CGRectGetHeight(_bounds), 0.0)));
 
     return aPoint;
 }
 
 - (void)setBoundsOrigin:(CGPoint)aPoint
 {
-    if (CGPointEqualToPoint(_bounds.origin, aPoint))
+    if (_CGPointEqualToPoint(_bounds.origin, aPoint))
         return;
 
     [super setBoundsOrigin:aPoint];

AppKit/CPCollectionView.j

@@ -20,6 +20,8 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#import "../Foundation/CPRange.h"
+
 @import <Foundation/CPArray.j>
 @import <Foundation/CPData.j>
 @import <Foundation/CPIndexSet.j>
@@ -32,6 +34,9 @@
 @import "CPPasteboard.j"
 @import "CPView.j"
 
+@class CPClipView
+
+
 /*!
     @ingroup appkit
     @class CPCollectionView
@@ -125,8 +130,8 @@ var HORIZONTAL_MARGIN = 2;
         _maxNumberOfRows = 0;
         _maxNumberOfColumns = 0;
 
-        _minItemSize = CGSizeMakeZero();
-        _maxItemSize = CGSizeMakeZero();
+        _minItemSize = _CGSizeMakeZero();
+        _maxItemSize = _CGSizeMakeZero();
 
         [self setBackgroundColors:nil];
 
@@ -150,11 +155,11 @@ var HORIZONTAL_MARGIN = 2;
     _numberOfColumns = CPNotFound;
     _numberOfRows = CPNotFound;
 
-    _itemSize = CGSizeMakeZero();
+    _itemSize = _CGSizeMakeZero();
 
     _selectionIndexes = [CPIndexSet indexSet];
 
-    _storedFrameSize = CGSizeMakeZero();
+    _storedFrameSize = _CGSizeMakeZero();
 
     _needsMinMaxItemSizeUpdate = YES;
     _uniformSubviewsResizing = NO;
@@ -170,47 +175,49 @@ var HORIZONTAL_MARGIN = 2;
 
 /*!
     Sets the item prototype to \c anItem
-    @param anItem the new item prototype.
 
-    @note
-    - If anItem is located in an external cib file, representedObject, outlets, and bindings will be automatically restored when an item is created.
-    - If anItem and its view belong to the same cib as the collection view, the item prototype should implement the CPCoding protocol because the item is copied by archiving and unarchiving the prototypal view.
-    @note
-        Bindings won't be restored through archiving, instead you need to subclass the -representedObject: method and update the view there.
+    The item prototype should implement the CPCoding protocol
+    because the item is copied by archiving and unarchiving.
 
-    @par Example:
+    Example:
 
-@code
-@implementation MyCustomPrototypeItem: CPCollectionViewItem
-{
-    @outlet CPTextField textField;
-}
+    <pre>
+      @implement MyCustomViewItem : CPCollectionViewItem
+      {
+          CPArray   items   @accessors;
+      }
 
-- (id)initWithCoder:(CPCoder)aCoder
-{
-    self = [super initWithCoder:aCoder];
+      - (id)initWithCibName:(CPString)aCibNameOrNil bundle:(CPBundle)aCibBundleOrNil
+      {
+        self = [super initWithCibName:aCibNameOrNil bundle:aCibBundleOrNil];
+        if (self)
+        {
+          items = [];
+        }
+        return self;
+      }
 
-    textField = [aCoder decodeObjectForKey:@"TextField"];
+      - (id)initWithCoder:(CPCoder)aCoder
+      {
+        self = [super initWithCoder:aCoder];
+        items = [aCoder decodeObjectForKey:@"KEY"];
+        return self;
+      }
 
-    return self;
-}
+      - (void)encodeWithCoder:(CPCoder)aCoder
+      {
+        [aCoder encodeObject:items forKey:@"KEY"];
+        [super encodeWithCoder:aCoder];
+      }
 
-- (void)encodeWithCoder:(CPCoder)aCoder
-{
-    [super encodeWithCoder:aCoder];
-    [aCoder encodeConditionalObject:textField forKey:@"TextField"];
-}
+      @end
+    </pre>
 
-- (void)setRepresentedObject:(id)anObject
-{
-    [super setRepresentedObject:anObject];
-    [textField setStringValue:[anObject objectForKey:@"value"]];
-    [[self view] setColor:[anObject objectForKey:@"color"]];
-}
-
-@end
-@endcode
+    This will allow the collection view to create multiple 'clean' copies
+    of the item prototype which will maintain the original values for item
+    and all of the properties archived by the super class.
 
+    @param anItem the new item prototype
 */
 - (void)setItemPrototype:(CPCollectionViewItem)anItem
 {
@@ -502,7 +509,7 @@ var HORIZONTAL_MARGIN = 2;
     if (!lazyFlag ||
         _numberOfColumns !== oldNumberOfColumns ||
         _numberOfRows    !== oldNumberOfRows ||
-        !CGSizeEqualToSize(_itemSize, oldItemSize))
+        !_CGSizeEqualToSize(_itemSize, oldItemSize))
 
         [self displayItems:_items frameSize:_storedFrameSize itemSize:_itemSize columns:_numberOfColumns rows:_numberOfRows count:count];
 }
@@ -511,7 +518,7 @@ var HORIZONTAL_MARGIN = 2;
 {
     var width               = aSuperviewSize.width,
         height              = aSuperviewSize.height,
-        itemSize            = CGSizeMakeCopy(_minItemSize),
+        itemSize            = _CGSizeMakeCopy(_minItemSize),
         maxItemSizeWidth    = _maxItemSize.width,
         maxItemSizeHeight   = _maxItemSize.height,
         itemsCount          = [_items count],
@@ -550,8 +557,8 @@ var HORIZONTAL_MARGIN = 2;
     if (maxItemSizeHeight > 0)
         itemSizeHeight = MIN(itemSizeHeight, maxItemSizeHeight);
 
-    _itemSize        = CGSizeMake(MAX(_minItemSize.width, itemSize.width), MAX(_minItemSize.height, itemSizeHeight));
-    _storedFrameSize = CGSizeMake(MAX(width, _minItemSize.width), height);
+    _itemSize        = _CGSizeMake(MAX(_minItemSize.width, itemSize.width), MAX(_minItemSize.height, itemSizeHeight));
+    _storedFrameSize = _CGSizeMake(MAX(width, _minItemSize.width), height);
     _numberOfColumns = numberOfColumns;
     _numberOfRows    = numberOfRows;
     countRef(MIN(itemsCount, numberOfColumns * numberOfRows));
@@ -572,7 +579,7 @@ var HORIZONTAL_MARGIN = 2;
 
         if (idx >= displayCount)
         {
-            [view setFrameOrigin:CGPointMake(-anItemSize.width, -anItemSize.height)];
+            [view setFrameOrigin:_CGPointMake(-anItemSize.width, -anItemSize.height)];
             return;
         }
 
@@ -582,7 +589,7 @@ var HORIZONTAL_MARGIN = 2;
             y += _verticalMargin + anItemSize.height;
         }
 
-        [view setFrameOrigin:CGPointMake(x, y)];
+        [view setFrameOrigin:_CGPointMake(x, y)];
         [view setFrameSize:anItemSize];
 
         x += anItemSize.width + _horizontalMargin;
@@ -685,12 +692,12 @@ var HORIZONTAL_MARGIN = 2;
     if (aSize === nil || aSize === undefined)
         [CPException raise:CPInvalidArgumentException reason:"Invalid value provided for minimum size"];
 
-    if (CGSizeEqualToSize(_minItemSize, aSize))
+    if (_CGSizeEqualToSize(_minItemSize, aSize))
         return;
 
-    _minItemSize = CGSizeMakeCopy(aSize);
+    _minItemSize = _CGSizeMakeCopy(aSize);
 
-    if (CGSizeEqualToSize(_minItemSize, CGSizeMakeZero()))
+    if (_CGSizeEqualToSize(_minItemSize, _CGSizeMakeZero()))
         _needsMinMaxItemSizeUpdate = YES;
 
     [self tile];
@@ -710,10 +717,10 @@ var HORIZONTAL_MARGIN = 2;
 */
 - (void)setMaxItemSize:(CGSize)aSize
 {
-    if (CGSizeEqualToSize(_maxItemSize, aSize))
+    if (_CGSizeEqualToSize(_maxItemSize, aSize))
         return;
 
-    _maxItemSize = CGSizeMakeCopy(aSize);
+    _maxItemSize = _CGSizeMakeCopy(aSize);
 
 //    if (_maxItemSize.width == 0 || _maxItemSize.height == 0)
 //        _needsMinMaxItemSizeUpdate = YES;
@@ -785,9 +792,9 @@ var HORIZONTAL_MARGIN = 2;
                     newSelectedRange = nil;
 
                 if (index < firstSelectedIndex)
-                    newSelectedRange = CPMakeRange(index, (firstSelectedIndex - index) + 1);
+                    newSelectedRange = _CPMakeRange(index, (firstSelectedIndex - index) + 1);
                 else
-                    newSelectedRange = CPMakeRange(firstSelectedIndex, (index - firstSelectedIndex) + 1);
+                    newSelectedRange = _CPMakeRange(firstSelectedIndex, (index - firstSelectedIndex) + 1);
 
                 indexes = [[self selectionIndexes] copy];
                 [indexes addIndexesInRange:newSelectedRange];
@@ -936,9 +943,9 @@ var HORIZONTAL_MARGIN = 2;
     // Create and position the drop indicator view.
 
     if (!_dropView)
-        _dropView = [[_CPCollectionViewDropIndicator alloc] initWithFrame:CGRectMake(-8, -8, 0, 0)];
+        _dropView = [[_CPCollectionViewDropIndicator alloc] initWithFrame:_CGRectMake(-8, -8, 0, 0)];
 
-    [_dropView setFrameSize:CGSizeMake(10, _itemSize.height + _verticalMargin)];
+    [_dropView setFrameSize:_CGSizeMake(10, _itemSize.height + _verticalMargin)];
     [self addSubview:_dropView];
 }
 
@@ -974,14 +981,14 @@ var HORIZONTAL_MARGIN = 2;
 
     [[CPPasteboard pasteboardWithName:CPDragPboard] declareTypes:dragTypes owner:self];
 
-    var dragImageOffset = CGSizeMakeZero(),
+    var dragImageOffset = _CGSizeMakeZero(),
         view = [self _draggingViewForItemsAtIndexes:_selectionIndexes withEvent:_mouseDownEvent offset:dragImageOffset];
 
     [view setFrameSize:_itemSize];
     [view setAlphaValue:0.7];
 
     var dragLocation = [self convertPoint:locationInWindow fromView:nil],
-        dragPoint = CGPointMake(dragLocation.x - _itemSize.width / 2 , dragLocation.y - _itemSize.height / 2);
+        dragPoint = _CGPointMake(dragLocation.x - _itemSize.width / 2 , dragLocation.y - _itemSize.height / 2);
 
     [self dragView:view
         at:dragPoint
@@ -1113,12 +1120,12 @@ Not supported. Use -collectionView:dataForItemsAtIndexes:fortype:
     _currentDragOperation = dragOperation;
 
     var frameOrigin,
-        dropviewFrameWidth = CGRectGetWidth([_dropView frame]);
+        dropviewFrameWidth = _CGRectGetWidth([_dropView frame]);
 
     if (_currentDropIndex == -1 || _currentDragOperation == CPDragOperationNone)
-        frameOrigin = CGPointMake(-dropviewFrameWidth, 0);
+        frameOrigin = _CGPointMake(-dropviewFrameWidth, 0);
     else if (_currentDropIndex == 0)
-        frameOrigin = CGPointMake(0, 0);
+        frameOrigin = _CGPointMake(0, 0);
     else
     {
         var offset;
@@ -1135,7 +1142,7 @@ Not supported. Use -collectionView:dataForItemsAtIndexes:fortype:
 
         var rect = [self frameForItemAtIndex:dropIndex];
 
-        frameOrigin = CGPointMake(CGRectGetMaxX(rect) + offset, rect.origin.y - _verticalMargin);
+        frameOrigin = _CGPointMake(_CGRectGetMaxX(rect) + offset, rect.origin.y - _verticalMargin);
     }
 
     [_dropView setFrameOrigin:frameOrigin];
@@ -1182,8 +1189,8 @@ Not supported. Use -collectionView:dataForItemsAtIndexes:fortype:
 - (void)drawRect:(CGRect)aRect
 {
     var context = [[CPGraphicsContext currentContext] graphicsPort],
-        width = CGRectGetWidth(aRect),
-        circleRect = CGRectMake(1, 1, width - 2, width - 2);
+        width = _CGRectGetWidth(aRect),
+        circleRect = _CGRectMake(1, 1, width - 2, width - 2);
 
     CGContextSetStrokeColor(context, [CPColor colorWithHexString:@"4886ca"]);
     CGContextSetFillColor(context, [CPColor whiteColor]);
@@ -1197,8 +1204,8 @@ Not supported. Use -collectionView:dataForItemsAtIndexes:fortype:
 
     //then draw the line
     CGContextBeginPath(context);
-    CGContextMoveToPoint(context, FLOOR(width / 2), CGRectGetMinY(aRect) + width);
-    CGContextAddLineToPoint(context, FLOOR(width / 2), CGRectGetHeight(aRect));
+    CGContextMoveToPoint(context, FLOOR(width / 2), _CGRectGetMinY(aRect) + width);
+    CGContextAddLineToPoint(context, FLOOR(width / 2), _CGRectGetHeight(aRect));
     CGContextStrokePath(context);
 }
 
@@ -1208,12 +1215,7 @@ Not supported. Use -collectionView:dataForItemsAtIndexes:fortype:
 
 - (void)_modifySelectionWithNewIndex:(int)anIndex direction:(int)aDirection expand:(BOOL)shouldExpand
 {
-    var count = [[self items] count];
-
-    if (count === 0)
-        return;
-
-    anIndex = MIN(MAX(anIndex, 0), count - 1);
+    anIndex = MIN(MAX(anIndex, 0), [[self items] count] - 1);
 
     if (_allowsMultipleSelection && shouldExpand)
     {
@@ -1223,9 +1225,9 @@ Not supported. Use -collectionView:dataForItemsAtIndexes:fortype:
 
         // if the direction is backward (-1) check with the bottom anchor
         if (aDirection === -1)
-            [indexes addIndexesInRange:CPMakeRange(anIndex, bottomAnchor - anIndex + 1)];
+            [indexes addIndexesInRange:_CPMakeRange(anIndex, bottomAnchor - anIndex + 1)];
         else
-            [indexes addIndexesInRange:CPMakeRange(topAnchor, anIndex -  topAnchor + 1)];
+            [indexes addIndexesInRange:_CPMakeRange(topAnchor, anIndex -  topAnchor + 1)];
     }
     else
         indexes = [CPIndexSet indexSetWithIndex:anIndex];
@@ -1238,7 +1240,7 @@ Not supported. Use -collectionView:dataForItemsAtIndexes:fortype:
 {
     var frame = [self frameForItemsAtIndexes:[self selectionIndexes]];
 
-    if (!CGRectIsEmpty(frame))
+    if (!_CGRectIsNull(frame))
         [self scrollRectToVisible:frame];
 }
 
@@ -1386,10 +1388,10 @@ var CPCollectionViewMinItemSizeKey              = @"CPCollectionViewMinItemSizeK
 {
     [super encodeWithCoder:aCoder];
 
-    if (!CGSizeEqualToSize(_minItemSize, CGSizeMakeZero()))
+    if (!_CGSizeEqualToSize(_minItemSize, _CGSizeMakeZero()))
       [aCoder encodeSize:_minItemSize forKey:CPCollectionViewMinItemSizeKey];
 
-    if (!CGSizeEqualToSize(_maxItemSize, CGSizeMakeZero()))
+    if (!_CGSizeEqualToSize(_maxItemSize, _CGSizeMakeZero()))
       [aCoder encodeSize:_maxItemSize forKey:CPCollectionViewMaxItemSizeKey];
 
     [aCoder encodeInt:_maxNumberOfRows forKey:CPCollectionViewMaxNumberOfRowsKey];

AppKit/CPColor.j

@@ -156,15 +156,11 @@ var cachedBlackColor,
 }
 
 /*!
-    Creates a new color based on the given HSB components.
+    Creates a new color in HSB space.
 
-    Note: earlier versions of this method took a hue component as degrees between 0-360,
-    and saturation and brightness components as percent between 0-100. This method has
-    now been corrected to take all components in the 0-1 range as in Cocoa.
-
-    @param hue the hue component (0.0-1.0)
-    @param saturation the saturation component (0.0-1.0)
-    @param brightness the brightness component (0.0-1.0)
+    @param hue the hue value
+    @param saturation the saturation value
+    @param brightness the brightness value
 
     @return the initialized color
 */
@@ -173,61 +169,25 @@ var cachedBlackColor,
     return [self colorWithHue:hue saturation:saturation brightness:brightness alpha:1.0];
 }
 
-/*!
-    Calibrated colors are not supported in Cappuccino.
-
-    This method has the same result as [CPColor colorWithHue:saturation:brightness:alpha:].
-*/
-+ (CPColor)colorWithCalibratedHue:(float)hue saturation:(float)saturation brightness:(float)brightness alpha:(float)alpha
-{
-    return [self colorWithHue:hue saturation:saturation brightness:brightness alpha:alpha];
-}
-
-/*!
-    Creates a new color based on the given HSB components.
-
-    Note: earlier versions of this method took a hue component as degrees between 0-360,
-    and saturation and brightness components as percent between 0-100. This method has
-    now been corrected to take all components in the 0-1 range as in Cocoa.
-
-    @param hue the hue component (0.0-1.0)
-    @param saturation the saturation component (0.0-1.0)
-    @param brightness the brightness component (0.0-1.0)
-    @param alpha the opacity component (0.0-1.0)
-
-    @return the initialized color
-*/
 + (CPColor)colorWithHue:(float)hue saturation:(float)saturation brightness:(float)brightness alpha:(float)alpha
 {
-    // Clamp values.
-    hue = MAX(MIN(hue, 1.0), 0.0);
-    saturation = MAX(MIN(saturation, 1.0), 0.0);
-    brightness = MAX(MIN(brightness, 1.0), 0.0);
-
     if (saturation === 0.0)
-        return [CPColor colorWithCalibratedWhite:brightness alpha:alpha];
+        return [CPColor colorWithCalibratedWhite:brightness / 100.0 alpha:alpha];
 
-    var f = (hue * 360) % 60,
-        p = (brightness * (1 - saturation)),
-        q = (brightness * (60 - saturation * f)) / 60,
-        t = (brightness * (60 - saturation * (60 - f))) / 60,
-        b = brightness;
+    var f = hue % 60,
+        p = (brightness * (100 - saturation)) / 10000,
+        q = (brightness * (6000 - saturation * f)) / 600000,
+        t = (brightness * (6000 - saturation * (60 -f))) / 600000,
+        b =  brightness / 100.0;
 
-    switch (FLOOR(hue * 6))
+    switch (FLOOR(hue / 60))
     {
-        case 0:
-        case 6:
-            return [CPColor colorWithCalibratedRed:b green:t blue:p alpha:alpha];
-        case 1:
-            return [CPColor colorWithCalibratedRed:q green:b blue:p alpha:alpha];
-        case 2:
-            return [CPColor colorWithCalibratedRed:p green:b blue:t alpha:alpha];
-        case 3:
-            return [CPColor colorWithCalibratedRed:p green:q blue:b alpha:alpha];
-        case 4:
-            return [CPColor colorWithCalibratedRed:t green:p blue:b alpha:alpha];
-        case 5:
-            return [CPColor colorWithCalibratedRed:b green:p blue:q alpha:alpha];
+        case 0: return [CPColor colorWithCalibratedRed:b green:t blue:p alpha:alpha];
+        case 1: return [CPColor colorWithCalibratedRed:q green:b blue:p alpha:alpha];
+        case 2: return [CPColor colorWithCalibratedRed:p green:b blue:t alpha:alpha];
+        case 3: return [CPColor colorWithCalibratedRed:p green:q blue:b alpha:alpha];
+        case 4: return [CPColor colorWithCalibratedRed:t green:p blue:b alpha:alpha];
+        case 5: return [CPColor colorWithCalibratedRed:b green:p blue:q alpha:alpha];
     }
 }
 
@@ -615,9 +575,6 @@ var cachedBlackColor,
 
 /*!
     Returns an array with the HSB values for this color.
-
-    The values are expressed as fractions between 0.0-1.0.
-
     The index values are ordered as:
 <pre>
 <b>Index</b>   <b>Component</b>
@@ -664,36 +621,12 @@ var cachedBlackColor,
     }
 
     return [
-        hue,
-        saturation,
-        brightness
+        ROUND(hue * 360.0),
+        ROUND(saturation * 100.0),
+        ROUND(brightness * 100.0)
     ];
 }
 
-/*!
-    Returns the hue component, the H in HSB, of the receiver.
-*/
-- (float)hueComponent
-{
-    return [self hsbComponents][0];
-}
-
-/*!
-    Returns the saturation component, the S in HSB, of the receiver.
-*/
-- (float)saturationComponent
-{
-    return [self hsbComponents][1];
-}
-
-/*!
-    Returns the brightness component, the B in HSB, of the receiver.
-*/
-- (float)brightnessComponent
-{
-    return [self hsbComponents][2];
-}
-
 /*!
     Returns the CSS representation of this color. The color will
     be in one of the following forms:

AppKit/CPColorPicker.j

@@ -115,12 +115,12 @@
 
 - (id)initView
 {
-    var aFrame = CGRectMake(0, 0, CPColorPickerViewWidth, CPColorPickerViewHeight);
+    var aFrame = _CGRectMake(0, 0, CPColorPickerViewWidth, CPColorPickerViewHeight);
 
     _pickerView = [[CPView alloc] initWithFrame:aFrame];
     [_pickerView setAutoresizingMask:CPViewWidthSizable | CPViewHeightSizable];
 
-    _brightnessSlider = [[CPSlider alloc] initWithFrame:CGRectMake(0, (aFrame.size.height - 34), aFrame.size.width, 15)];
+    _brightnessSlider = [[CPSlider alloc] initWithFrame:_CGRectMake(0, (aFrame.size.height - 34), aFrame.size.width, 15)];
 
     [_brightnessSlider setValue:15.0 forThemeAttribute:@"track-width"];
     [_brightnessSlider setValue:[CPColor colorWithPatternImage:[[CPImage alloc] initWithContentsOfFile:[[CPBundle bundleForClass:[CPColorPicker class]] pathForResource:@"brightness_bar.png"]]] forThemeAttribute:@"track-color"];
@@ -133,7 +133,7 @@
     [_brightnessSlider setAction:@selector(brightnessSliderDidChange:)];
     [_brightnessSlider setAutoresizingMask:CPViewWidthSizable | CPViewMinYMargin];
 
-    _hueSaturationView = [[__CPColorWheel alloc] initWithFrame:CGRectMake(0, 0, aFrame.size.width, aFrame.size.height - 38)];
+    _hueSaturationView = [[__CPColorWheel alloc] initWithFrame:_CGRectMake(0, 0, aFrame.size.width, aFrame.size.height - 38)];
     [_hueSaturationView setDelegate:self];
     [_hueSaturationView setAutoresizingMask:(CPViewWidthSizable | CPViewHeightSizable)];
 
@@ -158,12 +158,12 @@
         brightness = [_brightnessSlider floatValue];
 
     [_hueSaturationView setWheelBrightness:brightness / 100.0];
-    [_brightnessSlider setBackgroundColor:[CPColor colorWithHue:hue / 360.0 saturation:saturation / 100.0 brightness:1]];
+    [_brightnessSlider setBackgroundColor:[CPColor colorWithHue:hue saturation:saturation brightness:100]];
 
     var colorPanel = [self colorPanel],
         opacity = [colorPanel opacity];
 
-    _cachedColor = [CPColor colorWithHue:hue / 360.0 saturation:saturation / 100.0 brightness:brightness / 100.0 alpha:opacity];
+    _cachedColor = [CPColor colorWithHue:hue saturation:saturation brightness:brightness alpha:opacity];
 
     [[self colorPanel] setColor:_cachedColor];
 }
@@ -194,10 +194,10 @@
     var hsb = [newColor hsbComponents];
 
     [_hueSaturationView setPositionToColor:newColor];
-    [_brightnessSlider setFloatValue:hsb[2] * 100.0];
-    [_hueSaturationView setWheelBrightness:hsb[2]];
+    [_brightnessSlider setFloatValue:hsb[2]];
+    [_hueSaturationView setWheelBrightness:hsb[2] / 100.0];
 
-    [_brightnessSlider setBackgroundColor:[CPColor colorWithHue:hsb[0] saturation:hsb[1] brightness:1]];
+    [_brightnessSlider setBackgroundColor:[CPColor colorWithHue:hsb[0] saturation:hsb[1] brightness:100]];
 }
 
 - (CPImage)provideNewButtonImage
@@ -366,8 +366,8 @@
 {
     var hsb    = [aColor hsbComponents],
         bounds = [self bounds],
-        angle    = [self degreesToRadians:hsb[0] * 360.0],
-        distance = hsb[1] * _radius;
+        angle    = [self degreesToRadians:hsb[0]],
+        distance = (hsb[1] / 100.0) * _radius;
 
     [self setAngle:angle distance:distance];
 }

AppKit/CPColorWell.j

@@ -61,10 +61,10 @@ var _CPColorWellDidBecomeExclusiveNotification = @"_CPColorWellDidBecomeExclusiv
 + (id)themeAttributes
 {
     return @{
-            @"bezel-inset": CGInsetMakeZero(),
+            @"bezel-inset": _CGInsetMakeZero(),
             @"bezel-color": [CPNull null],
-            @"content-inset": CGInsetMake(3.0, 3.0, 3.0, 3.0),
-            @"content-border-inset": CGInsetMakeZero(),
+            @"content-inset": _CGInsetMake(3.0, 3.0, 3.0, 3.0),
+            @"content-border-inset": _CGInsetMakeZero(),
             @"content-border-color": [CPNull null],
         };
 }
@@ -249,21 +249,21 @@ var _CPColorWellDidBecomeExclusiveNotification = @"_CPColorWellDidBecomeExclusiv
 {
     var contentInset = [self currentValueForThemeAttribute:@"content-inset"];
 
-    return CGRectInsetByInset(bounds, contentInset);
+    return _CGRectInsetByInset(bounds, contentInset);
 }
 
 - (CGRect)bezelRectForBounds:(CGRect)bounds
 {
     var bezelInset = [self currentValueForThemeAttribute:@"bezel-inset"];
 
-    return CGRectInsetByInset(bounds, bezelInset);
+    return _CGRectInsetByInset(bounds, bezelInset);
 }
 
 - (CGRect)contentBorderRectForBounds:(CGRect)bounds
 {
     var contentBorderInset = [self currentValueForThemeAttribute:@"content-border-inset"];
 
-    return CGRectInsetByInset(bounds, contentBorderInset);
+    return _CGRectInsetByInset(bounds, contentBorderInset);
 }
 
 - (CGRect)rectForEphemeralSubviewNamed:(CPString)aName
@@ -283,7 +283,7 @@ var _CPColorWellDidBecomeExclusiveNotification = @"_CPColorWellDidBecomeExclusiv
 
 - (CPView)createEphemeralSubviewNamed:(CPString)aName
 {
-    var view = [[CPView alloc] initWithFrame:CGRectMakeZero()];
+    var view = [[CPView alloc] initWithFrame:_CGRectMakeZero()];
 
     [view setHitTests:NO];
 

AppKit/CPComboBox.j

@@ -61,8 +61,8 @@ var CPComboBoxTextSubview = @"text",
 + (id)themeAttributes
 {
     return @{
-                @"popup-button-size": CGSizeMake(21.0, 29.0),
-                @"border-inset": CGInsetMake(3.0, 3.0, 3.0, 3.0),
+                @"popup-button-size": _CGSizeMake(21.0, 29.0),
+                @"border-inset": _CGInsetMake(3.0, 3.0, 3.0, 3.0),
             };
 }
 
@@ -854,7 +854,7 @@ var CPComboBoxTextSubview = @"text",
 {
     if (aName === "popup-button-view")
     {
-        var view = [[_CPComboBoxPopUpButton alloc] initWithFrame:CGRectMakeZero() comboBox:self];
+        var view = [[_CPComboBoxPopUpButton alloc] initWithFrame:_CGRectMakeZero() comboBox:self];
 
         return view;
     }

AppKit/CPControl.j

@@ -117,11 +117,11 @@ var CPControlBlackColor = [CPColor blackColor];
             @"text-color": [CPColor blackColor],
             @"font": [CPFont systemFontOfSize:CPFontCurrentSystemSize],
             @"text-shadow-color": [CPNull null],
-            @"text-shadow-offset": CGSizeMakeZero(),
+            @"text-shadow-offset": _CGSizeMakeZero(),
             @"image-position": CPImageLeft,
             @"image-scaling": CPScaleToFit,
-            @"min-size": CGSizeMakeZero(),
-            @"max-size": CGSizeMake(-1.0, -1.0),
+            @"min-size": _CGSizeMakeZero(),
+            @"max-size": _CGSizeMake(-1.0, -1.0),
         };
 }
 

AppKit/CPDatePicker/CPDatePicker.j

@@ -1,691 +0,0 @@
-/* CPDatePicker.j
-* AppKit
-*
-* Created by Alexandre Wilhelm
-* Copyright 2012 <alexandre.wilhelmfr@gmail.com>
-*
-* This library is free software; you can redistribute it and/or
-* modify it under the terms of the GNU Lesser General Public
-* License as published by the Free Software Foundation; either
-* version 2.1 of the License, or (at your option) any later version.
-*
-* This library is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
-* Lesser General Public License for more details.
-*
-* You should have received a copy of the GNU Lesser General Public
-* License along with this library; if not, write to the Free Software
-* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-*/
-
-@import "CPControl.j"
-@import "CPFont.j"
-@import "CPTextField.j"
-@import "_CPDatePickerTextField.j"
-@import "_CPDatePickerCalendar.j"
-
-@import <Foundation/CPArray.j>
-@import <Foundation/CPObject.j>
-@import <Foundation/CPDate.j>
-@import <Foundation/CPDateFormatter.j>
-@import <Foundation/CPLocale.j>
-@import <Foundation/CPTimeZone.j>
-
-@class CPStepper
-@class CPApp
-
-@global CPLocaleLanguageCode
-@global CPDateFormatterShortStyle
-
-var CPDatePicker_validateProposedDateValue_timeInterval = 1 << 1;
-
-CPSingleDateMode = 0;
-CPRangeDateMode = 1;
-
-CPTextFieldAndStepperDatePickerStyle    = 0;
-CPClockAndCalendarDatePickerStyle       = 1;
-CPTextFieldDatePickerStyle              = 2;
-
-CPHourMinuteDatePickerElementFlag       = 0x000c;
-CPHourMinuteSecondDatePickerElementFlag = 0x000e;
-CPTimeZoneDatePickerElementFlag         = 0x0010;
-CPYearMonthDatePickerElementFlag        = 0x00c0;
-CPYearMonthDayDatePickerElementFlag     = 0x00e0;
-CPEraDatePickerElementFlag              = 0x0100;
-
-/*!
-    @ingroup appkit
-    This control displays a datepicker in a Cappuccino application
-*/
-@implementation CPDatePicker : CPControl
-{
-    BOOL            _isBordered         @accessors(getter=isBordered, setter=setBordered:);
-    BOOL            _isBezeled          @accessors(getter=isBezeled, setter=setBezeled:);
-    BOOL            _drawsBackground    @accessors(property=drawsBackground);
-    CPDate          _dateValue          @accessors(property=dateValue);
-    CPDate          _minDate            @accessors(property=minDate);
-    CPDate          _maxDate            @accessors(property=maxDate);
-    CPFont          _textFont           @accessors(property=textFont);
-    CPLocale        _locale             @accessors(property=locale);
-    //CPCalendar  _calendar           @accessors(property=calendar);
-    CPTimeZone      _timeZone           @accessors(property=timeZone);
-    id              _delegate           @accessors(property=delegate);
-    unsigned        _datePickerElements @accessors(property=datePickerElements);
-    CPInteger       _datePickerMode     @accessors(property=datePickerMode);
-    CPInteger       _datePickerStyle    @accessors(property=datePickerStyle);
-    CPInteger       _timeInterval       @accessors(property=timeInterval);
-
-    _CPDatePickerTextField  _datePickerTextfield;
-    _CPDatePickerCalendar   _datePickerCalendar;
-    unsigned                _implementedCDatePickerDelegateMethods;
-}
-
-
-#pragma mark -
-#pragma mark Theme methods
-
-+ (CPString)defaultThemeClass
-{
-    return @"datePicker";
-}
-
-+ (id)themeAttributes
-{
-    return @{
-            @"bezel-color": [CPColor clearColor],
-            @"border-width" : 1.0,
-            @"border-color": [CPColor clearColor],
-            @"content-inset": CGInsetMakeZero(),
-            @"bezel-inset": CGInsetMakeZero(),
-            @"datepicker-textfield-bezel-color": [CPColor clearColor],
-            @"min-size-datepicker-textfield": CGSizeMakeZero(),
-            @"content-inset-datepicker-textfield": CGInsetMakeZero(),
-            @"content-inset-datepicker-textfield-separator": CGInsetMakeZero(),
-            @"separator-content-inset": CGInsetMakeZero(),
-            @"date-hour-margin": 5.0,
-            @"stepper-margin": 5.0,
-            @"bezel-color-calendar": [CPColor clearColor],
-            @"title-text-color": [CPColor blackColor],
-            @"title-text-shadow-color": [CPColor clearColor],
-            @"title-text-shadow-offset": CGSizeMakeZero(),
-            @"title-font": [CPNull null],
-            @"weekday-text-color": [CPColor blackColor],
-            @"weekday-text-shadow-color": [CPColor clearColor],
-            @"weekday-text-shadow-offset": CGSizeMakeZero(),
-            @"weekday-font": [CPNull null],
-            @"arrow-image-left": [CPNull null],
-            @"arrow-image-right": [CPNull null],
-            @"arrow-image-left-highlighted": [CPNull null],
-            @"arrow-image-right-highlighted": [CPNull null],
-            @"arrow-inset": CGInsetMakeZero(),
-            @"circle-image": [CPNull null],
-            @"circle-image-highlighted": [CPNull null],
-            @"tile-text-color": [CPColor blackColor],
-            @"tile-text-shadow-color": [CPColor clearColor],
-            @"tile-text-shadow-offset": CGSizeMakeZero(),
-            @"tile-font": [CPNull null],
-            @"size-tile": CGSizeMakeZero(),
-            @"size-calendar": CGSizeMakeZero(),
-            @"size-header": CGSizeMakeZero(),
-            @"min-size-calendar": CGSizeMakeZero(),
-            @"max-size-calendar": CGSizeMakeZero(),
-            @"bezel-color-clock": [CPColor clearColor],
-            @"clock-text-color": [CPColor blackColor],
-            @"clock-text-shadow-color": [CPColor clearColor],
-            @"clock-text-shadow-offset": CGSizeMakeZero(),
-            @"clock-font": [CPNull null],
-            @"second-hand-color": [CPColor clearColor],
-            @"hour-hand-color": [CPColor clearColor],
-            @"middle-hand-color": [CPColor clearColor],
-            @"minute-hand-color": [CPColor clearColor],
-            @"size-clock": CGSizeMakeZero(),
-            @"second-hand-size": CGSizeMakeZero(),
-            @"hour-hand-size": CGSizeMakeZero(),
-            @"middle-hand-size": CGSizeMakeZero(),
-            @"minute-hand-size": CGSizeMakeZero(),
-    };
-}
-
-
-#pragma mark -
-#pragma mark Binding methods
-
-+ (Class)_binderClassForBinding:(CPString)theBinding
-{
-    if (theBinding == CPValueBinding || theBinding == CPMinValueBinding || theBinding == CPMaxValueBinding)
-        return [_CPDatePickerValueBinder class];
-
-    return [super _binderClassForBinding:theBinding];
-}
-
-- (id)_replacementKeyPathForBinding:(CPString)aBinding
-{
-    if (aBinding == CPValueBinding)
-        return @"dateValue";
-
-    if (aBinding == CPMinValueBinding)
-        return @"minDate";
-
-    if (aBinding == CPMaxValueBinding)
-        return @"maxDate";
-
-    return [super _replacementKeyPathForBinding:aBinding];
-}
-
-
-#pragma mark -
-#pragma mark Init methods
-
-- (id)initWithFrame:(CGRect)aFrame
-{
-    if (self = [super initWithFrame:aFrame])
-    {
-        _drawsBackground = YES;
-        _datePickerStyle = CPTextFieldAndStepperDatePickerStyle;
-        _datePickerMode = CPSingleDateMode;
-        _datePickerElements = CPYearMonthDayDatePickerElementFlag | CPHourMinuteSecondDatePickerElementFlag;
-        _timeInterval = 0;
-        _implementedCDatePickerDelegateMethods = 0;
-
-        [self setObjectValue:[CPDate date]];
-        _minDate = [CPDate distantPast];
-        _maxDate = [CPDate distantFuture];
-
-        [self setBezeled:YES];
-        [self setBordered:YES];
-
-        [self _init];
-    }
-
-    return self
-}
-
-- (void)_init
-{
-    if (!_locale)
-        _locale = [CPLocale currentLocale];
-
-    if (!_timeZone)
-        _timeZone = [CPTimeZone systemTimeZone];
-
-    _datePickerTextfield = [[_CPDatePickerTextField alloc] initWithFrame:[self bounds] withDatePicker:self];
-
-    [_datePickerTextfield setDateValue:_dateValue];
-    [self addSubview:_datePickerTextfield];
-
-    _datePickerCalendar = [[_CPDatePickerCalendar alloc] initWithFrame:[self bounds] withDatePicker:self];
-    [_datePickerCalendar setDateValue:_dateValue];
-    [_datePickerCalendar setHidden:YES];
-    [self addSubview:_datePickerCalendar];
-
-    [self setNeedsDisplay:YES];
-    [self setNeedsLayout];
-}
-
-
-#pragma mark -
-#pragma mark Delegate methods
-
-/*! Set the delegate of the datePicker
-    @param aDelegate delegate of the datePicker
-*/
-- (void)setDelegate:(id)aDelegate
-{
-    _delegate = aDelegate;
-    _implementedCDatePickerDelegateMethods = 0;
-
-    // Look if the delegate implements or not the delegate methods
-    if ([_delegate respondsToSelector:@selector(datePicker:validateProposedDateValue:timeInterval:)])
-        _implementedCDatePickerDelegateMethods |= CPDatePicker_validateProposedDateValue_timeInterval;
-}
-
-
-#pragma mark -
-#pragma mark Layout method
-
-/*! Layout the subviews
-*/
-- (void)layoutSubviews
-{
-    [super layoutSubviews];
-
-    if (_datePickerStyle == CPTextFieldAndStepperDatePickerStyle || _datePickerStyle == CPTextFieldDatePickerStyle)
-    {
-        [_datePickerTextfield setHidden:NO];
-        [_datePickerCalendar setHidden:YES];
-        [_datePickerTextfield setNeedsLayout];
-    }
-    else
-    {
-        [_datePickerCalendar setHidden:NO];
-        [_datePickerTextfield setHidden:YES];
-        [_datePickerCalendar setNeedsLayout];
-    }
-}
-
-#pragma mark -
-#pragma mark Setter
-
-/*! Return the objectValue of the datePicker. The objectValue should take the timeZoneEffect
-*/
-- (void)objectValue
-{
-    // TODO : add timeZone effect. How to do it because js ???
-    return _dateValue
-}
-
-/*! Set the objectValue ofhe datePier. It has to be a CPDate
-    @param aDateValue the dateValue
-*/
-- (void)setObjectValue:(CPDate)aValue
-{
-    [self setDateValue:aValue];
-}
-
-/* Set the dateValue of the datePicker
-    @param aDateValue the dateValue
-*/
-- (void)setDateValue:(CPDate)aDateValue
-{
-    if (aDateValue == nil)
-        return;
-
-    [self _setDateValue:aDateValue timeInterval:_timeInterval];
-}
-
-/*! Set the dateValue and the timeInterval. This method checks the min and max date of the datePicker also. It will call the delegate if possible.
-    @param aDateValue the dateValue
-    @param aTimeInterval the timeInterval
-*/
-- (void)_setDateValue:(CPDate)aDateValue timeInterval:(CPTimeInterval)aTimeInterval
-{
-    if (_minDate)
-        aDateValue = new Date (MAX(aDateValue, _minDate));
-
-    if (_maxDate)
-        aDateValue = new Date (MIN(aDateValue, _maxDate));
-
-    aTimeInterval = MAX(MIN(aTimeInterval, [_maxDate timeIntervalSinceDate:aDateValue]), [_minDate timeIntervalSinceDate:aDateValue]);
-
-    if ([aDateValue isEqualToDate:_dateValue] && aTimeInterval == _timeInterval)
-        return;
-
-    if (_implementedCDatePickerDelegateMethods & CPDatePicker_validateProposedDateValue_timeInterval)
-    {
-        // constrain timeInterval also
-        var aStartDateRef = function(x){if (typeof x == 'undefined') return aDateValue; aDateValue = x;}
-        var aTimeIntervalRef = function(x){if (typeof x == 'undefined') return aTimeInterval; aTimeInterval = x;}
-
-        [_delegate datePicker:self validateProposedDateValue:aStartDateRef timeInterval:aTimeIntervalRef];
-    }
-
-    [self willChangeValueForKey:@"objectValue"];
-    [self willChangeValueForKey:@"dateValue"];
-    _dateValue = aDateValue;
-    [super setObjectValue:_dateValue];
-    [self didChangeValueForKey:@"objectValue"];
-    [self didChangeValueForKey:@"dateValue"];
-
-    [self willChangeValueForKey:@"timeInterval"];
-    _timeInterval = (_datePickerMode == CPSingleDateMode)? 0 : aTimeInterval;
-    [self didChangeValueForKey:@"timeInterval"];
-
-    [self sendAction:[self action] to:[self target]];
-
-    if (_datePickerStyle == CPTextFieldAndStepperDatePickerStyle || _datePickerStyle == CPTextFieldDatePickerStyle)
-        [_datePickerTextfield setDateValue:_dateValue];
-    else
-        [_datePickerCalendar setDateValue:_dateValue];
-}
-
-/*! Set the minDate of the datePicker
-    @param aMinDate the minDate
-*/
-- (void)setMinDate:(CPDate)aMinDate
-{
-    [self willChangeValueForKey:@"minDate"];
-    _minDate = aMinDate;
-    [self didChangeValueForKey:@"minDate"];
-
-    [self _setDateValue:_dateValue timeInterval:_timeInterval];
-}
-
-/*! Set the maxDate of the datePicker
-    @param aMaxDate the maxDate
-*/
-- (void)setMaxDate:(CPDate)aMaxDate
-{
-    [self willChangeValueForKey:@"maxDate"];
-    _maxDate = aMaxDate;
-    [self didChangeValueForKey:@"maxDate"];
-
-    [self _setDateValue:_dateValue timeInterval:_timeInterval];
-}
-
-/*! Set the syle of the datePicker
-    @param aDatePickerStyle the datePicker style
-*/
-- (void)setDatePickerStyle:(CPDate)aDatePickerStyle
-{
-    _datePickerStyle = aDatePickerStyle;
-
-    [self setNeedsDisplay:YES];
-    [self setNeedsLayout];
-}
-
-/*! Set the elements of the datePicker
-    @param aDatePickerElements the datePicker elements
-*/
-- (void)setDatePickerElements:(CPDate)aDatePickerElements
-{
-    _datePickerElements = aDatePickerElements;
-
-    [self setNeedsDisplay:YES];
-    [self setNeedsLayout];
-}
-
-/*! Set the mode of the datePicker
-    @param aDatePickerMode the datePicker mode
-*/
-- (void)setDatePickerMode:(CPDate)aDatePickerMode
-{
-    _datePickerMode = aDatePickerMode;
-
-    if (_datePickerMode == CPSingleDateMode)
-        [self _setDateValue:[self dateValue] timeInterval:0];
-
-    [self setNeedsDisplay:YES];
-    [self setNeedsLayout];
-}
-
-/*! Set the timeInterval of the datePicker
-    @param aTimeInterval the timeInterval of the datePicker
-*/
-- (void)setTimeInterval:(CPInteger)aTimeInterval
-{
-    if (_datePickerMode == CPSingleDateMode)
-        return;
-
-    [self _setDateValue:[self dateValue] timeInterval:aTimeInterval];
-}
-
-/*! Set the locale of the datePicker. This update laso the locale of the formatter.
-    @param aLocale the locale
-*/
-- (void)setLocale:(CPLocale)aLocale
-{
-    _locale = aLocale;
-
-    if (_formatter)
-    {
-        [self willChangeValueForKey:@"locale"];
-        [_formatter setLocale:_locale];
-        [self didChangeValueForKey:@"locale"];
-    }
-
-    // This will update the textFields (usefull when changing with a date with pm and am)
-    [_datePickerTextfield setDateValue:_dateValue];
-    [self setNeedsDisplay:YES];
-    [self setNeedsLayout];
-}
-
-/*!
-    Sets whether the datepicker will have a bezeled border.
-    @param shouldBeBezeled \c YES means the datepicker will draw a bezeled border
-*/
-- (void)setBezeled:(BOOL)shouldBeBezeled
-{
-    _isBezeled = shouldBeBezeled;
-
-    if (shouldBeBezeled)
-        [self setThemeState:CPThemeStateBezeled];
-    else
-        [self unsetThemeState:CPThemeStateBezeled];
-}
-
-/*!
-    Sets whether the datepicker will have a border drawn. (actually it does nothing)
-    @param shouldBeBordered \c YES makes the datepicker draw a border
-*/
-- (void)setBordered:(BOOL)shouldBeBordered
-{
-    _isBordered = shouldBeBordered;
-
-    if (shouldBeBordered)
-        [self setThemeState:CPThemeStateBordered];
-    else
-        [self unsetThemeState:CPThemeStateBordered];
-}
-
-/*!
-    Sets the font of the control.
-    @param aFont
-*/
-- (void)setTextFont:(CPFont)aFont
-{
-    [self setFont:aFont];
-}
-
-/*! Sets the enabled status of the control. Controls that are not enabled can not be used by the user and obtain the CPThemeStateDisabled theme state.
-    @param a boolean. YES if the control should be enabled, otherwise NO.
-*/
-- (void)setEnabled:(BOOL)aBoolean
-{
-    [super setEnabled:aBoolean];
-
-    [_datePickerTextfield setEnabled:aBoolean];
-    [_datePickerCalendar setEnabled:aBoolean];
-}
-
-/*! Set the background color of the datePicker
-    @param aColor
-*/
-- (void)setBackgroundColor:(CPColor)aColor
-{
-    _backgroundColor = aColor;
-    [self setNeedsLayout];
-}
-
-/*! Set the boolean drawsBackgroundColor
-    @param aBoolean
-*/
-- (void)setDrawsBackground:(BOOL)aBoolean
-{
-    [self willChangeValueForKey:@"drawsBackground"];
-    _drawsBackground = aBoolean;
-    [self didChangeValueForKey:@"drawsBackground"];
-
-    [self setNeedsLayout];
-}
-
-/*! Set the timeZone
-    @param aTimeZone
-*/
-- (void)setTimeZone:(CPTimeZone)aTimeZone
-{
-    [self willChangeValueForKey:@"timeZone"];
-    _timeZone = aTimeZone;
-    [self didChangeValueForKey:@"timeZone"];
-
-    [self setNeedsLayout];
-}
-
-
-#pragma mark -
-#pragma mark First responder methods
-
-/*! Return YES if style is set to CPTextFieldAndStepperDatePickerStyle or CPTextFieldDatePickerStyle
-*/
-- (BOOL)becomeFirstResponder
-{
-    if (_datePickerStyle == CPTextFieldAndStepperDatePickerStyle || _datePickerStyle == CPTextFieldDatePickerStyle)
-        [_datePickerTextfield _selecteTextFieldWithFlags:[[CPApp currentEvent] modifierFlags]];
-    else
-        return NO;
-
-    return YES;
-}
-
-/*! Return YES
-*/
-- (BOOL)acceptsFirstResponder
-{
-    return YES;
-}
-
-/*! Return YES
-*/
-- (BOOL)resignFirstResponder
-{
-    if (_datePickerStyle == CPTextFieldAndStepperDatePickerStyle || _datePickerStyle == CPTextFieldDatePickerStyle)
-        [_datePickerTextfield resignFirstResponder];
-
-    return YES;
-}
-
-
-#pragma mark -
-#pragma mark getter
-
-/*!
-    Returns \c YES if the textfield is bezeled.
-*/
-- (BOOL)isBezeled
-{
-    return [self hasThemeState:CPThemeStateBezeled];
-}
-
-/*!
-    Returns \c YES if the textfield has a border.
-*/
-- (BOOL)isBordered
-{
-    return [self hasThemeState:CPThemeStateBordered];
-}
-
-/*!
-    Returns the font of the control.
-*/
-- (CPFont)textFont
-{
-    return [self font];
-}
-
-/*! Check if we are in the american format or not. Depending on the locale
-*/
-- (BOOL)_isAmericanFormat
-{
-    return [[_locale objectForKey:CPLocaleCountryCode] isEqualToString:@"US"];
-}
-
-/*! Check if we are in the english format or not. Depending on the locale
-*/
-- (BOOL)_isEnglishFormat
-{
-    return [[_locale objectForKey:CPLocaleLanguageCode] isEqualToString:@"en"];
-}
-
-
-#pragma mark -
-#pragma mark Key event
-
-/*! Key down event
-    @param anEvent
-*/
-- (void)keyDown:(CPEvent)anEvent
-{
-    if (_datePickerStyle == CPTextFieldAndStepperDatePickerStyle || _datePickerStyle == CPTextFieldDatePickerStyle)
-        [_datePickerTextfield keyDown:anEvent];
-}
-
-@end
-
-var CPDatePickerModeKey         = @"CPDatePickerModeKey",
-    CPIntervalKey               = @"CPIntervalKey",
-    CPMinDateKey                = @"CPMinDateKey",
-    CPMaxDateKey                = @"CPMaxDateKey",
-    CPBackgroundColorKey        = @"CPBackgroundColorKey",
-    CPDrawsBackgroundKey        = @"CPDrawsBackgroundKey",
-    CPTextFontKey               = @"CPTextFontKey",
-    CPDatePickerElementsKey     = @"CPDatePickerElementsKey",
-    CPDatePickerStyleKey        = @"CPDatePickerStyleKey",
-    CPLocaleKey                 = @"CPLocaleKey",
-    CPBorderedKey               = @"CPBorderedKey",
-    CPDateValueKey              = @"CPDateValueKey";
-
-@implementation CPDatePicker (CPCoding)
-
-- (id)initWithCoder:(CPCoder)aCoder
-{
-    self = [super initWithCoder:aCoder];
-
-    if (self)
-    {
-        _textFont = [aCoder decodeObjectForKey:CPTextFontKey];
-        _minDate = [aCoder decodeObjectForKey:CPMinDateKey] || [CPDate distantPast];
-        _maxDate = [aCoder decodeObjectForKey:CPMaxDateKey] || [CPDate distantFuture];
-        _timeInterval = [aCoder decodeDoubleForKey:CPIntervalKey];
-        _datePickerMode = [aCoder decodeIntForKey:CPDatePickerModeKey];
-        _datePickerElements = [aCoder decodeIntForKey:CPDatePickerElementsKey];
-        _datePickerStyle = [aCoder decodeIntForKey:CPDatePickerStyleKey];
-        _locale = [aCoder decodeObjectForKey:CPLocaleKey];
-        _dateValue = [aCoder decodeObjectForKey:CPDateValueKey];
-        _backgroundColor = [aCoder decodeObjectForKey:CPBackgroundColorKey];
-        _drawsBackground = [aCoder decodeBoolForKey:CPDrawsBackgroundKey];
-        _isBordered = [aCoder decodeBoolForKey:CPBorderedKey];
-        [self _init];
-    }
-
-    return self
-}
-
-- (void)encodeWithCoder:(CPCoder)aCoder
-{
-    [super encodeWithCoder:aCoder];
-    [aCoder encodeDouble:_timeInterval forKey:CPIntervalKey];
-    [aCoder encodeInt:_datePickerMode forKey:CPDatePickerModeKey];
-    [aCoder encodeInt:_datePickerStyle forKey:CPDatePickerStyleKey];
-    [aCoder encodeInt:_datePickerElements forKey:CPDatePickerElementsKey];
-    [aCoder encodeObject:_minDate forKey:CPMinDateKey];
-    [aCoder encodeObject:_maxDate forKey:CPMaxDateKey]
-    [aCoder encodeObject:_dateValue forKey:CPDateValueKey];;
-    [aCoder encodeObject:_textFont forKey:CPTextFontKey];
-    [aCoder encodeObject:_locale forKey:CPLocaleKey];
-    [aCoder encodeObject:_backgroundColor forKey:CPBackgroundColorKey];
-    [aCoder encodeObject:_drawsBackground forKey:CPDrawsBackgroundKey];
-    [aCoder encodeObject:_isBordered forKey:CPBorderedKey];
-}
-
-@end
-
-@implementation _CPDatePickerValueBinder : CPBinder
-{
-}
-
-@end
-
-@implementation CPDate (CPDatePickerAdditions)
-
-- (int)_daysInMonth
-{
-    return 32 - new Date(self.getFullYear(), self.getMonth(), 32).getDate();
-}
-
-- (void)_resetToMidnight
-{
-    self.setHours(0);
-    self.setMinutes(0);
-    self.setSeconds(0);
-    self.setMilliseconds(0);
-}
-
-- (void)_resetToLastSeconds
-{
-    self.setHours(23);
-    self.setMinutes(59);
-    self.setSeconds(59);
-    self.setMilliseconds(99);
-}
-
-@end

AppKit/CPDatePicker/_CPDatePickerClock.j

@@ -1,287 +0,0 @@
-/* _CPDatePickerClock.j
-* AppKit
-*
-* Created by Alexandre Wilhelm
-* Copyright 2012 <alexandre.wilhelmfr@gmail.com>
-*
-* This library is free software; you can redistribute it and/or
-* modify it under the terms of the GNU Lesser General Public
-* License as published by the Free Software Foundation; either
-* version 2.1 of the License, or (at your option) any later version.
-*
-* This library is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
-* Lesser General Public License for more details.
-*
-* You should have received a copy of the GNU Lesser General Public
-* License along with this library; if not, write to the Free Software
-* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-*/
-
-@import "CPView.j"
-@import "CPTextField.j"
-@import "CPImageView.j"
-@import "CALayer.j"
-
-@class CPDatePicker
-
-@global CPHourMinuteSecondDatePickerElementFlag
-
-@implementation _CPDatePickerClock : CPView
-{
-    BOOL            _isEnabled;
-    CALayer         _rootLayer;
-    CALayer         _hourHandLayer;
-    CALayer         _minuteHandLayer;
-    CALayer         _secondHandLayer;
-    CALayer         _middleHandLayer;
-    CPDatePicker    _datePicker;
-    CPTextField     _PMAMTextField;
-}
-
-
-#pragma mark -
-#pragma mark Init methods
-
-/*! Init a new _CPDatePickerClock
-    @param aFrame
-    @param aDatePicker
-    @return a new instance of _CPDatePickerClock
-*/
-- (id)initWithFrame:(CGRect)aFrame datePicker:(CPDatePicker)aDatePicker
-{
-    if (self = [super initWithFrame:aFrame])
-    {
-        _datePicker = aDatePicker;
-
-        _PMAMTextField = [[CPTextField alloc] initWithFrame:CGRectMakeZero()];
-
-        [_PMAMTextField setValue:[_datePicker valueForThemeAttribute:@"clock-font" inState:CPThemeStateNormal] forThemeAttribute:@"font" inState:CPThemeStateNormal];
-        [_PMAMTextField setValue:[_datePicker valueForThemeAttribute:@"clock-text-color" inState:CPThemeStateNormal] forThemeAttribute:@"text-color" inState:CPThemeStateNormal];
-        [_PMAMTextField setValue:[_datePicker valueForThemeAttribute:@"clock-text-shadow-color" inState:CPThemeStateNormal] forThemeAttribute:@"text-shadow-color" inState:CPThemeStateNormal];
-        [_PMAMTextField setValue:[_datePicker valueForThemeAttribute:@"clock-text-shadow-offset" inState:CPThemeStateNormal] forThemeAttribute:@"text-shadow-offset" inState:CPThemeStateNormal];
-
-        [_PMAMTextField setValue:[_datePicker valueForThemeAttribute:@"clock-font" inState:CPThemeStateDisabled] forThemeAttribute:@"font" inState:CPThemeStateDisabled];
-        [_PMAMTextField setValue:[_datePicker valueForThemeAttribute:@"clock-text-color" inState:CPThemeStateDisabled] forThemeAttribute:@"text-color" inState:CPThemeStateDisabled];
-        [_PMAMTextField setValue:[_datePicker valueForThemeAttribute:@"clock-text-shadow-color" inState:CPThemeStateDisabled] forThemeAttribute:@"text-shadow-color" inState:CPThemeStateDisabled];
-        [_PMAMTextField setValue:[_datePicker valueForThemeAttribute:@"clock-text-shadow-offset" inState:CPThemeStateDisabled] forThemeAttribute:@"text-shadow-offset" inState:CPThemeStateDisabled];
-
-        [self addSubview:_PMAMTextField];
-
-        var middleHandSize = [_datePicker valueForThemeAttribute:@"middle-hand-size"],
-            minuteHandSize = [_datePicker valueForThemeAttribute:@"minute-hand-size"],
-            hourHandSize = [_datePicker valueForThemeAttribute:@"hour-hand-size"],
-            secondHandSize = [_datePicker valueForThemeAttribute:@"second-hand-size"];
-
-        // We use layer to make the rotation possible
-        _hourHandLayer = [[HandLayer alloc] initWithSize:hourHandSize];
-        [_hourHandLayer setBounds:CGRectMake(0, 0, aFrame.size.width, aFrame.size.height)];
-        [_hourHandLayer setAnchorPoint:CGPointMakeZero()];
-        [_hourHandLayer setPosition:CGPointMake(0.0, 0.0)];
-
-        _minuteHandLayer = [[HandLayer alloc] initWithSize:minuteHandSize];
-        [_minuteHandLayer setBounds:CGRectMake(0, 0, aFrame.size.width, aFrame.size.height)];
-        [_minuteHandLayer setAnchorPoint:CGPointMakeZero()];
-        [_minuteHandLayer setPosition:CGPointMake(0.0, 0.0)];
-
-        _secondHandLayer = [[HandLayer alloc] initWithSize:secondHandSize];
-        [_secondHandLayer setBounds:CGRectMake(0, 0, aFrame.size.width, aFrame.size.height)];
-        [_secondHandLayer setAnchorPoint:CGPointMakeZero()];
-        [_secondHandLayer setPosition:CGPointMake(0.0, 0.0)];
-
-        _middleHandLayer = [[HandLayer alloc] initWithSize:middleHandSize];
-        [_middleHandLayer setBounds:CGRectMake(0, 0, aFrame.size.width, aFrame.size.height)];
-        [_middleHandLayer setAnchorPoint:CGPointMakeZero()];
-        [_middleHandLayer setPosition:CGPointMake(0.0, 0.0)];
-
-        _rootLayer = [CALayer layer];
-        [self setWantsLayer:YES];
-        [self setLayer:_rootLayer];
-
-        [_hourHandLayer setNeedsDisplay];
-        [_middleHandLayer setNeedsDisplay];
-        [_secondHandLayer setNeedsDisplay];
-        [_minuteHandLayer setNeedsDisplay];
-
-        [_rootLayer addSublayer:_hourHandLayer];
-        [_rootLayer addSublayer:_minuteHandLayer];
-        [_rootLayer addSublayer:_secondHandLayer];
-        [_rootLayer addSublayer:_middleHandLayer];
-
-        [_rootLayer setNeedsDisplay];
-
-    }
-    return self;
-}
-
-
-#pragma mark -
-#pragma mark Layout methods
-
-/*! Layout the subviews
-*/
-- (void)layoutSubviews
-{
-    [super layoutSubviews];
-
-    var bounds = [self bounds],
-        dateValue = [[_datePicker dateValue] copy];
-
-    [dateValue _dateWithTimeZone:[_datePicker timeZone]];
-
-    [self setBackgroundColor:[_datePicker valueForThemeAttribute:@"bezel-color-clock" inState:[_datePicker themeState]]];
-    [_middleHandLayer setBackgroundHandColor:[_datePicker valueForThemeAttribute:@"middle-hand-color" inState:[_datePicker themeState]]];
-    [_hourHandLayer setBackgroundHandColor:[_datePicker valueForThemeAttribute:@"hour-hand-color" inState:[_datePicker themeState]]];
-    [_minuteHandLayer setBackgroundHandColor:[_datePicker valueForThemeAttribute:@"minute-hand-color" inState:[_datePicker themeState]]];
-    [_secondHandLayer setBackgroundHandColor:[_datePicker valueForThemeAttribute:@"second-hand-color" inState:[_datePicker themeState]]];
-
-    if ([_datePicker _isEnglishFormat])
-    {
-        if (dateValue.getHours() > 11)
-            [_PMAMTextField setStringValue:@"PM"]
-        else
-            [_PMAMTextField setStringValue:@"AM"];
-
-        [_PMAMTextField sizeToFit];
-        [_PMAMTextField setFrameOrigin:CGPointMake(bounds.size.width / 2 - [_PMAMTextField frameSize].width / 2, bounds.size.height / 2 + 15)];
-        [_PMAMTextField setHidden:NO];
-    }
-    else
-    {
-        [_PMAMTextField setHidden:YES];
-    }
-
-    [_hourHandLayer setRotationRadians:[self _hourPositionRadianForDate:dateValue]];
-    [_minuteHandLayer setRotationRadians:[self _minutePositionRadianForDate:dateValue]];
-    [_secondHandLayer setRotationRadians:[self _secondPositionRadianForDate:dateValue]];
-
-    // Check if we have to display the hand second
-    if (([_datePicker datePickerElements] & CPHourMinuteSecondDatePickerElementFlag) == CPHourMinuteSecondDatePickerElementFlag)
-        [_secondHandLayer setHidden:NO];
-    else
-        [_secondHandLayer setHidden:YES];
-
-    [_rootLayer setNeedsDisplay];
-}
-
-
-#pragma mark -
-#pragma mark Getter Setter methods
-
-/*! Return the radian position of the hour
-*/
-- (float)_hourPositionRadianForDate:(CPDate)aDate
-{
-    var hours = aDate.getHours() + aDate.getMinutes() / 60;
-
-    return (360 * hours / 12) * (Math.PI / 180)
-}
-
-/*! Return the radian position of the second
-*/
-- (float)_secondPositionRadianForDate:(CPDate)aDate
-{
-    return (360 * aDate.getSeconds() / 60) * (Math.PI / 180)
-}
-
-/*! Return the radian position of the minute
-*/
-- (float)_minutePositionRadianForDate:(CPDate)aDate
-{
-    var minutes = aDate.getMinutes() + aDate.getSeconds() / 60;
-
-    return (360 * minutes / 60) * (Math.PI / 180)
-}
-
-/*! Set enabled
-    @param aBoolean
-*/
-- (void)setEnabled:(BOOL)aBoolean
-{
-    _isEnabled = aBoolean;
-    [_PMAMTextField setEnabled:aBoolean];
-    [_hourHandLayer setEnabled:aBoolean];
-    [_middleHandLayer setEnabled:aBoolean];
-    [_secondHandLayer setEnabled:aBoolean];
-    [_minuteHandLayer setEnabled:aBoolean];
-
-    [self setNeedsLayout];
-}
-
-@end
-
-
-@implementation HandLayer : CALayer
-{
-    BOOL    _isEnabled      @accessors(setter=setEnabled:, getter=isEnabled);
-
-    CALayer _imageLayer;
-    float   _rotationRadians;
-}
-
-
-#pragma mark -
-#pragma mark Init methods
-
-/*! Init a new hand layer with an image. The image will be draw in a ImageLayer
-    @param anImage
-    @return a new instance of handLayer
-*/
-- (id)initWithSize:(CGSize)aSize
-{
-    if (self = [super init])
-    {
-        _isEnabled = YES;
-        _imageLayer = [CALayer layer];
-        _rotationRadians = 0;
-
-        [_imageLayer setDelegate:self];
-        [_imageLayer setBounds:CGRectMake(0.0, 0.0, aSize.width, aSize.height)];
-
-        [self addSublayer:_imageLayer];
-    }
-    return self;
-}
-
-
-#pragma mark -
-#pragma mark Setter Getter methods
-
-/*! Set the bounds of the layer. The imageLayer will be at the center of this bounds
-    @param aRect
-*/
-- (void)setBounds:(CGRect)aRect
-{
-    [super setBounds:aRect];
-
-    [_imageLayer setPosition:CGPointMake(CGRectGetMidX(aRect), CGRectGetMidY(aRect))];
-}
-
-/*! Set the rotation of the imageLayer
-    @param radians
-*/
-- (void)setRotationRadians:(float)radians
-{
-    if (_rotationRadians == radians)
-        return;
-
-    _rotationRadians = radians;
-
-    [_imageLayer setAffineTransform:CGAffineTransformScale(
-        CGAffineTransformMakeRotation(_rotationRadians),
-        1.0, 1.0)];
-}
-
-- (void)setBackgroundHandColor:(CPColor)aColor
-{
-    [_imageLayer setBackgroundColor:aColor];
-}
-
-- (void)setEnabled:(BOOL)aBoolean
-{
-    _isEnabled = aBoolean;
-    [self setNeedsDisplay];
-}
-
-@end

AppKit/CPDragServer.j

@@ -163,7 +163,7 @@ var CPDraggingSource_draggedImage_movedTo_          = 1 << 0,
 
     if (self)
     {
-        _draggedWindow = [[CPWindow alloc] initWithContentRect:CGRectMakeZero() styleMask:CPBorderlessWindowMask];
+        _draggedWindow = [[CPWindow alloc] initWithContentRect:_CGRectMakeZero() styleMask:CPBorderlessWindowMask];
 
         [_draggedWindow setLevel:CPDraggingWindowLevel];
     }
@@ -201,12 +201,7 @@ var CPDraggingSource_draggedImage_movedTo_          = 1 << 0,
 - (void)draggingSourceUpdatedWithGlobalLocation:(CGPoint)aGlobalLocation
 {
     if (![CPPlatform supportsDragAndDrop])
-    {
-        var frame = [_draggedWindow frame];
-        frame.origin.x = aGlobalLocation.x - _draggingOffset.width;
-        frame.origin.y = aGlobalLocation.y - _draggingOffset.height;
-        [_draggedWindow _setFrame:frame display:YES animate:NO constrainWidth:NO constrainHeight:NO];
-    }
+        [_draggedWindow setFrameOrigin:_CGPointMake(aGlobalLocation.x - _draggingOffset.width, aGlobalLocation.y - _draggingOffset.height)];
 
     if (_implementedDraggingSourceMethods & CPDraggingSource_draggedImage_movedTo_)
         [_draggingSource draggedImage:[_draggedView image] movedTo:aGlobalLocation];
@@ -270,10 +265,10 @@ var CPDraggingSource_draggedImage_movedTo_          = 1 << 0,
             {
                 if ([scrollView hasVerticalScroller])
                 {
-                    if (eventLocation.y < CGRectGetMinY(insetBounds))
-                        deltaY = CGRectGetMinY(insetBounds) - eventLocation.y;
-                    else if (eventLocation.y > CGRectGetMaxY(insetBounds))
-                        deltaY = CGRectGetMaxY(insetBounds) - eventLocation.y;
+                    if (eventLocation.y < _CGRectGetMinY(insetBounds))
+                        deltaY = _CGRectGetMinY(insetBounds) - eventLocation.y;
+                    else if (eventLocation.y > _CGRectGetMaxY(insetBounds))
+                        deltaY = _CGRectGetMaxY(insetBounds) - eventLocation.y;
                     if (deltaY < -insetBounds.size.height)
                         deltaY = -insetBounds.size.height;
                     if (deltaY > insetBounds.size.height)
@@ -282,17 +277,17 @@ var CPDraggingSource_draggedImage_movedTo_          = 1 << 0,
 
                 if ([scrollView hasHorizontalScroller])
                 {
-                    if (eventLocation.x < CGRectGetMinX(insetBounds))
-                        deltaX = CGRectGetMinX(insetBounds) - eventLocation.x;
-                    else if (eventLocation.x > CGRectGetMaxX(insetBounds))
-                        deltaX = CGRectGetMaxX(insetBounds) - eventLocation.x;
+                    if (eventLocation.x < _CGRectGetMinX(insetBounds))
+                        deltaX = _CGRectGetMinX(insetBounds) - eventLocation.x;
+                    else if (eventLocation.x > _CGRectGetMaxX(insetBounds))
+                        deltaX = _CGRectGetMaxX(insetBounds) - eventLocation.x;
                     if (deltaX < -insetBounds.size.width)
                         deltaX = -insetBounds.size.width;
                     if (deltaX > insetBounds.size.width)
                         deltaX = insetBounds.size.width;
                 }
 
-                var scrollPoint = CGPointMake(bounds.origin.x - deltaX, bounds.origin.y - deltaY);
+                var scrollPoint = _CGPointMake(bounds.origin.x - deltaX, bounds.origin.y - deltaY);
 
                 [contentView scrollToPoint:scrollPoint];
                 [[scrollView _headerView] scrollPoint:scrollPoint];
@@ -370,26 +365,22 @@ var CPDraggingSource_draggedImage_movedTo_          = 1 << 0,
         if (mouseDownWindow)
             mouseDownEventLocation = [mouseDownWindow convertBaseToGlobal:mouseDownEventLocation];
 
-        _draggingOffset = CGSizeMake(mouseDownEventLocation.x - viewLocation.x, mouseDownEventLocation.y - viewLocation.y);
+        _draggingOffset = _CGSizeMake(mouseDownEventLocation.x - viewLocation.x, mouseDownEventLocation.y - viewLocation.y);
     }
     else
-        _draggingOffset = CGSizeMakeZero();
+        _draggingOffset = _CGSizeMakeZero();
 
     if ([CPPlatform isBrowser])
         [_draggedWindow setPlatformWindow:[aWindow platformWindow]];
 
-    [aView setFrameOrigin:CGPointMakeZero()];
+    [aView setFrameOrigin:_CGPointMakeZero()];
 
-    var mouseLocation = [CPEvent mouseLocation],
-        viewSize = [aView frameSize],
-        startDragLocationX = mouseLocation.x - _draggingOffset.width,
-        startDragLocationY = mouseLocation.y - _draggingOffset.height,
-        draggedWindowFrame = CGRectMake(startDragLocationX, startDragLocationY, viewSize.width, viewSize.height);
+    var mouseLocation = [CPEvent mouseLocation];
 
     // Place it where the mouse pointer is.
-    _startDragLocation = CGPointMake(startDragLocationX, startDragLocationY);
-
-    [_draggedWindow _setFrame:draggedWindowFrame display:YES animate:NO constrainWidth:NO constrainHeight:NO];
+    _startDragLocation = _CGPointMake(mouseLocation.x - _draggingOffset.width, mouseLocation.y - _draggingOffset.height);
+    [_draggedWindow setFrameOrigin:_startDragLocation];
+    [_draggedWindow setFrameSize:[aView frame].size];
 
     [[_draggedWindow contentView] addSubview:aView];
 
@@ -438,7 +429,7 @@ var CPDraggingSource_draggedImage_movedTo_          = 1 << 0,
     var imageSize = [anImage size];
 
     if (!_imageView)
-        _imageView = [[CPImageView alloc] initWithFrame:CGRectMake(0.0, 0.0, imageSize.width, imageSize.height)];
+        _imageView = [[CPImageView alloc] initWithFrame:_CGRectMake(0.0, 0.0, imageSize.width, imageSize.height)];
 
     [_imageView setImage:anImage];
 

AppKit/CPEvent.j

@@ -235,7 +235,7 @@ var _CPEventPeriodicEventPeriod         = 0,
 */
 - (CGPoint)locationInWindow
 {
-    return CGPointMakeCopy(_location);
+    return _CGPointMakeCopy(_location);
 }
 
 - (CGPoint)globalLocation
@@ -527,7 +527,7 @@ var _CPEventPeriodicEventPeriod         = 0,
 
 function _CPEventFirePeriodEvent()
 {
-    [CPApp sendEvent:[CPEvent otherEventWithType:CPPeriodic location:CGPointMakeZero() modifierFlags:0 timestamp:[CPEvent currentTimestamp] windowNumber:0 context:nil subtype:0 data1:0 data2:0]];
+    [CPApp sendEvent:[CPEvent otherEventWithType:CPPeriodic location:_CGPointMakeZero() modifierFlags:0 timestamp:[CPEvent currentTimestamp] windowNumber:0 context:nil subtype:0 data1:0 data2:0]];
 }
 
 var CPEventClass = [CPEvent class];

AppKit/CPFont.j

@@ -37,12 +37,12 @@ CPFontCurrentSystemSize = -1;
 // For internal use only by this class and subclasses
 _CPFontSystemFacePlaceholder = "_CPFontSystemFacePlaceholder";
 
-var _CPFontCache          = {},
-    _CPSystemFontCache    = {},
-    _CPFontSystemFontFace = CPFontDefaultSystemFontFace,
-    _CPFontSystemFontSize = 12,
-    _CPFontFallbackFaces  = CPFontDefaultSystemFontFace.split(", "),
-    _CPFontStripRegExp    = new RegExp("(^\\s*[\"']?|[\"']?\\s*$)", "g");
+var _CPFontCache                     = {},
+    _CPSystemFontCache               = {},
+    _CPFontSystemFontFace            = CPFontDefaultSystemFontFace,
+    _CPFontSystemFontSize            = 12,
+    _CPFontFallbackFaces             = CPFontDefaultSystemFontFace.split(", "),
+    _CPFontStripRegExp               = new RegExp("(^\\s*[\"']?|[\"']?\\s*$)", "g");
 
 
 #define _CPRealFontSize(aSize)  (aSize <= 0 ? _CPFontSystemFontSize : aSize)
@@ -181,10 +181,8 @@ following:
     {
         case CPSmallControlSize:
             return _CPFontSystemFontSize - 1;
-
         case CPMiniControlSize:
             return _CPFontSystemFontSize - 2;
-
         case CPRegularControlSize:
         default:
             return _CPFontSystemFontSize;

AppKit/CPGradient.j

@@ -108,13 +108,13 @@ CPGradientDrawsAfterEndingLocation      = kCGGradientDrawsAfterEndLocation;
     angle = ((angle % 360.0) + 360.0) % 360.0;
 
     if (angle < 90.0)
-        startPoint = CGPointMake(CGRectGetMinX(rect), CGRectGetMinY(rect));
+        startPoint = _CGPointMake(_CGRectGetMinX(rect), _CGRectGetMinY(rect));
     else if (angle < 180.0)
-        startPoint = CGPointMake(CGRectGetMaxX(rect), CGRectGetMinY(rect));
+        startPoint = _CGPointMake(_CGRectGetMaxX(rect), _CGRectGetMinY(rect));
     else if (angle < 270.0)
-        startPoint = CGPointMake(CGRectGetMaxX(rect), CGRectGetMaxY(rect));
+        startPoint = _CGPointMake(_CGRectGetMaxX(rect), _CGRectGetMaxY(rect));
     else
-        startPoint = CGPointMake(CGRectGetMinX(rect), CGRectGetMaxY(rect));
+        startPoint = _CGPointMake(_CGRectGetMinX(rect), _CGRectGetMaxY(rect));
 
     // A line segment comes out of the starting point at the given angle, with the first colour
     // at the starting point and the last at the end. To do what drawInRect: is supposed to do
@@ -129,9 +129,9 @@ CPGradientDrawsAfterEndingLocation      = kCGGradientDrawsAfterEndLocation;
     // This simplifies down to (in the first quadrant) rectWidth * cos(a) + rectHeight * sin(a).
 
     var radians = PI * angle / 180.0,
-        length = ABS(CGRectGetWidth(rect) * COS(radians)) + ABS(CGRectGetHeight(rect) * SIN(radians));
+        length = ABS(_CGRectGetWidth(rect) * COS(radians)) + ABS(_CGRectGetHeight(rect) * SIN(radians));
 
-    endPoint = CGPointMake(startPoint.x + length * COS(radians),
+    endPoint = _CGPointMake(startPoint.x + length * COS(radians),
                            startPoint.y + length * SIN(radians));
 
     [self drawFromPoint:startPoint toPoint:endPoint options:CPGradientDrawsBeforeStartingLocation | CPGradientDrawsAfterEndingLocation];

AppKit/CPGraphics.j

@@ -60,9 +60,9 @@ function CPDrawColorTiledRects(
     if (sides.length != colors.length)
         [CPException raise:CPInvalidArgumentException reason:@"sides (length: " + sides.length + ") and colors (length: " + colors.length + ") must have the same length."];
 
-    var resultRect = CGRectMakeCopy(boundsRect),
-        slice = CGRectMakeZero(),
-        remainder = CGRectMakeZero(),
+    var resultRect = _CGRectMakeCopy(boundsRect),
+        slice = _CGRectMakeZero(),
+        remainder = _CGRectMakeZero(),
         context = [[CPGraphicsContext currentContext] graphicsPort];
 
     CGContextSaveGState(context);
@@ -77,7 +77,7 @@ function CPDrawColorTiledRects(
         slice = CGRectIntersection(slice, clipRect);
 
         // Cocoa docs say that only slices that are within the clipRect are actually drawn
-        if (CGRectIsEmpty(slice))
+        if (_CGRectIsEmpty(slice))
             continue;
 
         var minX,
@@ -88,23 +88,23 @@ function CPDrawColorTiledRects(
         if (side == CPMinXEdge || side == CPMaxXEdge)
         {
             // Make sure we have at least 1 pixel to draw a line
-            if (CGRectGetWidth(slice) < 1.0)
+            if (_CGRectGetWidth(slice) < 1.0)
                 continue;
 
-            minX = CGRectGetMinX(slice) + 0.5;
+            minX = _CGRectGetMinX(slice) + 0.5;
             maxX = minX;
-            minY = CGRectGetMinY(slice);
-            maxY = CGRectGetMaxY(slice);
+            minY = _CGRectGetMinY(slice);
+            maxY = _CGRectGetMaxY(slice);
         }
         else // CPMinYEdge || CPMaxYEdge
         {
             // Make sure we have at least 1 pixel to draw a line
-            if (CGRectGetHeight(slice) < 1.0)
+            if (_CGRectGetHeight(slice) < 1.0)
                 continue;
 
-            minX = CGRectGetMinX(slice);
-            maxX = CGRectGetMaxX(slice);
-            minY = CGRectGetMinY(slice) + 0.5;
+            minX = _CGRectGetMinX(slice);
+            maxX = _CGRectGetMaxX(slice);
+            minY = _CGRectGetMinY(slice) + 0.5;
             maxY = minY;
         }
 

AppKit/CPImage.j

@@ -48,8 +48,8 @@ var imagesForNames = { },
     AppKitImageForNames = { },
     ImageDescriptionFormat = "%s {\n   filename: \"%s\",\n   size: { width:%f, height:%f }\n}";
 
-AppKitImageForNames[CPImageNameColorPanel]              = CGSizeMake(26.0, 29.0);
-AppKitImageForNames[CPImageNameColorPanelHighlighted]   = CGSizeMake(26.0, 29.0);
+AppKitImageForNames[CPImageNameColorPanel]              = _CGSizeMake(26.0, 29.0);
+AppKitImageForNames[CPImageNameColorPanelHighlighted]   = _CGSizeMake(26.0, 29.0);
 
 /*!
     Returns a resource image with a relative path and size
@@ -72,7 +72,7 @@ function CPImageInBundle()
     if (typeof(arguments[1]) === "number")
     {
         if (arguments[1] !== nil && arguments[1] !== undefined)
-            size = CGSizeMake(arguments[1], arguments[2]);
+            size = _CGSizeMake(arguments[1], arguments[2]);
 
         bundle = arguments[3];
     }
@@ -131,7 +131,7 @@ function CPAppKitImage(aFilename, aSize)
 
 - (id)init
 {
-    return [self initByReferencingFile:@"" size:CGSizeMake(-1, -1)];
+    return [self initByReferencingFile:@"" size:_CGSizeMake(-1, -1)];
 }
 
 /*!
@@ -148,7 +148,7 @@ function CPAppKitImage(aFilename, aSize)
 
     if (self)
     {
-        _size = CGSizeMakeCopy(aSize);
+        _size = _CGSizeMakeCopy(aSize);
         _filename = aFilename;
         _loadStatus = CPImageLoadStatusInitialized;
     }
@@ -180,7 +180,7 @@ function CPAppKitImage(aFilename, aSize)
 */
 - (id)initWithContentsOfFile:(CPString)aFilename
 {
-    self = [self initByReferencingFile:aFilename size:CGSizeMake(-1, -1)];
+    self = [self initByReferencingFile:aFilename size:_CGSizeMake(-1, -1)];
 
     if (self)
         [self load];
@@ -247,7 +247,7 @@ function CPAppKitImage(aFilename, aSize)
 */
 - (void)setSize:(CGSize)aSize
 {
-    _size = CGSizeMakeCopy(aSize);
+    _size = _CGSizeMakeCopy(aSize);
 }
 
 /*!
@@ -446,7 +446,7 @@ function CPAppKitImage(aFilename, aSize)
 
     // FIXME: IE is wrong on image sizes????
     if (!_size || (_size.width == -1 && _size.height == -1))
-        _size = CGSizeMake(_image.width, _image.height);
+        _size = _CGSizeMake(_image.width, _image.height);
 
     [[CPNotificationCenter defaultCenter]
         postNotificationName:CPImageDidLoadNotification

AppKit/CPImageView.j

@@ -302,8 +302,8 @@ var CPImageViewEmptyPlaceholderImage = nil;
         y = 0.0,
         insetWidth = (_hasShadow ? [_shadowView horizontalInset] : 0.0),
         insetHeight = (_hasShadow ? [_shadowView verticalInset] : 0.0),
-        boundsWidth = CGRectGetWidth(bounds),
-        boundsHeight = CGRectGetHeight(bounds),
+        boundsWidth = _CGRectGetWidth(bounds),
+        boundsHeight = _CGRectGetHeight(bounds),
         width = boundsWidth - insetWidth,
         height = boundsHeight - insetHeight;
 
@@ -401,10 +401,10 @@ var CPImageViewEmptyPlaceholderImage = nil;
 #endif
     }
 
-    _imageRect = CGRectMake(x, y, width, height);
+    _imageRect = _CGRectMake(x, y, width, height);
 
     if (_hasShadow)
-        [_shadowView setFrame:CGRectMake(x - [_shadowView leftInset], y - [_shadowView topInset], width + insetWidth, height + insetHeight)];
+        [_shadowView setFrame:_CGRectMake(x - [_shadowView leftInset], y - [_shadowView topInset], width + insetWidth, height + insetHeight)];
 }
 
 - (void)mouseDown:(CPEvent)anEvent
@@ -585,7 +585,7 @@ var CPImageViewImageKey          = @"CPImageViewImageKey",
 
 @end
 
-@implementation CPImage (CachedImage)
+@implementation CPImage (CahedImage)
 
 + (CPImage)cachedImageWithContentsOfFile:(CPString)aFile
 {
@@ -601,4 +601,4 @@ var CPImageViewImageKey          = @"CPImageViewImageKey",
     return image;
 }
 
-@end
+@end

AppKit/CPKeyValueBinding.j

@@ -257,11 +257,7 @@ var CPBindingOperationAnd = 0,
     if (valueTransformer)
         aValue = [valueTransformer transformedValue:aValue];
 
-    // If the value is nil AND the source doesn't respond to setPlaceholderString: then
-    // we set the value to the placeholder. Otherwise, we do not want to short cut the process
-    // of setting the placeholder that is based on the fact that the value is nil.
-    if ((aValue === undefined || aValue === nil || aValue === [CPNull null])
-        && ![_source respondsToSelector:@selector(setPlaceholderString:)])
+    if (aValue === undefined || aValue === nil || aValue === [CPNull null])
         aValue = [options objectForKey:CPNullPlaceholderBindingOption] || nil;
 
     return aValue;

AppKit/CPLevelIndicator.j

@@ -122,7 +122,7 @@ CPRatingLevelIndicatorStyle                 = 3;
 
 - (CPView)createEphemeralSubviewNamed:(CPString)aName
 {
-    return [[CPView alloc] initWithFrame:CGRectMakeZero()];
+    return [[CPView alloc] initWithFrame:_CGRectMakeZero()];
 }
 
 - (CGRect)rectForEphemeralSubviewNamed:(CPString)aViewName
@@ -130,11 +130,11 @@ CPRatingLevelIndicatorStyle                 = 3;
     // TODO Put into theme attributes.
     var bezelHeight = 18,
         segmentHeight = 17,
-        bounds = CGRectCreateCopy([self bounds]);
+        bounds = _CGRectCreateCopy([self bounds]);
 
     if (aViewName == "bezel")
     {
-        bounds.origin.y = (CGRectGetHeight(bounds) - bezelHeight) / 2.0;
+        bounds.origin.y = (_CGRectGetHeight(bounds) - bezelHeight) / 2.0;
         bounds.size.height = bezelHeight;
         return bounds;
     }
@@ -144,13 +144,13 @@ CPRatingLevelIndicatorStyle                 = 3;
             segmentCount = _maxValue - _minValue;
 
         if (segment >= segmentCount)
-            return CGRectMakeZero();
+            return _CGRectMakeZero();
 
         var basicSegmentWidth = bounds.size.width / segmentCount,
             segmentFrame = CGRectCreateCopy([self bounds]),
             spacing = [self valueForThemeAttribute:@"spacing"];
 
-        segmentFrame.origin.y = (CGRectGetHeight(bounds) - bezelHeight) / 2.0;
+        segmentFrame.origin.y = (_CGRectGetHeight(bounds) - bezelHeight) / 2.0;
         segmentFrame.origin.x =  FLOOR(segment * basicSegmentWidth);
         segmentFrame.size.width = (segment == segmentCount - 1) ? bounds.size.width - segmentFrame.origin.x : FLOOR(((segment + 1) * basicSegmentWidth)) - FLOOR((segment * basicSegmentWidth)) - spacing;
         segmentFrame.size.height = segmentHeight;
@@ -158,7 +158,7 @@ CPRatingLevelIndicatorStyle                 = 3;
         return segmentFrame;
     }
 
-    return CGRectMakeZero();
+    return _CGRectMakeZero();
 }
 
 /*!

AppKit/CPMenu/CPMenu.j

@@ -68,8 +68,6 @@ var _CPMenuBarVisible               = NO,
 
     int             _highlightedIndex;
     _CPMenuWindow   _menuWindow;
-
-    CPEvent         _lastCloseEvent;
 }
 
 // Managing the Menu Bar
@@ -355,7 +353,7 @@ var _CPMenuBarVisible               = NO,
     while (count--)
         [_items[count] setMenu:nil];
 
-    [self _highlightItemAtIndex:CPNotFound];
+    _highlightedIndex = CPNotFound;
 
     // Because we are changing _items directly, be sure to notify KVO
     [self willChangeValueForKey:@"items"];
@@ -851,8 +849,6 @@ var _CPMenuBarVisible               = NO,
     var theWindow = [aView window],
         menuWindow = [_CPMenuWindow menuWindowWithMenu:aMenu font:aFont];
 
-    [_CPMenuWindow poolMenuWindow:menuWindow];
-
     [menuWindow setBackgroundStyle:_CPMenuWindowPopUpBackgroundStyle];
 
     var constraintRect = [CPMenu _constraintRectForView:aView],
@@ -948,10 +944,6 @@ var _CPMenuBarVisible               = NO,
 
 - (void)_menuDidClose
 {
-    // Remember which event caused this menu to close, if any. CPPopUpButton uses this to detect
-    // when a click on the button itself caused the menu to close.
-    _lastCloseEvent = [CPApp currentEvent];
-
     var delegate = [self delegate];
 
     if ([delegate respondsToSelector:@selector(menuDidClose:)])
@@ -971,7 +963,7 @@ var _CPMenuBarVisible               = NO,
 {
     [CPApp sendEvent:[CPEvent
         otherEventWithType:CPAppKitDefined
-                  location:CGPointMakeZero()
+                  location:_CGPointMakeZero()
              modifierFlags:0
                  timestamp:0
               windowNumber:0
@@ -1151,7 +1143,6 @@ var _CPMenuBarVisible               = NO,
             return;
 
     [aMenuItem setMenu:self];
-    [self _highlightItemAtIndex:CPNotFound];
     [_items insertObject:aMenuItem atIndex:anIndex];
 
     [[CPNotificationCenter defaultCenter]
@@ -1166,7 +1157,6 @@ var _CPMenuBarVisible               = NO,
         return;
 
     [[_items objectAtIndex:anIndex] setMenu:nil];
-    [self _highlightItemAtIndex:CPNotFound];
     [_items removeObjectAtIndex:anIndex];
 
     [[CPNotificationCenter defaultCenter]

AppKit/CPMenu/_CPMenuBarWindow.j

@@ -67,8 +67,6 @@
 
     if (self)
     {
-        _constrainsToUsableScreen = NO;
-
         [self setLevel:CPMainMenuWindowLevel];
         [self setAutoresizingMask:CPWindowWidthSizable];
 
@@ -143,7 +141,6 @@
     _textColor = aColor;
 
     [_menuItemViews makeObjectsPerformSelector:@selector(setTextColor:) withObject:_textColor];
-    [_menuItemViews makeObjectsPerformSelector:@selector(setParentMenuTextColor:) withObject:_textColor];
 }
 
 - (void)setTitleColor:(CPColor)aColor
@@ -164,7 +161,6 @@
     _textShadowColor = aColor;
 
     [_menuItemViews makeObjectsPerformSelector:@selector(setTextShadowColor:) withObject:_textShadowColor];
-    [_menuItemViews makeObjectsPerformSelector:@selector(setParentMenuTextShadowColor:) withObject:_textShadowColor];
 }
 
 - (void)setTitleShadowColor:(CPColor)aColor
@@ -183,8 +179,6 @@
         return;
 
     _highlightColor = aColor;
-
-    [_menuItemViews makeObjectsPerformSelector:@selector(setParentMenuHighlightColor:) withObject:_highlightColor];
 }
 
 - (void)setHighlightTextColor:(CPColor)aColor
@@ -194,7 +188,7 @@
 
     _highlightTextColor = aColor;
 
-    [_menuItemViews makeObjectsPerformSelector:@selector(setParentMenuHighlightTextColor:) withObject:_highlightTextColor];
+//    [_menuItemViews makeObjectsPerformSelector:@selector(setActivateColor:) withObject:_highlightTextColor];
 }
 
 - (void)setHighlightTextShadowColor:(CPColor)aColor
@@ -204,7 +198,7 @@
 
     _highlightTextShadowColor = aColor;
 
-    [_menuItemViews makeObjectsPerformSelector:@selector(setParentMenuHighlightTextShadowColor:) withObject:_highlightTextShadowColor];
+//    [_menuItemViews makeObjectsPerformSelector:@selector(setActivateShadowColor:) withObject:_highlightTextShadowColor];
 }
 
 - (void)setMenu:(CPMenu)aMenu
@@ -417,7 +411,7 @@
 
     [super setFrame:aRect display:shouldDisplay animate:shouldAnimate];
 
-    if (!CGSizeEqualToSize(size, aRect.size))
+    if (!_CGSizeEqualToSize(size, aRect.size))
         [self tile];
 }
 

AppKit/CPMenu/_CPMenuManager.j

@@ -45,7 +45,6 @@ var STICKY_TIME_INTERVAL            = 0.4,
 @implementation _CPMenuManager: CPObject
 {
     CPTimeInterval      _startTime;
-    CPEvent             _openEvent;
     BOOL                _mouseWasDragged;
     int                 _scrollingState;
     CGPoint             _lastGlobalLocation;
@@ -104,7 +103,6 @@ var STICKY_TIME_INTERVAL            = 0.4,
     CPApp._activeMenu = menu;
 
     _startTime = [anEvent timestamp];
-    _openEvent = anEvent;
     _scrollingState = _CPMenuManagerScrollingStateNone;
 
     _constraintRect = aRect;
@@ -185,15 +183,8 @@ var STICKY_TIME_INTERVAL            = 0.4,
         activeItemIndex = activeMenuContainer ? [activeMenuContainer itemIndexAtPoint:menuLocation] : CPNotFound,
         activeItem = activeItemIndex !== CPNotFound ? [activeMenu itemAtIndex:activeItemIndex] : nil;
 
-    /*
-    Click outside the menu structure?
-
-    The event which caused the menu to open is not considered even if it's
-    technically a click outside of an open menu, since this would mean the same
-    click which opened the menu could also close it. This is actually common.
-    E.g. you click on a button and it opens a menu below itself.
-    */
-    if (type === CPLeftMouseDown && _openEvent !== anEvent && (!activeMenuContainer || !CGRectContainsPoint([activeMenuContainer globalFrame], globalLocation)))
+    // Click outside the menu structure?
+    if (type === CPLeftMouseDown && (!activeMenuContainer || !CGRectContainsPoint([activeMenuContainer globalFrame], globalLocation)))
     {
         [self completeTracking];
 
@@ -214,6 +205,15 @@ var STICKY_TIME_INTERVAL            = 0.4,
 
     [self _trackAgain];
 
+    if (_keyBuffer)
+    {
+        if (([anEvent timestamp] - _startTime) > (STICKY_TIME_INTERVAL + [activeMenu numberOfItems] / 2))
+            [self selectNextItemBeginningWith:_keyBuffer inMenu:menu clearBuffer:YES];
+
+        if (type === CPPeriodic)
+            return;
+    }
+
     // unhighlight when mouse is moved off the menu
     if (_lastGlobalLocation && CGRectContainsPoint([activeMenuContainer globalFrame], _lastGlobalLocation)
                             && !CGRectContainsPoint([activeMenuContainer globalFrame], globalLocation))
@@ -250,9 +250,9 @@ var STICKY_TIME_INTERVAL            = 0.4,
 
         if (_lastMouseOverMenuView != mouseOverMenuView)
         {
-            [_lastMouseOverMenuView mouseExited:anEvent];
+            [mouseOverMenuView mouseExited:anEvent];
             // FIXME: Possibly multiple of these?
-            [mouseOverMenuView mouseEntered:anEvent];
+            [_lastMouseOverMenuView mouseEntered:anEvent];
 
             _lastMouseOverMenuView = mouseOverMenuView;
         }
@@ -457,8 +457,8 @@ var STICKY_TIME_INTERVAL            = 0.4,
     {
         var menuContainer = _menuContainerStack[index],
             menuContainerFrame = [menuContainer globalFrame],
-            menuContainerMinX = CGRectGetMinX(menuContainerFrame),
-            menuContainerMaxX = CGRectGetMaxX(menuContainerFrame);
+            menuContainerMinX = _CGRectGetMinX(menuContainerFrame),
+            menuContainerMaxX = _CGRectGetMaxX(menuContainerFrame);
 
         // If within the x bounds of this menu container, return it.
         if (x < menuContainerMaxX && x >= menuContainerMinX)
@@ -554,9 +554,6 @@ var STICKY_TIME_INTERVAL            = 0.4,
     }
     else if (!(modifierFlags & (CPCommandKeyMask | CPControlKeyMask)))
     {
-        if (([anEvent timestamp] - _startTime) > STICKY_TIME_INTERVAL)
-            _keyBuffer = nil;
-
         if (!_keyBuffer)
         {
             _startTime = [anEvent timestamp];
@@ -568,12 +565,12 @@ var STICKY_TIME_INTERVAL            = 0.4,
         else
             _keyBuffer += character;
 
-        [self selectNextItemBeginningWith:_keyBuffer inMenu:menu];
-        _lastGlobalLocation = nil;
+        [self selectNextItemBeginningWith:_keyBuffer inMenu:menu clearBuffer:NO];
+        _lastGlobalLocation = Nil;
     }
 }
 
-- (void)selectNextItemBeginningWith:(CPString)characters inMenu:(CPMenu)menu
+- (void)selectNextItemBeginningWith:(CPString)characters inMenu:(CPMenu)menu clearBuffer:(BOOL)shouldClear
 {
     var iter = [[menu itemArray] objectEnumerator],
         obj;
@@ -590,7 +587,13 @@ var STICKY_TIME_INTERVAL            = 0.4,
         }
     }
 
-    _startTime = [CPEvent currentTimestamp];
+    if (shouldClear)
+    {
+        [CPEvent stopPeriodicEvents];
+        _keyBuffer = Nil;
+    }
+    else
+        _startTime = [CPEvent currentTimestamp];
 }
 
 - (void)scrollToBeginningOfDocument:(CPMenu)menu

AppKit/CPMenu/_CPMenuWindow.j

@@ -80,15 +80,13 @@ _CPMenuWindowAttachedMenuBackgroundStyle    = 2;
 
 - (id)initWithContentRect:(CGRect)aRect styleMask:(unsigned)aStyleMask
 {
-    _constraintRect = CGRectMakeZero();
-    _unconstrainedFrame = CGRectMakeZero();
+    _constraintRect = _CGRectMakeZero();
+    _unconstrainedFrame = _CGRectMakeZero();
 
     self = [super initWithContentRect:aRect styleMask:CPBorderlessWindowMask];
 
     if (self)
     {
-        _constrainsToUsableScreen = NO;
-
         [self setLevel:CPPopUpMenuWindowLevel];
         [self setHasShadow:YES];
         [self setShadowStyle:CPMenuWindowShadowStyle];
@@ -209,26 +207,26 @@ _CPMenuWindowAttachedMenuBackgroundStyle    = 2;
 
 - (CGRect)unconstrainedFrame
 {
-    return CGRectMakeCopy(_unconstrainedFrame);
+    return _CGRectMakeCopy(_unconstrainedFrame);
 }
 
 // We need this because if not this will call setFrame: with -frame instead of -unconstrainedFrame, turning
 // the constrained frame into the unconstrained frame.
 - (void)setFrameOrigin:(CGPoint)aPoint
 {
-    [super setFrame:CGRectMake(aPoint.x, aPoint.y, CGRectGetWidth(_unconstrainedFrame), CGRectGetHeight(_unconstrainedFrame))];
+    [super setFrame:_CGRectMake(aPoint.x, aPoint.y, _CGRectGetWidth(_unconstrainedFrame), _CGRectGetHeight(_unconstrainedFrame))];
 }
 
 - (void)setFrameSize:(CGSize)aSize
 {
-    [super setFrame:CGRectMake(CGRectGetMinX(_unconstrainedFrame), CGRectGetMinY(_unconstrainedFrame), aSize.width, aSize.height)];
+    [super setFrame:_CGRectMake(_CGRectGetMinX(_unconstrainedFrame), _CGRectGetMinY(_unconstrainedFrame), aSize.width, aSize.height)];
 }
 
 - (void)setFrame:(CGRect)aFrame display:(BOOL)shouldDisplay animate:(BOOL)shouldAnimate
 {
     // FIXME: There are integral window issues with platform windows.
     // FIXME: This gets called far too often.
-    _unconstrainedFrame = CGRectMakeCopy(aFrame);
+    _unconstrainedFrame = _CGRectMakeCopy(aFrame);
 
     var constrainedFrame = CGRectIntersection(_unconstrainedFrame, _constraintRect),
         marginInset = [_menuView valueForThemeAttribute:@"menu-window-margin-inset"],

AppKit/CPMenuItem/_CPMenuItemMenuBarView.j

@@ -28,18 +28,13 @@
 
 @implementation _CPMenuItemMenuBarView : CPView
 {
-    CPColor                 _highlightColor @accessors(property=highlightColor);
-    CPColor                 _textColor @accessors(property=textColor);
-    CPColor                 _textShadowColor @accessors(property=textShadowColor);
-    CPColor                 _highlightTextColor @accessors(property=highlightTextColor);
-    CPColor                 _highlightTextShadowColor @accessors(property=highlightTextShadowColor);
-
     CPMenuItem              _menuItem @accessors(property=menuItem);
 
     CPFont                  _font;
+    CPColor                 _textColor;
+    CPColor                 _textShadowColor;
 
     BOOL                    _isDirty;
-    BOOL                    _shouldHighlight;
 
     _CPImageAndTextView     _imageAndTextView;
 }
@@ -52,7 +47,9 @@
 + (id)themeAttributes
 {
     return @{
-            @"horizontal-margin": 9.0,
+            @"menu-item-selection-color": [CPNull null],
+            @"menu-item-text-shadow-color": [CPNull null],
+            @"horizontal-margin": 12.0,
             @"submenu-indicator-margin": 3.0,
             @"vertical-margin": 4.0,
         };
@@ -84,36 +81,12 @@
     return self;
 }
 
-- (CPColor)setTextColor:(CPColor)aColor
-{
-    _textColor = aColor;
-    [self setNeedsLayout];
-}
-
-- (CPColor)setTextShadowColor:(CPColor)aColor
-{
-    _textShadowColor = aColor;
-    [self setNeedsLayout];
-}
-
-- (CPColor)setHighlightTextColor:(CPColor)aColor
-{
-    _highlightTextColor = aColor;
-    [self setNeedsLayout];
-}
-
-- (CPColor)setHighlightTextShadowColor:(CPColor)aColor
-{
-    _highlightTextShadowColor = aColor;
-    [self setNeedsLayout];
-}
-
 - (CPColor)textColor
 {
     if (![_menuItem isEnabled])
         return [CPColor lightGrayColor];
 
-    return _textColor || [[CPTheme defaultTheme] valueForAttributeWithName:@"menu-bar-text-color" forClass:_CPMenuView];
+    return _textColor || [CPColor colorWithCalibratedRed:70.0 / 255.0 green:69.0 / 255.0 blue:69.0 / 255.0 alpha:1.0];
 }
 
 - (CPColor)textShadowColor
@@ -121,28 +94,7 @@
     if (![_menuItem isEnabled])
         return [CPColor clearColor];
 
-    return _textShadowColor || [[CPTheme defaultTheme] valueForAttributeWithName:@"menu-bar-text-shadow-color" forClass:_CPMenuView];
-}
-
-- (CPColor)highlightTextColor
-{
-    if (![_menuItem isEnabled])
-        return [CPColor lightGrayColor];
-
-    return _highlightTextColor || [[CPTheme defaultTheme] valueForAttributeWithName:@"menu-bar-highlight-text-color" forClass:_CPMenuView];
-}
-
-- (CPColor)highlightTextShadowColor
-{
-    if (![_menuItem isEnabled])
-        return [CPColor clearColor];
-
-    return _highlightTextShadowColor || [[CPTheme defaultTheme] valueForAttributeWithName:@"menu-bar-highlight-text-shadow-color" forClass:_CPMenuView];
-}
-
-- (CPColor)highlightColor
-{
-    return _highlightColor || [[CPTheme defaultTheme] valueForAttributeWithName:@"menu-bar-window-background-selected-color" forClass:_CPMenuView];
+    return _textShadowColor || [CPColor colorWithWhite:1.0 alpha:0.8];
 }
 
 - (void)update
@@ -150,11 +102,13 @@
     var x = [self valueForThemeAttribute:@"horizontal-margin"],
         height = 0.0;
 
-    [_imageAndTextView setText:[_menuItem title]];
     [_imageAndTextView setFont:[_menuItem font] || [_CPMenuBarWindow font]];
     [_imageAndTextView setVerticalAlignment:CPCenterVerticalTextAlignment];
-    [_imageAndTextView setTextShadowOffset:CGSizeMake(0.0, 1.0)];
     [_imageAndTextView setImage:[_menuItem image]];
+    [_imageAndTextView setText:[_menuItem title]];
+    [_imageAndTextView setTextColor:[self textColor]];
+    [_imageAndTextView setTextShadowColor:[self textShadowColor]];
+    [_imageAndTextView setTextShadowOffset:CGSizeMake(0.0, 1.0)];
     [_imageAndTextView sizeToFit];
 
     var imageAndTextViewFrame = [_imageAndTextView frame];
@@ -169,7 +123,6 @@
     [self setAutoresizesSubviews:NO];
     [self setFrameSize:CGSizeMake(x + [self valueForThemeAttribute:@"horizontal-margin"], height)];
     [self setAutoresizesSubviews:YES];
-    [self setNeedsLayout];
 }
 
 - (void)highlight:(BOOL)shouldHighlight
@@ -178,20 +131,14 @@
     if (![_menuItem isEnabled])
         shouldHighlight = NO;
 
-    _shouldHighlight = shouldHighlight;
-    [self setNeedsLayout];
-}
-
-- (void)layoutSubviews
-{
-    if (_shouldHighlight)
+    if (shouldHighlight)
     {
         if (![_menuItem _isMenuBarButton])
-            [self setBackgroundColor:[self highlightColor]];
+            [self setBackgroundColor:[[CPTheme defaultTheme] valueForAttributeWithName:@"menu-bar-window-background-selected-color" forClass:_CPMenuView]];
 
         [_imageAndTextView setImage:[_menuItem alternateImage] || [_menuItem image]];
-        [_imageAndTextView setTextColor:[self highlightTextColor]];
-        [_imageAndTextView setTextShadowColor:[self highlightTextShadowColor]];
+        [_imageAndTextView setTextColor:[CPColor whiteColor]];
+        [_imageAndTextView setTextShadowColor:[self valueForThemeAttribute:@"menu-item-text-shadow-color"]];
     }
     else
     {

AppKit/CPMenuItem/_CPMenuItemStandardView.j

@@ -336,11 +336,6 @@
     }
 }
 
-- (BOOL)isHighlighted
-{
-    return _highlighted;
-}
-
 @end
 
 @implementation _CPMenuItemSubmenuIndicatorView : CPView

AppKit/CPMenuItem/_CPMenuItemView.j

@@ -34,7 +34,7 @@
 @implementation _CPMenuItemView : CPView
 {
     CPMenuItem              _menuItem;
-    CPView                  _view       @accessors(property=view, readonly);
+    CPView                  _view;
 
     CPFont                  _font;
     CPColor                 _textColor;
@@ -220,36 +220,6 @@
     return [_menuItem isEnabled] ? (_textShadowColor ? _textShadowColor : [CPColor colorWithWhite:1.0 alpha:0.8]) : [CPColor colorWithWhite:0.8 alpha:0.8];
 }
 
-- (void)setParentMenuHighlightColor:(CPColor)aColor
-{
-    if ([_view respondsToSelector:@selector(setHighlightColor:)])
-        [_view setHighlightColor:aColor];
-}
-
-- (void)setParentMenuHighlightTextColor:(CPColor)aColor
-{
-    if ([_view respondsToSelector:@selector(setHighlightTextColor:)])
-        [_view setHighlightTextColor:aColor];
-}
-
-- (void)setParentMenuHighlightTextShadowColor:(CPColor)aColor
-{
-    if ([_view respondsToSelector:@selector(setHighlightTextShadowColor:)])
-        [_view setHighlightTextShadowColor:aColor];
-}
-
-- (void)setParentMenuTextColor:(CPColor)aColor
-{
-    if ([_view respondsToSelector:@selector(setTextColor:)])
-        [_view setTextColor:aColor];
-}
-
-- (void)setParentMenuTextShadowColor:(CPColor)aColor
-{
-    if ([_view respondsToSelector:@selector(setTextShadowColor:)])
-        [_view setTextShadowColor:aColor];
-}
-
 @end
 
 @implementation _CPMenuItemArrowView : CPView

AppKit/CPOutlineView.j

@@ -52,7 +52,6 @@ var CPOutlineViewDataSource_outlineView_objectValue_forTableColumn_byItem_
     CPOutlineViewDataSource_outlineView_sortDescriptorsDidChange_                                   = 1 << 11;
 
 var CPOutlineViewDelegate_outlineView_dataViewForTableColumn_item_                                  = 1 << 1,
-    CPOutlineViewDelegate_outlineView_viewForTableColumn_item_                                      = 1 << 26,
     CPOutlineViewDelegate_outlineView_didClickTableColumn_                                          = 1 << 2,
     CPOutlineViewDelegate_outlineView_didDragTableColumn_                                           = 1 << 3,
     CPOutlineViewDelegate_outlineView_heightOfRowByItem_                                            = 1 << 4,
@@ -710,36 +709,27 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
 {
     var theItem = [self itemAtRow:aRow];
     if (![self isExpandable:theItem] || ![self _shouldShowOutlineDisclosureControlForItem:theItem])
-        return CGRectMakeZero();
+        return _CGRectMakeZero();
 
     var dataViewFrame = [self _frameOfOutlineDataViewAtRow:aRow],
-        disclosureWidth = CGRectGetWidth([_disclosureControlPrototype frame]),
-        frame = CGRectMake(CGRectGetMinX(dataViewFrame) - disclosureWidth, CGRectGetMinY(dataViewFrame), disclosureWidth, CGRectGetHeight(dataViewFrame));
+        disclosureWidth = _CGRectGetWidth([_disclosureControlPrototype frame]),
+        frame = _CGRectMake(_CGRectGetMinX(dataViewFrame) - disclosureWidth, _CGRectGetMinY(dataViewFrame), disclosureWidth, _CGRectGetHeight(dataViewFrame));
 
     return frame;
 }
 
 /*!
     @ignore
-    Select or deselect rows, this is overridden because we need to change the color of the outline control.
+    Select or deselect rows, this is overridden because we need to change the color or the outline control.
 */
-- (void)_setSelectedRowIndexes:(CPIndexSet)rows
+- (void)_performSelection:(BOOL)select forRow:(CPInteger)rowIndex context:(id)context
 {
-    if (_disclosureControlsForRows.length)
-    {
-        var indexes = [_selectedRowIndexes copy];
-        [indexes removeIndexesInRange:CPMakeRange(_disclosureControlsForRows.length, _itemsForRows.length - _disclosureControlsForRows.length)];
-        [[_disclosureControlsForRows objectsAtIndexes:indexes] makeObjectsPerformSelector:@selector(unsetThemeState:) withObject:CPThemeStateSelected];
-    }
+    [super _performSelection:select forRow:rowIndex context:context];
 
-    [super _setSelectedRowIndexes:rows];
+    var control = _disclosureControlsForRows[rowIndex],
+        selector = select ? @"setThemeState:" : @"unsetThemeState:";
 
-    if (_disclosureControlsForRows.length)
-    {
-        var indexes = [_selectedRowIndexes copy];
-        [indexes removeIndexesInRange:CPMakeRange(_disclosureControlsForRows.length, _itemsForRows.length - _disclosureControlsForRows.length)];
-        [[_disclosureControlsForRows objectsAtIndexes:indexes] makeObjectsPerformSelector:@selector(setThemeState:) withObject:CPThemeStateSelected];
-    }
+    [control performSelector:CPSelectorFromString(selector) withObject:CPThemeStateSelected];
 }
 
 /*!
@@ -881,7 +871,6 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
 
     var delegateMethods = [
             CPOutlineViewDelegate_outlineView_dataViewForTableColumn_item_                       , @selector(outlineView:dataViewForTableColumn:item:),
-            CPOutlineViewDelegate_outlineView_viewForTableColumn_item_                           , @selector(outlineView:viewForTableColumn:item:),
             CPOutlineViewDelegate_outlineView_didClickTableColumn_                               , @selector(outlineView:didClickTableColumn:),
             CPOutlineViewDelegate_outlineView_didDragTableColumn_                                , @selector(outlineView:didDragTableColumn:),
             CPOutlineViewDelegate_outlineView_heightOfRowByItem_                                 , @selector(outlineView:heightOfRowByItem:),
@@ -974,10 +963,6 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
             name:CPOutlineViewItemDidCollapseNotification
             object:self];
 
-    [self _updateIsViewBased];
-
-    if ([self _delegateRespondsToDataViewForTableColumn])
-        CPLog.warn("outlineView:dataViewForTableColumn:item: is deprecated. You should use -outlineView:viewForTableColumn:item: where you can request the view with -makeViewWithIdentifier:owner:");
 }
 
 - (BOOL)_sendDelegateDeleteKeyPressed
@@ -1075,7 +1060,7 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
     var dragView = [[_CPColumnDragView alloc] initWithLineColor:[self gridColor]],
         tableColumn = [[self tableColumns] objectAtIndex:theColumnIndex],
         defaultRowHeight = [self valueForThemeAttribute:@"default-row-height"],
-        bounds = CGRectMake(0.0, 0.0, [tableColumn width], CGRectGetHeight([self exposedRect]) + defaultRowHeight),
+        bounds = _CGRectMake(0.0, 0.0, [tableColumn width], _CGRectGetHeight([self exposedRect]) + defaultRowHeight),
         columnRect = [self rectOfColumn:theColumnIndex],
         headerView = [tableColumn headerView],
         row = [_exposedRows firstIndex];
@@ -1089,7 +1074,7 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
         dataViewFrame.origin.x = 0.0;
 
         // Offset by table header height - scroll position
-        dataViewFrame.origin.y = (CGRectGetMinY(dataViewFrame) - CGRectGetMinY([self exposedRect])) + defaultRowHeight;
+        dataViewFrame.origin.y = ( _CGRectGetMinY(dataViewFrame) - _CGRectGetMinY([self exposedRect]) ) + defaultRowHeight;
         [dataView setFrame:dataViewFrame];
 
         [dataView setObjectValue:[self _objectValueForTableColumn:tableColumn row:row]];
@@ -1113,7 +1098,7 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
 
     // Add the column header view
     var headerFrame = [headerView frame];
-    headerFrame.origin = CGPointMakeZero();
+    headerFrame.origin = _CGPointMakeZero();
 
     var columnHeaderView = [[_CPTableColumnHeaderView alloc] initWithFrame:headerFrame];
     [columnHeaderView setStringValue:[headerView stringValue]];
@@ -1319,7 +1304,7 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
 
         var disclosureControlFrame = [self frameOfOutlineDisclosureControlAtRow:row];
 
-        if (CGRectIsEmpty(disclosureControlFrame))
+        if (_CGRectIsEmpty(disclosureControlFrame))
             continue;
 
         var control = [self _dequeueDisclosureControl];
@@ -1376,7 +1361,7 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
 - (void)_toggleFromDisclosureControl:(CPControl)aControl
 {
     var controlFrame = [aControl frame],
-        item = [self itemAtRow:[self rowAtPoint:CGPointMake(CGRectGetMinX(controlFrame), CGRectGetMidY(controlFrame))]];
+        item = [self itemAtRow:[self rowAtPoint:_CGPointMake(_CGRectGetMinX(controlFrame), _CGRectGetMidY(controlFrame))]];
 
     if ([self isItemExpanded:item])
         [self collapseItem:item];
@@ -1549,26 +1534,11 @@ var CPOutlineViewCoalesceSelectionNotificationStateOff  = 0,
     [super keyDown:anEvent];
 }
 
-- (CPView)_viewForTableColumn:(CPTableColumn)aTableColumn row:(CPInteger)aRow
-{
-    return [_outlineViewDelegate outlineView:self viewForTableColumn:aTableColumn item:[self itemAtRow:aRow]];
-}
-
-- (CPView)_dataViewForTableColumn:(CPTableColumn)aTableColumn row:(CPInteger)aRow
-{
-    return [_outlineViewDelegate outlineView:self dataViewForTableColumn:aTableColumn item:[self itemAtRow:aRow]];
-}
-
 - (BOOL)_dataSourceRespondsToObjectValueForTableColumn
 {
     return _implementedOutlineViewDataSourceMethods & CPOutlineViewDataSource_outlineView_objectValue_forTableColumn_byItem_;
 }
 
-- (BOOL)_delegateRespondsToViewForTableColumn
-{
-    return _implementedOutlineViewDelegateMethods & CPOutlineViewDelegate_outlineView_viewForTableColumn_item_;
-}
-
 - (BOOL)_delegateRespondsToDataViewForTableColumn
 {
     return _implementedOutlineViewDelegateMethods & CPOutlineViewDelegate_outlineView_dataViewForTableColumn_item_;
@@ -1923,6 +1893,17 @@ var _loadItemInfoForItem = function(/*CPOutlineView*/ anOutlineView, /*id*/ anIt
     return [_outlineView menu] || [[_outlineView class] defaultMenu];
 }
 
+- (CPView)tableView:(CPTableView)aTableView dataViewForTableColumn:(CPTableColumn)aTableColumn row:(int)aRow
+{
+    if ((_outlineView._implementedOutlineViewDelegateMethods & CPOutlineViewDelegate_outlineView_dataViewForTableColumn_item_))
+    {
+        var item = [_outlineView itemAtRow:aRow];
+        return [_outlineView._outlineViewDelegate outlineView:_outlineView dataViewForTableColumn:aTableColumn item:item]
+    }
+
+    return nil;
+}
+
 @end
 
 @implementation CPDisclosureButton : CPButton
@@ -1955,14 +1936,14 @@ var _loadItemInfoForItem = function(/*CPOutlineView*/ anOutlineView, /*id*/ anIt
 {
     var bounds = [self bounds],
         context = [[CPGraphicsContext currentContext] graphicsPort],
-        width = CGRectGetWidth(bounds),
-        height = CGRectGetHeight(bounds);
+        width = _CGRectGetWidth(bounds),
+        height = _CGRectGetHeight(bounds);
 
     CGContextBeginPath(context);
 
     if (_angle)
     {
-        var centre = CGPointMake(FLOOR(width / 2.0), FLOOR(height / 2.0));
+        var centre = _CGPointMake(FLOOR(width / 2.0), FLOOR(height / 2.0));
         CGContextTranslateCTM(context, centre.x, centre.y);
         CGContextRotateCTM(context, _angle);
         CGContextTranslateCTM(context, -centre.x, -centre.y);
@@ -2026,8 +2007,6 @@ var CPOutlineViewIndentationPerLevelKey = @"CPOutlineViewIndentationPerLevelKey"
 
         [super setDataSource:[[_CPOutlineViewTableViewDataSource alloc] initWithOutlineView:self]];
         [super setDelegate:[[_CPOutlineViewTableViewDelegate alloc] initWithOutlineView:self]];
-
-        [self _updateIsViewBased];
     }
 
     return self;

AppKit/CPPopUpButton.j

@@ -667,15 +667,10 @@ CPPopUpButtonStatePullsDown = CPThemeState("pulls-down");
     if (![self isEnabled] || ![self numberOfItems])
         return;
 
-    var menu = [self menu];
-
-    // Don't reopen the menu based on the same click which caused it to close, e.g. a click on this button.
-    if (menu._lastCloseEvent === anEvent)
-        return;
-
     [self highlight:YES];
 
-    var bounds = [self bounds],
+    var menu = [self menu],
+        bounds = [self bounds],
         minimumWidth = CGRectGetWidth(bounds);
 
     // FIXME: setFont: should set the font on the menu.

AppKit/CPPopover.j

@@ -63,7 +63,7 @@ var CPPopoverDelegate_popover_willShow_     = 1 << 0,
     @outlet CPViewController    _contentViewController  @accessors(property=contentViewController);
     @outlet id                  _delegate               @accessors(getter=delegate);
 
-    BOOL                        _animates               @accessors(getter=animates);
+    BOOL                        _animates               @accessors(property=animates);
     int                         _appearance             @accessors(property=appearance);
     int                         _behavior               @accessors(getter=behavior);
 
@@ -153,20 +153,6 @@ var CPPopoverDelegate_popover_willShow_     = 1 << 0,
     return [_popoverWindow isVisible];
 }
 
-/*!
-    Set if the popover should animate for open/close actions.
-
-    @param shouldAnimate if YES, the popover will be animated.
-*/
-- (void)setAnimates:(BOOL)shouldAnimate
-{
-    if (_animates == shouldAnimate)
-        return;
-
-    _animates = shouldAnimate;
-    [_popoverWindow setAnimates:_animates];
-}
-
 /*!
 Set the behavior of the CPPopover. It can be:
 
@@ -238,7 +224,6 @@ Set the behavior of the CPPopover. It can be:
         _popoverWindow = [[_CPPopoverWindow alloc] initWithContentRect:CGRectMakeZero() styleMask:[self styleMaskForBehavior]];
     }
 
-    [_popoverWindow setPlatformWindow:[[positioningView window] platformWindow]];
     [_popoverWindow setAppearance:_appearance];
     [_popoverWindow setAnimates:_animates];
     [_popoverWindow setDelegate:self];

AppKit/CPProgressIndicator.j

@@ -371,7 +371,7 @@ var CPProgressIndicatorSpinningStyleColors = [];
 
 - (CPView)createEphemeralSubviewNamed:(CPString)aName
 {
-    return [[CPView alloc] initWithFrame:CGRectMakeZero()];
+    return [[CPView alloc] initWithFrame:_CGRectMakeZero()];
 }
 
 - (CGRect)rectForEphemeralSubviewNamed:(CPString)aViewName
@@ -387,7 +387,7 @@ var CPProgressIndicatorSpinningStyleColors = [];
         if (_indeterminate)
             barWidth = width;
 
-        return CGRectMake(0, 0, barWidth, [self valueForThemeAttribute:@"default-height"]);
+        return _CGRectMake(0, 0, barWidth, [self valueForThemeAttribute:@"default-height"]);
     }
 
     return nil;

AppKit/CPRuleEditor/CPRuleEditor.j

@@ -2279,7 +2279,7 @@ TODO: implement
 
 - (void)_postRowCountChangedNotificationOfType:(CPString)notificationName indexes:indexes
 {
-    var userInfo = indexes === nil ? @{} : @{ "indexes": indexes };
+    var userInfo = @{ "indexes": indexes };
     [[CPNotificationCenter defaultCenter] postNotificationName:notificationName object:self userInfo:userInfo];
 }
 

AppKit/CPRuleEditor/_CPRuleEditorViewSlice.j

@@ -53,8 +53,8 @@
     if (select == _selected)
         return;
 
-    var selector = select ? @selector(setThemeState:) : @selector(unsetThemeState:);
-    [[self subviews] makeObjectsPerformSelector:selector  withObject:CPThemeStateSelectedDataView];
+    var selector = select ? @"setThemeState:" : @"unsetThemeState:";
+    [[self subviews] makeObjectsPerformSelector:CPSelectorFromString(selector)  withObject:CPThemeStateSelectedDataView];
     _selected = select;
 }
 

AppKit/CPScreen.j

@@ -43,9 +43,9 @@
 - (CGRect)visibleFrame
 {
 #if PLATFORM(DOM)
-    return CGRectMake(window.screen.availLeft, window.screen.availTop, window.screen.availWidth, window.screen.availHeight);
+    return _CGRectMake(window.screen.availLeft, window.screen.availTop, window.screen.availWidth, window.screen.availHeight);
 #else
-    return CGRectMakeZero();
+    return _CGRectMakeZero();
 #endif
 }
 

AppKit/CPScrollView.j

@@ -151,7 +151,7 @@ var CPScrollerStyleGlobal                       = CPScrollerStyleOverlay,
 
 + (CGSize)contentSizeForFrameSize:(CGSize)frameSize hasHorizontalScroller:(BOOL)hFlag hasVerticalScroller:(BOOL)vFlag borderType:(CPBorderType)borderType
 {
-    var bounds = [self _insetBounds:CGRectMake(0.0, 0.0, frameSize.width, frameSize.height) borderType:borderType],
+    var bounds = [self _insetBounds:_CGRectMake(0.0, 0.0, frameSize.width, frameSize.height) borderType:borderType],
         scrollerWidth = [CPScroller scrollerWidth];
 
     if (hFlag)
@@ -165,10 +165,10 @@ var CPScrollerStyleGlobal                       = CPScrollerStyleOverlay,
 
 + (CGSize)frameSizeForContentSize:(CGSize)contentSize hasHorizontalScroller:(BOOL)hFlag hasVerticalScroller:(BOOL)vFlag borderType:(CPBorderType)borderType
 {
-    var bounds = [self _insetBounds:CGRectMake(0.0, 0.0, contentSize.width, contentSize.height) borderType:borderType],
+    var bounds = [self _insetBounds:_CGRectMake(0.0, 0.0, contentSize.width, contentSize.height) borderType:borderType],
         widthInset = contentSize.width - bounds.size.width,
         heightInset = contentSize.height - bounds.size.height,
-        frameSize = CGSizeMake(contentSize.width + widthInset, contentSize.height + heightInset),
+        frameSize = _CGSizeMake(contentSize.width + widthInset, contentSize.height + heightInset),
         scrollerWidth = [CPScroller scrollerWidth];
 
     if (hFlag)
@@ -186,10 +186,10 @@ var CPScrollerStyleGlobal                       = CPScrollerStyleOverlay,
     {
         case CPLineBorder:
         case CPBezelBorder:
-            return CGRectInset(bounds, 1.0, 1.0);
+            return _CGRectInset(bounds, 1.0, 1.0);
 
         case CPGrooveBorder:
-            bounds = CGRectInset(bounds, 2.0, 2.0);
+            bounds = _CGRectInset(bounds, 2.0, 2.0);
             ++bounds.origin.y;
             --bounds.size.height;
             return bounds;
@@ -517,8 +517,8 @@ Notifies the delegate when the scroll view has finished scrolling.
     {
         var bounds = [self _insetBounds];
 
-        [self setHorizontalScroller:[[CPScroller alloc] initWithFrame:CGRectMake(0.0, 0.0, MAX(CGRectGetWidth(bounds), [CPScroller scrollerWidthInStyle:_scrollerStyle] + 1), [CPScroller scrollerWidthInStyle:_scrollerStyle])]];
-        [[self horizontalScroller] setFrameSize:CGSizeMake(CGRectGetWidth(bounds), [CPScroller scrollerWidthInStyle:_scrollerStyle])];
+        [self setHorizontalScroller:[[CPScroller alloc] initWithFrame:CGRectMake(0.0, 0.0, MAX(_CGRectGetWidth(bounds), [CPScroller scrollerWidthInStyle:_scrollerStyle] + 1), [CPScroller scrollerWidthInStyle:_scrollerStyle])]];
+        [[self horizontalScroller] setFrameSize:CGSizeMake(_CGRectGetWidth(bounds), [CPScroller scrollerWidthInStyle:_scrollerStyle])];
     }
 
     [self reflectScrolledClipView:_contentView];
@@ -582,8 +582,8 @@ Notifies the delegate when the scroll view has finished scrolling.
     {
         var bounds = [self _insetBounds];
 
-        [self setVerticalScroller:[[CPScroller alloc] initWithFrame:CGRectMake(0.0, 0.0, [CPScroller scrollerWidthInStyle:_scrollerStyle], MAX(CGRectGetHeight(bounds), [CPScroller scrollerWidthInStyle:_scrollerStyle] + 1))]];
-        [[self verticalScroller] setFrameSize:CGSizeMake([CPScroller scrollerWidthInStyle:_scrollerStyle], CGRectGetHeight(bounds))];
+        [self setVerticalScroller:[[CPScroller alloc] initWithFrame:_CGRectMake(0.0, 0.0, [CPScroller scrollerWidthInStyle:_scrollerStyle], MAX(_CGRectGetHeight(bounds), [CPScroller scrollerWidthInStyle:_scrollerStyle] + 1))]];
+        [[self verticalScroller] setFrameSize:CGSizeMake([CPScroller scrollerWidthInStyle:_scrollerStyle], _CGRectGetHeight(bounds))];
     }
 
     [self reflectScrolledClipView:_contentView];
@@ -859,13 +859,13 @@ Notifies the delegate when the scroll view has finished scrolling.
 - (CGRect)_cornerViewFrame
 {
     if (!_cornerView)
-        return CGRectMakeZero();
+        return _CGRectMakeZero();
 
     var bounds = [self _insetBounds],
         frame = [_cornerView frame];
 
-    frame.origin.x = CGRectGetMaxX(bounds) - CGRectGetWidth(frame);
-    frame.origin.y = CGRectGetMinY(bounds);
+    frame.origin.x = _CGRectGetMaxX(bounds) - _CGRectGetWidth(frame);
+    frame.origin.y = _CGRectGetMinY(bounds);
 
     return frame;
 }
@@ -876,14 +876,14 @@ Notifies the delegate when the scroll view has finished scrolling.
     var headerView = [self _headerView];
 
     if (!headerView)
-        return CGRectMakeZero();
+        return _CGRectMakeZero();
 
     var frame = [self _insetBounds];
 
-    frame.size.height = CGRectGetHeight([headerView frame]);
+    frame.size.height = _CGRectGetHeight([headerView frame]);
 
     if (SHOULD_SHOW_CORNER_VIEW())
-        frame.size.width -= CGRectGetWidth([self _cornerViewFrame]);
+        frame.size.width -= _CGRectGetWidth([self _cornerViewFrame]);
 
     return frame;
 }
@@ -924,18 +924,18 @@ Notifies the delegate when the scroll view has finished scrolling.
             break;
 
         case CPScrollerDecrementPage:
-            contentBounds.origin.y -= CGRectGetHeight(contentBounds) - _verticalPageScroll;
+            contentBounds.origin.y -= _CGRectGetHeight(contentBounds) - _verticalPageScroll;
             break;
 
         case CPScrollerIncrementPage:
-            contentBounds.origin.y += CGRectGetHeight(contentBounds) - _verticalPageScroll;
+            contentBounds.origin.y += _CGRectGetHeight(contentBounds) - _verticalPageScroll;
             break;
 
         // We want integral bounds!
         case CPScrollerKnobSlot:
         case CPScrollerKnob:
         default:
-            contentBounds.origin.y = ROUND(value * (CGRectGetHeight(documentFrame) - CGRectGetHeight(contentBounds)));
+            contentBounds.origin.y = ROUND(value * (_CGRectGetHeight(documentFrame) - _CGRectGetHeight(contentBounds)));
     }
 
     [self _sendDelegateMessages];
@@ -961,18 +961,18 @@ Notifies the delegate when the scroll view has finished scrolling.
             break;
 
         case CPScrollerDecrementPage:
-            contentBounds.origin.x -= CGRectGetWidth(contentBounds) - _horizontalPageScroll;
+            contentBounds.origin.x -= _CGRectGetWidth(contentBounds) - _horizontalPageScroll;
             break;
 
         case CPScrollerIncrementPage:
-            contentBounds.origin.x += CGRectGetWidth(contentBounds) - _horizontalPageScroll;
+            contentBounds.origin.x += _CGRectGetWidth(contentBounds) - _horizontalPageScroll;
             break;
 
         // We want integral bounds!
         case CPScrollerKnobSlot:
         case CPScrollerKnob:
         default:
-            contentBounds.origin.x = ROUND(value * (CGRectGetWidth(documentFrame) - CGRectGetWidth(contentBounds)));
+            contentBounds.origin.x = ROUND(value * (_CGRectGetWidth(documentFrame) - _CGRectGetWidth(contentBounds)));
     }
 
     [self _sendDelegateMessages];
@@ -1096,7 +1096,7 @@ Notifies the delegate when the scroll view has finished scrolling.
         }
 
         [_contentView setFrame:[self _insetBounds]];
-        [_headerClipView setFrame:CGRectMakeZero()];
+        [_headerClipView setFrame:_CGRectMakeZero()];
 
         --_recursionCount;
 
@@ -1106,12 +1106,12 @@ Notifies the delegate when the scroll view has finished scrolling.
     var documentFrame = [documentView frame], // the size of the whole document
         contentFrame = [self _insetBounds], // assume it takes up the entire size of the scrollview (no scrollers)
         headerClipViewFrame = [self _headerClipViewFrame],
-        headerClipViewHeight = CGRectGetHeight(headerClipViewFrame);
+        headerClipViewHeight = _CGRectGetHeight(headerClipViewFrame);
 
     contentFrame.origin.y += headerClipViewHeight;
     contentFrame.size.height -= headerClipViewHeight;
 
-    var difference = CGSizeMake(CGRectGetWidth(documentFrame) - CGRectGetWidth(contentFrame), CGRectGetHeight(documentFrame) - CGRectGetHeight(contentFrame)),
+    var difference = _CGSizeMake(_CGRectGetWidth(documentFrame) - _CGRectGetWidth(contentFrame), _CGRectGetHeight(documentFrame) - _CGRectGetHeight(contentFrame)),
         verticalScrollerWidth = [CPScroller scrollerWidthInStyle:[_verticalScroller style]],
         horizontalScrollerHeight = [CPScroller scrollerWidthInStyle:[_horizontalScroller style]],
         hasVerticalScroll = difference.height > 0.0,
@@ -1162,18 +1162,18 @@ Notifies the delegate when the scroll view has finished scrolling.
     if (shouldShowVerticalScroller)
     {
         var verticalScrollerY =
-            MAX(CGRectGetMinY(contentFrame), MAX(CGRectGetMaxY([self _cornerViewFrame]), CGRectGetMaxY(headerClipViewFrame)));
+            MAX(_CGRectGetMinY(contentFrame), MAX(_CGRectGetMaxY([self _cornerViewFrame]), _CGRectGetMaxY(headerClipViewFrame)));
 
-        var verticalScrollerHeight = CGRectGetMaxY(contentFrame) - verticalScrollerY;
+        var verticalScrollerHeight = _CGRectGetMaxY(contentFrame) - verticalScrollerY;
 
         // Make a gap at the bottom of the vertical scroller so that the horizontal and vertical can't overlap.
         if (_scrollerStyle === CPScrollerStyleOverlay && hasHorizontalScroll)
             verticalScrollerHeight -= horizontalScrollerHeight;
 
-        var documentHeight = CGRectGetHeight(documentFrame);
+        var documentHeight = _CGRectGetHeight(documentFrame);
         [_verticalScroller setFloatValue:(difference.height <= 0.0) ? 0.0 : scrollPoint.y / difference.height];
-        [_verticalScroller setKnobProportion:documentHeight > 0 ? CGRectGetHeight(contentFrame) / documentHeight : 1.0];
-        [_verticalScroller setFrame:CGRectMake(CGRectGetMaxX(contentFrame) - overlay, verticalScrollerY, verticalScrollerWidth, verticalScrollerHeight)];
+        [_verticalScroller setKnobProportion:documentHeight > 0 ? _CGRectGetHeight(contentFrame) / documentHeight : 1.0];
+        [_verticalScroller setFrame:_CGRectMake(_CGRectGetMaxX(contentFrame) - overlay, verticalScrollerY, verticalScrollerWidth, verticalScrollerHeight)];
     }
     else if (wasShowingVerticalScroller)
     {
@@ -1183,16 +1183,16 @@ Notifies the delegate when the scroll view has finished scrolling.
 
     if (shouldShowHorizontalScroller)
     {
-        var horizontalScrollerWidth = CGRectGetWidth(contentFrame);
+        var horizontalScrollerWidth = _CGRectGetWidth(contentFrame);
         // Make a gap at the bottom of the vertical scroller so that the horizontal and vertical can't overlap.
         if (_scrollerStyle === CPScrollerStyleOverlay && hasVerticalScroll)
             horizontalScrollerWidth -= verticalScrollerWidth;
 
-        var documentWidth = CGRectGetWidth(documentFrame);
+        var documentWidth = _CGRectGetWidth(documentFrame);
 
         [_horizontalScroller setFloatValue:(difference.width <= 0.0) ? 0.0 : scrollPoint.x / difference.width];
-        [_horizontalScroller setKnobProportion:documentWidth > 0 ? CGRectGetWidth(contentFrame) / documentWidth : 1.0];
-        [_horizontalScroller setFrame:CGRectMake(CGRectGetMinX(contentFrame), CGRectGetMaxY(contentFrame) - overlay, horizontalScrollerWidth, horizontalScrollerHeight)];
+        [_horizontalScroller setKnobProportion:documentWidth > 0 ? _CGRectGetWidth(contentFrame) / documentWidth : 1.0];
+        [_horizontalScroller setFrame:_CGRectMake(_CGRectGetMinX(contentFrame), _CGRectGetMaxY(contentFrame) - overlay, horizontalScrollerWidth, horizontalScrollerHeight)];
     }
     else if (wasShowingHorizontalScroller)
     {
@@ -1272,7 +1272,7 @@ Notifies the delegate when the scroll view has finished scrolling.
     {
         case CPLineBorder:
             CGContextSetStrokeColor(context, [self currentValueForThemeAttribute:@"border-color"]);
-            CGContextStrokeRect(context, CGRectInset(strokeRect, 0.5, 0.5));
+            CGContextStrokeRect(context, _CGRectInset(strokeRect, 0.5, 0.5));
             break;
 
         case CPBezelBorder:
@@ -1290,10 +1290,10 @@ Notifies the delegate when the scroll view has finished scrolling.
 
 - (void)_drawGrayBezelInContext:(CGContext)context bounds:(CGRect)aRect
 {
-    var minX = CGRectGetMinX(aRect),
-        maxX = CGRectGetMaxX(aRect),
-        minY = CGRectGetMinY(aRect),
-        maxY = CGRectGetMaxY(aRect),
+    var minX = _CGRectGetMinX(aRect),
+        maxX = _CGRectGetMaxX(aRect),
+        minY = _CGRectGetMinY(aRect),
+        maxY = _CGRectGetMaxY(aRect),
         y = minY + 0.5;
 
     // Slightly darker line on top.
@@ -1324,10 +1324,10 @@ Notifies the delegate when the scroll view has finished scrolling.
 
 - (void)_drawGrooveInContext:(CGContext)context bounds:(CGRect)aRect
 {
-    var minX = CGRectGetMinX(aRect),
-        maxX = CGRectGetMaxX(aRect),
-        minY = CGRectGetMinY(aRect),
-        maxY = CGRectGetMaxY(aRect);
+    var minX = _CGRectGetMinX(aRect),
+        maxX = _CGRectGetMaxX(aRect),
+        minY = _CGRectGetMinY(aRect),
+        maxY = _CGRectGetMaxY(aRect);
 
     CGContextBeginPath(context);
     CGContextSetStrokeColor(context, [CPColor colorWithWhite:159.0 / 255.0 alpha:1.0]);
@@ -1357,11 +1357,11 @@ Notifies the delegate when the scroll view has finished scrolling.
     CGContextBeginPath(context);
     CGContextSetStrokeColor(context, [CPColor whiteColor]);
 
-    var rect = CGRectOffset(aRect, 1.0, 1.0);
+    var rect = _CGRectOffset(aRect, 1.0, 1.0);
 
     rect.size.width -= 1.0;
     rect.size.height -= 1.0;
-    CGContextStrokeRect(context, CGRectInset(rect, 0.5, 0.5));
+    CGContextStrokeRect(context, _CGRectInset(rect, 0.5, 0.5));
 
     CGContextBeginPath(context);
     CGContextSetStrokeColor(context, [CPColor colorWithWhite:192.0 / 255.0 alpha:1.0]);
@@ -1395,29 +1395,29 @@ Notifies the delegate when the scroll view has finished scrolling.
 - (void)scrollPageUp:(id)sender
 {
     var contentBounds = [_contentView bounds];
-    [self moveByOffset:CGSizeMake(0.0, -(CGRectGetHeight(contentBounds) - _verticalPageScroll))];
+    [self moveByOffset:CGSizeMake(0.0, -(_CGRectGetHeight(contentBounds) - _verticalPageScroll))];
 }
 
 - (void)scrollPageDown:(id)sender
 {
     var contentBounds = [_contentView bounds];
-    [self moveByOffset:CGSizeMake(0.0, CGRectGetHeight(contentBounds) - _verticalPageScroll)];
+    [self moveByOffset:CGSizeMake(0.0, _CGRectGetHeight(contentBounds) - _verticalPageScroll)];
 }
 
 - (void)scrollToBeginningOfDocument:(id)sender
 {
-    [_contentView scrollToPoint:CGPointMakeZero()];
-    [_headerClipView scrollToPoint:CGPointMakeZero()];
+    [_contentView scrollToPoint:_CGPointMakeZero()];
+    [_headerClipView scrollToPoint:_CGPointMakeZero()];
 }
 
 - (void)scrollToEndOfDocument:(id)sender
 {
     var contentBounds = [_contentView bounds],
         documentFrame = [[self documentView] frame],
-        scrollPoint = CGPointMake(0.0, CGRectGetHeight(documentFrame) - CGRectGetHeight(contentBounds));
+        scrollPoint = _CGPointMake(0.0, _CGRectGetHeight(documentFrame) - _CGRectGetHeight(contentBounds));
 
     [_contentView scrollToPoint:scrollPoint];
-    [_headerClipView scrollToPoint:CGPointMakeZero()];
+    [_headerClipView scrollToPoint:_CGPointMakeZero()];
 }
 
 - (void)moveLeft:(id)sender

AppKit/CPScroller.j

@@ -116,11 +116,11 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
             @"decrement-line-color": [CPNull null],
             @"increment-line-color": [CPNull null],
             @"knob-color": [CPNull null],
-            @"decrement-line-size": CGSizeMakeZero(),
-            @"increment-line-size": CGSizeMakeZero(),
-            @"track-inset": CGInsetMakeZero(),
-            @"knob-inset": CGInsetMakeZero(),
-            @"minimum-knob-length": 21.0,
+            @"decrement-line-size":_CGSizeMakeZero(),
+            @"increment-line-size":_CGSizeMakeZero(),
+            @"track-inset":_CGInsetMakeZero(),
+            @"knob-inset": _CGInsetMakeZero(),
+            @"minimum-knob-length":21.0,
             @"track-border-overlay": 9.0
         };
 }
@@ -194,7 +194,7 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
 
         // We have to choose an orientation. If for some bizarre reason width === height,
         // punt and choose vertical.
-        [self _setIsVertical:CGRectGetHeight(aFrame) >= CGRectGetWidth(aFrame)];
+        [self _setIsVertical:_CGRectGetHeight(aFrame) >= _CGRectGetWidth(aFrame)];
     }
 
     return self;
@@ -321,7 +321,7 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
 - (CGRect)rectForPart:(CPScrollerPart)aPart
 {
     if (aPart == CPScrollerNoPart)
-        return CGRectMakeZero();
+        return _CGRectMakeZero();
 
     return _partRects[aPart];
 }
@@ -391,8 +391,8 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
 
     var knobInset = [self currentValueForThemeAttribute:@"knob-inset"],
         trackInset = [self currentValueForThemeAttribute:@"track-inset"],
-        width = CGRectGetWidth(bounds),
-        height = CGRectGetHeight(bounds);
+        width = _CGRectGetWidth(bounds),
+        height = _CGRectGetHeight(bounds);
 
     if ([self isVertical])
     {
@@ -406,21 +406,21 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
             knobHeight = MAX(minimumKnobLength, (slotSize * _knobProportion)),
             knobLocation = effectiveDecrementLineHeight + (slotSize - knobHeight) * [self floatValue];
 
-        _partRects[CPScrollerDecrementPage] = CGRectMake(0.0, effectiveDecrementLineHeight, width, knobLocation - effectiveDecrementLineHeight);
-        _partRects[CPScrollerKnob]          = CGRectMake(knobInset.left, knobLocation, knobWidth, knobHeight);
-        _partRects[CPScrollerIncrementPage] = CGRectMake(0.0, knobLocation + knobHeight, width, height - (knobLocation + knobHeight) - effectiveIncrementLineHeight);
-        _partRects[CPScrollerKnobSlot]      = CGRectMake(trackInset.left, effectiveDecrementLineHeight, width - trackInset.left - trackInset.right, slotSize);
-        _partRects[CPScrollerDecrementLine] = CGRectMake(0.0, 0.0, decrementLineSize.width, decrementLineSize.height);
-        _partRects[CPScrollerIncrementLine] = CGRectMake(0.0, height - incrementLineSize.height, incrementLineSize.width, incrementLineSize.height);
+        _partRects[CPScrollerDecrementPage] = _CGRectMake(0.0, effectiveDecrementLineHeight, width, knobLocation - effectiveDecrementLineHeight);
+        _partRects[CPScrollerKnob]          = _CGRectMake(knobInset.left, knobLocation, knobWidth, knobHeight);
+        _partRects[CPScrollerIncrementPage] = _CGRectMake(0.0, knobLocation + knobHeight, width, height - (knobLocation + knobHeight) - effectiveIncrementLineHeight);
+        _partRects[CPScrollerKnobSlot]      = _CGRectMake(trackInset.left, effectiveDecrementLineHeight, width - trackInset.left - trackInset.right, slotSize);
+        _partRects[CPScrollerDecrementLine] = _CGRectMake(0.0, 0.0, decrementLineSize.width, decrementLineSize.height);
+        _partRects[CPScrollerIncrementLine] = _CGRectMake(0.0, height - incrementLineSize.height, incrementLineSize.width, incrementLineSize.height);
 
         if (height < knobHeight + decrementLineSize.height + incrementLineSize.height + trackInset.top + trackInset.bottom)
-            _partRects[CPScrollerKnob] = CGRectMakeZero();
+            _partRects[CPScrollerKnob] = _CGRectMakeZero();
 
         if (height < decrementLineSize.height + incrementLineSize.height - 2)
         {
-            _partRects[CPScrollerIncrementLine] = CGRectMakeZero();
-            _partRects[CPScrollerDecrementLine] = CGRectMakeZero();
-            _partRects[CPScrollerKnobSlot]      = CGRectMake(trackInset.left, 0,  width - trackInset.left - trackInset.right, height);
+            _partRects[CPScrollerIncrementLine] = _CGRectMakeZero();
+            _partRects[CPScrollerDecrementLine] = _CGRectMakeZero();
+            _partRects[CPScrollerKnobSlot]      = _CGRectMake(trackInset.left, 0,  width - trackInset.left - trackInset.right, height);
         }
     }
     else
@@ -435,21 +435,21 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
             knobHeight = height - knobInset.top - knobInset.bottom,
             knobLocation = effectiveDecrementLineWidth + (slotSize - knobWidth) * [self floatValue];
 
-        _partRects[CPScrollerDecrementPage] = CGRectMake(effectiveDecrementLineWidth, 0.0, knobLocation - effectiveDecrementLineWidth, height);
-        _partRects[CPScrollerKnob]          = CGRectMake(knobLocation, knobInset.top, knobWidth, knobHeight);
-        _partRects[CPScrollerIncrementPage] = CGRectMake(knobLocation + knobWidth, 0.0, width - (knobLocation + knobWidth) - effectiveIncrementLineWidth, height);
-        _partRects[CPScrollerKnobSlot]      = CGRectMake(effectiveDecrementLineWidth, trackInset.top, slotSize, height - trackInset.top - trackInset.bottom);
-        _partRects[CPScrollerDecrementLine] = CGRectMake(0.0, 0.0, decrementLineSize.width, decrementLineSize.height);
-        _partRects[CPScrollerIncrementLine] = CGRectMake(width - incrementLineSize.width, 0.0, incrementLineSize.width, incrementLineSize.height);
+        _partRects[CPScrollerDecrementPage] = _CGRectMake(effectiveDecrementLineWidth, 0.0, knobLocation - effectiveDecrementLineWidth, height);
+        _partRects[CPScrollerKnob]          = _CGRectMake(knobLocation, knobInset.top, knobWidth, knobHeight);
+        _partRects[CPScrollerIncrementPage] = _CGRectMake(knobLocation + knobWidth, 0.0, width - (knobLocation + knobWidth) - effectiveIncrementLineWidth, height);
+        _partRects[CPScrollerKnobSlot]      = _CGRectMake(effectiveDecrementLineWidth, trackInset.top, slotSize, height - trackInset.top - trackInset.bottom);
+        _partRects[CPScrollerDecrementLine] = _CGRectMake(0.0, 0.0, decrementLineSize.width, decrementLineSize.height);
+        _partRects[CPScrollerIncrementLine] = _CGRectMake(width - incrementLineSize.width, 0.0, incrementLineSize.width, incrementLineSize.height);
 
         if (width < knobWidth + decrementLineSize.width + incrementLineSize.width + trackInset.left + trackInset.right)
-            _partRects[CPScrollerKnob] = CGRectMakeZero();
+            _partRects[CPScrollerKnob] = _CGRectMakeZero();
 
         if (width < decrementLineSize.width + incrementLineSize.width - 2)
         {
-            _partRects[CPScrollerIncrementLine] = CGRectMakeZero();
-            _partRects[CPScrollerDecrementLine] = CGRectMakeZero();
-            _partRects[CPScrollerKnobSlot]      = CGRectMake(0.0, 0.0,  width, slotSize);
+            _partRects[CPScrollerIncrementLine] = _CGRectMakeZero();
+            _partRects[CPScrollerDecrementLine] = _CGRectMakeZero();
+            _partRects[CPScrollerKnobSlot]      = _CGRectMake(0.0, 0.0,  width, slotSize);
         }
     }
 }
@@ -517,7 +517,7 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
 
 - (CPView)createViewForPart:(CPScrollerPart)aPart
 {
-    var view = [[CPView alloc] initWithFrame:CGRectMakeZero()];
+    var view = [[CPView alloc] initWithFrame:_CGRectMakeZero()];
 
     [view setHitTests:NO];
 
@@ -531,7 +531,7 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
 
 - (CPView)createEphemeralSubviewNamed:(CPString)aName
 {
-    var view = [[CPView alloc] initWithFrame:CGRectMakeZero()];
+    var view = [[CPView alloc] initWithFrame:_CGRectMakeZero()];
 
     [view setHitTests:NO];
 
@@ -606,7 +606,7 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
     {
         var knobRect = [self rectForPart:CPScrollerKnob],
             knobSlotRect = [self rectForPart:CPScrollerKnobSlot],
-            remainder = ![self isVertical] ? (CGRectGetWidth(knobSlotRect) - CGRectGetWidth(knobRect)) : (CGRectGetHeight(knobSlotRect) - CGRectGetHeight(knobRect));
+            remainder = ![self isVertical] ? (_CGRectGetWidth(knobSlotRect) - _CGRectGetWidth(knobRect)) : (_CGRectGetHeight(knobSlotRect) - _CGRectGetHeight(knobRect));
 
         if (remainder <= 0)
             [self setFloatValue:0.0];
@@ -660,11 +660,11 @@ CPThemeStateScrollerKnobDark    = CPThemeState("scroller-knob-dark");
             else if (_trackingPart === CPScrollerDecrementPage || _trackingPart === CPScrollerIncrementPage)
             {
                 var knobRect = [self rectForPart:CPScrollerKnob],
-                    knobWidth = ![self isVertical] ? CGRectGetWidth(knobRect) : CGRectGetHeight(knobRect),
+                    knobWidth = ![self isVertical] ? _CGRectGetWidth(knobRect) : _CGRectGetHeight(knobRect),
                     knobSlotRect = [self rectForPart:CPScrollerKnobSlot],
-                    remainder = (![self isVertical] ? CGRectGetWidth(knobSlotRect) : CGRectGetHeight(knobSlotRect)) - knobWidth;
+                    remainder = (![self isVertical] ? _CGRectGetWidth(knobSlotRect) : _CGRectGetHeight(knobSlotRect)) - knobWidth;
 
-                [self setFloatValue:((![self isVertical] ? _trackingStartPoint.x - CGRectGetMinX(knobSlotRect) : _trackingStartPoint.y - CGRectGetMinY(knobSlotRect)) - knobWidth / 2.0) / remainder];
+                [self setFloatValue:((![self isVertical] ? _trackingStartPoint.x - _CGRectGetMinX(knobSlotRect) : _trackingStartPoint.y - _CGRectGetMinY(knobSlotRect)) - knobWidth / 2.0) / remainder];
 
                 _hitPart = CPScrollerKnob;
 

AppKit/CPSearchField.j

@@ -229,22 +229,22 @@ var RECENT_SEARCH_PREFIX = @"   ";
 - (CGRect)searchTextRectForBounds:(CGRect)rect
 {
     var leftOffset = 0,
-        width = CGRectGetWidth(rect),
+        width = _CGRectGetWidth(rect),
         bounds = [self bounds];
 
     if (_searchButton)
     {
         var searchBounds = [self searchButtonRectForBounds:bounds];
-        leftOffset = CGRectGetMaxX(searchBounds) + 2;
+        leftOffset = _CGRectGetMaxX(searchBounds) + 2;
     }
 
     if (_cancelButton)
     {
         var cancelRect = [self cancelButtonRectForBounds:bounds];
-        width = CGRectGetMinX(cancelRect) - leftOffset;
+        width = _CGRectGetMinX(cancelRect) - leftOffset;
     }
 
-    return CGRectMake(leftOffset, CGRectGetMinY(rect), width, CGRectGetHeight(rect));
+    return _CGRectMake(leftOffset, _CGRectGetMinY(rect), width, _CGRectGetHeight(rect));
 }
 
 /*!
@@ -256,7 +256,7 @@ var RECENT_SEARCH_PREFIX = @"   ";
 {
     var size = [[self valueForThemeAttribute:@"image-search"] size] || CGSizeMakeZero();
 
-    return CGRectMake(5, (CGRectGetHeight(rect) - size.height) / 2, size.width, size.height);
+    return _CGRectMake(5, (_CGRectGetHeight(rect) - size.height) / 2, size.width, size.height);
 }
 
 /*!
@@ -268,7 +268,7 @@ var RECENT_SEARCH_PREFIX = @"   ";
 {
     var size = [[self valueForThemeAttribute:@"image-cancel"] size] || CGSizeMakeZero();
 
-    return CGRectMake(CGRectGetWidth(rect) - size.width - 5, (CGRectGetHeight(rect) - size.width) / 2, size.height, size.height);
+    return _CGRectMake(_CGRectGetWidth(rect) - size.width - 5, (_CGRectGetHeight(rect) - size.width) / 2, size.height, size.height);
 }
 
 // Managing Menu Templates
@@ -482,7 +482,7 @@ var RECENT_SEARCH_PREFIX = @"   ";
 - (CPView)hitTest:(CGPoint)aPoint
 {
     // Make sure a hit anywhere within the search field returns the search field itself
-    if (CGRectContainsPoint([self frame], aPoint))
+    if (_CGRectContainsPoint([self frame], aPoint))
         return self;
     else
         return nil;
@@ -498,7 +498,7 @@ var RECENT_SEARCH_PREFIX = @"   ";
     var location = [anEvent locationInWindow],
         point = [self convertPoint:location fromView:nil];
 
-    if (CGRectContainsPoint([self searchButtonRectForBounds:[self bounds]], point))
+    if (_CGRectContainsPoint([self searchButtonRectForBounds:[self bounds]], point))
     {
         if (_searchMenuTemplate == nil)
         {
@@ -510,7 +510,7 @@ var RECENT_SEARCH_PREFIX = @"   ";
         else
            [self _showMenu];
     }
-    else if (CGRectContainsPoint([self cancelButtonRectForBounds:[self bounds]], point))
+    else if (_CGRectContainsPoint([self cancelButtonRectForBounds:[self bounds]], point))
         [_cancelButton mouseDown:anEvent];
     else
         [super mouseDown:anEvent];

AppKit/CPSegmentedControl.j

@@ -63,8 +63,8 @@ CPSegmentSwitchTrackingMomentary = 2;
             @"vertical-alignment": CPCenterVerticalTextAlignment,
             @"image-position": CPImageLeft,
             @"image-scaling": CPImageScaleNone,
-            @"bezel-inset": CGInsetMakeZero(),
-            @"content-inset": CGInsetMakeZero(),
+            @"bezel-inset": _CGInsetMakeZero(),
+            @"content-inset": _CGInsetMakeZero(),
             @"left-segment-bezel-color": [CPNull null],
             @"right-segment-bezel-color": [CPNull null],
             @"center-segment-bezel-color": [CPNull null],
@@ -564,9 +564,9 @@ CPSegmentSwitchTrackingMomentary = 2;
 - (CPView)createEphemeralSubviewNamed:(CPString)aName
 {
     if ([aName hasPrefix:@"segment-content"])
-        return [[_CPImageAndTextView alloc] initWithFrame:CGRectMakeZero()];
+        return [[_CPImageAndTextView alloc] initWithFrame:_CGRectMakeZero()];
 
-    return [[CPView alloc] initWithFrame:CGRectMakeZero()];
+    return [[CPView alloc] initWithFrame:_CGRectMakeZero()];
 }
 
 - (void)layoutSubviews

AppKit/CPShadowView.j

@@ -60,7 +60,7 @@ CPThemeStateShadowViewHeavy = CPThemeState("shadowview-style-heavy");
     var shadowView = [CPShadowView new],
         inset = [shadowView valueForThemeAttribute:@"content-inset" inState:(aWeight == CPLightShadow) ? CPThemeStateShadowViewLight : CPThemeStateShadowViewHeavy];
 
-    return CGRectMake(CGRectGetMinX(aFrame) - inset.left, CGRectGetMinY(aFrame) - inset.top, CGRectGetWidth(aFrame) + inset.left + inset.right, CGRectGetHeight(aFrame) + inset.top + inset.bottom);
+    return CGRectMake(_CGRectGetMinX(aFrame) - inset.left, _CGRectGetMinY(aFrame) - inset.top, _CGRectGetWidth(aFrame) + inset.left + inset.right, _CGRectGetHeight(aFrame) + inset.top + inset.bottom);
 }
 
 + (id)shadowViewEnclosingView:(CPView)aView

AppKit/CPSlider.j

@@ -53,7 +53,7 @@ CPCircularSlider    = 1;
 {
     return @{
             @"knob-color": [CPNull null],
-            @"knob-size": CGSizeMakeZero(),
+            @"knob-size": _CGSizeMakeZero(),
             @"track-width": 0.0,
             @"track-color": [CPNull null],
         };
@@ -162,16 +162,16 @@ CPCircularSlider    = 1;
         var trackWidth = [self currentValueForThemeAttribute:@"track-width"];
 
         if (trackWidth <= 0)
-            return CGRectMakeZero();
+            return _CGRectMakeZero();
 
         if ([self isVertical])
         {
-            bounds.origin.x = (CGRectGetWidth(bounds) - trackWidth) / 2.0;
+            bounds.origin.x = (_CGRectGetWidth(bounds) - trackWidth) / 2.0;
             bounds.size.width = trackWidth;
         }
         else
         {
-            bounds.origin.y = (CGRectGetHeight(bounds) - trackWidth) / 2.0;
+            bounds.origin.y = (_CGRectGetHeight(bounds) - trackWidth) / 2.0;
             bounds.size.height = trackWidth;
         }
     }
@@ -184,13 +184,13 @@ CPCircularSlider    = 1;
     var knobSize = [self currentValueForThemeAttribute:@"knob-size"];
 
     if (knobSize.width <= 0 || knobSize.height <= 0)
-        return CGRectMakeZero();
+        return _CGRectMakeZero();
 
-    var knobRect = CGRectMake(0.0, 0.0, knobSize.width, knobSize.height),
+    var knobRect = _CGRectMake(0.0, 0.0, knobSize.width, knobSize.height),
         trackRect = [self trackRectForBounds:bounds];
 
     // No track, do our best to approximate a place for this thing.
-    if (!trackRect || CGRectIsEmpty(trackRect))
+    if (!trackRect || _CGRectIsEmpty(trackRect))
         trackRect = bounds;
 
     if ([self hasThemeState:CPThemeStateCircular])
@@ -203,13 +203,13 @@ CPCircularSlider    = 1;
     }
     else if ([self isVertical])
     {
-        knobRect.origin.x = CGRectGetMidX(trackRect) - knobSize.width / 2.0;
-        knobRect.origin.y = ((_maxValue - [self doubleValue]) / (_maxValue - _minValue)) * (CGRectGetHeight(trackRect) - knobSize.height);
+        knobRect.origin.x = _CGRectGetMidX(trackRect) - knobSize.width / 2.0;
+        knobRect.origin.y = ((_maxValue - [self doubleValue]) / (_maxValue - _minValue)) * (_CGRectGetHeight(trackRect) - knobSize.height);
     }
     else
     {
-        knobRect.origin.x = (([self doubleValue] - _minValue) / (_maxValue - _minValue)) * (CGRectGetWidth(trackRect) - knobSize.width);
-        knobRect.origin.y = CGRectGetMidY(trackRect) - knobSize.height / 2.0;
+        knobRect.origin.x = (([self doubleValue] - _minValue) / (_maxValue - _minValue)) * (_CGRectGetWidth(trackRect) - knobSize.width);
+        knobRect.origin.y = _CGRectGetMidY(trackRect) - knobSize.height / 2.0;
     }
 
     return knobRect;
@@ -260,8 +260,8 @@ CPCircularSlider    = 1;
 {
     // Recalculate isVertical.
     var bounds = [self bounds],
-        width = CGRectGetWidth(bounds),
-        height = CGRectGetHeight(bounds);
+        width = _CGRectGetWidth(bounds),
+        height = _CGRectGetHeight(bounds);
 
     _isVertical = width < height ? 1 : (width > height ? 0 : -1);
 
@@ -306,55 +306,55 @@ CPCircularSlider    = 1;
 
     if ([self hasThemeState:CPThemeStateCircular])
     {
-        var knobWidth = CGRectGetWidth(knobRect);
+        var knobWidth = _CGRectGetWidth(knobRect);
 
         trackRect.origin.x += knobWidth / 2;
         trackRect.size.width -= knobWidth;
 
         var minValue = [self minValue],
-            dx = aPoint.x - CGRectGetMidX(trackRect),
-            dy = aPoint.y - CGRectGetMidY(trackRect);
+            dx = aPoint.x - _CGRectGetMidX(trackRect),
+            dy = aPoint.y - _CGRectGetMidY(trackRect);
 
         return MAX(0.0, MIN(1.0, 1.0 - (3 * PI_2 - ATAN2(dy, dx)) % PI2 / PI2)) * ([self maxValue] - minValue) + minValue;
     }
     else if ([self isVertical])
     {
-        var knobHeight = CGRectGetHeight(knobRect);
+        var knobHeight = _CGRectGetHeight(knobRect);
 
         trackRect.origin.y += knobHeight / 2;
         trackRect.size.height -= knobHeight;
 
         var minValue = [self minValue];
 
-        return MAX(0.0, MIN(1.0, (CGRectGetMaxY(trackRect) - aPoint.y) / CGRectGetHeight(trackRect))) * ([self maxValue] - minValue) + minValue;
+        return MAX(0.0, MIN(1.0, (_CGRectGetMaxY(trackRect) - aPoint.y) / _CGRectGetHeight(trackRect))) * ([self maxValue] - minValue) + minValue;
     }
     else
     {
-        var knobWidth = CGRectGetWidth(knobRect);
+        var knobWidth = _CGRectGetWidth(knobRect);
 
         trackRect.origin.x += knobWidth / 2;
         trackRect.size.width -= knobWidth;
 
         var minValue = [self minValue];
 
-        return MAX(0.0, MIN(1.0, (aPoint.x - CGRectGetMinX(trackRect)) / CGRectGetWidth(trackRect))) * ([self maxValue] - minValue) + minValue;
+        return MAX(0.0, MIN(1.0, (aPoint.x - _CGRectGetMinX(trackRect)) / _CGRectGetWidth(trackRect))) * ([self maxValue] - minValue) + minValue;
     }
 }
 
 - (BOOL)startTrackingAt:(CGPoint)aPoint
 {
     var bounds = [self bounds],
-        knobRect = [self knobRectForBounds:CGRectMakeCopy(bounds)];
+        knobRect = [self knobRectForBounds:_CGRectMakeCopy(bounds)];
 
-    if (CGRectContainsPoint(knobRect, aPoint))
-        _dragOffset = CGSizeMake(CGRectGetMidX(knobRect) - aPoint.x, CGRectGetMidY(knobRect) - aPoint.y);
+    if (_CGRectContainsPoint(knobRect, aPoint))
+        _dragOffset = _CGSizeMake(_CGRectGetMidX(knobRect) - aPoint.x, _CGRectGetMidY(knobRect) - aPoint.y);
     else
     {
         var trackRect = [self trackRectForBounds:bounds];
 
-        if (trackRect && CGRectContainsPoint(trackRect, aPoint))
+        if (trackRect && _CGRectContainsPoint(trackRect, aPoint))
         {
-            _dragOffset = CGSizeMakeZero();
+            _dragOffset = _CGSizeMakeZero();
 
             [self setObjectValue:[self _valueAtPoint:aPoint]];
         }
@@ -373,7 +373,7 @@ CPCircularSlider    = 1;
 
 - (BOOL)continueTracking:(CGPoint)lastPoint at:(CGPoint)aPoint
 {
-    [self setObjectValue:[self _valueAtPoint:CGPointMake(aPoint.x + _dragOffset.width, aPoint.y + _dragOffset.height)]];
+    [self setObjectValue:[self _valueAtPoint:_CGPointMake(aPoint.x + _dragOffset.width, aPoint.y + _dragOffset.height)]];
 
     return YES;
 }

AppKit/CPSliderColorPicker.j

@@ -146,7 +146,7 @@
     [_hueLabel setTextColor:[CPColor blackColor]];
 
     _hueSlider = [[CPSlider alloc] initWithFrame:CGRectMake(15, 143, aFrame.size.width - 70, 20)];
-    [_hueSlider setMaxValue:0.999];
+    [_hueSlider setMaxValue:359.0];
     [_hueSlider setMinValue:0.0];
     [_hueSlider setTarget:self];
     [_hueSlider setAction:@selector(sliderChanged:)];
@@ -165,7 +165,7 @@
     [_saturationLabel setTextColor:[CPColor blackColor]];
 
     _saturationSlider = [[CPSlider alloc] initWithFrame:CGRectMake(15, 168, aFrame.size.width - 70, 20)];
-    [_saturationSlider setMaxValue:1.0];
+    [_saturationSlider setMaxValue:100.0];
     [_saturationSlider setMinValue:0.0];
     [_saturationSlider setTarget:self];
     [_saturationSlider setAction:@selector(sliderChanged:)];
@@ -184,7 +184,7 @@
     [_brightnessLabel setTextColor:[CPColor blackColor]];
 
     _brightnessSlider = [[CPSlider alloc] initWithFrame:CGRectMake(15, 194, aFrame.size.width - 70, 20)];
-    [_brightnessSlider setMaxValue:1.0];
+    [_brightnessSlider setMaxValue:100.0];
     [_brightnessSlider setMinValue:0.0];
     [_brightnessSlider setTarget:self];
     [_brightnessSlider setAction:@selector(sliderChanged:)];
@@ -282,9 +282,6 @@
 
 - (void)setColor:(CPColor)aColor
 {
-    if (!aColor)
-        [CPException raise:CPInvalidArgumentException reason:"aColor can't be nil"];
-
     [self updateRGBSliders:aColor];
     [self updateHSBSliders:aColor];
     [self updateHex:aColor];
@@ -316,9 +313,9 @@
 
 - (void)updateLabels
 {
-    [_hueValue setStringValue:ROUND([_hueSlider floatValue] * 360.0)];
-    [_saturationValue setStringValue:ROUND([_saturationSlider floatValue] * 100.0)];
-    [_brightnessValue setStringValue:ROUND([_brightnessSlider floatValue] * 100.0)];
+    [_hueValue setStringValue:ROUND([_hueSlider floatValue])];
+    [_saturationValue setStringValue:ROUND([_saturationSlider floatValue])];
+    [_brightnessValue setStringValue:ROUND([_brightnessSlider floatValue])];
 
     [_redValue setStringValue:ROUND([_redSlider floatValue] * 255)];
     [_greenValue setStringValue:ROUND([_greenSlider floatValue] * 255)];
@@ -366,15 +363,15 @@
                                    [self sliderChanged:_blueSlider];
                                    break;
 
-            case _hueValue:        [_hueSlider setFloatValue:MAX(MIN(ROUND(value), 360) / 360.0, 0)];
+            case _hueValue:        [_hueSlider setFloatValue:MAX(MIN(ROUND(value), 360), 0)];
                                    [self sliderChanged:_hueSlider];
                                    break;
 
-            case _saturationValue: [_saturationSlider setFloatValue:MAX(MIN(ROUND(value), 100) / 100.0, 0)];
+            case _saturationValue: [_saturationSlider setFloatValue:MAX(MIN(ROUND(value), 100), 0)];
                                    [self sliderChanged:_saturationSlider];
                                    break;
 
-            case _brightnessValue: [_brightnessSlider setFloatValue:MAX(MIN(ROUND(value), 100) / 100.0, 0)];
+            case _brightnessValue: [_brightnessSlider setFloatValue:MAX(MIN(ROUND(value), 100), 0)];
                                    [self sliderChanged:_brightnessSlider];
                                    break;
         }

AppKit/CPSplitView.j

@@ -334,8 +334,8 @@ var ShouldSuppressResizeNotifications   = 1,
     }
 
     [self _setupDOMDivider];
-    CPDOMDisplayServerSetStyleLeftTop(_DOMDividerElements[_drawingDivider], NULL, CGRectGetMinX(aRect), CGRectGetMinY(aRect));
-    CPDOMDisplayServerSetStyleSize(_DOMDividerElements[_drawingDivider], CGRectGetWidth(aRect), CGRectGetHeight(aRect));
+    CPDOMDisplayServerSetStyleLeftTop(_DOMDividerElements[_drawingDivider], NULL, _CGRectGetMinX(aRect), _CGRectGetMinY(aRect));
+    CPDOMDisplayServerSetStyleSize(_DOMDividerElements[_drawingDivider], _CGRectGetWidth(aRect), _CGRectGetHeight(aRect));
 #endif
 }
 
@@ -1110,7 +1110,7 @@ The sum of the views and the sum of the dividers should be equal to the size of
 */
 - (void)_restoreFromAutosaveIfNeeded
 {
-    if (_shouldRestoreFromAutosaveUnlessFrameSize && !CGSizeEqualToSize([self frameSize], _shouldRestoreFromAutosaveUnlessFrameSize))
+    if (_shouldRestoreFromAutosaveUnlessFrameSize && !_CGSizeEqualToSize([self frameSize], _shouldRestoreFromAutosaveUnlessFrameSize))
     {
         [self _restoreFromAutosave];
     }

AppKit/CPStepper.j

@@ -55,7 +55,7 @@
 */
 + (CPStepper)stepperWithInitialValue:(float)aValue minValue:(float)aMinValue maxValue:(float)aMaxValue
 {
-    var stepper = [[CPStepper alloc] initWithFrame:CGRectMakeZero()];
+    var stepper = [[CPStepper alloc] initWithFrame:_CGRectMakeZero()];
 
     [stepper setDoubleValue:aValue];
     [stepper setMinValue:aMinValue];
@@ -122,14 +122,14 @@
 
 - (void)_init
 {
-    _buttonUp = [[CPButton alloc] initWithFrame:CGRectMakeZero()];
+    _buttonUp = [[CPButton alloc] initWithFrame:_CGRectMakeZero()];
     [_buttonUp setContinuous:_autorepeat];
     [_buttonUp setTarget:self];
     [_buttonUp setAction:@selector(_buttonDidClick:)];
     [_buttonUp setAutoresizingMask:CPViewNotSizable];
     [self addSubview:_buttonUp];
 
-    _buttonDown = [[CPButton alloc] initWithFrame:CGRectMakeZero()];
+    _buttonDown = [[CPButton alloc] initWithFrame:_CGRectMakeZero()];
     [_buttonDown setContinuous:_autorepeat];
     [_buttonDown setTarget:self];
     [_buttonDown setAction:@selector(_buttonDidClick:)];
@@ -161,8 +161,8 @@
 {
     var upSize = [self valueForThemeAttribute:@"up-button-size"],
         downSize = [self valueForThemeAttribute:@"down-button-size"],
-        minSize = CGSizeMake(upSize.width, upSize.height + downSize.height),
-        frame = CGRectMakeCopy(aFrame);
+        minSize = _CGSizeMake(upSize.width, upSize.height + downSize.height),
+        frame = _CGRectMakeCopy(aFrame);
 
     frame.size.width = MAX(minSize.width, frame.size.width);
     frame.size.height = MAX(minSize.height, frame.size.height);
@@ -175,8 +175,8 @@
     var aFrame = [self frame],
         upSize = [self valueForThemeAttribute:@"up-button-size"],
         downSize = [self valueForThemeAttribute:@"down-button-size"],
-        upFrame = CGRectMake(aFrame.size.width - upSize.width, 0, upSize.width, upSize.height),
-        downFrame = CGRectMake(aFrame.size.width - downSize.width, upSize.height, downSize.width, downSize.height);
+        upFrame = _CGRectMake(aFrame.size.width - upSize.width, 0, upSize.width, upSize.height),
+        downFrame = _CGRectMake(aFrame.size.width - downSize.width, upSize.height, downSize.width, downSize.height);
 
     [_buttonUp setFrame:upFrame];
     [_buttonDown setFrame:downFrame];
@@ -272,8 +272,8 @@
     return @{
             @"bezel-color-up-button": [CPNull null],
             @"bezel-color-down-button": [CPNull null],
-            @"up-button-size": CGSizeMakeZero(),
-            @"down-button-size": CGSizeMakeZero(),
+            @"up-button-size": _CGSizeMakeZero(),
+            @"down-button-size": _CGSizeMakeZero(),
         };
 }
 

AppKit/CPTabView.j

@@ -79,11 +79,11 @@ var CPTabViewDidSelectTabViewItemSelector           = 1,
 {
     _selectedIndex = CPNotFound;
 
-    _tabs = [[CPSegmentedControl alloc] initWithFrame:CGRectMake(0, 0, 0, 0)];
+    _tabs = [[CPSegmentedControl alloc] initWithFrame:_CGRectMake(0, 0, 0, 0)];
     [_tabs setHitTests:NO];
 
     var height = [_tabs valueForThemeAttribute:@"default-height"];
-    [_tabs setFrameSize:CGSizeMake(0, height)];
+    [_tabs setFrameSize:_CGSizeMake(0, height)];
 
     _box = [[CPBox alloc] initWithFrame:[self  bounds]];
     [self setBackgroundColor:[CPColor colorWithCalibratedWhite:0.95 alpha:1.0]];
@@ -373,11 +373,11 @@ var CPTabViewDidSelectTabViewItemSelector           = 1,
     else
     {
         var aFrame = [self frame],
-            segmentedHeight = CGRectGetHeight([_tabs frame]),
+            segmentedHeight = _CGRectGetHeight([_tabs frame]),
             origin = _type === CPTopTabsBezelBorder ? segmentedHeight / 2 : 0;
 
-        [_box setFrame:CGRectMake(0, origin, CGRectGetWidth(aFrame),
-                                   CGRectGetHeight(aFrame) - segmentedHeight / 2)];
+        [_box setFrame:_CGRectMake(0, origin, _CGRectGetWidth(aFrame),
+                                   _CGRectGetHeight(aFrame) - segmentedHeight / 2)];
 
         [self _repositionTabs];
     }
@@ -447,13 +447,13 @@ var CPTabViewDidSelectTabViewItemSelector           = 1,
 
 - (void)_repositionTabs
 {
-    var horizontalCenterOfSelf = CGRectGetWidth([self bounds]) / 2,
-        verticalCenterOfTabs = CGRectGetHeight([_tabs bounds]) / 2;
+    var horizontalCenterOfSelf = _CGRectGetWidth([self bounds]) / 2,
+        verticalCenterOfTabs = _CGRectGetHeight([_tabs bounds]) / 2;
 
     if (_type === CPBottomTabsBezelBorder)
-        [_tabs setCenter:CGPointMake(horizontalCenterOfSelf, CGRectGetHeight([self bounds]) - verticalCenterOfTabs)];
+        [_tabs setCenter:_CGPointMake(horizontalCenterOfSelf, _CGRectGetHeight([self bounds]) - verticalCenterOfTabs)];
     else
-        [_tabs setCenter:CGPointMake(horizontalCenterOfSelf, verticalCenterOfTabs)];
+        [_tabs setCenter:_CGPointMake(horizontalCenterOfSelf, verticalCenterOfTabs)];
 }
 
 - (void)_setSelectedIndex:(CPNumber)index
@@ -504,6 +504,8 @@ var CPTabViewItemsKey               = "CPTabViewItemsKey",
         _items = [aCoder decodeObjectForKey:CPTabViewItemsKey];
         [_items makeObjectsPerformSelector:@selector(_setTabView:) withObject:self];
 
+        [self _updateItems];
+
         [self setDelegate:[aCoder decodeObjectForKey:CPTabViewDelegateKey]];
 
         self.selectOnAwake = [aCoder decodeObjectForKey:CPTabViewSelectedItemKey];
@@ -515,10 +517,6 @@ var CPTabViewItemsKey               = "CPTabViewItemsKey",
 
 - (void)awakeFromCib
 {
-    // This cannot be run in initWithCoder because it might call selectTabViewItem:, which is
-    // not safe to call before the views of the tab views items are fully decoded.
-    [self _updateItems];
-
     if (self.selectOnAwake)
     {
         [self selectTabViewItem:self.selectOnAwake];
@@ -534,13 +532,7 @@ var CPTabViewItemsKey               = "CPTabViewItemsKey",
 
 - (void)encodeWithCoder:(CPCoder)aCoder
 {
-    // Don't bother to encode the CPBox. We will recreate it on decode and its content view is already
-    // stored by the tab view item. Not encoding _box makes the resulting archive smaller and reduces
-    // the surface for decoding bugs (of which we've had many in tab view).
-    var subviews = [self subviews];
-    [_box removeFromSuperview];
     [super encodeWithCoder:aCoder];
-    [self setSubviews:subviews];
 
     [aCoder encodeObject:_items forKey:CPTabViewItemsKey];
 

AppKit/CPTableColumn.j

@@ -283,7 +283,7 @@ CPTableColumnUserResizingMask   = 1 << 1;
 */
 - (void)sizeToFit
 {
-    var width = CGRectGetWidth([_headerView frame]);
+    var width = _CGRectGetWidth([_headerView frame]);
 
     if (width < [self minWidth])
         [self setMinWidth:width];

AppKit/CPTableHeaderView.j

@@ -69,7 +69,7 @@
 
 - (void)_init
 {
-    _textField = [[_CPImageAndTextView alloc] initWithFrame:CGRectMakeZero()];
+    _textField = [[_CPImageAndTextView alloc] initWithFrame:_CGRectMakeZero()];
 
     [_textField setAutoresizingMask:CPViewWidthSizable | CPViewHeightSizable];
 
@@ -87,7 +87,7 @@
     var inset = [self currentValueForThemeAttribute:@"text-inset"],
         bounds = [self bounds];
 
-    [_textField setFrame:CGRectMake(inset.right, inset.top, bounds.size.width - inset.right - inset.left, bounds.size.height - inset.top - inset.bottom)];
+    [_textField setFrame:_CGRectMake(inset.right, inset.top, bounds.size.width - inset.right - inset.left, bounds.size.height - inset.top - inset.bottom)];
     [_textField setTextColor:[self currentValueForThemeAttribute:@"text-color"]];
     [_textField setFont:[self currentValueForThemeAttribute:@"font"]];
     [_textField setTextShadowColor:[self currentValueForThemeAttribute:@"text-shadow-color"]];
@@ -229,7 +229,6 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
     CGPoint                 _previousTrackingLocation;
     int                     _activeColumn;
     int                     _pressedColumn;
-    int                     _lastDragDestinationColumnIndex;
 
     BOOL                    _isResizing;
     BOOL                    _isDragging;
@@ -256,8 +255,8 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
 
 - (void)_init
 {
-    _mouseDownLocation = CGPointMakeZero();
-    _previousTrackingLocation = CGPointMakeZero();
+    _mouseDownLocation = _CGPointMakeZero();
+    _previousTrackingLocation = _CGPointMakeZero();
     _activeColumn = -1;
     _pressedColumn = -1;
 
@@ -291,8 +290,8 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
     var headerRect = CGRectMakeCopy([self bounds]),
         columnRect = [_tableView rectOfColumn:aColumnIndex];
 
-    headerRect.origin.x = CGRectGetMinX(columnRect);
-    headerRect.size.width = CGRectGetWidth(columnRect);
+    headerRect.origin.x = _CGRectGetMinX(columnRect);
+    headerRect.size.width = _CGRectGetWidth(columnRect);
 
     return headerRect;
 }
@@ -310,11 +309,11 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
 - (CGRect)_cursorRectForColumn:(int)column
 {
     if (column == -1 || !([_tableView._tableColumns[column] resizingMask] & CPTableColumnUserResizingMask))
-        return CGRectMakeZero();
+        return _CGRectMakeZero();
 
     var rect = [self headerRectOfColumn:column];
 
-    rect.origin.x = CGRectGetMaxX(rect) - 5;
+    rect.origin.x = _CGRectGetMaxX(rect) - 5;
     rect.size.width = 20;
 
     return rect;
@@ -354,7 +353,7 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
     currentLocation.x -= 5.0;
 
     var columnIndex = [self columnAtPoint:currentLocation],
-        shouldResize = [self shouldResizeTableColumn:columnIndex at:CGPointMake(currentLocation.x + 5.0, currentLocation.y)];
+        shouldResize = [self shouldResizeTableColumn:columnIndex at:_CGPointMake(currentLocation.x + 5.0, currentLocation.y)];
 
     if (type === CPLeftMouseUp)
     {
@@ -398,7 +397,7 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
             [self continueResizingTableColumn:_activeColumn at:currentLocation];
         else
         {
-            if (_activeColumn === columnIndex && CGRectContainsPoint([self headerRectOfColumn:columnIndex], currentLocation))
+            if (_activeColumn === columnIndex && _CGRectContainsPoint([self headerRectOfColumn:columnIndex], currentLocation))
             {
                 if (_isTrackingColumn && _pressedColumn !== -1)
                 {
@@ -418,7 +417,6 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
 
 - (void)startTrackingTableColumn:(int)aColumnIndex at:(CGPoint)aPoint
 {
-    _lastDragDestinationColumnIndex = -1;
     [self _setPressedColumn:aColumnIndex];
 }
 
@@ -427,14 +425,14 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
     if ([self _shouldDragTableColumn:aColumnIndex at:aPoint])
     {
         var columnRect = [self headerRectOfColumn:aColumnIndex],
-            offset = CGPointMakeZero(),
+            offset = _CGPointMakeZero(),
             view = [_tableView _dragViewForColumn:aColumnIndex event:[CPApp currentEvent] offset:offset],
-            viewLocation = CGPointMakeZero();
+            viewLocation = _CGPointMakeZero();
 
-        viewLocation.x = ( CGRectGetMinX(columnRect) + offset.x ) + ( aPoint.x - _mouseDownLocation.x );
-        viewLocation.y = CGRectGetMinY(columnRect) + offset.y;
+        viewLocation.x = ( _CGRectGetMinX(columnRect) + offset.x ) + ( aPoint.x - _mouseDownLocation.x );
+        viewLocation.y = _CGRectGetMinY(columnRect) + offset.y;
 
-        [self dragView:view at:viewLocation offset:CGSizeMakeZero() event:[CPApp currentEvent]
+        [self dragView:view at:viewLocation offset:_CGSizeMakeZero() event:[CPApp currentEvent]
             pasteboard:[CPPasteboard pasteboardWithName:CPDragPboard] source:self slideBack:YES];
 
         return NO;
@@ -446,7 +444,7 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
 - (BOOL)_shouldStopTrackingTableColumn:(int)aColumnIndex at:(CGPoint)aPoint
 {
     return _isTrackingColumn && _activeColumn === aColumnIndex &&
-        CGRectContainsPoint([self headerRectOfColumn:aColumnIndex], aPoint);
+        _CGRectContainsPoint([self headerRectOfColumn:aColumnIndex], aPoint);
 }
 
 - (void)stopTrackingTableColumn:(int)aColumnIndex at:(CGPoint)aPoint
@@ -457,7 +455,7 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
 
 - (BOOL)_shouldDragTableColumn:(int)aColumnIndex at:(CGPoint)aPoint
 {
-    return ABS(aPoint.x - _mouseDownLocation.x) >= 10.0 && [_tableView _shouldReorderColumn:aColumnIndex toColumn:-1];
+    return [_tableView allowsColumnReordering] && ABS(aPoint.x - _mouseDownLocation.x) >= 10.0;
 }
 
 - (CGRect)_headerRectOfLastVisibleColumn
@@ -490,10 +488,10 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
     frame.origin = [self convertPoint:frame.origin fromView:nil];
 
     // This effectively clamps the value between the minimum and maximum
-    frame.origin.x = MAX(0.0, MIN(CGRectGetMinX(frame), CGRectGetMaxX(lastColumnRect) - CGRectGetWidth(activeColumnRect)));
+    frame.origin.x = MAX(0.0, MIN(_CGRectGetMinX(frame), _CGRectGetMaxX(lastColumnRect) - _CGRectGetWidth(activeColumnRect)));
 
     // Make sure the column cannot move vertically
-    frame.origin.y = CGRectGetMinY(lastColumnRect);
+    frame.origin.y = _CGRectGetMinY(lastColumnRect);
 
     // Convert the calculated origin back to the window coordinate system
     frame.origin = [self convertPoint:frame.origin toView:nil];
@@ -505,12 +503,9 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
 
 - (void)_moveColumn:(int)aFromIndex toColumn:(int)aToIndex
 {
-    if ([_tableView _shouldReorderColumn:aFromIndex toColumn:aToIndex])
-    {
-        [_tableView moveColumn:aFromIndex toColumn:aToIndex];
-        _activeColumn = aToIndex;
-        _pressedColumn = _activeColumn;
-    }
+    [_tableView moveColumn:aFromIndex toColumn:aToIndex];
+    _activeColumn = aToIndex;
+    _pressedColumn = _activeColumn;
 }
 
 - (void)draggedView:(CPView)aView beganAt:(CGPoint)aPoint
@@ -535,9 +530,9 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
     var hoverPoint = CGPointCreateCopy(aPoint);
 
     if (aPoint.x < _previousTrackingLocation.x)
-        hoverPoint = CGPointMake(CGRectGetMinX(dragWindowFrame), CGRectGetMinY(dragWindowFrame));
+        hoverPoint = _CGPointMake(_CGRectGetMinX(dragWindowFrame), _CGRectGetMinY(dragWindowFrame));
     else if (aPoint.x > _previousTrackingLocation.x)
-        hoverPoint = CGPointMake(CGRectGetMaxX(dragWindowFrame), CGRectGetMinY(dragWindowFrame));
+        hoverPoint = _CGPointMake(_CGRectGetMaxX(dragWindowFrame), _CGRectGetMinY(dragWindowFrame));
 
     // Convert the hover point from the global coordinate system to windows' coordinate system
     hoverPoint = [[self window] convertGlobalToBase:hoverPoint];
@@ -546,21 +541,14 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
 
     var hoveredColumn = [self columnAtPoint:hoverPoint];
 
-    if (hoveredColumn !== _lastDragDestinationColumnIndex && hoveredColumn !== -1)
+    if (hoveredColumn !== -1)
     {
         var columnRect = [self headerRectOfColumn:hoveredColumn],
-            columnCenterPoint = [self convertPoint:CGPointMake(CGRectGetMidX(columnRect), CGRectGetMidY(columnRect)) fromView:self];
-
+            columnCenterPoint = [self convertPoint:CGPointMake(_CGRectGetMidX(columnRect), _CGRectGetMidY(columnRect)) fromView:self];
         if (hoveredColumn < _activeColumn && hoverPoint.x < columnCenterPoint.x)
-        {
             [self _moveColumn:_activeColumn toColumn:hoveredColumn];
-            _lastDragDestinationColumnIndex = hoveredColumn;
-        }
         else if (hoveredColumn > _activeColumn && hoverPoint.x > columnCenterPoint.x)
-        {
             [self _moveColumn:_activeColumn toColumn:hoveredColumn];
-            _lastDragDestinationColumnIndex = hoveredColumn;
-        }
     }
 
     _previousTrackingLocation = aPoint;
@@ -588,7 +576,7 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
     if (_isTrackingColumn)
         return NO;
 
-    return [_tableView allowsColumnResizing] && CGRectContainsPoint([self _cursorRectForColumn:aColumnIndex], aPoint);
+    return [_tableView allowsColumnResizing] && _CGRectContainsPoint([self _cursorRectForColumn:aColumnIndex], aPoint);
 }
 
 - (void)startResizingTableColumn:(int)aColumnIndex at:(CGPoint)aPoint
@@ -644,7 +632,7 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
         mouseOverLocation = CGPointMake(mouseLocation.x - 5, mouseLocation.y),
         overColumn = [self columnAtPoint:mouseOverLocation];
 
-    if (overColumn >= 0 && CGRectContainsPoint([self _cursorRectForColumn:overColumn], mouseLocation))
+    if (overColumn >= 0 && _CGRectContainsPoint([self _cursorRectForColumn:overColumn], mouseLocation))
     {
         var tableColumn = [[_tableView tableColumns] objectAtIndex:overColumn],
             width = [tableColumn width];
@@ -733,10 +721,10 @@ var _CPTableColumnHeaderViewStringValueKey = @"_CPTableColumnHeaderViewStringVal
         var columnIndex = columnsArray[columnArrayIndex],
             columnToStroke = [self headerRectOfColumn:columnIndex];
 
-        columnMaxX = CGRectGetMaxX(columnToStroke);
+        columnMaxX = _CGRectGetMaxX(columnToStroke);
 
-        CGContextMoveToPoint(context, FLOOR(columnMaxX) - 0.5, ROUND(CGRectGetMinY(columnToStroke)));
-        CGContextAddLineToPoint(context, FLOOR(columnMaxX) - 0.5, ROUND(CGRectGetMaxY(columnToStroke)) - 1.0);
+        CGContextMoveToPoint(context, FLOOR(columnMaxX) - 0.5, ROUND(_CGRectGetMinY(columnToStroke)));
+        CGContextAddLineToPoint(context, FLOOR(columnMaxX) - 0.5, ROUND(_CGRectGetMaxY(columnToStroke)) - 1.0);
     }
 
     CGContextClosePath(context);

AppKit/CPTextField.j

@@ -59,22 +59,15 @@ function CPTextFieldBlurFunction(anEvent, owner, domElement, inputElement, resig
     if (owner && domElement != inputElement.parentNode)
         return;
 
-    var ownerWindow = [owner window];
-
-    if (!resigning && [ownerWindow isKeyWindow])
+    if (!resigning && [[owner window] isKeyWindow])
     {
         /*
-            Browsers blur text fields when a click occurs anywhere outside the text field. That is normal for browsers, but in Cocoa the key view retains focus unless the click target accepts first responder. So if we lost focus but were not told to resign and our window is still key, restore focus,
-            but only if the text field is completely within the browser window. If we restore focus when it
-            is off screen, the entire body scrolls out of our control.
+            Browsers blur text fields when a click occurs anywhere outside the text field. That is normal for browsers, but in Cocoa the key view retains focus unless the click target accepts first responder. So if we lost focus but were not told to resign and our window is still key, restore focus.
         */
-        if ([owner _isWithinUsablePlatformRect])
+        window.setTimeout(function()
         {
-            window.setTimeout(function()
-            {
-                inputElement.focus();
-            }, 0.0);
-        }
+            inputElement.focus();
+        }, 0.0);
     }
 
     CPTextFieldHandleBlur(anEvent, @ref(owner));
@@ -212,8 +205,8 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
 + (id)themeAttributes
 {
     return @{
-            @"bezel-inset": CGInsetMakeZero(),
-            @"content-inset": CGInsetMake(1.0, 0.0, 0.0, 0.0),
+            @"bezel-inset": _CGInsetMakeZero(),
+            @"content-inset": _CGInsetMake(1.0, 0.0, 0.0, 0.0),
             @"bezel-color": [CPNull null],
         };
 }
@@ -238,7 +231,7 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
             return CPTextFieldBlurFunction(
                         anEvent,
                         CPTextFieldInputOwner,
-                        CPTextFieldInputOwner ? CPTextFieldInputOwner._DOMElement : nil,
+                        CPTextFieldInputOwner._DOMElement,
                         CPTextFieldDOMInputElement,
                         CPTextFieldInputResigning,
                         @ref(CPTextFieldInputDidBlur));
@@ -252,7 +245,7 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
                     return;
 
                 var cappEvent = [CPEvent keyEventWithType:CPKeyUp
-                                                 location:CGPointMakeZero()
+                                                 location:_CGPointMakeZero()
                                             modifierFlags:0
                                                 timestamp:[CPEvent currentTimestamp]
                                              windowNumber:[[CPApp keyWindow] windowNumber]
@@ -532,7 +525,7 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
 /* @ignore */
 - (BOOL)acceptsFirstResponder
 {
-    return [self isEditable] && [self isEnabled] && [self _isWithinUsablePlatformRect];
+    return [self isEditable] && [self isEnabled];
 }
 
 /* @ignore */
@@ -544,7 +537,7 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
     _isEditing = NO;
 
     if ([[self window] isKeyWindow])
-        return [self _becomeFirstKeyResponder];
+        [self _becomeFirstKeyResponder];
 
     return YES;
 }
@@ -554,12 +547,10 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
 
     Since a first responder but non-key window text field can't receive input it should not even look like an active text field (Cocoa has a "slightly active" text field look it uses when another window is the key window, but Cappuccino doesn't today.)
 */
-- (BOOL)_becomeFirstKeyResponder
+- (void)_becomeFirstKeyResponder
 {
-    // If the text field is still not completely on screen, refuse to become
-    // first responder, because the browser will scroll it into view out of our control.
-    if (![self _isWithinUsablePlatformRect])
-        return NO;
+    // Make sure the text field is visible so the browser will not scroll without the NSScrollView knowing about it.
+    [self scrollRectToVisible:[self bounds]];
 
     [self setThemeState:CPThemeStateEditing];
 
@@ -585,16 +576,11 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
 
     switch ([self alignment])
     {
-        case CPCenterTextAlignment:
-            element.style.textAlign = "center";
-            break;
-
-        case CPRightTextAlignment:
-            element.style.textAlign = "right";
-            break;
-
-        default:
-            element.style.textAlign = "left";
+        case CPCenterTextAlignment: element.style.textAlign = "center";
+                                    break;
+        case CPRightTextAlignment:  element.style.textAlign = "right";
+                                    break;
+        default:                    element.style.textAlign = "left";
     }
 
     var contentRect = [self contentRectForBounds:[self bounds]],
@@ -603,32 +589,31 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
     switch (verticalAlign)
     {
         case CPTopVerticalTextAlignment:
-            var topPoint = CGRectGetMinY(contentRect) + "px";
+            var topPoint = _CGRectGetMinY(contentRect) + "px";
             break;
 
         case CPCenterVerticalTextAlignment:
-            var topPoint = (CGRectGetMidY(contentRect) - (lineHeight / 2)) + "px";
+            var topPoint = (_CGRectGetMidY(contentRect) - (lineHeight / 2)) + "px";
             break;
 
         case CPBottomVerticalTextAlignment:
-            var topPoint = (CGRectGetMaxY(contentRect) - lineHeight) + "px";
+            var topPoint = (_CGRectGetMaxY(contentRect) - lineHeight) + "px";
             break;
 
         default:
-            var topPoint = CGRectGetMinY(contentRect) + "px";
+            var topPoint = _CGRectGetMinY(contentRect) + "px";
             break;
     }
 
     element.style.top = topPoint;
-
-    var left = CGRectGetMinX(contentRect);
+    var left = _CGRectGetMinX(contentRect);
 
     // If the browser has a built in left padding, compensate for it. We need the input text to be exactly on top of the original text.
     if (CPFeatureIsCompatible(CPInput1PxLeftPadding))
         left -= 1;
 
     element.style.left = left + "px";
-    element.style.width = CGRectGetWidth(contentRect) + "px";
+    element.style.width = _CGRectGetWidth(contentRect) + "px";
     element.style.height = ROUND(lineHeight) + "px";
     element.style.lineHeight = ROUND(lineHeight) + "px";
     element.style.verticalAlign = "top";
@@ -673,8 +658,6 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
     }, 0.0);
 
 #endif
-
-    return YES;
 }
 
 /* @ignore */
@@ -784,8 +767,7 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
 - (void)_windowDidBecomeKey:(CPNotification)aNotification
 {
     if ([[self window] isKeyWindow] && [[self window] firstResponder] === self)
-        if (![self _becomeFirstKeyResponder])
-            [[self window] makeFirstResponder:nil];
+        [self _becomeFirstKeyResponder];
 }
 
 - (BOOL)_valueIsValid:(CPString)aValue
@@ -1187,7 +1169,7 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
         maxSize = [self currentValueForThemeAttribute:@"max-size"],
         lineBreakMode = [self lineBreakMode],
         text = (_stringValue || @" "),
-        textSize = CGSizeMakeCopy(frameSize),
+        textSize = _CGSizeMakeCopy(frameSize),
         font = [self currentValueForThemeAttribute:@"font"];
 
     textSize.width -= contentInset.left + contentInset.right;
@@ -1481,14 +1463,14 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
 {
     var contentInset = [self currentValueForThemeAttribute:@"content-inset"];
 
-    return CGRectInsetByInset(bounds, contentInset);
+    return _CGRectInsetByInset(bounds, contentInset);
 }
 
 - (CGRect)bezelRectForBounds:(CGRect)bounds
 {
     var bezelInset = [self currentValueForThemeAttribute:@"bezel-inset"];
 
-    return CGRectInsetByInset(bounds, bezelInset);
+    return _CGRectInsetByInset(bounds, bezelInset);
 }
 
 - (CGRect)rectForEphemeralSubviewNamed:(CPString)aName
@@ -1506,7 +1488,7 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
 {
     if (aName === "bezel-view")
     {
-        var view = [[CPView alloc] initWithFrame:CGRectMakeZero()];
+        var view = [[CPView alloc] initWithFrame:_CGRectMakeZero()];
 
         [view setHitTests:NO];
 
@@ -1514,7 +1496,7 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
     }
     else
     {
-        var view = [[_CPImageAndTextView alloc] initWithFrame:CGRectMakeZero()];
+        var view = [[_CPImageAndTextView alloc] initWithFrame:_CGRectMakeZero()];
 
         [view setHitTests:NO];
 
@@ -1581,25 +1563,6 @@ CPTextFieldStatePlaceholder = CPThemeState("placeholder");
         }
 }
 
-#pragma mark Private
-
-- (BOOL)_isWithinUsablePlatformRect
-{
-    // Make sure the text field is completely within the platform window
-    // so the browser will not scroll it into view.
-
-    var wind = [self window],
-        frame = [self convertRectToBase:[self bounds]],
-        usableRect = [[wind platformWindow] usableContentFrame];
-
-    frame.origin = [wind convertBaseToGlobal:frame.origin];
-
-    return (CGRectGetMinX(frame) >= CGRectGetMinX(usableRect) &&
-            CGRectGetMaxX(frame) <= CGRectGetMaxX(usableRect) &&
-            CGRectGetMinY(frame) >= CGRectGetMinY(usableRect) &&
-            CGRectGetMaxY(frame) <= CGRectGetMaxY(usableRect));
-}
-
 @end
 
 var secureStringForString = function(aString)

AppKit/CPTheme.j

@@ -404,25 +404,25 @@ function CPThemeStateName(aState)
     return name;
 }
 
-CPThemeStateNames[0]         = "normal";
-CPThemeStateNormal           = CPThemeStates["normal"] = 0;
-CPThemeStateDisabled         = CPThemeState("disabled");
-CPThemeStateHovered          = CPThemeState("hovered");
-CPThemeStateHighlighted      = CPThemeState("highlighted");
-CPThemeStateSelected         = CPThemeState("selected");
-CPThemeStateTableDataView    = CPThemeState("tableDataView");
-CPThemeStateSelectedDataView = CPThemeState("selectedTableDataView");
-CPThemeStateGroupRow         = CPThemeState("CPThemeStateGroupRow");
-CPThemeStateBezeled          = CPThemeState("bezeled");
-CPThemeStateBordered         = CPThemeState("bordered");
-CPThemeStateEditable         = CPThemeState("editable");
-CPThemeStateEditing          = CPThemeState("editing");
-CPThemeStateVertical         = CPThemeState("vertical");
-CPThemeStateDefault          = CPThemeState("default");
-CPThemeStateCircular         = CPThemeState("circular");
-CPThemeStateAutocompleting   = CPThemeState("autocompleting");
-CPThemeStateMainWindow       = CPThemeState("mainWindow");
-CPThemeStateKeyWindow        = CPThemeState("keyWindow");
+CPThemeStateNames[0]        = "normal";
+CPThemeStateNormal          = CPThemeStates["normal"] = 0;
+CPThemeStateDisabled        = CPThemeState("disabled");
+CPThemeStateHovered         = CPThemeState("hovered");
+CPThemeStateHighlighted     = CPThemeState("highlighted");
+CPThemeStateSelected        = CPThemeState("selected");
+CPThemeStateTableDataView   = CPThemeState("tableDataView");
+CPThemeStateSelectedDataView = CPThemeStateSelectedTableDataView = CPThemeState("selectedTableDataView");
+CPThemeStateGroupRow        = CPThemeState("CPThemeStateGroupRow");
+CPThemeStateBezeled         = CPThemeState("bezeled");
+CPThemeStateBordered        = CPThemeState("bordered");
+CPThemeStateEditable        = CPThemeState("editable");
+CPThemeStateEditing         = CPThemeState("editing");
+CPThemeStateVertical        = CPThemeState("vertical");
+CPThemeStateDefault         = CPThemeState("default");
+CPThemeStateCircular        = CPThemeState("circular");
+CPThemeStateAutocompleting  = CPThemeState("autocompleting");
+CPThemeStateMainWindow      = CPThemeState("mainWindow");
+CPThemeStateKeyWindow       = CPThemeState("keyWindow");
 
 @implementation _CPThemeAttribute : CPObject
 {
@@ -431,7 +431,7 @@ CPThemeStateKeyWindow        = CPThemeState("keyWindow");
     CPDictionary        _values @accessors(readonly, getter=values);
 
     JSObject            _cache;
-    _CPThemeAttribute   _themeDefaultAttribute;
+    _CPThemeAttribute   _parentAttribute;
 }
 
 - (id)initWithName:(CPString)aName defaultValue:(id)aDefaultValue
@@ -542,18 +542,11 @@ CPThemeStateKeyWindow        = CPThemeState("keyWindow");
     }
 
     if (value === undefined || value === nil)
-        value = [_themeDefaultAttribute valueForState:aState];
+        value = [_parentAttribute valueForState:aState];
 
     if (value === undefined || value === nil)
-    {
         value = _defaultValue;
 
-        // Class theme attributes cannot use nil because it's a dictionary.
-        // So transform CPNull into nil.
-        if (value === [CPNull null])
-            value = nil;
-    }
-
     _cache[aState] = value;
 
     return value;
@@ -561,11 +554,11 @@ CPThemeStateKeyWindow        = CPThemeState("keyWindow");
 
 - (void)setParentAttribute:(_CPThemeAttribute)anAttribute
 {
-    if (_themeDefaultAttribute === anAttribute)
+    if (_parentAttribute === anAttribute)
         return;
 
     _cache = { };
-    _themeDefaultAttribute = anAttribute;
+    _parentAttribute = anAttribute;
 }
 
 - (_CPThemeAttribute)attributeMergedWithAttribute:(_CPThemeAttribute)anAttribute

AppKit/CPTokenField.j

@@ -20,6 +20,8 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#import "../Foundation/CPRange.h"
+
 @import <Foundation/CPCharacterSet.j>
 @import <Foundation/CPIndexSet.j>
 @import <Foundation/CPTimer.j>
@@ -98,7 +100,7 @@ CPTokenFieldDeleteButtonType     = 1;
 
 + (id)themeAttributes
 {
-    return @{ @"editor-inset": CGInsetMakeZero() };
+    return @{ @"editor-inset": _CGInsetMakeZero() };
 }
 
 - (id)initWithFrame:(CGRect)frame
@@ -122,7 +124,7 @@ CPTokenFieldDeleteButtonType     = 1;
 
 - (void)_init
 {
-    _selectedRange = CPMakeRange(0, 0);
+    _selectedRange = _CPMakeRange(0, 0);
 
     var frame = [self frame];
 
@@ -212,7 +214,7 @@ CPTokenFieldDeleteButtonType     = 1;
 
     if (delegateApprovedObjectsCount)
         location += delegateApprovedObjectsCount;
-    _selectedRange = CPMakeRange(location, 0);
+    _selectedRange = _CPMakeRange(location, 0);
 
     [self _inputElement].value = @"";
     [self setNeedsLayout];
@@ -232,12 +234,12 @@ CPTokenFieldDeleteButtonType     = 1;
     if (indexOfToken == CPNotFound)
     {
         if (!extend)
-            _selectedRange = CPMakeRange([[self _tokens] count], 0);
+            _selectedRange = _CPMakeRange([[self _tokens] count], 0);
     }
     else if (extend)
-        _selectedRange = CPUnionRange(_selectedRange, CPMakeRange(indexOfToken, 1));
+        _selectedRange = CPUnionRange(_selectedRange, _CPMakeRange(indexOfToken, 1));
     else
-        _selectedRange = CPMakeRange(indexOfToken, 1);
+        _selectedRange = _CPMakeRange(indexOfToken, 1);
 
     [self setNeedsLayout];
 }
@@ -247,7 +249,7 @@ CPTokenFieldDeleteButtonType     = 1;
     var indexOfToken = [[self _tokens] indexOfObject:token];
 
     if (CPLocationInRange(indexOfToken, _selectedRange))
-        _selectedRange = CPMakeRange(MAX(indexOfToken, _selectedRange.location), MIN(_selectedRange.length, indexOfToken - _selectedRange.location));
+        _selectedRange = _CPMakeRange(MAX(indexOfToken, _selectedRange.location), MIN(_selectedRange.length, indexOfToken - _selectedRange.location));
 
     [self setNeedsLayout];
 }
@@ -300,7 +302,7 @@ CPTokenFieldDeleteButtonType     = 1;
     [self setObjectValue:tokens];
     // setObjectValue moves the cursor to the end of the selection. We want it to stay
     // where the selected tokens were.
-    _selectedRange = CPMakeRange(collapsedSelection, 0);
+    _selectedRange = _CPMakeRange(collapsedSelection, 0);
 
     [self _controlTextDidChange];
 }
@@ -330,18 +332,13 @@ CPTokenFieldDeleteButtonType     = 1;
     [self scrollRectToVisible:[self bounds]];
 
     if ([[self window] isKeyWindow])
-        return [self _becomeFirstKeyResponder];
+        [self _becomeFirstKeyResponder];
 
     return YES;
 }
 
-- (BOOL)_becomeFirstKeyResponder
+- (void)_becomeFirstKeyResponder
 {
-    // If the token field is still not completely on screen, refuse to become
-    // first responder, because the browser will scroll it into view out of our control.
-    if (![self _isWithinUsablePlatformRect])
-        return NO;
-
     [self setThemeState:CPThemeStateEditing];
 
     [self _updatePlaceholderState];
@@ -361,16 +358,11 @@ CPTokenFieldDeleteButtonType     = 1;
 
     switch ([self alignment])
     {
-        case CPCenterTextAlignment:
-            element.style.textAlign = "center";
-            break;
-
-        case CPRightTextAlignment:
-            element.style.textAlign = "right";
-            break;
-
-        default:
-            element.style.textAlign = "left";
+        case CPCenterTextAlignment: element.style.textAlign = "center";
+                                    break;
+        case CPRightTextAlignment:  element.style.textAlign = "right";
+                                    break;
+        default:                    element.style.textAlign = "left";
     }
 
     var contentRect = [self contentRectForBounds:[self bounds]];
@@ -408,8 +400,6 @@ CPTokenFieldDeleteButtonType     = 1;
     }
 
 #endif
-
-    return YES;
 }
 
 - (BOOL)resignFirstResponder
@@ -491,7 +481,7 @@ CPTokenFieldDeleteButtonType     = 1;
 
 - (void)_mouseUpOnToken:(_CPTokenFieldToken)aToken withEvent:(CPEvent)anEvent
 {
-    if (_mouseDownEvent && CGPointEqualToPoint([_mouseDownEvent locationInWindow], [anEvent locationInWindow]))
+    if (_mouseDownEvent && _CGPointEqualToPoint([_mouseDownEvent locationInWindow], [anEvent locationInWindow]))
     {
         [self _selectToken:aToken byExtendingSelection:[anEvent modifierFlags] & CPShiftKeyMask];
         [[self window] makeFirstResponder:self];
@@ -703,7 +693,11 @@ CPTokenFieldDeleteButtonType     = 1;
 {
     if (![self hasThemeState:CPThemeStateEditing])
         return @"";
+#if PLATFORM(DOM)
     return [self _inputElement].value;
+#else
+    return @"";
+#endif
 }
 
 - (void)moveUp:(id)sender
@@ -827,7 +821,7 @@ CPTokenFieldDeleteButtonType     = 1;
         if (_selectedRange.length)
         {
             // Place the cursor at the end of the selection and collapse.
-            _selectedRange.location = CPMaxRange(_selectedRange);
+            _selectedRange.location = _CPMaxRange(_selectedRange);
             _selectedRange.length = 0;
         }
         else
@@ -848,7 +842,7 @@ CPTokenFieldDeleteButtonType     = 1;
 
 - (void)moveRightAndModifySelection:(id)sender
 {
-    if (CPMaxRange(_selectedRange) < [[self _tokens] count] && [self _editorValue] == "")
+    if (_CPMaxRange(_selectedRange) < [[self _tokens] count] && [self _editorValue] == "")
     {
         // Leave the selection location in place but include the next token to the right.
         _selectedRange.length++;
@@ -927,7 +921,7 @@ CPTokenFieldDeleteButtonType     = 1;
 
         // Finish any editing.
         [self _autocomplete];
-        _selectedRange = CPMakeRange(0, [[self _tokens] count]);
+        _selectedRange = _CPMakeRange(0, [[self _tokens] count]);
 
         [self setNeedsLayout];
     }
@@ -1019,7 +1013,7 @@ CPTokenFieldDeleteButtonType     = 1;
         return;
 
     // Move each token into the right position.
-    var contentRect = CGRectMakeCopy([contentView bounds]),
+    var contentRect = _CGRectMakeCopy([contentView bounds]),
         contentOrigin = contentRect.origin,
         contentSize = contentRect.size,
         offset = CGPointMake(contentOrigin.x, contentOrigin.y),
@@ -1036,11 +1030,11 @@ CPTokenFieldDeleteButtonType     = 1;
     // Get the height of a typical token, or a token token if you will.
     [tokenToken sizeToFit];
 
-    var tokenHeight = CGRectGetHeight([tokenToken bounds]);
+    var tokenHeight = _CGRectGetHeight([tokenToken bounds]);
 
     var fitAndFrame = function(width, height)
     {
-        var r = CGRectMake(0, 0, width, height);
+        var r = _CGRectMake(0, 0, width, height);
 
         if (offset.x + width >= contentSize.width && offset.x > contentOrigin.x)
         {
@@ -1053,8 +1047,8 @@ CPTokenFieldDeleteButtonType     = 1;
 
         // Make sure the frame fits.
         var scrollHeight = offset.y + tokenHeight + CEIL(spaceBetweenTokens.height / 2.0);
-        if (CGRectGetHeight([contentView bounds]) < scrollHeight)
-            [contentView setFrameSize:CGSizeMake(CGRectGetWidth([_tokenScrollView bounds]), scrollHeight)];
+        if (_CGRectGetHeight([contentView bounds]) < scrollHeight)
+            [contentView setFrameSize:_CGSizeMake(_CGRectGetWidth([_tokenScrollView bounds]), scrollHeight)];
 
         offset.x += width + spaceBetweenTokens.width;
 
@@ -1088,12 +1082,12 @@ CPTokenFieldDeleteButtonType     = 1;
 
         // When editing, always scroll to the cursor.
         if (_selectedRange.length == 0)
-            [[_tokenScrollView documentView] scrollPoint:CGPointMake(0, _inputFrame.origin.y)];
+            [[_tokenScrollView documentView] scrollPoint:_CGPointMake(0, _inputFrame.origin.y)];
     };
 
     for (var i = 0, count = [tokens count]; i < count; i++)
     {
-        if (isEditing && !_selectedRange.length && i == CPMaxRange(_selectedRange))
+        if (isEditing && !_selectedRange.length && i == _CPMaxRange(_selectedRange))
             placeEditor(false);
 
         var tokenView = [tokens objectAtIndex:i];
@@ -1114,7 +1108,7 @@ CPTokenFieldDeleteButtonType     = 1;
         [tokenView setButtonType:_buttonType];
     }
 
-    if (isEditing && !_selectedRange.length && CPMaxRange(_selectedRange) >= [tokens count])
+    if (isEditing && !_selectedRange.length && _CPMaxRange(_selectedRange) >= [tokens count])
         placeEditor(true);
 
     // Hide the editor if there are selected tokens, but still keep it active
@@ -1135,8 +1129,8 @@ CPTokenFieldDeleteButtonType     = 1;
 
     // Trim off any excess height downwards (in case we shrank).
     var scrollHeight = offset.y + tokenHeight;
-    if (CGRectGetHeight([contentView bounds]) > scrollHeight)
-        [contentView setFrameSize:CGSizeMake(CGRectGetWidth([_tokenScrollView bounds]), scrollHeight)];
+    if (_CGRectGetHeight([contentView bounds]) > scrollHeight)
+        [contentView setFrameSize:_CGSizeMake(_CGRectGetWidth([_tokenScrollView bounds]), scrollHeight)];
 
     if (_shouldScrollTo !== CPScrollDestinationNone)
     {
@@ -1148,7 +1142,7 @@ CPTokenFieldDeleteButtonType     = 1;
             if (scrollToToken === CPScrollDestinationLeft)
                 scrollToToken = tokens[_selectedRange.location]
             else if (scrollToToken === CPScrollDestinationRight)
-                scrollToToken = tokens[MAX(0, CPMaxRange(_selectedRange) - 1)];
+                scrollToToken = tokens[MAX(0, _CPMaxRange(_selectedRange) - 1)];
             [self _scrollTokenViewToVisible:scrollToToken];
         }
 
@@ -1161,7 +1155,7 @@ CPTokenFieldDeleteButtonType     = 1;
     if (!aToken)
         return;
 
-    return [[_tokenScrollView documentView] scrollPoint:CGPointMake(0, [aToken frameOrigin].y)];
+    return [[_tokenScrollView documentView] scrollPoint:_CGPointMake(0, [aToken frameOrigin].y)];
 }
 
 @end
@@ -1193,7 +1187,7 @@ CPTokenFieldDeleteButtonType     = 1;
 - (CGPoint)_completionOrigin:(_CPAutocompleteMenu)anAutocompleteMenu
 {
     var relativeFrame = _inputFrame ? [[_tokenScrollView documentView] convertRect:_inputFrame toView:self ] : [self bounds];
-    return CGPointMake(CGRectGetMinX(relativeFrame), CGRectGetMaxY(relativeFrame));
+    return _CGPointMake(_CGRectGetMinX(relativeFrame), _CGRectGetMaxY(relativeFrame));
 }
 
 /*!
@@ -1413,7 +1407,7 @@ CPTokenFieldDeleteButtonType     = 1;
 
 - (CGSize)_minimumFrameSize
 {
-    var size = CGSizeMakeZero(),
+    var size = _CGSizeMakeZero(),
         minSize = [self currentValueForThemeAttribute:@"min-size"],
         contentInset = [self currentValueForThemeAttribute:@"content-inset"];
 
@@ -1488,7 +1482,7 @@ CPTokenFieldDeleteButtonType     = 1;
                     buttonOffset = [_disclosureButton currentValueForThemeAttribute:@"offset"],
                     buttonSize = [_disclosureButton currentValueForThemeAttribute:@"min-size"];
 
-                [_disclosureButton setFrame:CGRectMake(CGRectGetMaxX(frame) - buttonOffset.x, CGRectGetMinY(frame) + buttonOffset.y, buttonSize.width, buttonSize.height)];
+                [_disclosureButton setFrame:_CGRectMake(CGRectGetMaxX(frame) - buttonOffset.x, CGRectGetMinY(frame) + buttonOffset.y, buttonSize.width, buttonSize.height)];
                 break;
             case CPTokenFieldDeleteButtonType:
                 [_deleteButton setEnabled:[self isEditable] && [self isEnabled]];
@@ -1497,7 +1491,7 @@ CPTokenFieldDeleteButtonType     = 1;
                     buttonOffset = [_deleteButton currentValueForThemeAttribute:@"offset"],
                     buttonSize = [_deleteButton currentValueForThemeAttribute:@"min-size"];
 
-                [_deleteButton setFrame:CGRectMake(CGRectGetMaxX(frame) - buttonOffset.x, CGRectGetMinY(frame) + buttonOffset.y, buttonSize.width, buttonSize.height)];
+                [_deleteButton setFrame:_CGRectMake(CGRectGetMaxX(frame) - buttonOffset.x, CGRectGetMinY(frame) + buttonOffset.y, buttonSize.width, buttonSize.height)];
                 break;
         }
     }
@@ -1539,7 +1533,7 @@ CPTokenFieldDeleteButtonType     = 1;
 {
     var attributes = [CPButton themeAttributes];
 
-    [attributes setObject:CGPointMake(15, 5) forKey:@"offset"];
+    [attributes setObject:_CGPointMake(15, 5) forKey:@"offset"];
 
     return attributes;
 }
@@ -1569,7 +1563,7 @@ CPTokenFieldDeleteButtonType     = 1;
 {
     var attributes = [CPButton themeAttributes];
 
-    [attributes setObject:CGPointMake(15, 5) forKey:@"offset"];
+    [attributes setObject:_CGPointMake(15, 5) forKey:@"offset"];
 
     return attributes;
 }

AppKit/CPToolbar.j

@@ -610,7 +610,7 @@ var _CPToolbarItemInfoMake = function(anIndex, aView, aLabel, aMinWidth)
             @"extra-item-width": 20.0,
             @"extra-item-extra-image": [CPNull null],
             @"extra-item-extra-alternate-image": [CPNull null],
-            @"content-inset": CGInsetMake(4.0, 4.0, 4.0, 10),
+            @"content-inset": _CGInsetMake(4.0, 4.0, 4.0, 10),
             @"regular-size-height": 59.0,
             @"small-size-height": 46.0,
             @"image-item-separator-color": [CPNull null],
@@ -629,7 +629,7 @@ var _CPToolbarItemInfoMake = function(anIndex, aView, aLabel, aMinWidth)
         _labelColor = [CPColor blackColor];
         _labelShadowColor = [CPColor colorWithWhite:1.0 alpha:0.75];
 
-        _additionalItemsButton = [[CPPopUpButton alloc] initWithFrame:CGRectMake(0.0, 0.0, 10.0, 15.0) pullsDown:YES];
+        _additionalItemsButton = [[CPPopUpButton alloc] initWithFrame:_CGRectMake(0.0, 0.0, 10.0, 15.0) pullsDown:YES];
         [_additionalItemsButton setBordered:NO];
 
         [_additionalItemsButton setImagePosition:CPImageOnly];
@@ -679,7 +679,7 @@ var _CPToolbarItemInfoMake = function(anIndex, aView, aLabel, aMinWidth)
 {
     // We begin by recalculating the visible items.
     var items = [_toolbar items],
-        itemsWidth = CGRectGetWidth([self bounds]),
+        itemsWidth = _CGRectGetWidth([self bounds]),
         minWidth = _minWidth,
         // FIXME: This should be a CPSet.
         invisibleItemsSortedByPriority = [];
@@ -766,7 +766,7 @@ var _CPToolbarItemInfoMake = function(anIndex, aView, aLabel, aMinWidth)
         // static width (min==max). This handles the case where the user did setView:
         // with a view of a different size than minSize/maxSize
         else
-            [view setFrameSize:CGSizeMake(minSize.width, height)];
+            [view setFrameSize:_CGSizeMake(minSize.width, height)];
 
         [view setHidden:NO];
     }
@@ -801,7 +801,7 @@ var _CPToolbarItemInfoMake = function(anIndex, aView, aLabel, aMinWidth)
                 remainingSpace += proposedWidth - constrainedWidth;
             }
 
-            [view setFrameSize:CGSizeMake(constrainedWidth, height)];
+            [view setFrameSize:_CGSizeMake(constrainedWidth, height)];
         }
     }
 
@@ -815,9 +815,9 @@ var _CPToolbarItemInfoMake = function(anIndex, aView, aLabel, aMinWidth)
     for (; index < count; ++index)
     {
         var view = [self viewForItem:_visibleItems[index]],
-            viewWidth = CGRectGetWidth([view frame]);
+            viewWidth = _CGRectGetWidth([view frame]);
 
-        [view setFrame:CGRectMake(x, y, viewWidth, height)];
+        [view setFrame:_CGRectMake(x, y, viewWidth, height)];
 
         x += viewWidth + [self valueForThemeAttribute:@"item-margin"];
     }
@@ -851,7 +851,7 @@ var _CPToolbarItemInfoMake = function(anIndex, aView, aLabel, aMinWidth)
 
     if (needsAdditionalItemsButton)
     {
-        [_additionalItemsButton setFrameOrigin:CGPointMake(itemsWidth + 5.0, (CGRectGetHeight([self bounds]) - CGRectGetHeight([_additionalItemsButton frame])) / 2.0)];
+        [_additionalItemsButton setFrameOrigin:_CGPointMake(itemsWidth + 5.0, (_CGRectGetHeight([self bounds]) - _CGRectGetHeight([_additionalItemsButton frame])) / 2.0)];
 
         [self addSubview:_additionalItemsButton];
 
@@ -994,12 +994,12 @@ var LABEL_MARGIN    = 2.0;
     {
         _toolbarItem = aToolbarItem;
 
-        _labelField = [[CPTextField alloc] initWithFrame:CGRectMakeZero()];
+        _labelField = [[CPTextField alloc] initWithFrame:_CGRectMakeZero()];
 
         [_labelField setFont:[CPFont systemFontOfSize:11.0]];
         [_labelField setTextColor:[self FIXME_labelColor]];
         [_labelField setTextShadowColor:[self FIXME_labelShadowColor]];
-        [_labelField setTextShadowOffset:CGSizeMake(0.0, 1.0)];
+        [_labelField setTextShadowOffset:_CGSizeMake(0.0, 1.0)];
         [_labelField setAutoresizingMask:CPViewWidthSizable | CPViewMinXMargin];
 
         [self addSubview:_labelField];
@@ -1101,8 +1101,8 @@ var LABEL_MARGIN    = 2.0;
     [_labelField setHidden:iconOnly];
     [_view setHidden:labelOnly];
 
-    _minSize = CGSizeMake(MAX(_labelSize.width, minSize.width), (labelOnly ? 0 : minSize.height) + (iconOnly ? 0 : _labelSize.height + LABEL_MARGIN));
-    _maxSize = CGSizeMake(MAX(_labelSize.width, maxSize.width), 100000000.0);
+    _minSize = _CGSizeMake(MAX(_labelSize.width, minSize.width), (labelOnly ? 0 : minSize.height) + (iconOnly ? 0 : _labelSize.height + LABEL_MARGIN));
+    _maxSize = _CGSizeMake(MAX(_labelSize.width, maxSize.width), 100000000.0);
 
     [_toolbar tile];
 }
@@ -1116,14 +1116,14 @@ var LABEL_MARGIN    = 2.0;
         return;
 
     var bounds = [self bounds],
-        width = CGRectGetWidth(bounds);
+        width = _CGRectGetWidth(bounds);
 
     if (identifier === CPToolbarSeparatorItemIdentifier)
     {
         var itemSeparatorColor = [_toolbar valueForThemeAttribute:@"image-item-separator-color"],
             itemSeparatorSize = [_toolbar valueForThemeAttribute:@"image-item-separator-size"];
 
-        [_view setFrame:CGRectMake(ROUND((width - itemSeparatorSize.size.width) / 2.0), 0.0, itemSeparatorSize.size.width, CGRectGetHeight(bounds))];
+        [_view setFrame:_CGRectMake(ROUND((width - itemSeparatorSize.size.width) / 2.0), 0.0, itemSeparatorSize.size.width, _CGRectGetHeight(bounds))];
         [_view setBackgroundColor:itemSeparatorColor];
 
         return;
@@ -1133,17 +1133,17 @@ var LABEL_MARGIN    = 2.0;
     var view = _view || _imageView,
         itemMaxSize = [_toolbarItem maxSize],
         iconOnly = [[_toolbarItem toolbar] displayMode] === CPToolbarDisplayModeIconOnly,
-        height = CGRectGetHeight(bounds) - (iconOnly ? 0 : _labelSize.height),
+        height = _CGRectGetHeight(bounds) - (iconOnly ? 0 : _labelSize.height),
         viewWidth = MIN(itemMaxSize.width, width),
         viewHeight =  MIN(itemMaxSize.height, height);
 
-    [view setFrame:CGRectMake(ROUND((width - viewWidth) / 2.0),
+    [view setFrame:_CGRectMake(ROUND((width - viewWidth) / 2.0),
                                ROUND((height - viewHeight) / 2.0),
                                viewWidth,
                                viewHeight)];
 
     // Label is always drawn at the bottom of the view. So if the view is really tall but the icon is tiny, the icon is centred above the label while the label remains on the bottom.
-    [_labelField setFrameOrigin:CGPointMake(ROUND((width - _labelSize.width) / 2.0), CGRectGetHeight(bounds) - _labelSize.height)];
+    [_labelField setFrameOrigin:_CGPointMake(ROUND((width - _labelSize.width) / 2.0), _CGRectGetHeight(bounds) - _labelSize.height)];
 }
 
 - (void)mouseDown:(CPEvent)anEvent
@@ -1210,7 +1210,7 @@ var LABEL_MARGIN    = 2.0;
         if (alternateImage)
             [_imageView setImage:alternateImage];
 
-        [_labelField setTextShadowOffset:CGSizeMakeZero()];
+        [_labelField setTextShadowOffset:_CGSizeMakeZero()];
     }
     else
     {
@@ -1219,7 +1219,7 @@ var LABEL_MARGIN    = 2.0;
         if (image)
             [_imageView setImage:image];
 
-        [_labelField setTextShadowOffset:CGSizeMake(0.0, 1.0)];
+        [_labelField setTextShadowOffset:_CGSizeMake(0.0, 1.0)];
     }
 
     [_labelField setTextShadowColor:[self FIXME_labelShadowColor]];

AppKit/CPView.j

@@ -294,8 +294,8 @@ var CPViewFlags                     = { },
 
     if (self)
     {
-        var width = CGRectGetWidth(aFrame),
-            height = CGRectGetHeight(aFrame);
+        var width = _CGRectGetWidth(aFrame),
+            height = _CGRectGetHeight(aFrame);
 
         _subviews = [];
         _registeredDraggedTypes = [CPSet set];
@@ -303,8 +303,8 @@ var CPViewFlags                     = { },
 
         _tag = -1;
 
-        _frame = CGRectMakeCopy(aFrame);
-        _bounds = CGRectMake(0.0, 0.0, width, height);
+        _frame = _CGRectMakeCopy(aFrame);
+        _bounds = _CGRectMake(0.0, 0.0, width, height);
 
         _autoresizingMask = CPViewNotSizable;
         _autoresizesSubviews = YES;
@@ -317,7 +317,7 @@ var CPViewFlags                     = { },
 #if PLATFORM(DOM)
         _DOMElement = DOMElementPrototype.cloneNode(false);
 
-        CPDOMDisplayServerSetStyleLeftTop(_DOMElement, NULL, CGRectGetMinX(aFrame), CGRectGetMinY(aFrame));
+        CPDOMDisplayServerSetStyleLeftTop(_DOMElement, NULL, _CGRectGetMinX(aFrame), _CGRectGetMinY(aFrame));
         CPDOMDisplayServerSetStyleSize(_DOMElement, width, height);
 
         if (typeof(appkit_tag_dom_elements) !== "undefined" && !!appkit_tag_dom_elements)
@@ -373,9 +373,9 @@ var CPViewFlags                     = { },
 #if PLATFORM(DOM)
     if (_DOMElement.addEventListener)
     {
-        _DOMElement.addEventListener("mouseover", _toolTipFunctionIn, YES);
-        _DOMElement.addEventListener("keypress", _toolTipFunctionOut, YES);
-        _DOMElement.addEventListener("mouseout", _toolTipFunctionOut, YES);
+        _DOMElement.addEventListener("mouseover", _toolTipFunctionIn, NO);
+        _DOMElement.addEventListener("keypress", _toolTipFunctionOut, NO);
+        _DOMElement.addEventListener("mouseout", _toolTipFunctionOut, NO);
     }
     else if (_DOMElement.attachEvent)
     {
@@ -400,9 +400,9 @@ var CPViewFlags                     = { },
 #if PLATFORM(DOM)
     if (_DOMElement.removeEventListener)
     {
-        _DOMElement.removeEventListener("mouseover", _toolTipFunctionIn, YES);
-        _DOMElement.removeEventListener("keypress", _toolTipFunctionOut, YES);
-        _DOMElement.removeEventListener("mouseout", _toolTipFunctionOut, YES);
+        _DOMElement.removeEventListener("mouseover", _toolTipFunctionIn, NO);
+        _DOMElement.removeEventListener("keypress", _toolTipFunctionOut, NO);
+        _DOMElement.removeEventListener("mouseout", _toolTipFunctionOut, NO);
     }
     else if (_DOMElement.detachEvent)
     {
@@ -672,6 +672,9 @@ var CPViewFlags                     = { },
     if (_window === aWindow)
         return;
 
+    // Unlike in Cocoa you can observe the window of a view.
+    [self willChangeValueForKey:@"window"];
+
     [[self window] _dirtyKeyViewLoop];
 
     // Clear out first responder if we're the first responder and leaving.
@@ -699,6 +702,8 @@ var CPViewFlags                     = { },
     [self viewDidMoveToWindow];
 
     [[self window] _dirtyKeyViewLoop];
+
+    [self didChangeValueForKey:@"window"];
 }
 
 /*!
@@ -829,7 +834,7 @@ var CPViewFlags                     = { },
 */
 - (void)setFrame:(CGRect)aFrame
 {
-    if (CGRectEqualToRect(_frame, aFrame))
+    if (_CGRectEqualToRect(_frame, aFrame))
         return;
 
     _inhibitFrameAndBoundsChangedNotifications = YES;
@@ -849,17 +854,17 @@ var CPViewFlags                     = { },
 */
 - (CGRect)frame
 {
-    return CGRectMakeCopy(_frame);
+    return _CGRectMakeCopy(_frame);
 }
 
 - (CGPoint)frameOrigin
 {
-    return CGPointMakeCopy(_frame.origin);
+    return _CGPointMakeCopy(_frame.origin);
 }
 
 - (CGSize)frameSize
 {
-    return CGSizeMakeCopy(_frame.size);
+    return _CGSizeMakeCopy(_frame.size);
 }
 
 /*!
@@ -894,7 +899,7 @@ var CPViewFlags                     = { },
 {
     var origin = _frame.origin;
 
-    if (!aPoint || CGPointEqualToPoint(origin, aPoint))
+    if (!aPoint || _CGPointEqualToPoint(origin, aPoint))
         return;
 
     origin.x = aPoint.x;
@@ -920,10 +925,10 @@ var CPViewFlags                     = { },
 {
     var size = _frame.size;
 
-    if (!aSize || CGSizeEqualToSize(size, aSize))
+    if (!aSize || _CGSizeEqualToSize(size, aSize))
         return;
 
-    var oldSize = CGSizeMakeCopy(size);
+    var oldSize = _CGSizeMakeCopy(size);
 
     size.width = aSize.width;
     size.height = aSize.height;
@@ -1060,7 +1065,7 @@ var CPViewFlags                     = { },
 */
 - (void)setBounds:(CGRect)bounds
 {
-    if (CGRectEqualToRect(_bounds, bounds))
+    if (_CGRectEqualToRect(_bounds, bounds))
         return;
 
     _inhibitFrameAndBoundsChangedNotifications = YES;
@@ -1080,17 +1085,17 @@ var CPViewFlags                     = { },
 */
 - (CGRect)bounds
 {
-    return CGRectMakeCopy(_bounds);
+    return _CGRectMakeCopy(_bounds);
 }
 
 - (CGPoint)boundsOrigin
 {
-    return CGPointMakeCopy(_bounds.origin);
+    return _CGPointMakeCopy(_bounds.origin);
 }
 
 - (CGSize)boundsSize
 {
-    return CGSizeMakeCopy(_bounds.size);
+    return _CGSizeMakeCopy(_bounds.size);
 }
 
 /*!
@@ -1103,7 +1108,7 @@ var CPViewFlags                     = { },
 {
     var origin = _bounds.origin;
 
-    if (CGPointEqualToPoint(origin, aPoint))
+    if (_CGPointEqualToPoint(origin, aPoint))
         return;
 
     origin.x = aPoint.x;
@@ -1111,7 +1116,7 @@ var CPViewFlags                     = { },
 
     if (origin.x != 0 || origin.y != 0)
     {
-        _boundsTransform = CGAffineTransformMakeTranslation(-origin.x, -origin.y);
+        _boundsTransform = _CGAffineTransformMakeTranslation(-origin.x, -origin.y);
         _inverseBoundsTransform = CGAffineTransformInvert(_boundsTransform);
     }
     else
@@ -1146,12 +1151,12 @@ var CPViewFlags                     = { },
 {
     var size = _bounds.size;
 
-    if (CGSizeEqualToSize(size, aSize))
+    if (_CGSizeEqualToSize(size, aSize))
         return;
 
     var frameSize = _frame.size;
 
-    if (!CGSizeEqualToSize(size, frameSize))
+    if (!_CGSizeEqualToSize(size, frameSize))
     {
         var origin = _bounds.origin;
 
@@ -1162,7 +1167,7 @@ var CPViewFlags                     = { },
     size.width = aSize.width;
     size.height = aSize.height;
 
-    if (!CGSizeEqualToSize(size, frameSize))
+    if (!_CGSizeEqualToSize(size, frameSize))
     {
         var origin = _bounds.origin;
 
@@ -1187,29 +1192,21 @@ var CPViewFlags                     = { },
         return;
 
     var frame = _superview._frame,
-        newFrame = CGRectMakeCopy(_frame),
-        dX = frame.size.width - aSize.width,
-        dY = frame.size.height - aSize.height,
-        evenFractionX = 1.0 / ((mask & CPViewMinXMargin ? 1 : 0) + (mask & CPViewWidthSizable ? 1 : 0) + (mask & CPViewMaxXMargin ? 1 : 0)),
-        evenFractionY = 1.0 / ((mask & CPViewMinYMargin ? 1 : 0) + (mask & CPViewHeightSizable ? 1 : 0) + (mask & CPViewMaxYMargin ? 1 : 0)),
-        baseX = (mask & CPViewMinXMargin    ? _frame.origin.x : 0) +
-                (mask & CPViewWidthSizable  ? _frame.size.width : 0) +
-                (mask & CPViewMaxXMargin    ? aSize.width - _frame.size.width - _frame.origin.x : 0),
-        baseY = (mask & CPViewMinYMargin    ? _frame.origin.y : 0) +
-                (mask & CPViewHeightSizable ? _frame.size.height : 0) +
-                (mask & CPViewMaxYMargin    ? aSize.height - _frame.size.height - _frame.origin.y : 0);
+        newFrame = _CGRectMakeCopy(_frame),
+        dX = (_CGRectGetWidth(frame) - aSize.width) /
+            (((mask & CPViewMinXMargin) ? 1 : 0) + (mask & CPViewWidthSizable ? 1 : 0) + (mask & CPViewMaxXMargin ? 1 : 0)),
+        dY = (_CGRectGetHeight(frame) - aSize.height) /
+            ((mask & CPViewMinYMargin ? 1 : 0) + (mask & CPViewHeightSizable ? 1 : 0) + (mask & CPViewMaxYMargin ? 1 : 0));
 
     if (mask & CPViewMinXMargin)
-        newFrame.origin.x += dX * (baseX > 0 ? _frame.origin.x / baseX : evenFractionX);
-
+        newFrame.origin.x += dX;
     if (mask & CPViewWidthSizable)
-        newFrame.size.width += dX * (baseX > 0 ? _frame.size.width / baseX : evenFractionX);
+        newFrame.size.width += dX;
 
     if (mask & CPViewMinYMargin)
-        newFrame.origin.y += dY * (baseY > 0 ? _frame.origin.y / baseY : evenFractionY);
-
+        newFrame.origin.y += dY;
     if (mask & CPViewHeightSizable)
-        newFrame.size.height += dY * (baseY > 0 ? _frame.size.height / baseY : evenFractionY);
+        newFrame.size.height += dY;
 
     [self setFrame:newFrame];
 }
@@ -1547,15 +1544,15 @@ var CPViewFlags                     = { },
 */
 - (CPView)hitTest:(CGPoint)aPoint
 {
-    if (_isHidden || !_hitTests || !CGRectContainsPoint(_frame, aPoint))
+    if (_isHidden || !_hitTests || !_CGRectContainsPoint(_frame, aPoint))
         return nil;
 
     var view = nil,
         i = _subviews.length,
-        adjustedPoint = CGPointMake(aPoint.x - CGRectGetMinX(_frame), aPoint.y - CGRectGetMinY(_frame));
+        adjustedPoint = _CGPointMake(aPoint.x - _CGRectGetMinX(_frame), aPoint.y - _CGRectGetMinY(_frame));
 
     if (_inverseBoundsTransform)
-        adjustedPoint = CGPointApplyAffineTransform(adjustedPoint, _inverseBoundsTransform);
+        adjustedPoint = _CGPointApplyAffineTransform(adjustedPoint, _inverseBoundsTransform);
 
     while (i--)
         if (view = [_subviews[i] hitTest:adjustedPoint])
@@ -1994,6 +1991,9 @@ setFrameOrigin:
         return;
 
     _postsFrameChangedNotifications = shouldPostFrameChangedNotifications;
+
+    if (_postsFrameChangedNotifications)
+        [CachedNotificationCenter postNotificationName:CPViewFrameDidChangeNotification object:self];
 }
 
 /*!
@@ -2024,6 +2024,9 @@ setBoundsOrigin:
         return;
 
     _postsBoundsChangedNotifications = shouldPostBoundsChangedNotifications;
+
+    if (_postsBoundsChangedNotifications)
+        [CachedNotificationCenter postNotificationName:CPViewBoundsDidChangeNotification object:self];
 }
 
 /*!
@@ -2136,20 +2139,20 @@ setBoundsOrigin:
     if (!(_viewClassFlags & CPViewHasCustomDrawRect))
         return;
 
-    if (CGRectIsEmpty(aRect))
+    if (_CGRectIsEmpty(aRect))
         return;
 
-    if (_dirtyRect && !CGRectIsEmpty(_dirtyRect))
+    if (_dirtyRect && !_CGRectIsEmpty(_dirtyRect))
         _dirtyRect = CGRectUnion(aRect, _dirtyRect);
     else
-        _dirtyRect = CGRectMakeCopy(aRect);
+        _dirtyRect = _CGRectMakeCopy(aRect);
 
     _CPDisplayServerAddDisplayObject(self);
 }
 
 - (BOOL)needsDisplay
 {
-    return _dirtyRect && !CGRectIsEmpty(_dirtyRect);
+    return _dirtyRect && !_CGRectIsEmpty(_dirtyRect);
 }
 
 /*!
@@ -2225,13 +2228,13 @@ setBoundsOrigin:
         _DOMContentsElement.style.position = "absolute";
         _DOMContentsElement.style.visibility = "visible";
 
-        _DOMContentsElement.width = ROUND(CGRectGetWidth(_frame));
-        _DOMContentsElement.height = ROUND(CGRectGetHeight(_frame));
+        _DOMContentsElement.width = ROUND(_CGRectGetWidth(_frame));
+        _DOMContentsElement.height = ROUND(_CGRectGetHeight(_frame));
 
         _DOMContentsElement.style.top = "0px";
         _DOMContentsElement.style.left = "0px";
-        _DOMContentsElement.style.width = ROUND(CGRectGetWidth(_frame)) + "px";
-        _DOMContentsElement.style.height = ROUND(CGRectGetHeight(_frame)) + "px";
+        _DOMContentsElement.style.width = ROUND(_CGRectGetWidth(_frame)) + "px";
+        _DOMContentsElement.style.height = ROUND(_CGRectGetHeight(_frame)) + "px";
 
         // The performance implications of this aren't clear, but without this subviews might not be redrawn when this
         // view moves.
@@ -2339,7 +2342,7 @@ setBoundsOrigin:
     aRect = CGRectIntersection(aRect, _bounds);
 
     // If aRect is empty no scrolling required.
-    if (CGRectIsEmpty(aRect))
+    if (_CGRectIsEmpty(aRect))
         return NO;
 
     var enclosingClipView = [self _enclosingClipView];
@@ -2362,18 +2365,18 @@ setBoundsOrigin:
     if (CGRectContainsRect(documentViewVisibleRect, rectInDocumentView))
         return NO;
 
-    var scrollPoint = CGPointMakeCopy(documentViewVisibleRect.origin);
+    var scrollPoint = _CGPointMakeCopy(documentViewVisibleRect.origin);
 
     // One of the following has to be true since our current visible rect didn't contain aRect.
-    if (CGRectGetMinX(rectInDocumentView) < CGRectGetMinX(documentViewVisibleRect))
-        scrollPoint.x = CGRectGetMinX(rectInDocumentView);
-    else if (CGRectGetMaxX(rectInDocumentView) > CGRectGetMaxX(documentViewVisibleRect))
-        scrollPoint.x += CGRectGetMaxX(rectInDocumentView) - CGRectGetMaxX(documentViewVisibleRect);
+    if (_CGRectGetMinX(rectInDocumentView) < _CGRectGetMinX(documentViewVisibleRect))
+        scrollPoint.x = _CGRectGetMinX(rectInDocumentView);
+    else if (_CGRectGetMaxX(rectInDocumentView) > _CGRectGetMaxX(documentViewVisibleRect))
+        scrollPoint.x += _CGRectGetMaxX(rectInDocumentView) - _CGRectGetMaxX(documentViewVisibleRect);
 
-    if (CGRectGetMinY(rectInDocumentView) < CGRectGetMinY(documentViewVisibleRect))
-        scrollPoint.y = CGRectGetMinY(rectInDocumentView);
-    else if (CGRectGetMaxY(rectInDocumentView) > CGRectGetMaxY(documentViewVisibleRect))
-        scrollPoint.y += CGRectGetMaxY(rectInDocumentView) - CGRectGetMaxY(documentViewVisibleRect);
+    if (_CGRectGetMinY(rectInDocumentView) < _CGRectGetMinY(documentViewVisibleRect))
+        scrollPoint.y = _CGRectGetMinY(rectInDocumentView);
+    else if (_CGRectGetMaxY(rectInDocumentView) > _CGRectGetMaxY(documentViewVisibleRect))
+        scrollPoint.y += _CGRectGetMaxY(rectInDocumentView) - _CGRectGetMaxY(documentViewVisibleRect);
 
     [enclosingClipView scrollToPoint:scrollPoint];
 
@@ -2559,35 +2562,21 @@ setBoundsOrigin:
 
 - (void)_setPreviousKeyView:(CPView)previous
 {
-    if (![previous isEqual:self])
-    {
-        var previousWindow = [previous window];
-
-        if (!previousWindow || previousWindow === _window)
-        {
-            _previousKeyView = previous;
-            return;
-        }
-    }
-
-    _previousKeyView = nil;
+    if ([previous isEqual:self] || ![[previous window] isEqual:[self window]])
+        _previousKeyView = nil;
+    else
+        _previousKeyView = previous;
 }
 
 - (void)setNextKeyView:(CPView)next
 {
-    if (![next isEqual:self])
+    if ([next isEqual:self] || ![[next window] isEqual:[self window]])
+        _nextKeyView = nil;
+    else
     {
-        var nextWindow = [next window];
-
-        if (!nextWindow || nextWindow === _window)
-        {
-            _nextKeyView = next;
-            [_nextKeyView _setPreviousKeyView:self];
-            return;
-        }
+        _nextKeyView = next;
+        [_nextKeyView _setPreviousKeyView:self];
     }
-
-    _nextKeyView = nil;
 }
 
 @end
@@ -2964,7 +2953,7 @@ setBoundsOrigin:
 
 - (CGRect)rectForEphemeralSubviewNamed:(CPString)aViewName
 {
-    return CGRectMakeZero();
+    return _CGRectMakeZero();
 }
 
 - (CPView)layoutEphemeralSubviewNamed:(CPString)aViewName
@@ -3103,8 +3092,8 @@ var CPViewAutoresizingMaskKey       = @"CPViewAutoresizingMask",
         _DOMImageParts = [];
         _DOMImageSizes = [];
 
-        CPDOMDisplayServerSetStyleLeftTop(_DOMElement, NULL, CGRectGetMinX(_frame), CGRectGetMinY(_frame));
-        CPDOMDisplayServerSetStyleSize(_DOMElement, CGRectGetWidth(_frame), CGRectGetHeight(_frame));
+        CPDOMDisplayServerSetStyleLeftTop(_DOMElement, NULL, _CGRectGetMinX(_frame), _CGRectGetMinY(_frame));
+        CPDOMDisplayServerSetStyleSize(_DOMElement, _CGRectGetWidth(_frame), _CGRectGetHeight(_frame));
 
         var index = 0,
             count = _subviews.length;
@@ -3256,12 +3245,12 @@ var _CPViewGetTransform = function(/*CPView*/ fromView, /*CPView */ toView)
         {
             var frame = view._frame;
 
-            transform.tx += CGRectGetMinX(frame);
-            transform.ty += CGRectGetMinY(frame);
+            transform.tx += _CGRectGetMinX(frame);
+            transform.ty += _CGRectGetMinY(frame);
 
             if (view._boundsTransform)
             {
-                CGAffineTransformConcatTo(transform, view._boundsTransform, transform);
+                _CGAffineTransformConcatTo(transform, view._boundsTransform, transform);
             }
 
             view = view._superview;
@@ -3282,8 +3271,8 @@ var _CPViewGetTransform = function(/*CPView*/ fromView, /*CPView */ toView)
 
                 var frame = [fromWindow frame];
 
-                transform.tx += CGRectGetMinX(frame);
-                transform.ty += CGRectGetMinY(frame);
+                transform.tx += _CGRectGetMinX(frame);
+                transform.ty += _CGRectGetMinY(frame);
             }
         }
     }
@@ -3295,12 +3284,12 @@ var _CPViewGetTransform = function(/*CPView*/ fromView, /*CPView */ toView)
     {
         var frame = view._frame;
 
-        transform.tx -= CGRectGetMinX(frame);
-        transform.ty -= CGRectGetMinY(frame);
+        transform.tx -= _CGRectGetMinX(frame);
+        transform.ty -= _CGRectGetMinY(frame);
 
         if (view._boundsTransform)
         {
-            CGAffineTransformConcatTo(transform, view._inverseBoundsTransform, transform);
+            _CGAffineTransformConcatTo(transform, view._inverseBoundsTransform, transform);
         }
 
         view = view._superview;
@@ -3310,8 +3299,8 @@ var _CPViewGetTransform = function(/*CPView*/ fromView, /*CPView */ toView)
     {
         var frame = [toWindow frame];
 
-        transform.tx -= CGRectGetMinX(frame);
-        transform.ty -= CGRectGetMinY(frame);
+        transform.tx -= _CGRectGetMinX(frame);
+        transform.ty -= _CGRectGetMinY(frame);
     }
 /*    var views = [],
         view = toView;
@@ -3328,8 +3317,8 @@ var _CPViewGetTransform = function(/*CPView*/ fromView, /*CPView */ toView)
     {
         var frame = views[index]._frame;
 
-        transform.tx -= CGRectGetMinX(frame);
-        transform.ty -= CGRectGetMinY(frame);
+        transform.tx -= _CGRectGetMinX(frame);
+        transform.ty -= _CGRectGetMinY(frame);
     }*/
 
     return transform;

AppKit/CPViewAnimation.j

@@ -116,7 +116,7 @@ CPViewAnimationFadeOutEffect = @"CPViewAnimationFadeOutEffect";
             view = [self _targetView:dictionary],
             startFrame = [self _startFrame:dictionary],
             endFrame = [self _endFrame:dictionary],
-            differenceFrame = CGRectMakeZero(),
+            differenceFrame = _CGRectMakeZero(),
             value = [super currentValue];
 
         differenceFrame.origin.x = endFrame.origin.x - startFrame.origin.x;
@@ -124,7 +124,7 @@ CPViewAnimationFadeOutEffect = @"CPViewAnimationFadeOutEffect";
         differenceFrame.size.width = endFrame.size.width - startFrame.size.width;
         differenceFrame.size.height = endFrame.size.height - startFrame.size.height;
 
-        var intermediateFrame = CGRectMakeZero();
+        var intermediateFrame = _CGRectMakeZero();
         intermediateFrame.origin.x = startFrame.origin.x + differenceFrame.origin.x * value;
         intermediateFrame.origin.y = startFrame.origin.y + differenceFrame.origin.y * value;
         intermediateFrame.size.width = startFrame.size.width + differenceFrame.size.width * value;
@@ -140,7 +140,7 @@ CPViewAnimationFadeOutEffect = @"CPViewAnimationFadeOutEffect";
             [view setAlphaValue:1.0 + ( 0.0 - 1.0 ) * value];
 
         if (progress === 1.0)
-            [self _targetView:view setHidden:CGRectIsEmpty(endFrame) || [view alphaValue] === 0.0];
+            [self _targetView:view setHidden:_CGRectIsNull(endFrame) || [view alphaValue] === 0.0];
     }
 }
 
@@ -161,7 +161,7 @@ CPViewAnimationFadeOutEffect = @"CPViewAnimationFadeOutEffect";
         else if (effect === CPViewAnimationFadeOutEffect)
             [view setAlphaValue:0.0];
 
-        [self _targetView:view setHidden:CGRectIsEmpty(endFrame) || [view alphaValue] === 0.0];
+        [self _targetView:view setHidden:_CGRectIsNull(endFrame) || [view alphaValue] === 0.0];
     }
 
     [super stopAnimation];

AppKit/CPWindow/CPWindow.j

@@ -56,10 +56,7 @@
 var CPWindowSaveImage       = nil,
 
     CPWindowResizeTime      = 0.2,
-    CPWindowResizeStyleGlobalChangeNotification = @"CPWindowResizeStyleGlobalChangeNotification",
-
-    CPWindowMinVisibleHorizontalMargin = 40,
-    CPWindowMinVisibleVerticalMargin = 2;
+    CPWindowResizeStyleGlobalChangeNotification = @"CPWindowResizeStyleGlobalChangeNotification";
 
 /*
     Keys for which action messages will be sent by default when unhandled, e.g. complete:.
@@ -147,7 +144,6 @@ var CPWindowActionMessageKeys = [
     BOOL                                _hasShadow;
     BOOL                                _isMovableByWindowBackground;
     BOOL                                _isMovable;
-    BOOL                                _constrainsToUsableScreen;
     unsigned                            _shadowStyle;
     BOOL                                _showsResizeIndicator;
 
@@ -230,7 +226,7 @@ var CPWindowActionMessageKeys = [
 
 - (id)init
 {
-    return [self initWithContentRect:CGRectMakeZero() styleMask:CPTitledWindowMask];
+    return [self initWithContentRect:_CGRectMakeZero() styleMask:CPTitledWindowMask];
 }
 
 /*!
@@ -257,7 +253,6 @@ CPTexturedBackgroundWindowMask
         var windowViewClass = [[self class] _windowViewClassForStyleMask:aStyleMask];
 
         _frame = [windowViewClass frameRectForContentRect:aContentRect];
-        _constrainsToUsableScreen = YES;
 
         [self _setSharesChromeWithPlatformWindow:![CPPlatform isBrowser]];
 
@@ -303,19 +298,19 @@ CPTexturedBackgroundWindowMask
         [self setLevel:CPNormalWindowLevel];
 
         // Create our border view which is the actual root of our view hierarchy.
-        _windowView = [[windowViewClass alloc] initWithFrame:CGRectMake(0.0, 0.0, CGRectGetWidth(_frame), CGRectGetHeight(_frame)) styleMask:aStyleMask];
+        _windowView = [[windowViewClass alloc] initWithFrame:_CGRectMake(0.0, 0.0, _CGRectGetWidth(_frame), _CGRectGetHeight(_frame)) styleMask:aStyleMask];
 
         [_windowView _setWindow:self];
         [_windowView setNextResponder:self];
 
         // Size calculation needs _windowView
-        _minSize = [self _calculateMinSizeForProposedSize:CGSizeMake(0.0, 0.0)];
-        _maxSize = CGSizeMake(1000000.0, 1000000.0);
+        _minSize = [self _calculateMinSizeForProposedSize:_CGSizeMake(0.0, 0.0)];
+        _maxSize = _CGSizeMake(1000000.0, 1000000.0);
 
         [self setMovableByWindowBackground:aStyleMask & CPHUDBackgroundWindowMask];
 
         // Create a generic content view.
-        [self setContentView:[[CPView alloc] initWithFrame:CGRectMakeZero()]];
+        [self setContentView:[[CPView alloc] initWithFrame:_CGRectMakeZero()]];
 
         _firstResponder = self;
 
@@ -328,7 +323,7 @@ CPTexturedBackgroundWindowMask
 
         if (![self _sharesChromeWithPlatformWindow])
         {
-            CPDOMDisplayServerSetStyleLeftTop(_DOMElement, NULL, CGRectGetMinX(_frame), CGRectGetMinY(_frame));
+            CPDOMDisplayServerSetStyleLeftTop(_DOMElement, NULL, _CGRectGetMinX(_frame), _CGRectGetMinY(_frame));
         }
 
         CPDOMDisplayServerSetStyleSize(_DOMElement, 1, 1);
@@ -547,7 +542,7 @@ CPTexturedBackgroundWindowMask
         _fullPlatformWindowSession = _CPWindowFullPlatformWindowSessionMake(_windowView, [self contentRectForFrameRect:[self frame]], [self hasShadow], [self level]);
 
         var fullPlatformWindowViewClass = [[self class] _windowViewClassForFullPlatformWindowStyleMask:_styleMask],
-            windowView = [[fullPlatformWindowViewClass alloc] initWithFrame:CGRectMakeZero() styleMask:_styleMask];
+            windowView = [[fullPlatformWindowViewClass alloc] initWithFrame:_CGRectMakeZero() styleMask:_styleMask];
 
         [self _setWindowView:windowView];
 
@@ -633,7 +628,7 @@ CPTexturedBackgroundWindowMask
 */
 - (CGRect)frame
 {
-    return CGRectMakeCopy(_frame);
+    return _CGRectMakeCopy(_frame);
 }
 
 /*!
@@ -645,54 +640,48 @@ CPTexturedBackgroundWindowMask
 */
 - (void)setFrame:(CGRect)aFrame display:(BOOL)shouldDisplay animate:(BOOL)shouldAnimate
 {
-    [self _setFrame:aFrame display:shouldDisplay animate:shouldAnimate constrainWidth:NO constrainHeight:YES];
-}
+    aFrame = _CGRectMakeCopy(aFrame);
 
-- (void)_setFrame:(CGRect)aFrame display:(BOOL)shouldDisplay animate:(BOOL)shouldAnimate constrainWidth:(BOOL)shouldConstrainWidth constrainHeight:(BOOL)shouldConstrainHeight
-{
-    var frame = CGRectMakeCopy(aFrame),
-        value = frame.origin.x,
+    var value = aFrame.origin.x,
         delta = value - FLOOR(value);
 
     if (delta)
-        frame.origin.x = value > 0.879 ? CEIL(value) : FLOOR(value);
+        aFrame.origin.x = value > 0.879 ? CEIL(value) : FLOOR(value);
 
-    value = frame.origin.y;
+    value = aFrame.origin.y;
     delta = value - FLOOR(value);
 
     if (delta)
-        frame.origin.y = value > 0.879 ? CEIL(value) : FLOOR(value);
+        aFrame.origin.y = value > 0.879 ? CEIL(value) : FLOOR(value);
 
-    value = frame.size.width;
+    value = aFrame.size.width;
     delta = value - FLOOR(value);
 
     if (delta)
-        frame.size.width = value > 0.15 ? CEIL(value) : FLOOR(value);
+        aFrame.size.width = value > 0.15 ? CEIL(value) : FLOOR(value);
 
-    value = frame.size.height;
+    value = aFrame.size.height;
     delta = value - FLOOR(value);
 
     if (delta)
-        frame.size.height = value > 0.15 ? CEIL(value) : FLOOR(value);
-
-    frame = [self _constrainFrame:frame toUsableScreenWidth:shouldConstrainWidth andHeight:shouldConstrainHeight];
+        aFrame.size.height = value > 0.15 ? CEIL(value) : FLOOR(value);
 
     if (shouldAnimate)
     {
         [_frameAnimation stopAnimation];
-        _frameAnimation = [[_CPWindowFrameAnimation alloc] initWithWindow:self targetFrame:frame];
+        _frameAnimation = [[_CPWindowFrameAnimation alloc] initWithWindow:self targetFrame:aFrame];
 
         [_frameAnimation startAnimation];
     }
     else
     {
         var origin = _frame.origin,
-            newOrigin = frame.origin,
-            originMoved = !CGPointEqualToPoint(origin, newOrigin);
+            newOrigin = aFrame.origin,
+            originMoved = !_CGPointEqualToPoint(origin, newOrigin);
 
         if (originMoved)
         {
-            delta = CGPointMake(newOrigin.x - origin.x, newOrigin.y - origin.y);
+            delta = _CGPointMake(newOrigin.x - origin.x, newOrigin.y - origin.y);
             origin.x = newOrigin.x;
             origin.y = newOrigin.y;
 
@@ -703,17 +692,13 @@ CPTexturedBackgroundWindowMask
             }
 #endif
 
-            // reposition sheet
-            if ([self attachedSheet])
-                [self _setAttachedSheetFrameOrigin];
-
             [[CPNotificationCenter defaultCenter] postNotificationName:CPWindowDidMoveNotification object:self];
         }
 
         var size = _frame.size,
-            newSize = frame.size;
+            newSize = aFrame.size;
 
-        if (!CGSizeEqualToSize(size, newSize))
+        if (!_CGSizeEqualToSize(size, newSize))
         {
             size.width = newSize.width;
             size.height = newSize.height;
@@ -735,87 +720,13 @@ CPTexturedBackgroundWindowMask
     }
 }
 
-- (CGRect)_constrainFrame:(CGRect)aFrame toUsableScreenWidth:(BOOL)constrainWidth andHeight:(BOOL)constrainHeight
-{
-    var frame = CGRectMakeCopy(aFrame);
-
-    if (!_constrainsToUsableScreen || !_isVisible)
-        return frame;
-
-    var usableRect = [_platformWindow usableContentFrame];
-
-    if (constrainWidth)
-    {
-        // First move the frame right to ensure the left side is within the usable rect.
-        frame.origin.x = MAX(frame.origin.x, usableRect.origin.x);
-
-        // Now move the frame left so that the right side is within the usable rect.
-        var maxX = MIN(CGRectGetMaxX(frame), CGRectGetMaxX(usableRect));
-        frame.origin.x = maxX - frame.size.width;
-
-        // Finally, adjust the left + width to ensure the left side is within the usable rect.
-        var usableWidth = CGRectGetWidth(usableRect);
-
-        if (CGRectGetWidth(frame) > usableWidth)
-        {
-            frame.origin.x = CGRectGetMinX(usableRect);
-            frame.size.width = usableWidth;
-        }
-    }
-
-    if (constrainHeight)
-    {
-        // First move the frame down to ensure the top is within the usable rect.
-        frame.origin.y = MAX(frame.origin.y, usableRect.origin.y);
-
-        // Now move the frame up so that the bottom is within the usable rect.
-        var maxY = MIN(CGRectGetMaxY(frame), CGRectGetMaxY(usableRect));
-        frame.origin.y = maxY - frame.size.height;
-
-        // Finally, adjust the top + height to ensure the top is within the usable rect.
-        var usableHeight = CGRectGetHeight(usableRect);
-
-        if (CGRectGetHeight(frame) > usableHeight)
-        {
-            frame.origin.y = CGRectGetMinY(usableRect);
-            frame.size.height = usableHeight;
-        }
-    }
-
-    return frame;
-}
-
-- (CGRect)_constrainOriginOfFrame:(CGRect)aFrame
-{
-    var frame = CGRectMakeCopy(aFrame);
-
-    if (!_constrainsToUsableScreen || !_isVisible)
-        return frame;
-
-    /*
-        - CPWindowMinVisibleHorizontalMargin is kept onscreen at the left/right of the window.
-        - The top of the window is kept below the top of the usable content.
-        - The top of the contentView + CPWindowMinVisibleVerticalMargin is kept above the bottom of the usable content.
-    */
-    var usableRect = [_platformWindow usableContentFrame],
-        maxUsableY = CGRectGetMaxY(usableRect) - CGRectGetMinY([_contentView frame]) - CPWindowMinVisibleVerticalMargin;
-
-    frame.origin.x = MAX(frame.origin.x, CGRectGetMinX(usableRect) + CPWindowMinVisibleHorizontalMargin - CGRectGetWidth(frame));
-    frame.origin.x = MIN(frame.origin.x, CGRectGetMaxX(usableRect) - CPWindowMinVisibleHorizontalMargin);
-
-    frame.origin.y = MAX(frame.origin.y, CGRectGetMinY(usableRect));
-    frame.origin.y = MIN(frame.origin.y, maxUsableY);
-
-    return frame;
-}
-
 - (void)_moveChildWindows:(CGPoint)delta
 {
     [_childWindows enumerateObjectsUsingBlock:function(childWindow)
         {
             var origin = [childWindow frame].origin;
 
-            [childWindow setFrameOrigin:CGPointMake(origin.x + delta.x, origin.y + delta.y)];
+            [childWindow setFrameOrigin:_CGPointMake(origin.x + delta.x, origin.y + delta.y)];
         }
     ];
 }
@@ -845,8 +756,11 @@ CPTexturedBackgroundWindowMask
 */
 - (void)setFrameOrigin:(CGPoint)anOrigin
 {
-    var frame = [self _constrainOriginOfFrame:CGRectMake(anOrigin.x, anOrigin.y, _frame.size.width, _frame.size.height)];
-    [self _setFrame:frame display:YES animate:NO constrainWidth:NO constrainHeight:NO];
+    [self setFrame:_CGRectMake(anOrigin.x, anOrigin.y, _CGRectGetWidth(_frame), _CGRectGetHeight(_frame)) display:YES animate:NO];
+
+    // reposition sheet
+    if ([self attachedSheet])
+        [self _setAttachedSheetFrameOrigin];
 }
 
 /*!
@@ -855,7 +769,7 @@ CPTexturedBackgroundWindowMask
 */
 - (void)setFrameSize:(CGSize)aSize
 {
-    [self setFrame:CGRectMake(CGRectGetMinX(_frame), CGRectGetMinY(_frame), aSize.width, aSize.height) display:YES animate:NO];
+    [self setFrame:_CGRectMake(_CGRectGetMinX(_frame), _CGRectGetMinY(_frame), aSize.width, aSize.height) display:YES animate:NO];
 }
 
 /*!
@@ -871,14 +785,13 @@ CPTexturedBackgroundWindowMask
 {
 #if PLATFORM(DOM)
     // -dw- if a sheet is clicked, the parent window should come up too
-    if (_isSheet)
+    if ([self isSheet])
         [_parentView orderFront:self];
 
-    if (!_isVisible)
-        [self _setFrame:_frame display:YES animate:NO constrainWidth:YES constrainHeight:YES];
-
     [_platformWindow orderFront:self];
     [_platformWindow order:CPWindowAbove window:self relativeTo:nil];
+#else
+    _isVisible = YES;
 #endif
 
     if (!CPApp._keyWindow)
@@ -943,6 +856,8 @@ CPTexturedBackgroundWindowMask
         [_platformWindow orderOut:self];
 
     [_platformWindow order:CPWindowOut window:self relativeTo:nil];
+#else
+    _isVisible = NO;
 #endif
 
     [self _updateMainAndKeyWindows];
@@ -985,7 +900,6 @@ CPTexturedBackgroundWindowMask
     [_platformWindow moveWindow:self fromLevel:_level toLevel:aLevel];
 
     _level = aLevel;
-    [_childWindows makeObjectsPerformSelector:@selector(setLevel:) withObject:_level];
 
     if ([self _sharesChromeWithPlatformWindow])
         [_platformWindow setLevel:aLevel];
@@ -1084,7 +998,7 @@ CPTexturedBackgroundWindowMask
     if (_contentView)
         [_contentView removeFromSuperview];
 
-    var bounds = CGRectMake(0.0, 0.0, CGRectGetWidth(_frame), CGRectGetHeight(_frame));
+    var bounds = _CGRectMake(0.0, 0.0, _CGRectGetWidth(_frame), _CGRectGetHeight(_frame));
 
     _contentView = aView;
     [_contentView setFrame:[self contentRectForFrameRect:bounds]];
@@ -1151,12 +1065,12 @@ CPTexturedBackgroundWindowMask
 */
 - (void)setMinSize:(CGSize)aSize
 {
-    if (CGSizeEqualToSize(_minSize, aSize))
+    if (_CGSizeEqualToSize(_minSize, aSize))
         return;
 
     _minSize = [self _calculateMinSizeForProposedSize:aSize];
 
-    var size = CGSizeMakeCopy([self frame].size),
+    var size = _CGSizeMakeCopy([self frame].size),
         needsFrameChange = NO;
 
     if (size.width < _minSize.width)
@@ -1187,9 +1101,9 @@ CPTexturedBackgroundWindowMask
 - (CGSize)_calculateMinSizeForProposedSize:(CGSize)proposedSize
 {
     var contentFrame = [self contentRectForFrameRect:_frame],
-        minHeight = CGRectGetHeight(_frame) - CGRectGetHeight(contentFrame);
+        minHeight = _CGRectGetHeight(_frame) - _CGRectGetHeight(contentFrame);
 
-    return CGSizeMake(MAX(proposedSize.width, 0), MAX(proposedSize.height, minHeight));
+    return _CGSizeMake(MAX(proposedSize.width, 0), MAX(proposedSize.height, minHeight));
 }
 
 /*!
@@ -1200,12 +1114,12 @@ CPTexturedBackgroundWindowMask
 */
 - (void)setMaxSize:(CGSize)aSize
 {
-    if (CGSizeEqualToSize(_maxSize, aSize))
+    if (_CGSizeEqualToSize(_maxSize, aSize))
         return;
 
-    _maxSize = CGSizeMakeCopy(aSize);
+    _maxSize = _CGSizeMakeCopy(aSize);
 
-    var size = CGSizeMakeCopy([self frame].size),
+    var size = _CGSizeMakeCopy([self frame].size),
         needsFrameChange = NO;
 
     if (size.width > _maxSize.width)
@@ -1259,7 +1173,7 @@ CPTexturedBackgroundWindowMask
 
     if (_hasShadow && !_shadowView)
     {
-        _shadowView = [[_CPShadowWindowView alloc] initWithFrame:CGRectMakeZero()];
+         _shadowView = [[_CPShadowWindowView alloc] initWithFrame:CGRectMakeZero()];
 
         [_shadowView setWindowView:_windowView];
         [_shadowView setAutoresizingMask:CPViewWidthSizable | CPViewHeightSizable];
@@ -1544,6 +1458,8 @@ CPTexturedBackgroundWindowMask
 
     [_windowView setTitle:aTitle];
     [_platformWindow _setTitle:_title window:self];
+
+    [self _synchronizeMenuBarTitleWithWindowTitle];
 }
 
 /*!
@@ -1640,7 +1556,7 @@ CPTexturedBackgroundWindowMask
     var size = [self frame].size,
         containerSize = [CPPlatform isBrowser] ? [_platformWindow contentBounds].size : [[self screen] visibleFrame].size;
 
-    var origin = CGPointMake((containerSize.width - size.width) / 2.0, (containerSize.height - size.height) / 2.0);
+    var origin = _CGPointMake((containerSize.width - size.width) / 2.0, (containerSize.height - size.height) / 2.0);
 
     if (origin.x < 0.0)
         origin.x = 0.0;
@@ -1658,12 +1574,13 @@ CPTexturedBackgroundWindowMask
 - (void)sendEvent:(CPEvent)anEvent
 {
     var type = [anEvent type],
-        sheet = [self attachedSheet];
+        point = [anEvent locationInWindow];
 
     // If a sheet is attached events get filtered here.
     // It is not clear what events should be passed to the view, perhaps all?
     // CPLeftMouseDown is needed for window moving and resizing to work.
     // CPMouseMoved is needed for rollover effects on title bar buttons.
+    var sheet = [self attachedSheet];
 
     if (sheet)
     {
@@ -1675,19 +1592,14 @@ CPTexturedBackgroundWindowMask
                 // -dw- if the window is clicked, the sheet should come to front, and become key,
                 // and the window should be immediately behind
                 [sheet makeKeyAndOrderFront:self];
-                return;
-
-            case CPMouseMoved:
-                // Allow these through to the parent
                 break;
-
-            default:
-                // Everything else is filtered
-                return;
+            case CPMouseMoved:
+                [_windowView mouseMoved:anEvent];
+                break;
         }
-    }
 
-    var point = [anEvent locationInWindow];
+        return;
+    }
 
     switch (type)
     {
@@ -1809,8 +1721,7 @@ CPTexturedBackgroundWindowMask
         case CPMouseMoved:
             [_windowView setCursorForLocation:point resizing:NO];
 
-            // Ignore mouse moves for parents of sheets
-            if (!_acceptsMouseMovedEvents || sheet)
+            if (!_acceptsMouseMovedEvents)
                 return;
 
             if (!_mouseEnteredStack)
@@ -2327,13 +2238,6 @@ CPTexturedBackgroundWindowMask
 */
 - (void)makeMainWindow
 {
-    // Sheets cannot be main. Their parent window becomes main.
-    if (_isSheet)
-    {
-        [_parentView makeMainWindow];
-        return;
-    }
-
     if ([CPApp mainWindow] === self || ![self canBecomeMainWindow])
         return;
 
@@ -2348,6 +2252,7 @@ CPTexturedBackgroundWindowMask
 {
     CPApp._mainWindow = self;
 
+    [self _synchronizeMenuBarTitleWithWindowTitle];
     [self _synchronizeSaveMenuWithDocumentSaving];
 
     [_windowView noteMainWindowStateChanged];
@@ -2486,7 +2391,7 @@ CPTexturedBackgroundWindowMask
 
 - (void)_noteToolbarChanged
 {
-    var frame = CGRectMakeCopy([self frame]),
+    var frame = _CGRectMakeCopy([self frame]),
         newFrame;
 
     [_windowView noteToolbarChanged];
@@ -2495,7 +2400,7 @@ CPTexturedBackgroundWindowMask
         newFrame = [_platformWindow visibleFrame];
     else
     {
-        newFrame = CGRectMakeCopy([self frame]);
+        newFrame = _CGRectMakeCopy([self frame]);
 
         newFrame.origin = frame.origin;
     }
@@ -2531,7 +2436,6 @@ CPTexturedBackgroundWindowMask
 
     [childWindow setParentWindow:self];
     [childWindow _setChildOrdering:orderingMode];
-    [childWindow setLevel:[self level]];
 
     if ([self isVisible] && ![childWindow isVisible])
         [childWindow orderWindow:orderingMode relativeTo:_windowNumber];
@@ -2589,24 +2493,25 @@ CPTexturedBackgroundWindowMask
     return CPWindowResizeTime;
 }
 
+/* @ignore */
 - (void)_setAttachedSheetFrameOrigin
 {
     // Position the sheet above the contentRect.
     var attachedSheet = [self attachedSheet],
         contentRect = [_contentView frame],
-        sheetFrame = CGRectMakeCopy([attachedSheet frame]);
+        sheetFrame = _CGRectMakeCopy([attachedSheet frame]);
 
-    sheetFrame.origin.y = CGRectGetMinY(_frame) + CGRectGetMinY(contentRect);
-    sheetFrame.origin.x = CGRectGetMinX(_frame) + FLOOR((CGRectGetWidth(_frame) - CGRectGetWidth(sheetFrame)) / 2.0);
+    sheetFrame.origin.y = _CGRectGetMinY(_frame) + _CGRectGetMinY(contentRect);
+    sheetFrame.origin.x = _CGRectGetMinX(_frame) + FLOOR((_CGRectGetWidth(_frame) - _CGRectGetWidth(sheetFrame)) / 2.0);
 
     [attachedSheet setFrame:sheetFrame display:YES animate:NO];
 }
 
-/*
+/* @ignore
     Starting point for sheet session, called from CPApplication beginSheet:
 */
 - (void)_attachSheet:(CPWindow)aSheet modalDelegate:(id)aModalDelegate
-        didEndSelector:(SEL)didEndSelector contextInfo:(id)contextInfo
+        didEndSelector:(SEL)aDidEndSelector contextInfo:(id)aContextInfo
 {
     if (_sheetContext)
     {
@@ -2615,21 +2520,24 @@ CPTexturedBackgroundWindowMask
         return;
     }
 
-    _sheetContext = {
-        "sheet": aSheet,
-        "modalDelegate": aModalDelegate,
-        "endSelector": didEndSelector,
-        "contextInfo": contextInfo,
-        "returnCode": -1,
-        "opened": NO,
-        "isAttached": YES,
-        "savedConstrains": aSheet._constrainsToUsableScreen
-    };
+    var sheetFrame = [aSheet frame];
 
-    // Sheets are not constrained, they are controlled by their parent
-    aSheet._constrainsToUsableScreen = NO;
+    _sheetContext = {"sheet": aSheet, "modalDelegate": aModalDelegate, "endSelector": aDidEndSelector,
+        "contextInfo": aContextInfo, "frame": _CGRectMakeCopy(sheetFrame), "returnCode": -1,
+        "opened": NO};
 
-    // A timer seems to be necessary for the animation to work correctly
+    [self _attachSheetWindow];
+}
+
+/* @ignore
+    Called to animate the sheet in. The timer seems to solve a bug where sheets would
+    be partially animated under certain conditions.
+*/
+- (void)_attachSheetWindow
+{
+    _sheetContext["isAttached"] = YES;
+
+    // it would be ideal to block here and spin an event loop, until attach is complete
     [CPTimer scheduledTimerWithTimeInterval:0.0
         target:self
         selector:@selector(_sheetShouldAnimateIn:)
@@ -2637,7 +2545,7 @@ CPTexturedBackgroundWindowMask
         repeats:NO];
 }
 
-/*
+/* @ignore
     Called to end the sheet. Note that orderOut: is needed to animate the sheet out, as in Cocoa.
     The sheet isn't completely gone until _cleanupSheetWindow gets called.
 */
@@ -2658,7 +2566,7 @@ CPTexturedBackgroundWindowMask
     }
 }
 
-/*
+/* @ignore
     Called to animate the sheet out. If called while animating in, schedules an animate
     out at completion
 */
@@ -2666,8 +2574,7 @@ CPTexturedBackgroundWindowMask
 {
     _sheetContext["isAttached"] = NO;
 
-    // A timer seems to be necessary for the animation to work correctly.
-    // It would be ideal to block here and spin the event loop, until attach is complete.
+    // it would be ideal to block here and spin the event loop, until attach is complete
     [CPTimer scheduledTimerWithTimeInterval:0.0
         target:self
         selector:@selector(_sheetShouldAnimateOut:)
@@ -2675,26 +2582,27 @@ CPTexturedBackgroundWindowMask
         repeats:NO];
 }
 
-/*
+/* @ignore
     Called to cleanup sheet, when we are definitely done with it
 */
 - (void)_cleanupSheetWindow
 {
     var sheet = _sheetContext["sheet"],
+        lastFrame = _sheetContext["frame"],
         deferDidEnd = _sheetContext["deferDidEndSelector"];
 
-    // If the parent window is modal, the sheet started its own modal session
+    [sheet setFrame:lastFrame];
+    [self _restoreMasksForView:[sheet contentView]];
+
+    // if the parent window is modal, the sheet started its own modal session
     if (sheet._isModal)
         [CPApp stopModal];
 
-    [self _removeClipForSheet:sheet];
+    // restore the state of window before it was sheetified
+    [sheet._windowView _enableSheet:NO];
 
-    // Restore the state of window before it was sheetified
+    // close it
     sheet._isSheet = NO;
-    [sheet._windowView _enableSheet:NO inWindow:self];
-    sheet._constrainsToUsableScreen = _sheetContext["savedConstrains"];
-
-    // Close it
     [sheet orderOut:self];
 
     [[CPNotificationCenter defaultCenter] postNotificationName:CPWindowDidEndSheetNotification object:self];
@@ -2706,7 +2614,7 @@ CPTexturedBackgroundWindowMask
             returnCode = _sheetContext["returnCode"],
             contextInfo = _sheetContext["contextInfo"];
 
-        // Context must be destroyed, since didEnd might want to attach another sheet
+        // context must be destroyed, since didEnd might want to attach another sheet
         _sheetContext = nil;
         sheet._parentView = nil;
 
@@ -2734,19 +2642,31 @@ CPTexturedBackgroundWindowMask
         repeats:NO];
 }
 
+/* @ignore */
 - (void)_sheetShouldAnimateIn:(CPTimer)timer
 {
-    // Can't open sheet while opening or closing animation is going on
-    if (_sheetContext["isOpening"] || _sheetContext["isClosing"])
+    // can't open sheet while opening or closing animation is going on
+    if (_sheetContext["isOpening"] ||
+        _sheetContext["isClosing"])
         return;
 
-    var sheet = _sheetContext["sheet"];
+    var sheet = _sheetContext["sheet"],
+        sheetFrame = [sheet frame],
+        frame = [self frame];
+
+    [self _setUpMasksForView:[sheet contentView]];
+
     sheet._isSheet = YES;
     sheet._parentView = self;
 
+    var originx = frame.origin.x + FLOOR((frame.size.width - sheetFrame.size.width) / 2),
+        originy = frame.origin.y + [_contentView frame].origin.y,
+        startFrame = _CGRectMake(originx, originy, sheetFrame.size.width, 0),
+        endFrame = _CGRectMake(originx, originy, sheetFrame.size.width, sheetFrame.size.height);
+
     [[CPNotificationCenter defaultCenter] postNotificationName:CPWindowWillBeginSheetNotification object:self];
 
-    // If sheet is attached to a modal window, the sheet runs
+    // if sheet is attached to a modal window, the sheet runs
     // as if itself and the parent window are modal
     sheet._isModal = NO;
 
@@ -2756,29 +2676,7 @@ CPTexturedBackgroundWindowMask
         sheet._isModal = YES;
     }
 
-    // The sheet starts hidden just above the top of a clip rect
-    // TODO : Make properly for the -1 in endY
-    var sheetFrame = [sheet frame],
-        sheetShadowFrame = sheet._hasShadow ? [sheet._shadowView frame] : sheetFrame,
-        frame = [self frame],
-        originX = frame.origin.x + FLOOR((frame.size.width - sheetFrame.size.width) / 2),
-        startFrame = CGRectMake(originX, -sheetShadowFrame.size.height, sheetFrame.size.width, sheetFrame.size.height),
-        endY = -1 + [_windowView bodyOffset] - [[self contentView] frame].origin.y,
-        endFrame = CGRectMake(originX, endY, sheetFrame.size.width, sheetFrame.size.height);
-
-    if (_toolbar && [_windowView showsToolbar] && [self isFullPlatformWindow])
-    {
-        endY    += [[_toolbar _toolbarView] frameSize].height;
-        endFrame = CGRectMake(originX, endY, sheetFrame.size.width, sheetFrame.size.height);
-    }
-
-    // Move the sheet offscreen before ordering front so it doesn't appear briefly
-    [sheet setFrameOrigin:CGPointMake(0, -13000)];
-
-    // Because clipping does funny thing with the DOM, we have to orderFront before clipping
     [sheet orderFront:self];
-    [self _clipSheet:sheet];
-
     [sheet setFrame:startFrame display:YES animate:NO];
 
     _sheetContext["opened"] = YES;
@@ -2786,13 +2684,23 @@ CPTexturedBackgroundWindowMask
     _sheetContext["isOpening"] = YES;
 
     [sheet _setFrame:endFrame delegate:self duration:[self animationResizeTime:endFrame] curve:CPAnimationEaseOut];
+
+    // NOTE: cocoa doesn't make window key until animation is done, but a
+    // keypress while animating eventually gets to the window. Therefore,
+    // there must be a runloop specifically designed for sheets?
+    [sheet makeKeyWindow];
 }
 
+/* @ignore */
 - (void)_sheetShouldAnimateOut:(CPTimer)timer
 {
+    var sheet = _sheetContext["sheet"],
+        startFrame = [sheet frame],
+        endFrame = _CGRectMakeCopy(startFrame);
+
     if (_sheetContext["isOpening"])
     {
-        // Allow sheet to be closed while opening, it will close when animate in completes
+        // allow sheet to be closed while opening, it will close when animate in completes
         _sheetContext["shouldClose"] = YES;
         return;
     }
@@ -2801,24 +2709,14 @@ CPTexturedBackgroundWindowMask
         return;
 
     _sheetContext["opened"] = NO;
+    _sheetContext["frame"] = startFrame;
     _sheetContext["isClosing"] = YES;
 
-    // The parent window can be orderedOut to disable the sheet animate out, as in Cocoa
+    // the parent window can be orderedOut to disable the sheet animate out, as in Cocoa
     if ([self isVisible])
     {
-        var sheet = _sheetContext["sheet"],
-            sheetFrame = [sheet frame],
-            fullHeight = sheet._hasShadow ? [sheet._shadowView frame].size.height : sheetFrame.size.height,
-            endFrame = CGRectMakeCopy(sheetFrame),
-            contentOrigin = [self convertBaseToGlobal:[[self contentView] frame].origin];
-
-        // Don't constrain sheets, they are controlled by the parent
-        sheet._constrainsToUsableScreen = NO;
-
-        [sheet setFrameOrigin:CGPointMake(sheetFrame.origin.x, sheetFrame.origin.y - contentOrigin.y)];
-        [self _clipSheet:sheet];
-
-        endFrame.origin.y = -fullHeight;
+        endFrame.size.height = 0;
+        [self _setUpMasksForView:[sheet contentView]];
         [sheet _setFrame:endFrame delegate:self duration:[self animationResizeTime:endFrame] curve:CPAnimationEaseIn];
     }
     else
@@ -2827,6 +2725,7 @@ CPTexturedBackgroundWindowMask
     }
 }
 
+/* @ignore */
 - (void)_sheetAnimationDidEnd:(CPTimer)timer
 {
     var sheet = _sheetContext["sheet"];
@@ -2836,17 +2735,12 @@ CPTexturedBackgroundWindowMask
 
     if (_sheetContext["opened"] === YES)
     {
-        var sheetFrame = [sheet frame],
-            sheetOrigin = CGPointMakeCopy(sheetFrame.origin);
-
-        [self _removeClipForSheet:sheet];
-        [sheet setFrameOrigin:CGPointMake(sheetOrigin.x, [sheet frame].origin.y + sheetOrigin.y)];
+        // sheet is open and completely visible
+        [self _restoreMasksForView:[sheet contentView]];
 
         // we wanted to close the sheet while it animated in, do that now
         if (_sheetContext["shouldClose"] === YES)
             [self _detachSheetWindow];
-        else
-            [sheet makeKeyWindow];
     }
     else
     {
@@ -2855,17 +2749,36 @@ CPTexturedBackgroundWindowMask
     }
 }
 
-- (void)_clipSheet:(CPWindow)aSheet
+- (void)_setUpMasksForView:(CPView)aView
 {
-    var clipRect = [_platformWindow contentBounds];
-    clipRect.origin.y = [self frame].origin.y + [[self contentView] frame].origin.y;
+    var views = [aView subviews];
 
-    [[_platformWindow layerAtLevel:_level create:NO] clipWindow:aSheet toRect:clipRect];
+    [views addObject:aView];
+
+    for (var i = 0, count = [views count]; i < count; i++)
+    {
+        var view = [views objectAtIndex:i],
+            mask = [view autoresizingMask],
+            maskToAdd = (mask & CPViewMinYMargin) ? 128 : CPViewMinYMargin;
+
+        [view setAutoresizingMask:(mask | maskToAdd)];
+    }
 }
 
-- (void)_removeClipForSheet:(CPWindow)aSheet
+- (void)_restoreMasksForView:(CPView)aView
 {
-    [[_platformWindow layerAtLevel:_level create:NO] removeClipForWindow:aSheet];
+    var views = [aView subviews];
+
+    [views addObject:aView];
+
+    for (var i = 0, count = [views count]; i < count; i++)
+    {
+        var view = [views objectAtIndex:i],
+            mask = [view autoresizingMask],
+            maskToRemove = (mask & 128) ? 128 : CPViewMinYMargin;
+
+        [view setAutoresizingMask:(mask & (~ maskToRemove))];
+    }
 }
 
 /*!
@@ -3232,11 +3145,11 @@ var keyViewComparator = function(lhs, rhs, context)
 {
     var lhsBounds = [lhs convertRect:[lhs bounds] toView:nil],
         rhsBounds = [rhs convertRect:[rhs bounds] toView:nil],
-        lhsY = CGRectGetMinY(lhsBounds),
-        rhsY = CGRectGetMinY(rhsBounds),
-        lhsX = CGRectGetMinX(lhsBounds),
-        rhsX = CGRectGetMinX(rhsBounds),
-        intersectsVertically = MIN(CGRectGetMaxY(lhsBounds), CGRectGetMaxY(rhsBounds)) - MAX(lhsY, rhsY);
+        lhsY = _CGRectGetMinY(lhsBounds),
+        rhsY = _CGRectGetMinY(rhsBounds),
+        lhsX = _CGRectGetMinX(lhsBounds),
+        rhsX = _CGRectGetMinX(rhsBounds),
+        intersectsVertically = MIN(_CGRectGetMaxY(lhsBounds), _CGRectGetMaxY(rhsBounds)) - MAX(lhsY, rhsY);
 
     // If two views are "on the same line" (intersect vertically), then rely on the x comparison.
     if (intersectsVertically > 0)
@@ -3259,6 +3172,19 @@ var keyViewComparator = function(lhs, rhs, context)
     return CPOrderedDescending;
 };
 
+@implementation CPWindow (MenuBar)
+
+- (void)_synchronizeMenuBarTitleWithWindowTitle
+{
+    // Windows with Documents automatically update the native window title and the menu bar title.
+    if (![_windowController document] || ![self isMainWindow])
+        return;
+
+    [CPMenu setMenuBarTitle:_title];
+}
+
+@end
+
 @implementation CPWindow (BridgeSupport)
 
 /*
@@ -3269,25 +3195,23 @@ var keyViewComparator = function(lhs, rhs, context)
     if ([self isFullPlatformWindow])
         return [self setFrame:[_platformWindow visibleFrame]];
 
-    if (_autoresizingMask === CPWindowNotSizable)
+    if (_autoresizingMask == CPWindowNotSizable)
         return;
 
     var frame = [_platformWindow contentBounds],
-        newFrame = CGRectMakeCopy(_frame),
-        dX = (CGRectGetWidth(frame) - aSize.width) /
+        newFrame = _CGRectMakeCopy(_frame),
+        dX = (_CGRectGetWidth(frame) - aSize.width) /
             (((_autoresizingMask & CPWindowMinXMargin) ? 1 : 0) + (_autoresizingMask & CPWindowWidthSizable ? 1 : 0) + (_autoresizingMask & CPWindowMaxXMargin ? 1 : 0)),
-        dY = (CGRectGetHeight(frame) - aSize.height) /
+        dY = (_CGRectGetHeight(frame) - aSize.height) /
             ((_autoresizingMask & CPWindowMinYMargin ? 1 : 0) + (_autoresizingMask & CPWindowHeightSizable ? 1 : 0) + (_autoresizingMask & CPWindowMaxYMargin ? 1 : 0));
 
     if (_autoresizingMask & CPWindowMinXMargin)
         newFrame.origin.x += dX;
-
     if (_autoresizingMask & CPWindowWidthSizable)
         newFrame.size.width += dX;
 
     if (_autoresizingMask & CPWindowMinYMargin)
         newFrame.origin.y += dY;
-
     if (_autoresizingMask & CPWindowHeightSizable)
         newFrame.size.height += dY;
 
@@ -3332,11 +3256,11 @@ var keyViewComparator = function(lhs, rhs, context)
 - (CGPoint)convertBaseToPlatformWindow:(CGPoint)aPoint
 {
     if ([self _sharesChromeWithPlatformWindow])
-        return CGPointMakeCopy(aPoint);
+        return _CGPointMakeCopy(aPoint);
 
     var origin = [self frame].origin;
 
-    return CGPointMake(aPoint.x + origin.x, aPoint.y + origin.y);
+    return _CGPointMake(aPoint.x + origin.x, aPoint.y + origin.y);
 }
 
 /*!
@@ -3345,11 +3269,11 @@ var keyViewComparator = function(lhs, rhs, context)
 - (CGPoint)convertPlatformWindowToBase:(CGPoint)aPoint
 {
     if ([self _sharesChromeWithPlatformWindow])
-        return CGPointMakeCopy(aPoint);
+        return _CGPointMakeCopy(aPoint);
 
     var origin = [self frame].origin;
 
-    return CGPointMake(aPoint.x - origin.x, aPoint.y - origin.y);
+    return _CGPointMake(aPoint.x - origin.x, aPoint.y - origin.y);
 }
 
 - (CGPoint)convertScreenToBase:(CGPoint)aPoint
@@ -3425,7 +3349,7 @@ var keyViewComparator = function(lhs, rhs, context)
 
 - (BOOL)containsPoint:(CGPoint)aPoint
 {
-    return CGRectContainsPoint(_frame, aPoint);
+    return _CGRectContainsPoint(_frame, aPoint);
 }
 
 /* aPoint should be global */
@@ -3433,9 +3357,9 @@ var keyViewComparator = function(lhs, rhs, context)
 {
     // If we are using the new resizing mode, mouse events are valid
     // outside the window's frame for non-full platform windows.
-    var mouseFrame = (!_isFullPlatformWindow && (_styleMask & CPResizableWindowMask) && (CPWindowResizeStyle === CPWindowResizeStyleModern)) ? CGRectInset(_frame, -_CPWindowViewResizeSlop, -_CPWindowViewResizeSlop) : _frame;
+    var mouseFrame = (!_isFullPlatformWindow && (_styleMask & CPResizableWindowMask) && (CPWindowResizeStyle === CPWindowResizeStyleModern)) ? _CGRectInset(_frame, -_CPWindowViewResizeSlop, -_CPWindowViewResizeSlop) : _frame;
 
-    return CGRectContainsPoint(mouseFrame, aPoint);
+    return _CGRectContainsPoint(mouseFrame, aPoint);
 }
 
 @end
@@ -3501,8 +3425,8 @@ var interpolate = function(fromValue, toValue, progress)
     {
         _window = aWindow;
 
-        _targetFrame = CGRectMakeCopy(aTargetFrame);
-        _startFrame = CGRectMakeCopy([_window frame]);
+        _targetFrame = _CGRectMakeCopy(aTargetFrame);
+        _startFrame = _CGRectMakeCopy([_window frame]);
     }
 
     return self;
@@ -3524,11 +3448,11 @@ var interpolate = function(fromValue, toValue, progress)
     if (value == 1.0)
         _window._isAnimating = NO;
 
-    var newFrame = CGRectMake(
-            interpolate(CGRectGetMinX(_startFrame), CGRectGetMinX(_targetFrame), value),
-            interpolate(CGRectGetMinY(_startFrame), CGRectGetMinY(_targetFrame), value),
-            interpolate(CGRectGetWidth(_startFrame), CGRectGetWidth(_targetFrame), value),
-            interpolate(CGRectGetHeight(_startFrame), CGRectGetHeight(_targetFrame), value));
+    var newFrame = _CGRectMake(
+            interpolate(_CGRectGetMinX(_startFrame), _CGRectGetMinX(_targetFrame), value),
+            interpolate(_CGRectGetMinY(_startFrame), _CGRectGetMinY(_targetFrame), value),
+            interpolate(_CGRectGetWidth(_startFrame), _CGRectGetWidth(_targetFrame), value),
+            interpolate(_CGRectGetHeight(_startFrame), _CGRectGetHeight(_targetFrame), value));
 
     [_window setFrame:newFrame display:YES animate:NO];
 }

AppKit/CPWindow/_CPDocModalWindowView.j

@@ -26,6 +26,7 @@
 @implementation _CPDocModalWindowView : _CPWindowView
 {
     CPView _bodyView;
+    CPView _shadowView;
 }
 
 + (CPString)defaultThemeClass
@@ -37,7 +38,7 @@
 {
     return @{
             @"body-color": [CPColor whiteColor],
-            @"shadow-height": 8,
+            @"height-shadow": 8,
         };
 }
 
@@ -49,7 +50,7 @@
     */
     var contentRect = [super contentRectForFrameRect:aFrameRect];
 
-    return CGRectInset(contentRect, 1.0, 1.0);
+    return _CGRectInset(contentRect, 1.0, 1.0);
 }
 
 - (id)initWithFrame:(CGRect)aFrame styleMask:(unsigned)aStyleMask
@@ -60,13 +61,17 @@
     {
         var bounds = [self bounds];
 
-        _bodyView = [[CPView alloc] initWithFrame:CGRectMake(0.0, 0.0, CGRectGetWidth(bounds), CGRectGetHeight(bounds))];
+       _bodyView = [[CPView alloc] initWithFrame:_CGRectMake(0.0, 0.0, _CGRectGetWidth(bounds), _CGRectGetHeight(bounds))];
 
         [_bodyView setAutoresizingMask:CPViewWidthSizable | CPViewHeightSizable];
         [_bodyView setHitTests:NO];
 
         [self addSubview:_bodyView];
-    }
+
+        _shadowView = [[CPView alloc] initWithFrame:CGRectMake(0, 0, _CGRectGetWidth(bounds), [self valueForThemeAttribute:@"height-shadow"])];
+        [_shadowView setAutoresizingMask:CPViewWidthSizable];
+        [self addSubview:_shadowView];
+     }
 
     return self;
 }
@@ -81,6 +86,11 @@
     return [[self class] frameRectForContentRect:aContentRect];
 }
 
+- (void)_enableSheet:(BOOL)enable
+{
+    // do nothing, already a sheet
+}
+
 - (void)layoutSubviews
 {
     [super layoutSubviews];
@@ -88,11 +98,9 @@
     var bounds = [self bounds];
 
     [_bodyView setBackgroundColor:[self valueForThemeAttribute:@"body-color"]];
-}
 
-- (int)bodyOffset
-{
-    return [_bodyView frame].origin.y;
+    [_shadowView setFrame:CGRectMake(0,0, _CGRectGetWidth(bounds), [self valueForThemeAttribute:@"height-shadow"])];
+    [_shadowView setBackgroundColor:[self valueForThemeAttribute:@"attached-sheet-shadow-color"]];
 }
 
 @end

AppKit/CPWindow/_CPHUDWindowView.j

@@ -127,7 +127,7 @@
 
 - (CGSize)toolbarOffset
 {
-    return CGSizeMake(0.0, [[self class] titleBarHeight]);
+    return _CGSizeMake(0.0, [[self class] titleBarHeight]);
 }
 
 - (void)tile
@@ -136,22 +136,22 @@
 
     var theWindow = [self window],
         bounds = [self bounds],
-        width = CGRectGetWidth(bounds);
+        width = _CGRectGetWidth(bounds);
 
-    [_titleField setFrame:CGRectMake(20.0, 0, width - 40.0, [self toolbarOffset].height)];
+    [_titleField setFrame:_CGRectMake(20.0, 0, width - 40.0, [self toolbarOffset].height)];
 
     var maxY = [self toolbarMaxY];
     if ([_titleField isHidden])
         maxY -= ([self toolbarOffset]).height;
 
-    var contentRect = CGRectMake(0.0, maxY, width, CGRectGetHeight(bounds) - maxY);
+    var contentRect = _CGRectMake(0.0, maxY, width, _CGRectGetHeight(bounds) - maxY);
 
     [[theWindow contentView] setFrame:contentRect];
 }
 
-- (void)_enableSheet:(BOOL)enable inWindow:(CPWindow)parentWindow
+- (void)_enableSheet:(BOOL)enable
 {
-    // No need to call super, it just deals with the shadow view, which we don't want
+    [super _enableSheet:enable];
 
     [_closeButton setHidden:enable];
     [_titleField setHidden:enable];
@@ -164,17 +164,15 @@
     if (enable)
         dy = -dy;
 
-    var newHeight = CGRectGetMaxY(frame) + dy,
-        newWidth = CGRectGetMaxX(frame);
+    var newHeight = _CGRectGetMaxY(frame) + dy,
+        newWidth = _CGRectGetMaxX(frame);
 
     frame.size.height += dy;
 
-    [self setFrameSize:CGSizeMake(newWidth, newHeight)];
+    [self setFrameSize:_CGSizeMake(newWidth, newHeight)];
     [self tile];
     [theWindow setFrame:frame display:NO animate:NO];
     [theWindow setMovableByWindowBackground:!enable];
-
-    [self setNeedsLayout];
 }
 
 - (void)layoutSubviews

AppKit/CPWindow/_CPPopoverWindowView.j

@@ -28,10 +28,10 @@
 
 @global CPPopoverAppearanceMinimal
 
-var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
+var _CPPopoverWindowViewDefaultCursorSize = _CGSizeMake(16, 10),
     _CPPopoverWindowViewRadius = 5.0,
     _CPPopoverWindowViewStrokeWidth = 1.0,
-    _CPPopoverWindowViewShadowSize = CGSizeMake(0, 6),
+    _CPPopoverWindowViewShadowSize = _CGSizeMake(0, 6),
     _CPPopoverWindowViewShadowBlur = 15.0;
 
 /*!
@@ -71,7 +71,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
 */
 - (CGRect)contentRectForFrameRect:(CGRect)aFrameRect
 {
-    var contentRect = CGRectMakeCopy(aFrameRect),
+    var contentRect = _CGRectMakeCopy(aFrameRect),
         modifierX = 16,
         modifierY = 19;
 
@@ -79,7 +79,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
     //
     // @comment: If we use this, each time we open the popover, the content
     // view is reduced a little over and over
-    // return CGRectInset(contentRect, modifierX, modifierY);
+    // return _CGRectInset(contentRect, modifierX, modifierY);
 
     contentRect.origin.x += modifierX;
     contentRect.origin.y += modifierY;
@@ -96,7 +96,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
 */
 + (CGRect)frameRectForContentRect:(CGRect)aContentRect
 {
-    var frameRect = CGRectMakeCopy(aContentRect),
+    var frameRect = _CGRectMakeCopy(aContentRect),
         modifierX = 16,
         modifierY = 19;
 
@@ -104,7 +104,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
     // @comment: If we use this, each time we open the popover, the content
     //
     // view is reduced a little over and over
-    // return CGRectOffset(frameRect, modifierX, modifierY);
+    // return _CGRectOffset(frameRect, modifierX, modifierY);
 
     frameRect.origin.x -= modifierX;
     frameRect.origin.y -= modifierY;
@@ -124,7 +124,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
         _arrowOffsetX = 0.0;
         _arrowOffsetY = 0.0;
         _appearance = CPPopoverAppearanceMinimal;
-        _cursorSize = CGSizeMakeCopy(_CPPopoverWindowViewDefaultCursorSize);
+        _cursorSize = _CGSizeMakeCopy(_CPPopoverWindowViewDefaultCursorSize);
     }
 
     return self;
@@ -135,7 +135,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
 */
 - (void)hideCursor
 {
-    _cursorSize = CGSizeMakeZero();
+    _cursorSize = _CGSizeMakeZero();
     [self setNeedsDisplay:YES];
 }
 
@@ -144,7 +144,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
 */
 - (void)showCursor
 {
-    _cursorSize = CGSizeMakeCopy(_CPPopoverWindowViewDefaultCursorSize);
+    _cursorSize = _CGSizeMakeCopy(_CPPopoverWindowViewDefaultCursorSize);
     [self setNeedsDisplay:YES];
 }
 
@@ -190,19 +190,19 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
 
     CGContextBeginPath(context);
     CGContextSetShadowWithColor(context, shadowSize, shadowBlur, shadowColor);
-    CGContextDrawLinearGradient(context, gradient, CGPointMake(CGRectGetMidX(frame), 0.0), CGPointMake(CGRectGetMidX(frame), frame.size.height), 0);
+    CGContextDrawLinearGradient(context, gradient, _CGPointMake(_CGRectGetMidX(frame), 0.0), _CGPointMake(_CGRectGetMidX(frame), frame.size.height), 0);
 
-    var xMin = CGRectGetMinX(frame),
-        xMax = CGRectGetMaxX(frame),
-        yMin = CGRectGetMinY(frame),
-        yMax = CGRectGetMaxY(frame),
+    var xMin = _CGRectGetMinX(frame),
+        xMax = _CGRectGetMaxX(frame),
+        yMin = _CGRectGetMinY(frame),
+        yMax = _CGRectGetMaxY(frame),
         arrowMinX = CGAlignCoordinate(xMin + radius + strokeWidth),
         arrowMaxX = CGAlignCoordinate(xMax - radius - strokeWidth),
         arrowMinY = CGAlignCoordinate(yMin + radius + strokeWidth),
         arrowMaxY = CGAlignCoordinate(yMax - radius + strokeWidth),
-        arrowAnchor = CGPointMakeZero(),
-        arrowStart = CGPointMakeZero(),
-        pt = CGPointMakeZero();
+        arrowAnchor = _CGPointMakeZero(),
+        arrowStart = _CGPointMakeZero(),
+        pt = _CGPointMakeZero();
 
     // draw!
     var path = CGPathCreateMutable();
@@ -237,7 +237,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
                     pt.y = arrowMaxY - arrowWidth;
 
                 pt.x = arrowAnchor.x;
-                arrowStart = CGPointMakeCopy(pt);
+                arrowStart = _CGPointMakeCopy(pt);
                 CGPathAddLineToPoint(path, NULL, pt.x, pt.y);
 
                 // top edge -> point
@@ -279,7 +279,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
                     pt.y = arrowMaxY;
 
                 pt.x = arrowAnchor.x;
-                arrowStart = CGPointMakeCopy(pt);
+                arrowStart = _CGPointMakeCopy(pt);
                 CGPathAddLineToPoint(path, NULL, pt.x, pt.y);
 
                 // bottom edge -> point
@@ -328,7 +328,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
                     pt.x = arrowMaxX - arrowWidth;
 
                 pt.y = arrowAnchor.y;
-                arrowStart = CGPointMakeCopy(pt);
+                arrowStart = _CGPointMakeCopy(pt);
                 CGPathAddLineToPoint(path, NULL, pt.x, pt.y);
 
                 // left edge -> point
@@ -370,7 +370,7 @@ var _CPPopoverWindowViewDefaultCursorSize = CGSizeMake(16, 10),
                     pt.x = arrowMaxX;
 
                 pt.y = arrowAnchor.y;
-                arrowStart = CGPointMakeCopy(pt);
+                arrowStart = _CGPointMakeCopy(pt);
                 CGPathAddLineToPoint(path, NULL, pt.x, pt.y);
 
                 // right edge -> point

AppKit/CPWindow/_CPShadowWindowView.j

@@ -54,7 +54,7 @@
         shadowDistance = [_windowView valueForThemeAttribute:@"shadow-distance"],
         shadowInset = [_windowView valueForThemeAttribute:@"shadow-inset"],
         size = [_windowView frameSize],
-        shadowSize = CGSizeMake(size.width, size.height);
+        shadowSize = _CGSizeMake(size.width, size.height);
 
     // if the shadow would be taller/wider than the window height,
     // make it the same as the window height. this allows views to

AppKit/CPWindow/_CPStandardWindowView.j

@@ -29,8 +29,6 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
 
 @implementation _CPTexturedWindowHeadView : CPView
 {
-    BOOL            _isSheet    @accessors(setter=setSheet:);
-
     _CPWindowView   _parentView;
     CPView          _gradientView;
     CPView          _solidView;
@@ -53,10 +51,10 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
     if (self)
     {
         _parentView = parentView;
-        _gradientView = [[CPView alloc] initWithFrame:CGRectMakeZero()];
+        _gradientView = [[CPView alloc] initWithFrame:_CGRectMakeZero()];
         [self addSubview:_gradientView];
 
-        _solidView = [[CPView alloc] initWithFrame:CGRectMakeZero()];
+        _solidView = [[CPView alloc] initWithFrame:_CGRectMakeZero()];
         [self addSubview:_solidView];
     }
 
@@ -68,13 +66,12 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
     [super layoutSubviews];
 
     var gradientHeight = [[CPTheme defaultTheme] valueForAttributeWithName:@"gradient-height" forClass:_CPStandardWindowView],
-        bounds = [self bounds],
-        bezelHeadColor = [[CPTheme defaultTheme] valueForAttributeWithName:_isSheet ? @"bezel-head-sheet-color" : @"bezel-head-color" inState:[_parentView themeState] forClass:_CPStandardWindowView];
+        bounds = [self bounds];
 
-    [_gradientView setFrame:CGRectMake(0.0, 0.0, CGRectGetWidth(bounds), gradientHeight)];
-    [_gradientView setBackgroundColor:bezelHeadColor];
+    [_gradientView setFrame:_CGRectMake(0.0, 0.0, _CGRectGetWidth(bounds), gradientHeight)];
+    [_gradientView setBackgroundColor:[[CPTheme defaultTheme] valueForAttributeWithName:@"bezel-head-color" inState:[_parentView themeState] forClass:_CPStandardWindowView]];
 
-    [_solidView setFrame:CGRectMake(0.0, gradientHeight, CGRectGetWidth(bounds), CGRectGetHeight(bounds) - gradientHeight)];
+    [_solidView setFrame:_CGRectMake(0.0, gradientHeight, _CGRectGetWidth(bounds), _CGRectGetHeight(bounds) - gradientHeight)];
     [_solidView setBackgroundColor:[[CPTheme defaultTheme] valueForAttributeWithName:@"solid-color" forClass:_CPStandardWindowView]];
 }
 
@@ -82,8 +79,8 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
 {
     var bounds = [self bounds];
 
-    [_gradientView setFrameSize:CGSizeMake(CGRectGetWidth(bounds), [[CPTheme defaultTheme] valueForAttributeWithName:@"gradient-height" forClass:_CPStandardWindowView])];
-    [_solidView setFrameSize:CGSizeMake(CGRectGetWidth(bounds), CGRectGetHeight(bounds) - [[CPTheme defaultTheme] valueForAttributeWithName:@"gradient-height" forClass:_CPStandardWindowView])];
+    [_gradientView setFrameSize:_CGSizeMake(_CGRectGetWidth(bounds), [[CPTheme defaultTheme] valueForAttributeWithName:@"gradient-height" forClass:_CPStandardWindowView])];
+    [_solidView setFrameSize:_CGSizeMake(_CGRectGetWidth(bounds), _CGRectGetHeight(bounds) - [[CPTheme defaultTheme] valueForAttributeWithName:@"gradient-height" forClass:_CPStandardWindowView])];
 }
 
 @end
@@ -100,7 +97,6 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
     CPButton                    _minimizeButton;
 
     BOOL                        _isDocumentEdited;
-    BOOL                        _isSheet;
 }
 
 + (CPString)defaultThemeClass
@@ -114,7 +110,6 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
             @"gradient-height": [CPNull null],
             @"solid-color": [CPNull null],
             @"bezel-head-color": [CPNull null],
-            @"bezel-head-sheet-color": [CPNull null],
             @"divider-color": [CPColor blackColor],
             @"body-color": [CPColor whiteColor],
             @"title-bar-height": 32,
@@ -135,6 +130,7 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
         The top coordinate has already been adjusted by _CPTitleableWindowView.
     */
     var contentRect = [super contentRectForFrameRect:aFrameRect];
+
     contentRect.origin.x += 1;
     contentRect.size.width -= 2;
     contentRect.size.height -= 1;
@@ -155,34 +151,34 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
         var theClass = [self class],
             bounds = [self bounds];
 
-        _headView = [[_CPTexturedWindowHeadView alloc] initWithFrame:CGRectMake(0.0, 0.0, CGRectGetWidth(bounds), [self valueForThemeAttribute:@"title-bar-height"]) windowView:self];
+        _headView = [[_CPTexturedWindowHeadView alloc] initWithFrame:_CGRectMake(0.0, 0.0, _CGRectGetWidth(bounds), [self valueForThemeAttribute:@"title-bar-height"]) windowView:self];
 
         [_headView setAutoresizingMask:CPViewWidthSizable];;
         [_headView setHitTests:NO];
 
         [self addSubview:_headView positioned:CPWindowBelow relativeTo:_titleField];
 
-        _dividerView = [[CPView alloc] initWithFrame:CGRectMake(0.0, CGRectGetMaxY([_headView frame]), CGRectGetWidth(bounds), _CPStandardWindowViewDividerViewHeight)];
+        _dividerView = [[CPView alloc] initWithFrame:_CGRectMake(0.0, _CGRectGetMaxY([_headView frame]), _CGRectGetWidth(bounds), _CPStandardWindowViewDividerViewHeight)];
 
         [_dividerView setAutoresizingMask:CPViewWidthSizable];
         [_dividerView setHitTests:NO];
 
         [self addSubview:_dividerView];
 
-        var y = CGRectGetMinY([_dividerView frame]);
+        var y = _CGRectGetMaxY([_dividerView frame]);
 
-        _bodyView = [[CPView alloc] initWithFrame:CGRectMake(0.0, y, CGRectGetWidth(bounds), CGRectGetHeight(bounds) - y)];
+        _bodyView = [[CPView alloc] initWithFrame:_CGRectMake(0.0, y, _CGRectGetWidth(bounds), _CGRectGetHeight(bounds) - y)];
 
         [_bodyView setAutoresizingMask:CPViewWidthSizable | CPViewHeightSizable];
         [_bodyView setHitTests:NO];
 
         [self addSubview:_bodyView];
 
-        [self setResizeIndicatorOffset:CGSizeMake(2.0, 2.0)];
+        [self setResizeIndicatorOffset:_CGSizeMake(2.0, 2.0)];
 
         if (_styleMask & CPClosableWindowMask)
         {
-            _closeButton = [[CPButton alloc] initWithFrame:CGRectMake(8.0, 8.0, 16.0, 16.0)];
+            _closeButton = [[CPButton alloc] initWithFrame:_CGRectMake(8.0, 8.0, 16.0, 16.0)];
 
             [_closeButton setButtonType:CPMomentaryChangeButton];
             [_closeButton setBordered:NO];
@@ -193,7 +189,7 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
 
         if (_styleMask & CPMiniaturizableWindowMask && ![CPPlatform isBrowser])
         {
-            _minimizeButton = [[CPButton alloc] initWithFrame:CGRectMake(27.0, 7.0, 16.0, 16.0)];
+            _minimizeButton = [[CPButton alloc] initWithFrame:_CGRectMake(27.0, 7.0, 16.0, 16.0)];
             [_minimizeButton setButtonType:CPMomentaryChangeButton];
             [_minimizeButton setBordered:NO];
 
@@ -217,7 +213,7 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
 
 - (CGSize)toolbarOffset
 {
-    return CGSizeMake(0.0, [self valueForThemeAttribute:@"title-bar-height"]);
+    return _CGSizeMake(0.0, [self valueForThemeAttribute:@"title-bar-height"]);
 }
 
 - (void)tile
@@ -226,26 +222,22 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
 
     var theWindow = [self window],
         bounds = [self bounds],
-        width = CGRectGetWidth(bounds),
+        width = _CGRectGetWidth(bounds),
         headHeight = [self toolbarMaxY];
 
-    if (_isSheet && _toolbarView && [self showsToolbar])
-    {
-        headHeight = [_toolbarView frameSize].height;
-        [_toolbarView setFrameOrigin:CGPointMake(0.0, 0.0)];
-    }
+    [_headView setFrameSize:_CGSizeMake(width, headHeight)];
+    [_dividerView setFrame:_CGRectMake(0.0, headHeight, width, 1.0)];
 
-    [_headView setFrameSize:CGSizeMake(width, headHeight)];
-
-    [_dividerView setFrame:CGRectMake(0.0, headHeight, width, _CPStandardWindowViewDividerViewHeight)];
-
-    var dividerMinY = 0,
-        dividerFrame = [_dividerView frame];
+    var dividerMaxY = 0,
+        dividerMinY = 0;
 
     if (![_dividerView isHidden])
-        dividerMinY = CGRectGetMinY(dividerFrame);
+    {
+        dividerMinY = _CGRectGetMinY([_dividerView frame]);
+        dividerMaxY = _CGRectGetMaxY([_dividerView frame]);
+    }
 
-    [_bodyView setFrame:CGRectMake(0.0, dividerMinY, width, CGRectGetHeight(bounds) - dividerMinY)];
+    [_bodyView setFrame:_CGRectMake(0.0, dividerMaxY, width, _CGRectGetHeight(bounds) - dividerMaxY)];
 
     var leftOffset = 8;
 
@@ -254,10 +246,11 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
     if (_minimizeButton)
         leftOffset += 19.0;
 
-    [_titleField setFrame:CGRectMake(leftOffset, 0, width - leftOffset * 2.0, [self valueForThemeAttribute:@"title-bar-height"])];
+    [_titleField setFrame:_CGRectMake(leftOffset, 0, width - leftOffset * 2.0, [self valueForThemeAttribute:@"title-bar-height"])];
 
-    var contentFrame = [_bodyView frame];
-    [[theWindow contentView] setFrame:CGRectInset(contentFrame, 1.0, 1.0)];
+    var contentRect = _CGRectMake(0.0, dividerMaxY, width, _CGRectGetHeight([_bodyView frame]));
+
+    [[theWindow contentView] setFrame:contentRect];
 }
 
 /*
@@ -314,65 +307,43 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
 - (BOOL)couldBeMoveEvent:(CPEvent)anEvent
 {
     if (![_headView isHidden])
-        if (CGRectContainsPoint([_headView frame], [self convertPoint:[anEvent locationInWindow] fromView:nil]))
+        if (_CGRectContainsPoint([_headView frame], [self convertPoint:[anEvent locationInWindow] fromView:nil]))
             return YES;
 
     return [super couldBeMoveEvent:anEvent];
 }
 
-- (void)_enableSheet:(BOOL)enable inWindow:(CPWindow)parentWindow
+- (void)_enableSheet:(BOOL)enable
 {
-    [super _enableSheet:enable inWindow:parentWindow];
-
-    _isSheet = enable;
-    [_headView setSheet:enable];
-
-    if (_toolbarView && [self showsToolbar])
-    {
-        [_headView setHidden:NO];
-        [_dividerView setHidden:NO];
-    }
-    else
-    {
-        [_headView setHidden:enable];
-        [_dividerView setHidden:enable];
-    }
+    [super _enableSheet:enable];
 
+    [_headView setHidden:enable];
+    [_dividerView setHidden:enable];
     [_closeButton setHidden:enable];
     [_minimizeButton setHidden:enable];
     [_titleField setHidden:enable];
 
-    [[self window] setMovable:!enable];
-
     if (enable)
-    {
         [_bodyView setBackgroundColor:[[CPTheme defaultTheme] valueForAttributeWithName:@"body-color" forClass:_CPDocModalWindowView]];
-
-        // Move the shadow view down so it is inside the content border
-        var shadowFrame = [_sheetShadowView frame];
-        [_sheetShadowView setFrameOrigin:CGPointMake(shadowFrame.origin.x, shadowFrame.origin.y + 1)];
-    }
     else
         [_bodyView setBackgroundColor:[self valueForThemeAttribute:@"body-color"]];
 
     // resize the window
     var theWindow = [self window],
         frame = [theWindow frame],
-        dividerHeight = [_dividerView frame].size.height,
-        dy = [self toolbarMaxY] + dividerHeight;
-
-    if (_toolbarView && [self showsToolbar])
-        dy = [[CPTheme defaultTheme] valueForAttributeWithName:@"gradient-height" forClass:_CPStandardWindowView];
+        dy;
 
     if (enable)
-        dy = -dy;
+        dy = -(_CGRectGetHeight([_headView frame]) + _CGRectGetHeight([_dividerView frame]));
+    else
+        dy = [self toolbarMaxY] + 1.0;
 
-    var newHeight = CGRectGetHeight(frame) + dy,
-        newWidth = CGRectGetWidth(frame);
+    var newHeight = _CGRectGetMaxY(frame) + dy,
+        newWidth = _CGRectGetMaxX(frame);
 
     frame.size.height += dy;
 
-    [self setFrameSize:CGSizeMake(newWidth, newHeight)];
+    [self setFrameSize:_CGSizeMake(newWidth, newHeight)];
 
     [self tile];
     [theWindow setFrame:frame display:NO animate:NO];
@@ -409,9 +380,4 @@ var _CPStandardWindowViewDividerViewHeight = 1.0;
     return size;
 }
 
-- (int)bodyOffset
-{
-    return [_bodyView frame].origin.y;
-}
-
 @end

AppKit/CPWindow/_CPTitleableWindowView.j

@@ -95,7 +95,7 @@
 
     // The vertical alignment of the title is set by the theme, so just give it all available space. By default
     // the title will vertically centre within.
-    [_titleField setFrame:CGRectMake(20.0, 0, width - 40.0, [[self class] titleBarHeight])];
+    [_titleField setFrame:_CGRectMake(20.0, 0, width - 40.0, [[self class] titleBarHeight])];
 }
 
 - (void)layoutSubviews
@@ -121,9 +121,4 @@
     return size;
 }
 
-- (int)bodyOffset
-{
-    return [self contentRectForFrameRect:[self frame]].origin.y;
-}
-
 @end

AppKit/CPWindow/_CPWindowView.j

@@ -57,7 +57,7 @@ _CPWindowViewResizeSlop = 3;
     CGSize      _toolbarOffset;
 //    BOOL        _isAnimatingToolbar;
 
-    CGRect      _cachedFrame;
+    CGRect      _resizeFrame;
     int         _resizeRegion;
     CGPoint     _mouseDraggedPoint;
 
@@ -68,12 +68,12 @@ _CPWindowViewResizeSlop = 3;
 
 + (CGRect)contentRectForFrameRect:(CGRect)aFrameRect
 {
-    return CGRectMakeCopy(aFrameRect);
+    return _CGRectMakeCopy(aFrameRect);
 }
 
 + (CGRect)frameRectForContentRect:(CGRect)aContentRect
 {
-    return CGRectMakeCopy(aContentRect);
+    return _CGRectMakeCopy(aContentRect);
 }
 
 + (CPString)defaultThemeClass
@@ -91,7 +91,6 @@ _CPWindowViewResizeSlop = 3;
             @"size-indicator": CGSizeMakeZero(),
             @"resize-indicator": [CPNull null],
             @"attached-sheet-shadow-color": [CPColor blackColor],
-            @"shadow-height": 8,
             @"close-image-origin": [CPNull null],
             @"close-image-size": [CPNull null],
             @"close-image": [CPNull null],
@@ -100,7 +99,7 @@ _CPWindowViewResizeSlop = 3;
             @"title-text-color": [CPColor blackColor],
             @"title-font": [CPFont systemFontOfSize:CPFontCurrentSystemSize],
             @"title-text-shadow-color": [CPNull null],
-            @"title-text-shadow-offset": CGSizeMakeZero(),
+            @"title-text-shadow-offset": _CGSizeMakeZero(),
             @"title-alignment": CPCenterTextAlignment,
             @"title-line-break-mode": CPLineBreakByTruncatingTail,
             @"title-vertical-alignment": CPTopVerticalTextAlignment,
@@ -114,7 +113,7 @@ _CPWindowViewResizeSlop = 3;
 
     if ([theToolbar isVisible])
     {
-        var toolbarHeight = CGRectGetHeight([[theToolbar _toolbarView] frame]);
+        var toolbarHeight = _CGRectGetHeight([[theToolbar _toolbarView] frame]);
 
         contentRect.origin.y += toolbarHeight;
         contentRect.size.height -= toolbarHeight;
@@ -130,7 +129,7 @@ _CPWindowViewResizeSlop = 3;
 
     if ([theToolbar isVisible])
     {
-        var toolbarHeight = CGRectGetHeight([[theToolbar _toolbarView] frame]);
+        var toolbarHeight = _CGRectGetHeight([[theToolbar _toolbarView] frame]);
 
         frameRect.origin.y -= toolbarHeight;
         frameRect.size.height += toolbarHeight;
@@ -146,8 +145,8 @@ _CPWindowViewResizeSlop = 3;
     if (self)
     {
         _styleMask = aStyleMask;
-        _resizeIndicatorOffset = CGSizeMakeZero();
-        _toolbarOffset = CGSizeMakeZero();
+        _resizeIndicatorOffset = _CGSizeMakeZero();
+        _toolbarOffset = _CGSizeMakeZero();
     }
 
     return self;
@@ -202,8 +201,8 @@ _CPWindowViewResizeSlop = 3;
         {
             // Extend the resize frame to the edge of the window frame
             var resizeFrame = [_resizeIndicator frame];
-            resizeFrame.size.width = CGRectGetWidth(windowFrame) - CGRectGetMinX(resizeFrame);
-            resizeFrame.size.height = CGRectGetHeight(windowFrame) - CGRectGetMinY(resizeFrame);
+            resizeFrame.size.width = _CGRectGetWidth(windowFrame) - _CGRectGetMinX(resizeFrame);
+            resizeFrame.size.height = _CGRectGetHeight(windowFrame) - _CGRectGetMinY(resizeFrame);
 
             var localPoint = [self convertPoint:[anEvent locationInWindow] fromView:nil];
             shouldResize = CGRectContainsPoint(resizeFrame, localPoint);
@@ -246,8 +245,6 @@ _CPWindowViewResizeSlop = 3;
         rects are the same size. So to save calculations, we can just create
         3 rects and move them around to do hit testing. Start with the corners
         and then do left/right and top/bottom.
-
-        NOTE: If the window is a sheet, the top is never eligible for resizing.
     */
     var wind = [self window],
         frame = [wind frame],
@@ -255,88 +252,87 @@ _CPWindowViewResizeSlop = 3;
         minSize = [wind minSize],
         maxSize = [wind maxSize],
         isFixedWidth = minSize.width === maxSize.width,
-        isFixedHeight = minSize.height === maxSize.height,
-        isSheet = wind._isSheet;
+        isFixedHeight = minSize.height === maxSize.height;
 
     if (isFixedWidth)
     {
-        rect = CGRectMake(frame.origin.x - _CPWindowViewResizeSlop,
+        rect = _CGRectMake(frame.origin.x - _CPWindowViewResizeSlop,
                            frame.origin.y - _CPWindowViewResizeSlop,
                            frame.size.width + (_CPWindowViewResizeSlop * 2),
                            _CPWindowViewResizeSlop * 2);
 
-        if (CGRectContainsPoint(rect, aPoint))
-            return isSheet ? _CPWindowViewResizeRegionNone : _CPWindowViewResizeRegionTop;
+        if (_CGRectContainsPoint(rect, aPoint))
+            return _CPWindowViewResizeRegionTop;
 
-        rect.origin.y = CGRectGetMaxY(frame) - _CPWindowViewResizeSlop;
+        rect.origin.y = _CGRectGetMaxY(frame) - _CPWindowViewResizeSlop;
 
-        if (CGRectContainsPoint(rect, aPoint))
+        if (_CGRectContainsPoint(rect, aPoint))
             return _CPWindowViewResizeRegionBottom;
     }
     else if (isFixedHeight)
     {
-        rect = CGRectMake(frame.origin.x - _CPWindowViewResizeSlop,
+        rect = _CGRectMake(frame.origin.x - _CPWindowViewResizeSlop,
                            frame.origin.y - _CPWindowViewResizeSlop,
                            _CPWindowViewResizeSlop * 2,
                            frame.size.height + (_CPWindowViewResizeSlop * 2));
 
-        if (CGRectContainsPoint(rect, aPoint))
+        if (_CGRectContainsPoint(rect, aPoint))
             return _CPWindowViewResizeRegionLeft;
 
-        rect.origin.x = CGRectGetMaxX(frame) - _CPWindowViewResizeSlop;
+        rect.origin.x = _CGRectGetMaxX(frame) - _CPWindowViewResizeSlop;
 
-        if (CGRectContainsPoint(rect, aPoint))
+        if (_CGRectContainsPoint(rect, aPoint))
             return _CPWindowViewResizeRegionRight;
     }
     else
     {
-        rect = CGRectMake(frame.origin.x - _CPWindowViewResizeSlop,
+        rect = _CGRectMake(frame.origin.x - _CPWindowViewResizeSlop,
                            frame.origin.y - _CPWindowViewResizeSlop,
                            _CPWindowViewCornerResizeRectWidth + _CPWindowViewResizeSlop,
                            _CPWindowViewCornerResizeRectWidth + _CPWindowViewResizeSlop);
 
-        if (CGRectContainsPoint(rect, aPoint))
-            return isSheet ? _CPWindowViewResizeRegionNone : _CPWindowViewResizeRegionTopLeft;
+        if (_CGRectContainsPoint(rect, aPoint))
+            return _CPWindowViewResizeRegionTopLeft;
 
-        rect.origin.x = CGRectGetMaxX(frame) - _CPWindowViewCornerResizeRectWidth;
+        rect.origin.x = _CGRectGetMaxX(frame) - _CPWindowViewCornerResizeRectWidth;
 
-        if (CGRectContainsPoint(rect, aPoint))
-            return isSheet ? _CPWindowViewResizeRegionNone : _CPWindowViewResizeRegionTopRight;
+        if (_CGRectContainsPoint(rect, aPoint))
+            return _CPWindowViewResizeRegionTopRight;
 
-        rect.origin.y = CGRectGetMaxY(frame) - _CPWindowViewCornerResizeRectWidth;
+        rect.origin.y = _CGRectGetMaxY(frame) - _CPWindowViewCornerResizeRectWidth;
 
-        if (CGRectContainsPoint(rect, aPoint))
+        if (_CGRectContainsPoint(rect, aPoint))
             return _CPWindowViewResizeRegionBottomRight;
 
         rect.origin.x = frame.origin.x - _CPWindowViewResizeSlop;
 
-        if (CGRectContainsPoint(rect, aPoint))
+        if (_CGRectContainsPoint(rect, aPoint))
             return _CPWindowViewResizeRegionBottomLeft;
 
-        rect = CGRectMake(rect.origin.x,
+        rect = _CGRectMake(rect.origin.x,
                            frame.origin.y + _CPWindowViewCornerResizeRectWidth,
                            _CPWindowViewResizeSlop * 2,
-                           CGRectGetHeight(frame) - (_CPWindowViewCornerResizeRectWidth * 2));
+                           _CGRectGetHeight(frame) - (_CPWindowViewCornerResizeRectWidth * 2));
 
-        if (CGRectContainsPoint(rect, aPoint))
+        if (_CGRectContainsPoint(rect, aPoint))
             return _CPWindowViewResizeRegionLeft;
 
-        rect.origin.x = CGRectGetMaxX(frame) - _CPWindowViewResizeSlop;
+        rect.origin.x = _CGRectGetMaxX(frame) - _CPWindowViewResizeSlop;
 
-        if (CGRectContainsPoint(rect, aPoint))
+        if (_CGRectContainsPoint(rect, aPoint))
             return _CPWindowViewResizeRegionRight;
 
-        rect = CGRectMake(frame.origin.x + _CPWindowViewCornerResizeRectWidth,
+        rect = _CGRectMake(frame.origin.x + _CPWindowViewCornerResizeRectWidth,
                            frame.origin.y - _CPWindowViewResizeSlop,
-                           CGRectGetWidth(frame) - (_CPWindowViewCornerResizeRectWidth * 2),
+                           _CGRectGetWidth(frame) - (_CPWindowViewCornerResizeRectWidth * 2),
                            _CPWindowViewResizeSlop * 2);
 
-        if (CGRectContainsPoint(rect, aPoint))
-            return isSheet ? _CPWindowViewResizeRegionNone : _CPWindowViewResizeRegionTop;
+        if (_CGRectContainsPoint(rect, aPoint))
+            return _CPWindowViewResizeRegionTop;
 
-        rect.origin.y = CGRectGetMaxY(frame) - _CPWindowViewResizeSlop;
+        rect.origin.y = _CGRectGetMaxY(frame) - _CPWindowViewResizeSlop;
 
-        if (CGRectContainsPoint(rect, aPoint))
+        if (_CGRectContainsPoint(rect, aPoint))
             return _CPWindowViewResizeRegionBottom;
     }
 
@@ -371,9 +367,9 @@ _CPWindowViewResizeSlop = 3;
     switch (resizeRegion)
     {
         case _CPWindowViewResizeRegionTopLeft:
-            if (minSize && CGSizeEqualToSize(frameSize, minSize))
+            if (minSize && _CGSizeEqualToSize(frameSize, minSize))
                 [[CPCursor resizeNorthwestCursor] set];
-            else if (maxSize && CGSizeEqualToSize(frameSize, maxSize))
+            else if (maxSize && _CGSizeEqualToSize(frameSize, maxSize))
                 [[CPCursor resizeSoutheastCursor] set];
             else
                 [[CPCursor resizeNorthwestSoutheastCursor] set];
@@ -384,16 +380,16 @@ _CPWindowViewResizeSlop = 3;
                 [[CPCursor resizeUpCursor] set];
             else if (maxSize && (frameSize.height === maxSize.height))
                 [[CPCursor resizeDownCursor] set];
-            else if ([CPMenu menuBarVisible] && (CGRectGetMinY([theWindow frame]) <= [CPMenu menuBarHeight]))
+            else if ([CPMenu menuBarVisible] && (_CGRectGetMinY([theWindow frame]) <= [CPMenu menuBarHeight]))
                 [[CPCursor resizeDownCursor] set];
             else
                 [[CPCursor resizeNorthSouthCursor] set];
             break;
 
         case _CPWindowViewResizeRegionTopRight:
-            if (minSize && CGSizeEqualToSize(frameSize, minSize))
+            if (minSize && _CGSizeEqualToSize(frameSize, minSize))
                 [[CPCursor resizeNortheastCursor] set];
-            else if (maxSize && CGSizeEqualToSize(frameSize, maxSize))
+            else if (maxSize && _CGSizeEqualToSize(frameSize, maxSize))
                 [[CPCursor resizeSouthwestCursor] set];
             else
                 [[CPCursor resizeNortheastSouthwestCursor] set];
@@ -409,9 +405,9 @@ _CPWindowViewResizeSlop = 3;
             break;
 
         case _CPWindowViewResizeRegionBottomRight:
-            if (minSize && CGSizeEqualToSize(frameSize, minSize))
+            if (minSize && _CGSizeEqualToSize(frameSize, minSize))
                 [[CPCursor resizeSoutheastCursor] set];
-            else if (maxSize && CGSizeEqualToSize(frameSize, maxSize))
+            else if (maxSize && _CGSizeEqualToSize(frameSize, maxSize))
                 [[CPCursor resizeNorthwestCursor] set];
             else
                 [[CPCursor resizeNorthwestSoutheastCursor] set];
@@ -427,9 +423,9 @@ _CPWindowViewResizeSlop = 3;
             break;
 
         case _CPWindowViewResizeRegionBottomLeft:
-            if (minSize && CGSizeEqualToSize(frameSize, minSize))
+            if (minSize && _CGSizeEqualToSize(frameSize, minSize))
                 [[CPCursor resizeSouthwestCursor] set];
-            else if (maxSize && CGSizeEqualToSize(frameSize, maxSize))
+            else if (maxSize && _CGSizeEqualToSize(frameSize, maxSize))
                 [[CPCursor resizeNortheastCursor] set];
             else
                 [[CPCursor resizeNortheastSouthwestCursor] set];
@@ -454,10 +450,7 @@ _CPWindowViewResizeSlop = 3;
     var type = [anEvent type];
 
     if (type === CPLeftMouseUp)
-    {
-        _cachedScreenFrame = nil;
         return;
-    }
 
     var location = [anEvent locationInWindow],
         theWindow = [self window],
@@ -466,31 +459,28 @@ _CPWindowViewResizeSlop = 3;
 
     if (type === CPLeftMouseDown)
     {
-        _mouseDraggedPoint = CGPointMake(globalLocation.x, globalLocation.y);
-        _cachedFrame = CGRectMakeCopy(frame);
-        _cachedScreenFrame = [[CPPlatformWindow primaryPlatformWindow] visibleFrame];
+        _mouseDraggedPoint = _CGPointMakeCopy(globalLocation);
+        _resizeFrame = _CGRectMakeCopy(frame);
     }
+
     else if (type === CPLeftMouseDragged)
     {
         var deltaX = globalLocation.x - _mouseDraggedPoint.x,
             deltaY = globalLocation.y - _mouseDraggedPoint.y,
-            startX = CGRectGetMinX(_cachedFrame),
-            startY = CGRectGetMinY(_cachedFrame),
-            startWidth = CGRectGetWidth(_cachedFrame),
-            startHeight = CGRectGetHeight(_cachedFrame),
+            startX = _CGRectGetMinX(_resizeFrame),
+            startY = _CGRectGetMinY(_resizeFrame),
+            startWidth = _CGRectGetWidth(_resizeFrame),
+            startHeight = _CGRectGetHeight(_resizeFrame),
             newX,
             newY,
             newWidth,
             newHeight,
+            platformFrame = [[theWindow platformWindow] usableContentFrame],
             resizeMinSize = [self _minimumResizeSize],
             minSize = [theWindow minSize],
             maxSize = [theWindow maxSize];
 
-        minSize = CGSizeMake(MAX(minSize.width, resizeMinSize.width), MAX(minSize.height, resizeMinSize.height));
-
-        // If it's a sheet, horizontal resizing is symmetrical, so the movement is effectively doubled
-        if (theWindow._isSheet)
-            deltaX *= 2;
+        minSize = _CGSizeMake(MAX(minSize.width, resizeMinSize.width), MAX(minSize.height, resizeMinSize.height));
 
         // Calculate x and width first
         switch (_resizeRegion)
@@ -508,24 +498,8 @@ _CPWindowViewResizeSlop = 3;
                 else if (deltaX < 0)
                     deltaX = -MIN(maxSize.width - startWidth, ABS(deltaX));
 
-                if (theWindow._isSheet)
-                    deltaX = FLOOR(deltaX / 2);
-
-                newX = startX + deltaX;
-
-                // Pin the left edge to the usable screen left edge
-                var pinnedX = MAX(newX, CGRectGetMinX(_cachedScreenFrame));
-
-                if (pinnedX !== newX)
-                {
-                    deltaX += pinnedX - newX;
-                    newX = pinnedX;
-                }
-
                 // When resizing from the left, we change the origin and the width
-                if (theWindow._isSheet)
-                    deltaX *= 2;
-
+                newX = startX + deltaX;
                 newWidth = startWidth - deltaX;
                 break;
 
@@ -542,26 +516,9 @@ _CPWindowViewResizeSlop = 3;
                 else if (deltaX < 0)
                     deltaX = -MIN(startWidth - minSize.width, ABS(deltaX));
 
-                if (theWindow._isSheet)
-                    deltaX = FLOOR(deltaX / 2);
-
-                // Pin the right edge to the usable screen right edge
-                var newMaxX = startX + startWidth + deltaX,
-                    pinnedX = MIN(newMaxX, CGRectGetMaxX(_cachedScreenFrame));
-
-                if (pinnedX !== newMaxX)
-                    deltaX += pinnedX - newMaxX;
-
-                if (theWindow._isSheet)
-                {
-                    newWidth = startWidth + (deltaX * 2);
-                    newX = startX - FLOOR((newWidth - startWidth) / 2);
-                }
-                else
-                {
-                    newWidth = startWidth + deltaX;
-                    newX = startX;
-                }
+                // When resizing from the right, change only the width
+                newX = startX;
+                newWidth = startWidth + deltaX;
                 break;
 
             default:
@@ -585,18 +542,8 @@ _CPWindowViewResizeSlop = 3;
                 else if (deltaY < 0)
                     deltaY = -MIN(maxSize.height - startHeight, ABS(deltaY));
 
-                newY = startY + deltaY;
-
-                // Pin the top edge to the usable screen top edge
-                var pinnedY = MAX(newY, CGRectGetMinY(_cachedScreenFrame));
-
-                if (pinnedY !== newY)
-                {
-                    deltaY += pinnedY - newY;
-                    newY = pinnedY;
-                }
-
                 // When resizing from the top, change the origin and the height
+                newY = startY + deltaY;
                 newHeight = startHeight - deltaY;
                 break;
 
@@ -613,16 +560,8 @@ _CPWindowViewResizeSlop = 3;
                 else if (deltaY < 0)
                     deltaY = -MIN(startHeight - minSize.height, ABS(deltaY));
 
-                newY = startY;
-
-                // Pin the bottom edge to the usable screen bottom edge
-                var newMaxY = startY + startHeight + deltaY,
-                    pinnedY = MIN(newMaxY, CGRectGetMaxY(_cachedScreenFrame));
-
-                if (pinnedY !== newMaxY)
-                    deltaY += pinnedY - newMaxY;
-
                 // When resizing from the bottom, change only the height
+                newY = startY;
                 newHeight = startHeight + deltaY;
                 break;
 
@@ -631,40 +570,72 @@ _CPWindowViewResizeSlop = 3;
                 newHeight = startHeight;
         }
 
-        [theWindow _setFrame:CGRectMake(newX, newY, newWidth, newHeight) display:YES animate:NO constrainWidth:NO constrainHeight:NO];
+        if (theWindow._isSheet && theWindow._parentView && (frame.size.width !== newWidth))
+            [theWindow._parentView _setAttachedSheetFrameOrigin];
+
+        // Constrain resize to fit within the platform window.
+        var newFrame = CGRectIntersection(_CGRectMake(newX, newY, newWidth, newHeight), platformFrame);
+
+        [theWindow setFrame:newFrame];
         [self setCursorForLocation:location resizing:YES];
     }
 
     [CPApp setTarget:self selector:@selector(trackResizeWithEvent:) forNextEventMatchingMask:CPLeftMouseDraggedMask | CPLeftMouseUpMask untilDate:nil inMode:nil dequeue:YES];
 }
 
+- (CGPoint)_pointWithinScreenFrame:(CGPoint)aPoint
+{
+    // FIXME: this is WRONG, all of this is WRONG
+    if (![CPPlatform isBrowser])
+        return aPoint;
+
+    var visibleFrame = _cachedScreenFrame;
+
+    if (!visibleFrame)
+        visibleFrame = [[CPPlatformWindow primaryPlatformWindow] visibleFrame];
+
+    var minPointY = 0;
+
+    if ([CPMenu menuBarVisible])
+        minPointY = [[CPApp mainMenu] menuBarHeight];
+
+    var restrictedPoint = _CGPointMake(0, 0);
+
+    restrictedPoint.x = MIN(MAX(aPoint.x, -_frame.size.width + 4.0), _CGRectGetMaxX(visibleFrame) - 4.0);
+    restrictedPoint.y = MIN(MAX(aPoint.y, minPointY), _CGRectGetMaxY(visibleFrame) - 8.0);
+
+    return restrictedPoint;
+}
+
 - (void)trackMoveWithEvent:(CPEvent)anEvent
 {
-    var theWindow = [self window];
-
-    if (![theWindow isMovable])
+    if (![[self window] isMovable])
         return;
 
     var type = [anEvent type];
 
     if (type === CPLeftMouseUp)
     {
+        _cachedScreenFrame = nil;
         return;
     }
     else if (type === CPLeftMouseDown)
     {
-        _mouseDraggedPoint = [theWindow convertBaseToGlobal:[anEvent locationInWindow]];
-        _cachedFrame = CGRectMakeCopy([theWindow frame]);
+        _mouseDraggedPoint = [[self window] convertBaseToGlobal:[anEvent locationInWindow]];
+        _cachedScreenFrame = [[CPPlatformWindow primaryPlatformWindow] visibleFrame];
     }
     else if (type === CPLeftMouseDragged)
     {
         var theWindow = [self window],
+            frame = [theWindow frame],
             location = [theWindow convertBaseToGlobal:[anEvent locationInWindow]],
             deltaX = location.x - _mouseDraggedPoint.x,
             deltaY = location.y - _mouseDraggedPoint.y,
-            origin = CGPointMake(_cachedFrame.origin.x + deltaX, _cachedFrame.origin.y + deltaY);
-
+            origin = [self _pointWithinScreenFrame:_CGPointMake(frame.origin.x + deltaX,
+                                                                frame.origin.y + deltaY)];
         [theWindow setFrameOrigin:origin];
+
+        _mouseDraggedPoint = [self _pointWithinScreenFrame:location];
     }
 
     [CPApp setTarget:self selector:@selector(trackMoveWithEvent:) forNextEventMatchingMask:CPLeftMouseDraggedMask | CPLeftMouseUpMask untilDate:nil inMode:nil dequeue:YES];
@@ -675,16 +646,10 @@ _CPWindowViewResizeSlop = 3;
     [super setFrameSize:newSize];
 
     // reposition sheet if the parent window resizes or moves
-    var theWindow = [self window],
-        sheet = [theWindow attachedSheet];
+    var theWindow = [self window];
 
-    if (sheet)
-    {
+    if ([theWindow attachedSheet])
         [theWindow _setAttachedSheetFrameOrigin];
-        [sheet._windowView _adjustShadowViewSize];
-    }
-    else if (theWindow._isSheet)
-        [self _adjustShadowViewSize];
 }
 
 - (void)setShowsResizeIndicator:(BOOL)shouldShowResizeIndicator
@@ -713,7 +678,7 @@ _CPWindowViewResizeSlop = 3;
 
 - (void)setResizeIndicatorOffset:(CGSize)anOffset
 {
-    if (CGSizeEqualToSize(_resizeIndicatorOffset, anOffset))
+    if (_CGSizeEqualToSize(_resizeIndicatorOffset, anOffset))
         return;
 
     _resizeIndicatorOffset = anOffset;
@@ -724,7 +689,7 @@ _CPWindowViewResizeSlop = 3;
     var size = [_resizeIndicator frame].size,
         boundsSize = [self frame].size;
 
-    [_resizeIndicator setFrameOrigin:CGPointMake(boundsSize.width - size.width - anOffset.width, boundsSize.height - size.height - anOffset.height)];
+    [_resizeIndicator setFrameOrigin:_CGPointMake(boundsSize.width - size.width - anOffset.width, boundsSize.height - size.height - anOffset.height)];
 }
 
 - (CGSize)resizeIndicatorOffset
@@ -742,9 +707,7 @@ _CPWindowViewResizeSlop = 3;
 
 - (BOOL)showsToolbar
 {
-    var styleMaskWindow = [[self window] styleMask];
-
-    return styleMaskWindow & CPBorderlessWindowMask || styleMaskWindow & CPTitledWindowMask || styleMaskWindow & CPHUDBackgroundWindowMask || styleMaskWindow & CPBorderlessBridgeWindowMask;
+    return YES;
 }
 
 - (CGSize)toolbarOffset
@@ -762,7 +725,7 @@ _CPWindowViewResizeSlop = 3;
     if (!_toolbarView || [_toolbarView isHidden])
         return [self toolbarOffset].height;
 
-    return CGRectGetMaxY([_toolbarView frame]);
+    return _CGRectGetMaxY([_toolbarView frame]);
 }
 
 - (_CPToolbarView)toolbarView
@@ -774,14 +737,14 @@ _CPWindowViewResizeSlop = 3;
 {
     var theWindow = [self window],
         bounds = [self bounds],
-        width = CGRectGetWidth(bounds);
+        width = _CGRectGetWidth(bounds);
 
     if ([[theWindow toolbar] isVisible])
     {
         var toolbarView = [self toolbarView],
             toolbarOffset = [self toolbarOffset];
 
-        [toolbarView setFrame:CGRectMake(toolbarOffset.width, toolbarOffset.height, width, CGRectGetHeight([toolbarView frame]))];
+        [toolbarView setFrame:_CGRectMake(toolbarOffset.width, toolbarOffset.height, width, _CGRectGetHeight([toolbarView frame]))];
     }
 
     if ([self showsResizeIndicator])
@@ -789,7 +752,7 @@ _CPWindowViewResizeSlop = 3;
         var size = [_resizeIndicator frame].size,
             boundsSize = [self bounds].size;
 
-        [_resizeIndicator setFrameOrigin:CGPointMake(boundsSize.width - size.width - _resizeIndicatorOffset.width, boundsSize.height - size.height - _resizeIndicatorOffset.height)];
+        [_resizeIndicator setFrameOrigin:_CGPointMake(boundsSize.width - size.width - _resizeIndicatorOffset.width, boundsSize.height - size.height - _resizeIndicatorOffset.height)];
     }
 }
 
@@ -866,36 +829,22 @@ _CPWindowViewResizeSlop = 3;
     [self addSubview:_resizeIndicator];
 }
 
-- (void)_enableSheet:(BOOL)enable inWindow:(CPWindow)parentWindow
+- (void)_enableSheet:(BOOL)enable
 {
     if (enable)
     {
-        // Clip the shadow view width to the parent's content view
-        var myWidth = [self bounds].size.width,
-            shadowWidth = [self _shadowViewWidthForParentWindow:parentWindow],
-            shadowHeight = [self currentValueForThemeAttribute:@"shadow-height"];
-
-        _sheetShadowView = [[CPView alloc] initWithFrame:CGRectMake(FLOOR((myWidth - shadowWidth) / 2), 0, shadowWidth, shadowHeight)];
+        _sheetShadowView = [[CPView alloc] initWithFrame:_CGRectMake(0, 0, _CGRectGetWidth([self bounds]), 8)];
         [_sheetShadowView setAutoresizingMask:CPViewWidthSizable];
         [self addSubview:_sheetShadowView];
     }
     else
     {
         [_sheetShadowView removeFromSuperview];
-        _sheetShadowView = nil;
     }
 
     [self setNeedsLayout];
 }
 
-- (CGRect)_shadowViewWidthForParentWindow:(CPWindow)parentWindow
-{
-    var myWidth = [self bounds].size.width,
-        parentWidth = [[parentWindow contentView] bounds].size.width;
-
-    return MIN(myWidth, parentWidth);
-}
-
 - (void)layoutSubviews
 {
     [super layoutSubviews];
@@ -912,28 +861,9 @@ _CPWindowViewResizeSlop = 3;
     }
 }
 
-- (void)_adjustShadowViewSize
-{
-    if (!_sheetShadowView)
-        return;
-
-    var myWidth = [self frame].size.width,
-        shadowFrame = [_sheetShadowView frame],
-        shadowWidth = [self _shadowViewWidthForParentWindow:_window._parentView];
-
-    shadowFrame.origin.x = FLOOR((myWidth - shadowWidth) / 2);
-    shadowFrame.size.width = shadowWidth;
-    [_sheetShadowView setFrame:shadowFrame];
-}
-
 - (CGSize)_minimumResizeSize
 {
-    return CGSizeMake(0, _CPWindowViewMinContentHeight);
-}
-
-- (int)bodyOffset
-{
-    return [self frame].origin.y;
+    return _CGSizeMake(0, _CPWindowViewMinContentHeight);
 }
 
 @end

AppKit/Cib/CPCib.j

@@ -165,14 +165,7 @@ var CPCibObjectDataKey  = @"CPCibObjectDataKey";
 
 - (BOOL)instantiateCibWithOwner:(id)anOwner topLevelObjects:(CPArray)topLevelObjects
 {
-    // anOwner can be nil, and we can't store nil in a dictionary. If we leave it out,
-    // anyone who asks for CPCibOwner will get nil back.
-    var nameTable = @{ CPCibTopLevelObjects: topLevelObjects };
-
-    if (anOwner)
-        [nameTable setObject:anOwner forKey:CPCibOwner];
-
-    return [self instantiateCibWithExternalNameTable:nameTable];
+    return [self instantiateCibWithExternalNameTable:@{ CPCibOwner: anOwner, CPCibTopLevelObjects: topLevelObjects }];
 }
 
 @end

AppKit/Cib/_CPCibCustomResource.j

@@ -31,7 +31,7 @@
 @import "CPTheme.j"
 
 @class CPButtonBar
-@class CPView
+
 
 var _CPCibCustomResourceClassNameKey    = @"_CPCibCustomResourceClassNameKey",
     _CPCibCustomResourceResourceNameKey = @"_CPCibCustomResourceResourceNameKey",
@@ -42,7 +42,6 @@ var _CPCibCustomResourceClassNameKey    = @"_CPCibCustomResourceClassNameKey",
     CPString        _className;
     CPString        _resourceName;
     CPDictionary    _properties;
-    CPBundle        _bundle;
 }
 
 + (id)imageResourceWithName:(CPString)aResourceName size:(CGSize)aSize
@@ -64,7 +63,6 @@ var _CPCibCustomResourceClassNameKey    = @"_CPCibCustomResourceClassNameKey",
         _className = aClassName;
         _resourceName = aResourceName;
         _properties = properties;
-        _bundle = nil;
     }
 
     return self;
@@ -79,7 +77,6 @@ var _CPCibCustomResourceClassNameKey    = @"_CPCibCustomResourceClassNameKey",
         _className = [aCoder decodeObjectForKey:_CPCibCustomResourceClassNameKey];
         _resourceName = [aCoder decodeObjectForKey:_CPCibCustomResourceResourceNameKey];
         _properties = [aCoder decodeObjectForKey:_CPCibCustomResourcePropertiesKey];
-        _bundle = nil;
     }
 
     return self;
@@ -103,72 +100,39 @@ var _CPCibCustomResourceClassNameKey    = @"_CPCibCustomResourceClassNameKey",
             else if (_resourceName == "CPRemoveTemplate")
                 return [[CPTheme defaultTheme] valueForAttributeWithName:@"button-image-minus" forClass:[CPButtonBar class]];
 
-            return [self imageFromCoder:aCoder];
+            return [self imageFromBundle:[aCoder bundle]];
         }
 
     return self;
 }
 
-@end
-
-@implementation _CPCibCustomResource (CPImage)
-
-- (CPBundle)imageBundleWithCoder:(CPCoder)aCoder
+- (CPImage)imageFromBundle:(CPBundle)aBundle
 {
-    if (_bundle)
-        return _bundle;
-
-    var bundleIdentifier = [_properties valueForKey:@"bundleIdentifier"];
-
-    if (bundleIdentifier)
-        _bundle = [CPBundle bundleWithIdentifier:bundleIdentifier];
-    else
+    if (!aBundle)
     {
-        var bundleClass = [_properties valueForKey:@"bundleClass"];
+        var bundleClass = _properties.valueForKey(@"bundleClass");
 
         if (bundleClass)
         {
             bundleClass = CPClassFromString(bundleClass);
 
             if (bundleClass)
-                _bundle = [CPBundle bundleForClass:bundleClass];
+                aBundle = [CPBundle bundleForClass:bundleClass];
         }
-    }
-
-    if (!_bundle)
-    {
-        var framework = [_properties valueForKey:@"framework"];
-
-        if (framework)
-        {
-            // Get AppKit and hope the framework is in the same directory
-            var appKit = [CPBundle bundleForClass:[CPView class]],
-                url = [[appKit bundleURL] URLByDeletingLastPathComponent];
-
-            url = [CPURL URLWithString:framework relativeToURL:url];
-            _bundle = [CPBundle bundleWithURL:url];
-        }
-    }
-
-    if (!_bundle)
-    {
-        if (aCoder)
-            _bundle = [aCoder bundle];
         else
-            _bundle = [CPBundle mainBundle];
+            aBundle = [CPBundle mainBundle];
     }
 
-    return _bundle;
+    return [[CPImage alloc] initWithContentsOfFile:[aBundle pathForResource:_resourceName] size:_properties.valueForKey(@"size")];
 }
 
-- (CPImage)imageFromCoder:(CPCoder)aCoder
-{
-    return [[CPImage alloc] initWithContentsOfFile:[[self imageBundleWithCoder:aCoder] pathForResource:_resourceName] size:[_properties valueForKey:@"size"]];
-}
+@end
+
+@implementation _CPCibCustomResource (CPImage)
 
 - (CPString)filename
 {
-    return [[self imageBundleWithCoder:nil] pathForResource:_resourceName];
+    return [[CPBundle mainBundle] pathForResource:_resourceName];
 }
 
 - (CGSize)size
@@ -198,7 +162,7 @@ var _CPCibCustomResourceClassNameKey    = @"_CPCibCustomResourceClassNameKey",
 
 - (CPString)description
 {
-    var image = [self imageFromCoder:nil];
+    var image = [self imageFromBundle:nil];
 
     return [image description];
 }

AppKit/CoreAnimation/CALayer.j

@@ -157,7 +157,6 @@ var CALayerRegisteredRunLoopUpdates             = nil;
 
         _sublayers = [];
 
-#if PLATFORM(DOM)
         _DOMElement = document.createElement("div");
 
         _DOMElement.style.overflow = "visible";
@@ -168,7 +167,6 @@ var CALayerRegisteredRunLoopUpdates             = nil;
         _DOMElement.style.zIndex = 0;
         _DOMElement.style.width = "0px";
         _DOMElement.style.height = "0px";
-#endif
     }
 
     return self;
@@ -186,7 +184,7 @@ var CALayerRegisteredRunLoopUpdates             = nil;
 
     var oldOrigin = _bounds.origin;
 
-    _bounds = CGRectMakeCopy(aBounds);
+    _bounds = _CGRectMakeCopy(aBounds);
 
     if (_hasSublayerTransform)
         _CALayerUpdateSublayerTransformForSublayers(self);
@@ -221,7 +219,7 @@ var CALayerRegisteredRunLoopUpdates             = nil;
     if (CGPointEqualToPoint(_position, aPosition))
         return;
 
-    _position = CGPointMakeCopy(aPosition);
+    _position = _CGPointMakeCopy(aPosition);
 
     _CALayerRecalculateGeometry(self, CALayerGeometryPositionMask);
 }
@@ -254,7 +252,7 @@ var CALayerRegisteredRunLoopUpdates             = nil;
 */
 - (void)setAnchorPoint:(CGPoint)anAnchorPoint
 {
-    anAnchorPoint = CGPointMakeCopy(anAnchorPoint);
+    anAnchorPoint = _CGPointMakeCopy(anAnchorPoint);
     anAnchorPoint.x = MIN(1.0, MAX(0.0, anAnchorPoint.x));
     anAnchorPoint.y = MIN(1.0, MAX(0.0, anAnchorPoint.y));
 
@@ -267,7 +265,7 @@ var CALayerRegisteredRunLoopUpdates             = nil;
         _CALayerUpdateSublayerTransformForSublayers(self);
 
     if (_owningView)
-        _position = CGPointMake(CGRectGetWidth(_bounds) * _anchorPoint.x, CGRectGetHeight(_bounds) * _anchorPoint.y);
+        _position = CGPointMake(_CGRectGetWidth(_bounds) * _anchorPoint.x, _CGRectGetHeight(_bounds) * _anchorPoint.y);
 
     _CALayerRecalculateGeometry(self, CALayerGeometryAnchorPointMask);
 }
@@ -289,7 +287,7 @@ var CALayerRegisteredRunLoopUpdates             = nil;
     if (CGAffineTransformEqualToTransform(_affineTransform, anAffineTransform))
         return;
 
-    _affineTransform = CGAffineTransformMakeCopy(anAffineTransform);
+    _affineTransform = _CGAffineTransformMakeCopy(anAffineTransform);
 
     _CALayerRecalculateGeometry(self, CALayerGeometryAffineTransformMask);
 }
@@ -313,8 +311,8 @@ var CALayerRegisteredRunLoopUpdates             = nil;
 
     var hadSublayerTransform = _hasSublayerTransform;
 
-    _sublayerTransform = CGAffineTransformMakeCopy(anAffineTransform);
-    _hasSublayerTransform = !CGAffineTransformIsIdentity(_sublayerTransform);
+    _sublayerTransform = _CGAffineTransformMakeCopy(anAffineTransform);
+    _hasSublayerTransform = !_CGAffineTransformIsIdentity(_sublayerTransform);
 
     if (_hasSublayerTransform)
     {
@@ -402,8 +400,8 @@ var CALayerRegisteredRunLoopUpdates             = nil;
             var bounds = [_superlayer bounds],
                 frame = [_superlayer convertRect:bounds toLayer:nil];
 
-            aFrame.origin.x -= CGRectGetMinX(frame);
-            aFrame.origin.y -= CGRectGetMinY(frame);
+            aFrame.origin.x -= _CGRectGetMinX(frame);
+            aFrame.origin.y -= _CGRectGetMinY(frame);
         }
         else
             aFrame = CGRectMakeCopy(aFrame);
@@ -451,7 +449,7 @@ var CALayerRegisteredRunLoopUpdates             = nil;
     if (USE_BUFFER && !_contents || !_context)
         return;
 
-    CGContextClearRect(_context, CGRectMake(0.0, 0.0, CGRectGetWidth(_backingStoreFrame), CGRectGetHeight(_backingStoreFrame)));
+    CGContextClearRect(_context, _CGRectMake(0.0, 0.0, _CGRectGetWidth(_backingStoreFrame), _CGRectGetHeight(_backingStoreFrame)));
 
     // Recomposite
     var transform;
@@ -471,8 +469,8 @@ var CALayerRegisteredRunLoopUpdates             = nil;
         // Copy so we don't affect the original.
         transform = CGAffineTransformCreateCopy(_transformFromLayer);
 
-    transform.tx -= CGRectGetMinX(_backingStoreFrame);
-    transform.ty -= CGRectGetMinY(_backingStoreFrame);
+    transform.tx -= _CGRectGetMinX(_backingStoreFrame);
+    transform.ty -= _CGRectGetMinY(_backingStoreFrame);
 
     CGContextSaveGState(_context);
 
@@ -481,7 +479,7 @@ var CALayerRegisteredRunLoopUpdates             = nil;
     if (USE_BUFFER)
     {
 //        CGContextDrawImage(_context, _bounds, _contents.context);
-        _context.drawImage(_contents.buffer, CGRectGetMinX(_bounds), CGRectGetMinY(_bounds));//, CGRectGetWidth(_standardBackingStoreFrame), CGRectGetHeight(_standardBackingStoreFrame));
+        _context.drawImage(_contents.buffer, _CGRectGetMinX(_bounds), _CGRectGetMinY(_bounds));//, _CGRectGetWidth(_standardBackingStoreFrame), _CGRectGetHeight(_standardBackingStoreFrame));
     }
     else
         [self drawInContext:_context];
@@ -506,13 +504,13 @@ var CALayerRegisteredRunLoopUpdates             = nil;
         _DOMContentsElement.style.position = "absolute";
         _DOMContentsElement.style.visibility = "visible";
 
-        _DOMContentsElement.width = ROUND(CGRectGetWidth(_backingStoreFrame));
-        _DOMContentsElement.height = ROUND(CGRectGetHeight(_backingStoreFrame));
+        _DOMContentsElement.width = ROUND(_CGRectGetWidth(_backingStoreFrame));
+        _DOMContentsElement.height = ROUND(_CGRectGetHeight(_backingStoreFrame));
 
         _DOMContentsElement.style.top = "0px";
         _DOMContentsElement.style.left = "0px";
-        _DOMContentsElement.style.width = ROUND(CGRectGetWidth(_backingStoreFrame)) + "px";
-        _DOMContentsElement.style.height = ROUND(CGRectGetHeight(_backingStoreFrame)) + "px";
+        _DOMContentsElement.style.width = ROUND(_CGRectGetWidth(_backingStoreFrame)) + "px";
+        _DOMContentsElement.style.height = ROUND(_CGRectGetHeight(_backingStoreFrame)) + "px";
 
         _DOMElement.appendChild(_DOMContentsElement);
     }
@@ -522,7 +520,7 @@ var CALayerRegisteredRunLoopUpdates             = nil;
         if (_delegateRespondsToDisplayLayerSelector)
             return [_delegate displayInLayer:self];
 
-        if (CGRectGetWidth(_backingStoreFrame) == 0.0 || CGRectGetHeight(_backingStoreFrame) == 0.0)
+        if (_CGRectGetWidth(_backingStoreFrame) == 0.0 || _CGRectGetHeight(_backingStoreFrame) == 0.0)
             return;
 
         if (!_contents)
@@ -713,12 +711,10 @@ if (_DOMContentsElement && aLayer._zPosition > _DOMContentsElement.style.zIndex)
 
     [_sublayers insertObject:aLayer atIndex:anIndex];
 
-#if PLATFORM(DOM)
     if (anIndex >= _sublayers.length - 1)
         _DOMElement.appendChild(DOM(aLayer));
     else
         _DOMElement.insertBefore(DOM(aLayer), _sublayers[anIndex + 1]._DOMElement);
-#endif
 
     aLayer._superlayer = self;
 
@@ -917,7 +913,7 @@ if (_DOMContentsElement && aLayer._zPosition > _DOMContentsElement.style.zIndex)
 */
 - (BOOL)containsPoint:(CGPoint)aPoint
 {
-    return CGRectContainsPoint(_bounds, aPoint);
+    return _CGRectContainsPoint(_bounds, aPoint);
 }
 
 /*!
@@ -932,7 +928,7 @@ if (_DOMContentsElement && aLayer._zPosition > _DOMContentsElement.style.zIndex)
 
     var point = CGPointApplyAffineTransform(aPoint, _transformToLayer);
 
-    if (!CGRectContainsPoint(_bounds, point))
+    if (!_CGRectContainsPoint(_bounds, point))
         return nil;
 
     var layer = nil,
@@ -983,7 +979,7 @@ if (_DOMContentsElement && aLayer._zPosition > _DOMContentsElement.style.zIndex)
         _owningView = anOwningView;
 
         _bounds.size = CGSizeMakeCopy([_owningView bounds].size);
-        _position = CGPointMake(CGRectGetWidth(_bounds) * _anchorPoint.x, CGRectGetHeight(_bounds) * _anchorPoint.y);
+        _position = CGPointMake(_CGRectGetWidth(_bounds) * _anchorPoint.x, _CGRectGetHeight(_bounds) * _anchorPoint.y);
     }
 
     _CALayerRecalculateGeometry(self, CALayerGeometryPositionMask | CALayerGeometryBoundsMask);
@@ -993,7 +989,7 @@ if (_DOMContentsElement && aLayer._zPosition > _DOMContentsElement.style.zIndex)
 - (void)_owningViewBoundsChanged
 {
     _bounds.size = CGSizeMakeCopy([_owningView bounds].size);
-    _position = CGPointMake(CGRectGetWidth(_bounds) * _anchorPoint.x, CGRectGetHeight(_bounds) * _anchorPoint.y);
+    _position = CGPointMake(_CGRectGetWidth(_bounds) * _anchorPoint.x, _CGRectGetHeight(_bounds) * _anchorPoint.y);
 
     _CALayerRecalculateGeometry(self, CALayerGeometryPositionMask | CALayerGeometryBoundsMask);
 }
@@ -1025,8 +1021,8 @@ function _CALayerUpdateSublayerTransformForSublayers(aLayer)
 {
     var bounds = aLayer._bounds,
         anchorPoint = aLayer._anchorPoint,
-        translateX = CGRectGetWidth(bounds) * anchorPoint.x,
-        translateY = CGRectGetHeight(bounds) * anchorPoint.y;
+        translateX = _CGRectGetWidth(bounds) * anchorPoint.x,
+        translateY = _CGRectGetHeight(bounds) * anchorPoint.y;
 
     aLayer._sublayerTransformForSublayers = CGAffineTransformConcat(
         CGAffineTransformMakeTranslation(-translateX, -translateY),
@@ -1045,14 +1041,14 @@ function _CALayerUpdateDOM(aLayer, aMask)
 
     if (aMask & CALayerFrameOriginUpdateMask)
     {
-        DOMElementStyle.top = ROUND(CGRectGetMinY(frame)) + "px";
-        DOMElementStyle.left = ROUND(CGRectGetMinX(frame)) + "px";
+        DOMElementStyle.top = ROUND(_CGRectGetMinY(frame)) + "px";
+        DOMElementStyle.left = ROUND(_CGRectGetMinX(frame)) + "px";
     }
 
     if (aMask & CALayerFrameSizeUpdateMask)
     {
-        var width = MAX(0.0, ROUND(CGRectGetWidth(frame))),
-            height = MAX(0.0, ROUND(CGRectGetHeight(frame))),
+        var width = MAX(0.0, ROUND(_CGRectGetWidth(frame))),
+            height = MAX(0.0, ROUND(_CGRectGetHeight(frame))),
             DOMContentsElement = aLayer._DOMContentsElement;
 
         DOMElementStyle.width = width + "px";
@@ -1072,24 +1068,24 @@ function _CALayerRecalculateGeometry(aLayer, aGeometryChange)
 {
     var bounds = aLayer._bounds,
         superlayer = aLayer._superlayer,
-        width = CGRectGetWidth(bounds),
-        height = CGRectGetHeight(bounds),
+        width = _CGRectGetWidth(bounds),
+        height = _CGRectGetHeight(bounds),
         position = aLayer._position,
         anchorPoint = aLayer._anchorPoint,
         affineTransform = aLayer._affineTransform,
-        backingStoreFrameSize = CGSizeMakeCopy(aLayer._backingStoreFrame),
+        backingStoreFrameSize = _CGSizeMakeCopy(aLayer._backingStoreFrame),
         hasCustomBackingStoreFrame = aLayer._hasCustomBackingStoreFrame;
 
     // Go to anchor, transform, go back to bounds.
     aLayer._transformFromLayer =  CGAffineTransformConcat(
-        CGAffineTransformMakeTranslation(-width * anchorPoint.x - CGRectGetMinX(aLayer._bounds), -height * anchorPoint.y - CGRectGetMinY(aLayer._bounds)),
+        CGAffineTransformMakeTranslation(-width * anchorPoint.x - _CGRectGetMinX(aLayer._bounds), -height * anchorPoint.y - _CGRectGetMinY(aLayer._bounds)),
         CGAffineTransformConcat(affineTransform,
         CGAffineTransformMakeTranslation(position.x, position.y)));
 
     if (superlayer && superlayer._hasSublayerTransform)
     {
         // aLayer._transformFromLayer = CGAffineTransformConcat(aLayer._transformFromLayer, superlayer._sublayerTransformForSublayers);
-        CGAffineTransformConcatTo(aLayer._transformFromLayer, superlayer._sublayerTransformForSublayers, aLayer._transformFromLayer);
+        _CGAffineTransformConcatTo(aLayer._transformFromLayer, superlayer._sublayerTransformForSublayers, aLayer._transformFromLayer);
     }
 
     aLayer._transformToLayer = CGAffineTransformInvert(aLayer._transformFromLayer);
@@ -1105,8 +1101,8 @@ function _CALayerRecalculateGeometry(aLayer, aGeometryChange)
         var bounds = [superlayer bounds],
             frame = [superlayer convertRect:bounds toLayer:nil];
 
-        aLayer._standardBackingStoreFrame.origin.x -= CGRectGetMinX(frame);
-        aLayer._standardBackingStoreFrame.origin.y -= CGRectGetMinY(frame);
+        aLayer._standardBackingStoreFrame.origin.x -= _CGRectGetMinX(frame);
+        aLayer._standardBackingStoreFrame.origin.y -= _CGRectGetMinY(frame);
     }
 
     // We used to use CGRectIntegral here, but what we actually want, is the largest integral
@@ -1132,13 +1128,13 @@ function _CALayerRecalculateGeometry(aLayer, aGeometryChange)
 
         // These values get rounded in the DOM, so don't both updating them if they're
         // not going to be different after rounding.
-        if (ROUND(CGRectGetMinX(backingStoreFrame)) != ROUND(CGRectGetMinX(aLayer._backingStoreFrame)) ||
-            ROUND(CGRectGetMinY(backingStoreFrame)) != ROUND(CGRectGetMinY(aLayer._backingStoreFrame)))
+        if (ROUND(_CGRectGetMinX(backingStoreFrame)) != ROUND(_CGRectGetMinX(aLayer._backingStoreFrame)) ||
+            ROUND(_CGRectGetMinY(backingStoreFrame)) != ROUND(_CGRectGetMinY(aLayer._backingStoreFrame)))
             [aLayer registerRunLoopUpdateWithMask:CALayerFrameOriginUpdateMask];
 
         // Any change in size due to a geometry change is purely due to rounding error.
-        if ((CGRectGetWidth(backingStoreFrame) != ROUND(CGRectGetWidth(aLayer._backingStoreFrame)) ||
-            CGRectGetHeight(backingStoreFrame) != ROUND(CGRectGetHeight(aLayer._backingStoreFrame))))
+        if ((_CGRectGetWidth(backingStoreFrame) != ROUND(_CGRectGetWidth(aLayer._backingStoreFrame)) ||
+            _CGRectGetHeight(backingStoreFrame) != ROUND(_CGRectGetHeight(aLayer._backingStoreFrame))))
             [aLayer registerRunLoopUpdateWithMask:CALayerFrameSizeUpdateMask];
 
         aLayer._backingStoreFrame = backingStoreFrame;
@@ -1176,7 +1172,7 @@ function _CALayerGetTransform(fromLayer, toLayer)
             var transformFromLayer = layer._transformFromLayer;
 
             //transform = CGAffineTransformConcat(transform, layer._transformFromLayer);
-            CGAffineTransformConcatTo(transform, transformFromLayer, transform);
+            _CGAffineTransformConcatTo(transform, transformFromLayer, transform);
 
             layer = layer._superlayer;
         }
@@ -1201,7 +1197,7 @@ function _CALayerGetTransform(fromLayer, toLayer)
     {
         var transformToLayer = layers[index]._transformToLayer;
 
-        CGAffineTransformConcatTo(transform, transformToLayer, transform);
+        _CGAffineTransformConcatTo(transform, transformToLayer, transform);
     }
 
     return transform;

AppKit/CoreGraphics/CGAffineTransform.h

@@ -0,0 +1,62 @@
+/*
+ * CGAffineTransform.h
+ * AppKit
+ *
+ * Created by Francisco Tolmasky.
+ * Copyright 2008, 280 North, Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include "../../Foundation/_CGGeometry.h"
+
+#define _CGAffineTransformMake(a_, b_, c_, d_, tx_, ty_) { a:a_, b:b_, c:c_, d:d_, tx:tx_, ty:ty_ }
+#define _CGAffineTransformMakeIdentity() _CGAffineTransformMake(1.0, 0.0, 0.0, 1.0, 0.0, 0.0)
+#define _CGAffineTransformMakeCopy(aTransform) _CGAffineTransformMake(aTransform.a, aTransform.b, aTransform.c, aTransform.d, aTransform.tx, aTransform.ty)
+
+#define _CGAffineTransformMakeScale(sx, sy) _CGAffineTransformMake(sx, 0.0, 0.0, sy, 0.0, 0.0)
+#define _CGAffineTransformMakeTranslation(tx, ty) _CGAffineTransformMake(1.0, 0.0, 0.0, 1.0, tx, ty)
+
+#define _CGAffineTransformTranslate(aTransform, tx, ty) _CGAffineTransformMake(aTransform.a, aTransform.b, aTransform.c, aTransform.d, aTransform.tx + aTransform.a * tx + aTransform.c * ty, aTransform.ty + aTransform.b * tx + aTransform.d * ty)
+#define _CGAffineTransformScale(aTransform, sx, sy) _CGAffineTransformMake(aTransform.a * sx, aTransform.b * sx, aTransform.c * sy, aTransform.d * sy, aTransform.tx, aTransform.ty)
+
+#define _CGAffineTransformConcat(lhs, rhs) _CGAffineTransformMake(lhs.a * rhs.a + lhs.b * rhs.c, lhs.a * rhs.b + lhs.b * rhs.d, lhs.c * rhs.a + lhs.d * rhs.c, lhs.c * rhs.b + lhs.d * rhs.d, lhs.tx * rhs.a + lhs.ty * rhs.c + rhs.tx, lhs.tx * rhs.b + lhs.ty * rhs.d + rhs.ty)
+
+#define _CGPointApplyAffineTransform(aPoint, aTransform) _CGPointMake(aPoint.x * aTransform.a + aPoint.y * aTransform.c + aTransform.tx, aPoint.x * aTransform.b + aPoint.y * aTransform.d + aTransform.ty)
+#define _CGSizeApplyAffineTransform(aSize, aTransform) _CGSizeMake(aSize.width * aTransform.a + aSize.height * aTransform.c, aSize.width * aTransform.b + aSize.height * aTransform.d)
+#define _CGRectApplyAffineTransform(aRect, aTransform) { origin:_CGPointApplyAffineTransform(aRect.origin, aTransform), size:_CGSizeApplyAffineTransform(aRect.size, aTransform) }
+
+#define _CGAffineTransformIsIdentity(aTransform) (aTransform.a == 1 && aTransform.b == 0 && aTransform.c == 0 && aTransform.d == 1 && aTransform.tx == 0 && aTransform.ty == 0)
+#define _CGAffineTransformEqualToTransform(lhs, rhs) (lhs.a == rhs.a && lhs.b == rhs.b && lhs.c == rhs.c && lhs.d == rhs.d && lhs.tx == rhs.tx && lhs.ty == rhs.ty)
+
+#define _CGStringCreateWithCGAffineTransform(aTransform) (" [[ " + aTransform.a + ", " + aTransform.b + ", 0 ], [ " + aTransform.c + ", " + aTransform.d + ", 0 ], [ " + aTransform.tx + ", " + aTransform.ty + ", 1]]")
+
+#define _CGAffineTransformConcatTo(lhs, rhs, to) \
+var tx = lhs.tx * rhs.a + lhs.ty * rhs.c + rhs.tx;\
+to.ty = lhs.tx * rhs.b + lhs.ty * rhs.d + rhs.ty;\
+to.tx = tx;\
+var a = lhs.a * rhs.a + lhs.b * rhs.c,\
+    b = lhs.a * rhs.b + lhs.b * rhs.d,\
+    c = lhs.c * rhs.a + lhs.d * rhs.c;\
+to.d = lhs.c * rhs.b + lhs.d * rhs.d;\
+to.a = a;\
+to.b = b;\
+to.c = c;\
+
+/*
+a  b  0 cos sin 0
+c  d  0 -sin cos 0
+tx ty 1 0 0 1
+*/

AppKit/CoreGraphics/CGAffineTransform.j

@@ -23,110 +23,35 @@
 @import "CGGeometry.j"
 
 
-function CGAffineTransformMake(a, b, c, d, tx, ty)
-{
-    return { a:a, b:b, c:c, d:d, tx:tx, ty:ty };
-}
+#define _function(inline) function inline { return _##inline; }
 
-function CGAffineTransformMakeIdentity()
-{
-    return { a:1.0, b:0.0, c:0.0, d:1.0, tx:0.0, ty:0.0 };
-}
+_function(CGAffineTransformMake(a, b, c, d, tx, ty))
+_function(CGAffineTransformMakeIdentity())
+_function(CGAffineTransformMakeCopy(anAffineTransform))
 
-function CGAffineTransformMakeCopy(anAffineTransform)
-{
-    return { a:anAffineTransform.a, b:anAffineTransform.b, c:anAffineTransform.c, d:anAffineTransform.d, tx:anAffineTransform.tx, ty:anAffineTransform.ty };
-}
+_function(CGAffineTransformMakeScale(sx, sy))
+_function(CGAffineTransformMakeTranslation(tx, ty))
+_function(CGAffineTransformTranslate(aTransform, tx, ty))
+_function(CGAffineTransformScale(aTransform, sx, sy))
 
-function CGAffineTransformMakeScale(sx, sy)
-{
-    return { a:sx, b:0.0, c:0.0, d:sy, tx:0.0, ty:0.0 };
-}
+_function(CGAffineTransformConcat(lhs, rhs))
+_function(CGPointApplyAffineTransform(aPoint, aTransform))
+_function(CGSizeApplyAffineTransform(aSize, aTransform))
 
-function CGAffineTransformMakeTranslation(tx, ty)
-{
-    return { a:1.0, b:0.0, c:0.0, d:1.0, tx:tx, ty:ty };
-}
-
-function CGAffineTransformTranslate(aTransform, tx, ty)
-{
-    return CGAffineTransformMake(aTransform.a, aTransform.b, aTransform.c, aTransform.d, aTransform.tx + aTransform.a * tx + aTransform.c * ty, aTransform.ty + aTransform.b * tx + aTransform.d * ty);
-}
-
-function CGAffineTransformScale(aTransform, sx, sy)
-{
-    return CGAffineTransformMake(aTransform.a * sx, aTransform.b * sx, aTransform.c * sy, aTransform.d * sy, aTransform.tx, aTransform.ty);
-}
-
-
-function CGAffineTransformConcat(lhs, rhs)
-{
-    return CGAffineTransformMake(lhs.a * rhs.a + lhs.b * rhs.c, lhs.a * rhs.b + lhs.b * rhs.d, lhs.c * rhs.a + lhs.d * rhs.c, lhs.c * rhs.b + lhs.d * rhs.d, lhs.tx * rhs.a + lhs.ty * rhs.c + rhs.tx, lhs.tx * rhs.b + lhs.ty * rhs.d + rhs.ty);
-}
-
-function CGAffineTransformConcatTo(lhs, rhs, to)
-{
-    var tx = lhs.tx * rhs.a + lhs.ty * rhs.c + rhs.tx;
-
-    to.ty = lhs.tx * rhs.b + lhs.ty * rhs.d + rhs.ty;
-    to.tx = tx;
-
-    var a = lhs.a * rhs.a + lhs.b * rhs.c,
-        b = lhs.a * rhs.b + lhs.b * rhs.d,
-        c = lhs.c * rhs.a + lhs.d * rhs.c;
-
-    to.d = lhs.c * rhs.b + lhs.d * rhs.d;
-    to.a = a;
-    to.b = b;
-    to.c = c;
-}
-
-function CGPointApplyAffineTransform(aPoint, aTransform)
-{
-    return { x:aPoint.x * aTransform.a + aPoint.y * aTransform.c + aTransform.tx,
-             y:aPoint.x * aTransform.b + aPoint.y * aTransform.d + aTransform.ty };
-}
-
-function CGSizeApplyAffineTransform(aSize, aTransform)
-{
-    return { width:aSize.width * aTransform.a + aSize.height * aTransform.c,
-             height:aSize.width * aTransform.b + aSize.height * aTransform.d };
-}
-
-
-function CGAffineTransformIsIdentity(aTransform)
-{
-    return (aTransform.a === 1.0 &&
-            aTransform.b === 0.0 &&
-            aTransform.c === 0.0 &&
-            aTransform.d === 1.0 &&
-            aTransform.tx === 0.0 &&
-            aTransform.ty === 0.0);
-}
-
-function CGAffineTransformEqualToTransform(lhs, rhs)
-{
-    return (lhs.a === rhs.a &&
-            lhs.b === rhs.b &&
-            lhs.c === rhs.c &&
-            lhs.d === rhs.d &&
-            lhs.tx === rhs.tx &&
-            lhs.ty === rhs.ty);
-}
-
-
-function CGStringCreateWithCGAffineTransform(aTransform)
-{
-    return (" [[ " + aTransform.a + ", " + aTransform.b + ", 0 ], [ " + aTransform.c + ", " + aTransform.d + ", 0 ], [ " + aTransform.tx + ", " + aTransform.ty + ", 1]]");
-}
+_function(CGAffineTransformIsIdentity(aTransform))
+_function(CGAffineTransformEqualToTransform(lhs, rhs))
 
+_function(CGStringCreateWithCGAffineTransform(aTransform))
 
 /*
     FIXME: !!!!
     @return void
     @group CGAffineTransform
 */
-CGAffineTransformCreateCopy = CGAffineTransformMakeCopy;
+function CGAffineTransformCreateCopy(aTransform)
+{
+    return _CGAffineTransformMakeCopy(aTransform);
+}
 
 /*!
     Returns a transform that rotates a coordinate system.
@@ -141,7 +66,7 @@ function CGAffineTransformMakeRotation(anAngle)
     var sin = SIN(anAngle),
         cos = COS(anAngle);
 
-    return CGAffineTransformMake(cos, sin, -sin, cos, 0.0, 0.0);
+    return _CGAffineTransformMake(cos, sin, -sin, cos, 0.0, 0.0);
 }
 
 /*!
@@ -196,20 +121,20 @@ function CGAffineTransformInvert(aTransform)
 */
 function CGRectApplyAffineTransform(aRect, anAffineTransform)
 {
-    var top = CGRectGetMinY(aRect),
-        left = CGRectGetMinX(aRect),
-        right = CGRectGetMaxX(aRect),
-        bottom = CGRectGetMaxY(aRect),
-        topLeft = CGPointApplyAffineTransform(CGPointMake(left, top), anAffineTransform),
-        topRight = CGPointApplyAffineTransform(CGPointMake(right, top), anAffineTransform),
-        bottomLeft = CGPointApplyAffineTransform(CGPointMake(left, bottom), anAffineTransform),
-        bottomRight = CGPointApplyAffineTransform(CGPointMake(right, bottom), anAffineTransform),
+    var top = _CGRectGetMinY(aRect),
+        left = _CGRectGetMinX(aRect),
+        right = _CGRectGetMaxX(aRect),
+        bottom = _CGRectGetMaxY(aRect),
+        topLeft = CGPointApplyAffineTransform(_CGPointMake(left, top), anAffineTransform),
+        topRight = CGPointApplyAffineTransform(_CGPointMake(right, top), anAffineTransform),
+        bottomLeft = CGPointApplyAffineTransform(_CGPointMake(left, bottom), anAffineTransform),
+        bottomRight = CGPointApplyAffineTransform(_CGPointMake(right, bottom), anAffineTransform),
         minX = MIN(topLeft.x, topRight.x, bottomLeft.x, bottomRight.x),
         maxX = MAX(topLeft.x, topRight.x, bottomLeft.x, bottomRight.x),
         minY = MIN(topLeft.y, topRight.y, bottomLeft.y, bottomRight.y),
         maxY = MAX(topLeft.y, topRight.y, bottomLeft.y, bottomRight.y);
 
-    return CGRectMake(minX, minY, (maxX - minX), (maxY - minY));
+    return _CGRectMake(minX, minY, (maxX - minX), (maxY - minY));
 }
 
 /*!

AppKit/CoreGraphics/CGContext.j

@@ -116,7 +116,7 @@ function CGGStateCreate()
 {
     return { alpha:1.0, strokeStyle:"#000", fillStyle:"#ccc", lineWidth:1.0, lineJoin:kCGLineJoinMiter, lineCap:kCGLineCapButt, miterLimit:10.0, globalAlpha:1.0,
         blendMode:kCGBlendModeNormal,
-        shadowOffset:CGSizeMakeZero(), shadowBlur:0.0, shadowColor:NULL, CTM:CGAffineTransformMakeIdentity() };
+        shadowOffset:_CGSizeMakeZero(), shadowBlur:0.0, shadowColor:NULL, CTM:_CGAffineTransformMakeIdentity() };
 }
 
 /*!
@@ -129,7 +129,7 @@ function CGGStateCreateCopy(aGState)
     return { alpha:aGState.alpha, strokeStyle:aGState.strokeStyle, fillStyle:aGState.fillStyle, lineWidth:aGState.lineWidth,
         lineJoin:aGState.lineJoin, lineCap:aGState.lineCap, miterLimit:aGState.miterLimit, globalAlpha:aGState.globalAlpha,
         blendMode:aGState.blendMode,
-        shadowOffset:CGSizeMakeCopy(aGState.shadowOffset), shadowBlur:aGState.shadowBlur, shadowColor:aGState.shadowColor, CTM:CGAffineTransformMakeCopy(aGState.CTM) };
+        shadowOffset:_CGSizeMakeCopy(aGState.shadowOffset), shadowBlur:aGState.shadowBlur, shadowColor:aGState.shadowColor, CTM:_CGAffineTransformMakeCopy(aGState.CTM) };
 }
 
 /*!
@@ -166,12 +166,6 @@ function CGContextSetLineCap(aContext, aLineCap)
     aContext.gState.lineCap = aLineCap;
 }
 
-function CGContextSetLineDash(aContext, aPhase, someDashes)
-{
-    aContext.gState.lineDashes = someDashes;
-    aContext.gState.lineDashesPhase = aPhase;
-}
-
 function CGContextSetLineJoin(aContext, aLineJoin)
 {
     aContext.gState.lineJoin = aLineJoin;
@@ -424,7 +418,7 @@ function CGContextConcatCTM(aContext, aTransform)
 {
     var CTM = aContext.gState.CTM;
 
-    CGAffineTransformConcatTo(CTM, aTransform, CTM);
+    _CGAffineTransformConcatTo(CTM, aTransform, CTM);
 }
 
 /*!
@@ -462,7 +456,7 @@ function CGContextScaleCTM(aContext, sx, sy)
 {
     var gState = aContext.gState;
 
-    gState.CTM = CGAffineTransformScale(gState.CTM, sx, sy);
+    gState.CTM = _CGAffineTransformScale(gState.CTM, sx, sy);
 }
 
 /*!
@@ -476,7 +470,7 @@ function CGContextTranslateCTM(aContext, tx, ty)
 {
     var gState = aContext.gState;
 
-    gState.CTM = CGAffineTransformTranslate(gState.CTM, tx, ty);
+    gState.CTM = _CGAffineTransformTranslate(gState.CTM, tx, ty);
 }
 
 /*!
@@ -491,7 +485,7 @@ function CGContextSetShadow(aContext, aSize, aBlur)
 {
     var gState = aContext.gState;
 
-    gState.shadowOffset = CGSizeMakeCopy(aSize);
+    gState.shadowOffset = _CGSizeMakeCopy(aSize);
     gState.shadowBlur = aBlur;
     gState.shadowColor = [CPColor shadowColor];
 }
@@ -508,7 +502,7 @@ function CGContextSetShadowWithColor(aContext, aSize, aBlur, aColor)
 {
     var gState = aContext.gState;
 
-    gState.shadowOffset = CGSizeMakeCopy(aSize);
+    gState.shadowOffset = _CGSizeMakeCopy(aSize);
     gState.shadowBlur = aBlur;
     gState.shadowColor = aColor;
 }

AppKit/CoreGraphics/CGContextCanvas.j

@@ -38,9 +38,9 @@ var CANVAS_LINECAP_TABLE    = [ "butt", "round", "square" ],
 #define _CGContextClosePathCanvas(aContext) aContext.closePath()
 #define _CGContextMoveToPointCanvas(aContext, x, y) aContext.moveTo(x, y)
 
-#define _CGContextAddRectCanvas(aContext, aRect) aContext.rect(CGRectGetMinX(aRect), CGRectGetMinY(aRect), CGRectGetWidth(aRect), CGRectGetHeight(aRect))
+#define _CGContextAddRectCanvas(aContext, aRect) aContext.rect(_CGRectGetMinX(aRect), _CGRectGetMinY(aRect), _CGRectGetWidth(aRect), _CGRectGetHeight(aRect))
 #define _CGContextBeginPathCanvas(aContext) aContext.beginPath()
-#define _CGContextFillRectCanvas(aContext, aRect) aContext.fillRect(CGRectGetMinX(aRect), CGRectGetMinY(aRect), CGRectGetWidth(aRect), CGRectGetHeight(aRect))
+#define _CGContextFillRectCanvas(aContext, aRect) aContext.fillRect(_CGRectGetMinX(aRect), _CGRectGetMinY(aRect), _CGRectGetWidth(aRect), _CGRectGetHeight(aRect))
 #define _CGContextClipCanvas(aContext) aContext.clip()
 
 // In Cocoa, all primitives excepts rects cannot be added to the context's path
@@ -68,29 +68,6 @@ function CGContextSetLineCap(aContext, aLineCap)
     aContext.lineCap = CANVAS_LINECAP_TABLE[aLineCap];
 }
 
-function CGContextSetLineDash(aContext, aPhase, someDashes)
-{
-    if (aContext.setLineDash)
-    {
-        aContext.setLineDash(someDashes);
-        aContext.lineDashOffset = aPhase;
-    }
-    else if (typeof aContext['webkitLineDash'] !== 'undefined')
-    {
-        aContext.webkitLineDash = someDashes;
-        aContext.webkitLineDashOffset = aPhase;
-    }
-    else if (typeof aContext['mozDash'] !== 'undefined')
-    {
-        aContext.mozDash = someDashes;
-        aContext.mozDashOffset = aPhase;
-    }
-    else if (someDashes)
-    {
-        CPLog.warn("CGContextSetLineDash not implemented in this environment.")
-    }
-}
-
 function CGContextSetLineJoin(aContext, aLineJoin)
 {
     aContext.lineJoin = CANVAS_LINEJOIN_TABLE[aLineJoin];
@@ -270,7 +247,7 @@ function CGContextMoveToPoint(aContext, x, y)
 
 function CGContextClearRect(aContext, aRect)
 {
-    aContext.clearRect(CGRectGetMinX(aRect), CGRectGetMinY(aRect), CGRectGetWidth(aRect), CGRectGetHeight(aRect));
+    aContext.clearRect(_CGRectGetMinX(aRect), _CGRectGetMinY(aRect), _CGRectGetWidth(aRect), _CGRectGetHeight(aRect));
     aContext.hasPath = NO;
 }
 
@@ -311,7 +288,7 @@ function CGContextFillRects(aContext, rects, count)
 
 function CGContextStrokeRect(aContext, aRect)
 {
-    aContext.strokeRect(CGRectGetMinX(aRect), CGRectGetMinY(aRect), CGRectGetWidth(aRect), CGRectGetHeight(aRect));
+    aContext.strokeRect(_CGRectGetMinX(aRect), _CGRectGetMinY(aRect), _CGRectGetWidth(aRect), _CGRectGetHeight(aRect));
     aContext.hasPath = NO;
 }
 
@@ -583,7 +560,7 @@ CGContextConcatCTM = function(aContext, anAffineTransform)
 
 function CGContextDrawImage(aContext, aRect, anImage)
 {
-    aContext.drawImage(anImage._image, CGRectGetMinX(aRect), CGRectGetMinY(aRect), CGRectGetWidth(aRect), CGRectGetHeight(aRect));
+    aContext.drawImage(anImage._image, _CGRectGetMinX(aRect), _CGRectGetMinY(aRect), _CGRectGetWidth(aRect), _CGRectGetHeight(aRect));
     aContext.hasPath = NO;
 }
 

AppKit/CoreGraphics/CGContextVML.j

@@ -82,7 +82,7 @@ function CGContextDrawImage(aContext, aRect, anImage)
         {
             var angle = CGPointMake(1.0, 0.0);
 
-            angle = CGPointApplyAffineTransform(angle, ctm);
+            angle = _CGPointApplyAffineTransform(angle, ctm);
 
             vml.push(";rotation:", ATAN2(angle.y - ctm.ty, angle.x - ctm.tx) * 180 / PI);
         }*/
@@ -95,7 +95,7 @@ function CGContextDrawImage(aContext, aRect, anImage)
         {
             var transformedRect = CGRectApplyAffineTransform(aRect, ctm);
 
-            vml.push(   ";padding:0 ", ROUND(CGRectGetMaxX(transformedRect)), "px ", ROUND(CGRectGetMaxY(transformedRect)),
+            vml.push(   ";padding:0 ", ROUND(_CGRectGetMaxX(transformedRect)), "px ", ROUND(_CGRectGetMaxY(transformedRect)),
                         "px 0;filter:progid:DXImageTransform.Microsoft.Matrix(",
                         "M11='", ctm.a, "',M12='", ctm.c, "',M21='", ctm.b, "',M22='", ctm.d, "',",
                         "Dx='", ROUND(origin.x), "', Dy='", ROUND(origin.y), "', sizingmethod='clip');");
@@ -104,7 +104,7 @@ function CGContextDrawImage(aContext, aRect, anImage)
         //    vml.push(";top:", ROUND(origin.y - 0.5), "px;left:", ROUND(origin.x - 0.5), "px;");
 
         vml.push(   "\"><cg_vml_:image src=\"", anImage._image.src,
-                    "\" style=\"width:", CGRectGetWidth(aRect), "px;height:", CGRectGetHeight(aRect),
+                    "\" style=\"width:", _CGRectGetWidth(aRect), "px;height:", _CGRectGetHeight(aRect),
                     "px;\"/></g_vml_:group>");
 
         string = vml.join("");
@@ -175,7 +175,7 @@ function CGContextDrawPath(aContext, aMode)
                                                         endAngle = element.endAngle,
                                                         startAngle = element.startAngle,
 
-                                                        start = CGPointMake(x + radius * COS(startAngle), y + radius * SIN(startAngle));
+                                                        start = _CGPointMake(x + radius * COS(startAngle), y + radius * SIN(startAngle));
 
                                                     // If the angle's are equal, then we won't actually draw an arc, but instead
                                                     // simply move to its start/end to get the proper fill.
@@ -188,12 +188,12 @@ function CGContextDrawPath(aContext, aMode)
                                                         continue;
                                                     }
 
-                                                    var end = CGPointMake(x + radius * COS(endAngle), y + radius * SIN(endAngle));
+                                                    var end = _CGPointMake(x + radius * COS(endAngle), y + radius * SIN(endAngle));
 
                                                     // Only do the start correction if the angles aren't equal.  If they are, then
                                                     // let the circle be empty.
                                                     // FIXME: Should this be |star.x - end.x| < 0.125 ?
-                                                    if (clockwise && startAngle != endAngle && CGPointEqualToPoint(start, end))
+                                                    if (clockwise && startAngle != endAngle && _CGPointEqualToPoint(start, end))
                                                         if (start.x >= x)
                                                         {
                                                             if (start.y < y)

AppKit/CoreGraphics/CGPath.j

@@ -43,7 +43,7 @@ kCGPathElementAddArcToPoint         = 6;
 */
 function CGPathCreateMutable()
 {
-    return { count:0, start:CGPointMake(0, 0), current:CGPointMake(0, 0), elements:[] };
+    return { count:0, start:_CGPointMake(0, 0), current:_CGPointMake(0, 0), elements:[] };
 }
 
 /*!
@@ -79,15 +79,15 @@ function CGPathRetain(aPath)
 
 function CGPathAddArc(aPath, aTransform, x, y, aRadius, aStartAngle, anEndAngle, isClockwise)
 {
-    if (aTransform && !CGAffineTransformIsIdentity(aTransform))
+    if (aTransform && !_CGAffineTransformIsIdentity(aTransform))
     {
-        var center = CGPointMake(x, y),
-            end = CGPointMake(COS(anEndAngle), SIN(anEndAngle)),
-            start = CGPointMake(COS(aStartAngle), SIN(aStartAngle));
+        var center = _CGPointMake(x, y),
+            end = _CGPointMake(COS(anEndAngle), SIN(anEndAngle)),
+            start = _CGPointMake(COS(aStartAngle), SIN(aStartAngle));
 
-        end = CGPointApplyAffineTransform(end, aTransform);
-        start = CGPointApplyAffineTransform(start, aTransform);
-        center = CGPointApplyAffineTransform(center, aTransform);
+        end = _CGPointApplyAffineTransform(end, aTransform);
+        start = _CGPointApplyAffineTransform(start, aTransform);
+        center = _CGPointApplyAffineTransform(center, aTransform);
 
         x = center.x;
         y = center.y;
@@ -107,8 +107,8 @@ function CGPathAddArc(aPath, aTransform, x, y, aRadius, aStartAngle, anEndAngle,
             else
                 aStartAngle = aStartAngle - PI2;
 
-        aRadius = CGSizeMake(aRadius, 0);
-        aRadius = CGSizeApplyAffineTransform(aRadius, aTransform);
+        aRadius = _CGSizeMake(aRadius, 0);
+        aRadius = _CGSizeApplyAffineTransform(aRadius, aTransform);
         aRadius = SQRT(aRadius.width * aRadius.width + aRadius.height * aRadius.height);
     }
 
@@ -132,22 +132,22 @@ function CGPathAddArc(aPath, aTransform, x, y, aRadius, aStartAngle, anEndAngle,
         var arcStartX = x + aRadius * COS(aStartAngle),
             arcStartY = y + aRadius * SIN(aStartAngle);
 
-        aPath.start = CGPointMake(arcStartX, arcStartY);
+        aPath.start = _CGPointMake(arcStartX, arcStartY);
     }
 
-    aPath.current = CGPointMake(arcEndX, arcEndY);
+    aPath.current = _CGPointMake(arcEndX, arcEndY);
     aPath.elements[aPath.count++] = { type:kCGPathElementAddArc, x:x, y:y, radius:aRadius, startAngle:aStartAngle, endAngle:anEndAngle, clockwise:isClockwise };
 }
 
 function CGPathAddArcToPoint(aPath, aTransform, x1, y1, x2, y2, aRadius)
 {
-    var p1 = CGPointMake(x1, y1),
-        p2 = CGPointMake(x2, y2);
+    var p1 = _CGPointMake(x1, y1),
+        p2 = _CGPointMake(x2, y2);
 
     if (aTransform)
     {
-        p1 = CGPointApplyAffineTransform(p1, aTransform);
-        p2 = CGPointApplyAffineTransform(p2, aTransform);
+        p1 = _CGPointApplyAffineTransform(p1, aTransform);
+        p2 = _CGPointApplyAffineTransform(p2, aTransform);
     }
 
     /*
@@ -171,15 +171,15 @@ function CGPathAddArcToPoint(aPath, aTransform, x1, y1, x2, y2, aRadius)
 
 function CGPathAddCurveToPoint(aPath, aTransform, cp1x, cp1y, cp2x, cp2y, x, y)
 {
-    var cp1 = CGPointMake(cp1x, cp1y),
-        cp2 = CGPointMake(cp2x, cp2y),
-        end = CGPointMake(x, y);
+    var cp1 = _CGPointMake(cp1x, cp1y),
+        cp2 = _CGPointMake(cp2x, cp2y),
+        end = _CGPointMake(x, y);
 
     if (aTransform)
     {
-        cp1 = CGPointApplyAffineTransform(cp1, aTransform);
-        cp2 = CGPointApplyAffineTransform(cp2, aTransform);
-        end = CGPointApplyAffineTransform(end, aTransform);
+        cp1 = _CGPointApplyAffineTransform(cp1, aTransform);
+        cp2 = _CGPointApplyAffineTransform(cp2, aTransform);
+        end = _CGPointApplyAffineTransform(end, aTransform);
     }
 
     aPath.current = end;
@@ -202,10 +202,10 @@ function CGPathAddLines(aPath, aTransform, points, count)
 
 function CGPathAddLineToPoint(aPath, aTransform, x, y)
 {
-    var point = CGPointMake(x, y);
+    var point = _CGPointMake(x, y);
 
     if (aTransform !== NULL)
-        point = CGPointApplyAffineTransform(point, aTransform);
+        point = _CGPointApplyAffineTransform(point, aTransform);
 
     aPath.elements[aPath.count++] = { type: kCGPathElementAddLineToPoint, x:point.x, y:point.y };
     aPath.current = point;
@@ -262,13 +262,13 @@ function CGPathAddPath(aPath, aTransform, anotherPath)
 
 function CGPathAddQuadCurveToPoint(aPath, aTransform, cpx, cpy, x, y)
 {
-    var cp = CGPointMake(cpx, cpy),
-        end = CGPointMake(x, y);
+    var cp = _CGPointMake(cpx, cpy),
+        end = _CGPointMake(x, y);
 
     if (aTransform)
     {
-        cp = CGPointApplyAffineTransform(cp, aTransform);
-        end = CGPointApplyAffineTransform(end, aTransform);
+        cp = _CGPointApplyAffineTransform(cp, aTransform);
+        end = _CGPointApplyAffineTransform(end, aTransform);
     }
 
     aPath.elements[aPath.count++] = { type:kCGPathElementAddQuadCurveToPoint, cpx:cp.x, cpy:cp.y, x:end.x, y:end.y }
@@ -291,10 +291,10 @@ function CGPathAddRects(aPath, aTransform, rects, count)
     {
         var rect = rects[i];
 
-        CGPathMoveToPoint(aPath, aTransform, CGRectGetMinX(rect), CGRectGetMinY(rect));
-        CGPathAddLineToPoint(aPath, aTransform, CGRectGetMaxX(rect), CGRectGetMinY(rect));
-        CGPathAddLineToPoint(aPath, aTransform, CGRectGetMaxX(rect), CGRectGetMaxY(rect));
-        CGPathAddLineToPoint(aPath, aTransform, CGRectGetMinX(rect), CGRectGetMaxY(rect));
+        CGPathMoveToPoint(aPath, aTransform, _CGRectGetMinX(rect), _CGRectGetMinY(rect));
+        CGPathAddLineToPoint(aPath, aTransform, _CGRectGetMaxX(rect), _CGRectGetMinY(rect));
+        CGPathAddLineToPoint(aPath, aTransform, _CGRectGetMaxX(rect), _CGRectGetMaxY(rect));
+        CGPathAddLineToPoint(aPath, aTransform, _CGRectGetMinX(rect), _CGRectGetMaxY(rect));
 
         CGPathCloseSubpath(aPath);
     }
@@ -302,10 +302,10 @@ function CGPathAddRects(aPath, aTransform, rects, count)
 
 function CGPathMoveToPoint(aPath, aTransform, x, y)
 {
-    var point = CGPointMake(x, y);
+    var point = _CGPointMake(x, y);
 
     if (aTransform !== NULL)
-        point = CGPointApplyAffineTransform(point, aTransform);
+        point = _CGPointApplyAffineTransform(point, aTransform);
 
     aPath.start = aPath.current = point;
 
@@ -331,12 +331,12 @@ function CGPathWithEllipseInRect(aRect)
 {
     var path = CGPathCreateMutable();
 
-    if (CGRectGetWidth(aRect) === CGRectGetHeight(aRect))
-        CGPathAddArc(path, nil, CGRectGetMidX(aRect), CGRectGetMidY(aRect), CGRectGetWidth(aRect) / 2.0, 0.0, 2 * PI, YES);
+    if (_CGRectGetWidth(aRect) === _CGRectGetHeight(aRect))
+        CGPathAddArc(path, nil, _CGRectGetMidX(aRect), _CGRectGetMidY(aRect), _CGRectGetWidth(aRect) / 2.0, 0.0, 2 * PI, YES);
     else
     {
-        var axis = CGSizeMake(CGRectGetWidth(aRect) / 2.0, CGRectGetHeight(aRect) / 2.0),
-            center = CGPointMake(CGRectGetMinX(aRect) + axis.width, CGRectGetMinY(aRect) + axis.height);
+        var axis = _CGSizeMake(_CGRectGetWidth(aRect) / 2.0, _CGRectGetHeight(aRect) / 2.0),
+            center = _CGPointMake(_CGRectGetMinX(aRect) + axis.width, _CGRectGetMinY(aRect) + axis.height);
 
         CGPathMoveToPoint(path, nil, center.x, center.y - axis.height);
 
@@ -354,10 +354,10 @@ function CGPathWithEllipseInRect(aRect)
 function CGPathWithRoundedRectangleInRect(aRect, xRadius, yRadius/*not currently supported*/, ne, se, sw, nw)
 {
     var path = CGPathCreateMutable(),
-        xMin = CGRectGetMinX(aRect),
-        xMax = CGRectGetMaxX(aRect),
-        yMin = CGRectGetMinY(aRect),
-        yMax = CGRectGetMaxY(aRect);
+        xMin = _CGRectGetMinX(aRect),
+        xMax = _CGRectGetMaxX(aRect),
+        yMin = _CGRectGetMinY(aRect),
+        yMax = _CGRectGetMaxY(aRect);
 
     CGPathMoveToPoint(path, nil, xMin + xRadius, yMin);
 
@@ -407,7 +407,7 @@ function CGPathCloseSubpath(aPath)
         return;
 
     // After closing, the current point is the previous path's starting point
-    aPath.current = CGPointCreateCopy(aPath.start);
+    aPath.current = _CGPointCreateCopy(aPath.start);
     aPath.elements[aPath.count++] = { type:kCGPathElementCloseSubpath, start:aPath.start };
 }
 
@@ -416,7 +416,7 @@ function CGPathEqualToPath(aPath, anotherPath)
     if (aPath === anotherPath)
         return YES;
 
-    if (aPath.count !== anotherPath.count || !CGPointEqualToPoint(aPath.start, anotherPath.start) || !CGPointEqualToPoint(aPath.current, anotherPath.current))
+    if (aPath.count !== anotherPath.count || !_CGPointEqualToPoint(aPath.start, anotherPath.start) || !_CGPointEqualToPoint(aPath.current, anotherPath.current))
         return NO;
 
     var i = 0,
@@ -487,7 +487,7 @@ function CGPathEqualToPath(aPath, anotherPath)
                 break;
 
             case kCGPathElementCloseSubpath:
-                if (!CGPointEqualToPoint(element.start, anotherElement.start))
+                if (!_CGPointEqualToPoint(element.start, anotherElement.start))
                     return NO;
                 break;
         }
@@ -498,7 +498,7 @@ function CGPathEqualToPath(aPath, anotherPath)
 
 function CGPathGetCurrentPoint(aPath)
 {
-    return CGPointCreateCopy(aPath.current);
+    return _CGPointCreateCopy(aPath.current);
 }
 
 function CGPathIsEmpty(aPath)
@@ -512,7 +512,7 @@ function CGPathIsEmpty(aPath)
 function CGPathGetBoundingBox(aPath)
 {
     if (!aPath || !aPath.count)
-        return CGRectMakeZero();
+        return _CGRectMakeZero();
 
     var ox = 0,
         oy = 0,
@@ -591,7 +591,7 @@ function CGPathGetBoundingBox(aPath)
                 break;
 
             case kCGPathElementMoveToPoint:
-                movePoint = CGPointMake(element.x, element.y);
+                movePoint = _CGPointMake(element.x, element.y);
                 break;
 
             case kCGPathElementCloseSubpath:
@@ -605,7 +605,7 @@ function CGPathGetBoundingBox(aPath)
         }
     }
 
-    return CGRectMake(ox, oy, rx - ox, ry - oy);
+    return _CGRectMake(ox, oy, rx - ox, ry - oy);
 }
 
 /*!

AppKit/Platform/CPPlatformString.j

@@ -33,7 +33,7 @@
 
 + (CGSize)sizeOfString:(CPString)aString withFont:(CPFont)aFont forWidth:(float)aWidth
 {
-    return CGSizeMakeZero();
+    return _CGSizeMakeZero();
 }
 
 @end
@@ -45,7 +45,7 @@
 
 + (CGSize)sizeOfString:(CPString)aString withFont:(CPFont)aFont forWidth:(float)aWidth
 {
-    return CGSizeMakeZero();
+    return _CGSizeMakeZero();
 }
 
 + (CPDictionary)metricsOfFont:(CPFont)aFont

AppKit/Platform/CPPlatformWindow.j

@@ -106,7 +106,7 @@ var PrimaryPlatformWindow   = NULL;
 
     if (self)
     {
-        _contentRect = CGRectMakeCopy(aRect);
+        _contentRect = _CGRectMakeCopy(aRect);
 
 #if PLATFORM(DOM)
         _windowLevels = [];
@@ -121,19 +121,19 @@ var PrimaryPlatformWindow   = NULL;
 
 - (id)init
 {
-    return [self initWithContentRect:CGRectMake(0.0, 0.0, 400.0, 500.0)];
+    return [self initWithContentRect:_CGRectMake(0.0, 0.0, 400.0, 500.0)];
 }
 
 - (CGRect)contentRect
 {
-    return CGRectMakeCopy(_contentRect);
+    return _CGRectMakeCopy(_contentRect);
 }
 
 - (CGRect)contentBounds
 {
     var contentBounds = [self contentRect];
 
-    contentBounds.origin = CGPointMakeZero();
+    contentBounds.origin = _CGPointMakeZero();
 
     return contentBounds;
 }
@@ -142,7 +142,7 @@ var PrimaryPlatformWindow   = NULL;
 {
     var frame = [self contentBounds];
 
-    frame.origin = CGPointMakeZero();
+    frame.origin = _CGPointMakeZero();
 
     if ([CPMenu menuBarVisible] && [CPPlatformWindow primaryPlatformWindow] === self)
     {
@@ -162,10 +162,10 @@ var PrimaryPlatformWindow   = NULL;
 
 - (void)setContentRect:(CGRect)aRect
 {
-    if (!aRect || CGRectEqualToRect(_contentRect, aRect))
+    if (!aRect || _CGRectEqualToRect(_contentRect, aRect))
         return;
 
-    _contentRect = CGRectMakeCopy(aRect);
+    _contentRect = _CGRectMakeCopy(aRect);
 
 #if PLATFORM(DOM)
      [self updateNativeContentRect];
@@ -181,14 +181,14 @@ var PrimaryPlatformWindow   = NULL;
 {
     var contentRect = [self contentRect];
 
-    return CGPointMake(aPoint.x + CGRectGetMinX(contentRect), aPoint.y + CGRectGetMinY(contentRect));
+    return _CGPointMake(aPoint.x + _CGRectGetMinX(contentRect), aPoint.y + _CGRectGetMinY(contentRect));
 }
 
 - (CGPoint)convertScreenToBase:(CGPoint)aPoint
 {
     var contentRect = [self contentRect];
 
-    return CGPointMake(aPoint.x - CGRectGetMinX(contentRect), aPoint.y - CGRectGetMinY(contentRect));
+    return _CGPointMake(aPoint.x - _CGRectGetMinX(contentRect), aPoint.y - _CGRectGetMinY(contentRect));
 }
 
 - (BOOL)isVisible

AppKit/Platform/DOM/CPDOMDisplayServer.h

@@ -49,26 +49,26 @@
     CPDOMDisplayServerInstructions[__index + 4] = y;
 #if !DOM_OPTIMIZATION
 #define CPDOMDisplayServerSetStyleLeftTop(aDOMElement, aTransform, aLeft, aTop) \
-if (aTransform) var ____p = CGPointApplyAffineTransform(CGPointMake(aLeft, aTop), aTransform); \
-else var ____p = CGPointMake(aLeft, aTop); \
+if (aTransform) var ____p = _CGPointApplyAffineTransform(CGPointMake(aLeft, aTop), aTransform); \
+else var ____p = _CGPointMake(aLeft, aTop); \
 aDOMElement.style.left = ROUND(____p.x) + "px";\
 aDOMElement.style.top = ROUND(____p.y) + "px";
 
 #define CPDOMDisplayServerSetStyleRightTop(aDOMElement, aTransform, aRight, aTop) \
-if (aTransform) var ____p = CGPointApplyAffineTransform(CGPointMake(aRight, aTop), aTransform); \
-else var ____p = CGPointMake(aRight, aTop); \
+if (aTransform) var ____p = _CGPointApplyAffineTransform(CGPointMake(aRight, aTop), aTransform); \
+else var ____p = _CGPointMake(aRight, aTop); \
 aDOMElement.style.right = ROUND(____p.x) + "px";\
 aDOMElement.style.top = ROUND(____p.y) + "px";
 
 #define CPDOMDisplayServerSetStyleLeftBottom(aDOMElement, aTransform, aLeft, aBottom) \
-if (aTransform) var ____p = CGPointApplyAffineTransform(CGPointMake(aLeft, aBottom), aTransform); \
-else var ____p = CGPointMake(aLeft, aBottom); \
+if (aTransform) var ____p = _CGPointApplyAffineTransform(CGPointMake(aLeft, aBottom), aTransform); \
+else var ____p = _CGPointMake(aLeft, aBottom); \
 aDOMElement.style.left = ROUND(____p.x) + "px";\
 aDOMElement.style.bottom = ROUND(____p.y) + "px";
 
 #define CPDOMDisplayServerSetStyleRightBottom(aDOMElement, aTransform, aRight, aBottom) \
-if (aTransform) var ____p = CGPointApplyAffineTransform(CGPointMake(aRight, aBottom), aTransform); \
-else var ____p = CGPointMake(aRight, aBottom); \
+if (aTransform) var ____p = _CGPointApplyAffineTransform(CGPointMake(aRight, aBottom), aTransform); \
+else var ____p = _CGPointMake(aRight, aBottom); \
 aDOMElement.style.right = ROUND(____p.x) + "px";\
 aDOMElement.style.bottom = ROUND(____p.y) + "px";
 
@@ -166,8 +166,8 @@ CPDOMDisplayServerInstructionCount = 0;
                                             var transform = CPDOMDisplayServerInstructions[index++];\
                                             if (transform)\
                                             {\
-                                                var point = CGPointMake(CPDOMDisplayServerInstructions[index++], CPDOMDisplayServerInstructions[index++]),\
-                                                    transformed = CGPointApplyAffineTransform(point, transform);\
+                                                var point = _CGPointMake(CPDOMDisplayServerInstructions[index++], CPDOMDisplayServerInstructions[index++]),\
+                                                    transformed = _CGPointApplyAffineTransform(point, transform);\
                                                 style[x] = ROUND(transformed.x) + "px";\
                                                 style[y] = ROUND(transformed.y) + "px";\
                                             }\

AppKit/Platform/DOM/CPDOMWindowLayer.j

@@ -130,52 +130,4 @@
     return _windows;
 }
 
-/*!
-    Places \c aWindow within an element that clips it to the global rect \c clipRect.
-
-    NOTE: This is only meant for temporary usage during animation and should be balanced
-    with a call to removeClipForWindow:. No attempt is made to make the clipping element follow
-    changes to the window.
-*/
-- (void)clipWindow:(CPWindow)aWindow toRect:(CGRect)clipRect
-{
-    // First check to see if the window is already clipped.
-    // If so, just update its rect.
-    var windowElement = aWindow._DOMElement,
-        clip = document.createElement("div"),
-        style = clip.style;
-
-    style = clip.style;
-    style.className = "cpwindowclip";
-    style.position = "absolute";
-    style.overflow = "hidden";
-
-    style.left = clipRect.origin.x + "px";
-    style.top = clipRect.origin.y + "px";
-    style.width = clipRect.size.width + "px";
-    style.height = clipRect.size.height + "px";
-
-    // Replace the window with the clip element, then put it inside the clip
-    var parent = windowElement.parentNode;
-    CPDOMDisplayServerInsertBefore(parent, clip, windowElement);
-    CPDOMDisplayServerRemoveChild(parent, windowElement);
-    CPDOMDisplayServerAppendChild(clip, windowElement);
-}
-
-/*!
-    Unclips a window that was previously clipped with clipWindow:toWindow:.
-    If the window was not clipped, a warning is logged.
-*/
-- (void)removeClipForWindow:(CPWindow)aWindow
-{
-    var windowElement = aWindow._DOMElement,
-        clip = windowElement.parentNode,
-        parent = clip.parentNode;
-
-    CPDOMDisplayServerRemoveChild(clip, windowElement);
-    [aWindow setFrameOrigin:CGPointMake([aWindow frame].origin.x, clip.offsetTop)];
-    CPDOMDisplayServerInsertBefore(parent, windowElement, clip);
-    CPDOMDisplayServerRemoveChild(parent, clip);
-}
-
 @end

AppKit/Platform/DOM/CPPlatformString.j

@@ -151,7 +151,7 @@ var DOMFixedWidthSpanElement    = nil,
     else if (CPFeatureIsCompatible(CPJavaScriptTextContentFeature))
         span.textContent = aString;
 
-    return CGSizeMake(span.clientWidth, span.clientHeight);
+    return _CGSizeMake(span.clientWidth, span.clientHeight);
 }
 
 + (CPDictionary)metricsOfFont:(CPFont)aFont

AppKit/Platform/DOM/CPPlatformWindow+DOM.j

@@ -210,7 +210,7 @@ var resizeTimer = nil;
     if (self)
     {
         _DOMWindow = window;
-        _contentRect = CGRectMakeZero();
+        _contentRect = _CGRectMakeZero();
 
         _windowLevels = [];
         _windowLayers = @{};
@@ -232,25 +232,25 @@ var resizeTimer = nil;
     if (_DOMWindow.cpFrame)
         return _DOMWindow.cpFrame();
 
-    var contentRect = CGRectMakeZero();
+    var contentRect = _CGRectMakeZero();
 
     if (window.screenTop)
-        contentRect.origin = CGPointMake(_DOMWindow.screenLeft, _DOMWindow.screenTop);
+        contentRect.origin = _CGPointMake(_DOMWindow.screenLeft, _DOMWindow.screenTop);
 
     else if (window.screenX)
-        contentRect.origin = CGPointMake(_DOMWindow.screenX, _DOMWindow.screenY);
+        contentRect.origin = _CGPointMake(_DOMWindow.screenX, _DOMWindow.screenY);
 
     // Safari, Mozilla, Firefox, and Opera
     if (_DOMWindow.innerWidth)
-        contentRect.size = CGSizeMake(_DOMWindow.innerWidth, _DOMWindow.innerHeight);
+        contentRect.size = _CGSizeMake(_DOMWindow.innerWidth, _DOMWindow.innerHeight);
 
     // Internet Explorer 6 in Strict Mode
     else if (document.documentElement && document.documentElement.clientWidth)
-        contentRect.size = CGSizeMake(_DOMWindow.document.documentElement.clientWidth, _DOMWindow.document.documentElement.clientHeight);
+        contentRect.size = _CGSizeMake(_DOMWindow.document.documentElement.clientWidth, _DOMWindow.document.documentElement.clientHeight);
 
     // Internet Explorer X
     else
-        contentRect.size = CGSizeMake(_DOMWindow.document.body.clientWidth, _DOMWindow.document.body.clientHeight);
+        contentRect.size = _CGSizeMake(_DOMWindow.document.body.clientWidth, _DOMWindow.document.body.clientHeight);
 
     return contentRect;
 }
@@ -548,7 +548,7 @@ var resizeTimer = nil;
     if (_DOMWindow)
         return _DOMWindow.focus();
 
-    _DOMWindow = window.open("about:blank", "_blank", "menubar=no,location=no,resizable=yes,scrollbars=no,status=no,left=" + CGRectGetMinX(_contentRect) + ",top=" + CGRectGetMinY(_contentRect) + ",width=" + CGRectGetWidth(_contentRect) + ",height=" + CGRectGetHeight(_contentRect));
+    _DOMWindow = window.open("about:blank", "_blank", "menubar=no,location=no,resizable=yes,scrollbars=no,status=no,left=" + _CGRectGetMinX(_contentRect) + ",top=" + _CGRectGetMinY(_contentRect) + ",width=" + _CGRectGetWidth(_contentRect) + ",height=" + _CGRectGetHeight(_contentRect));
 
     [PlatformWindows addObject:self];
 
@@ -585,7 +585,7 @@ var resizeTimer = nil;
 {
     var type = aDOMEvent.type,
         dragServer = [CPDragServer sharedDragServer],
-        location = CGPointMake(aDOMEvent.clientX, aDOMEvent.clientY),
+        location = _CGPointMake(aDOMEvent.clientX, aDOMEvent.clientY),
         pasteboard = [_CPDOMDataTransferPasteboard DOMDataTransferPasteboard];
 
     [pasteboard _setDataTransfer:aDOMEvent.dataTransfer];
@@ -600,8 +600,8 @@ var resizeTimer = nil;
             draggedWindowFrame = [draggedWindow frame],
             DOMDragElement = draggedWindow._DOMElement;
 
-        DOMDragElement.style.left = -CGRectGetWidth(draggedWindowFrame) + "px";
-        DOMDragElement.style.top = -CGRectGetHeight(draggedWindowFrame) + "px";
+        DOMDragElement.style.left = -_CGRectGetWidth(draggedWindowFrame) + "px";
+        DOMDragElement.style.top = -_CGRectGetHeight(draggedWindowFrame) + "px";
 
         var parentNode = DOMDragElement.parentNode;
 
@@ -615,7 +615,7 @@ var resizeTimer = nil;
         aDOMEvent.dataTransfer.setDragImage(DOMDragElement, draggingOffset.width, draggingOffset.height);
         aDOMEvent.dataTransfer.effectAllowed = "all";
 
-        [dragServer draggingStartedInPlatformWindow:self globalLocation:[CPPlatform isBrowser] ? location : CGPointMake(aDOMEvent.screenX, aDOMEvent.screenY)];
+        [dragServer draggingStartedInPlatformWindow:self globalLocation:[CPPlatform isBrowser] ? location : _CGPointMake(aDOMEvent.screenX, aDOMEvent.screenY)];
     }
     else if (type === "drag")
     {
@@ -624,7 +624,7 @@ var resizeTimer = nil;
         if (CPFeatureIsCompatible(CPHTML5DragAndDropSourceYOffBy1))
             y -= 1;
 
-        [dragServer draggingSourceUpdatedWithGlobalLocation:[CPPlatform isBrowser] ? location : CGPointMake(aDOMEvent.screenX, y)];
+        [dragServer draggingSourceUpdatedWithGlobalLocation:[CPPlatform isBrowser] ? location : _CGPointMake(aDOMEvent.screenX, y)];
     }
     else if (type === "dragover" || type === "dragleave")
     {
@@ -656,7 +656,7 @@ var resizeTimer = nil;
         else
             dragOperation = CPDragOperationNone;
 
-        [dragServer draggingEndedInPlatformWindow:self globalLocation:[CPPlatform isBrowser] ? location : CGPointMake(aDOMEvent.screenX, aDOMEvent.screenY) operation:dragOperation];
+        [dragServer draggingEndedInPlatformWindow:self globalLocation:[CPPlatform isBrowser] ? location : _CGPointMake(aDOMEvent.screenX, aDOMEvent.screenY) operation:dragOperation];
     }
     else //if (type === "drop")
     {
@@ -676,7 +676,7 @@ var resizeTimer = nil;
 - (void)keyEvent:(DOMEvent)aDOMEvent
 {
     var event,
-        location = _lastMouseEventLocation || CGPointMakeZero(),
+        location = _lastMouseEventLocation || _CGPointMakeZero(),
         timestamp = [CPEvent currentTimestamp],
         sourceElement = aDOMEvent.target || aDOMEvent.srcElement,
         windowNumber = [[CPApp keyWindow] windowNumber],
@@ -897,7 +897,7 @@ var resizeTimer = nil;
             timestamp = [CPEvent currentTimestamp],  // fake event, might as well use current timestamp
             windowNumber = [[CPApp keyWindow] windowNumber],
             modifierFlags = CPPlatformActionKeyMask,
-            location = _lastMouseEventLocation || CGPointMakeZero(),
+            location = _lastMouseEventLocation || _CGPointMakeZero(),
             event = [CPEvent keyEventWithType:CPKeyDown location:location modifierFlags:modifierFlags
                     timestamp:timestamp windowNumber:windowNumber context:nil
                     characters:characters charactersIgnoringModifiers:characters isARepeat:NO keyCode:keyCode];
@@ -1018,12 +1018,12 @@ var resizeTimer = nil;
             } while (element = element.offsetParent);
         }
 
-        location = CGPointMake((x + ((aDOMEvent.clientX - 8) / 15)), (y + ((aDOMEvent.clientY - 8) / 15)));
+        location = _CGPointMake((x + ((aDOMEvent.clientX - 8) / 15)), (y + ((aDOMEvent.clientY - 8) / 15)));
     }
     else if (aDOMEvent._overrideLocation)
         location = aDOMEvent._overrideLocation;
     else
-        location = CGPointMake(aDOMEvent.clientX, aDOMEvent.clientY);
+        location = _CGPointMake(aDOMEvent.clientX, aDOMEvent.clientY);
 
     var deltaX = 0.0,
         deltaY = 0.0,
@@ -1212,7 +1212,7 @@ var resizeTimer = nil;
     }
 
     var event,
-        location = CGPointMake(aDOMEvent.clientX, aDOMEvent.clientY),
+        location = _CGPointMake(aDOMEvent.clientX, aDOMEvent.clientY),
         timestamp = [CPEvent currentTimestamp],
         sourceElement = (aDOMEvent.target || aDOMEvent.srcElement),
         windowNumber = 0,
@@ -1490,8 +1490,7 @@ var resizeTimer = nil;
     // relative to it or the furthest parent.
     var children = [aWindow childWindows],
         count = [children count],
-        parent = aWindow,
-        parentLevel = [parent level];
+        parent = aWindow;
 
     for (var i = 0; i < count; ++i)
     {
@@ -1502,10 +1501,6 @@ var resizeTimer = nil;
         if (!childWasVisible && ![child _hasBeenOrderedIn])
             continue;
 
-        // If a user moved level of the child window, we should respect that
-        if ([child level] !== parentLevel)
-            continue;
-
         var ordering = [child _childOrdering];
 
         if ((ordering === CPWindowAbove && furthestParent._index > parent._index) ||

AppKit/Resources/AboutPanel.cib

@@ -0,0 +1 @@
+280NPLIST;1.0;D;K;4;$topD;K;18;CPCibObjectDataKeyD;K;6;CP$UIDd;1;2E;K;21;CPCibObjectRecordsKeyD;K;6;CP$UIDd;1;4E;E;K;8;$objectsA;S;5;$nullD;K;10;$classnameS;16;_CPCibObjectDataK;8;$classesA;S;16;_CPCibObjectDataS;8;CPObjectE;E;D;K;6;$classD;K;6;CP$UIDd;1;1E;K;28;_CPCibObjectDataNamesKeysKeyD;K;6;CP$UIDd;1;5E;K;30;_CPCibObjectDataNamesValuesKeyD;K;6;CP$UIDd;1;6E;K;30;_CPCibObjectDataClassesKeysKeyD;K;6;CP$UIDd;1;7E;K;32;_CPCibObjectDataClassesValuesKeyD;K;6;CP$UIDd;1;8E;K;30;_CPCibObjectDataConnectionsKeyD;K;6;CP$UIDd;1;9E;K;28;_CPCibObjectDataFrameworkKeyD;K;6;CP$UIDd;2;10E;K;26;_CPCibObjectDataNextOidKeyD;K;6;CP$UIDd;2;11E;K;30;_CPCibObjectDataObjectsKeysKeyD;K;6;CP$UIDd;2;12E;K;32;_CPCibObjectDataObjectsValuesKeyD;K;6;CP$UIDd;2;13E;K;26;_CPCibObjectDataOidKeysKeyD;K;6;CP$UIDd;2;14E;K;28;_CPCibObjectDataOidValuesKeyD;K;6;CP$UIDd;2;15E;K;28;_CPCibObjectDataFileOwnerKeyD;K;6;CP$UIDd;2;17E;K;33;_CPCibObjectDataVisibleWindowsKeyD;K;6;CP$UIDd;2;19E;E;D;K;10;$classnameS;7;CPArrayK;8;$classesA;S;7;CPArrayS;8;CPObjectE;E;D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;D;K;6;CP$UIDd;2;21E;D;K;6;CP$UIDd;2;22E;D;K;6;CP$UIDd;2;23E;D;K;6;CP$UIDd;2;24E;D;K;6;CP$UIDd;2;25E;D;K;6;CP$UIDd;2;26E;D;K;6;CP$UIDd;2;27E;D;K;6;CP$UIDd;2;28E;D;K;6;CP$UIDd;2;29E;D;K;6;CP$UIDd;2;30E;D;K;6;CP$UIDd;2;31E;D;K;6;CP$UIDd;2;32E;D;K;6;CP$UIDd;2;33E;D;K;6;CP$UIDd;2;21E;D;K;6;CP$UIDd;2;34E;D;K;6;CP$UIDd;2;35E;D;K;6;CP$UIDd;2;36E;D;K;6;CP$UIDd;2;37E;E;E;D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;D;K;6;CP$UIDd;2;17E;D;K;6;CP$UIDd;2;39E;D;K;6;CP$UIDd;2;40E;D;K;6;CP$UIDd;2;42E;D;K;6;CP$UIDd;2;44E;D;K;6;CP$UIDd;2;46E;D;K;6;CP$UIDd;2;47E;D;K;6;CP$UIDd;2;48E;E;E;D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;D;K;6;CP$UIDd;2;49E;D;K;6;CP$UIDd;2;50E;D;K;6;CP$UIDd;2;51E;D;K;6;CP$UIDd;2;52E;D;K;6;CP$UIDd;2;53E;D;K;6;CP$UIDd;2;54E;D;K;6;CP$UIDd;2;54E;D;K;6;CP$UIDd;2;54E;E;E;D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;E;E;D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;E;E;D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;D;K;6;CP$UIDd;2;56E;E;E;S;16;IBCocoaFrameworkd;3;461D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;D;K;6;CP$UIDd;2;39E;D;K;6;CP$UIDd;2;40E;D;K;6;CP$UIDd;2;42E;D;K;6;CP$UIDd;2;44E;D;K;6;CP$UIDd;2;46E;D;K;6;CP$UIDd;2;47E;D;K;6;CP$UIDd;2;48E;E;E;D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;D;K;6;CP$UIDd;2;17E;D;K;6;CP$UIDd;2;17E;D;K;6;CP$UIDd;2;39E;D;K;6;CP$UIDd;2;42E;D;K;6;CP$UIDd;2;42E;D;K;6;CP$UIDd;2;42E;D;K;6;CP$UIDd;2;42E;E;E;D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;E;E;D;K;6;$classD;K;6;CP$UIDd;1;3E;K;10;CP.objectsA;E;E;D;K;10;$classnameS;18;_CPCibCustomObjectK;8;$classesA;S;18;_CPCibCustomObjectS;8;CPObjectE;E;D;K;6;$classD;K;6;CP$UIDd;2;16E;K;27;_CPCibCustomObjectClassNameD;K;6;CP$UIDd;2;57E;E;D;K;10;$classnameS;5;CPSetK;8;$classesA;S;5;CPSetS;8;CPObjectE;E;D;K;6;$classD;K;6;CP$UIDd;2;18E;K;15;CPSetObjectsKeyD;K;6;CP$UIDd;2;58E;E;D;K;10;$classnameS;15;CibObjectRecordK;8;$classesA;S;15;CibObjectRecordS;8;CPObjectE;E;D;K;6;$classD;K;6;CP$UIDd;2;20E;K;24;CibObjectRecordParentKeyD;K;6;CP$UIDd;1;0E;K;26;CibObjectRecordChildrenKeyD;K;6;CP$UIDd;2;59E;K;24;CibObjectRecordObjectKeyD;K;6;CP$UIDd;2;60E;K;23;CibObjectRecordLabelKeyD;K;6;CP$UIDd;2;61E;E;D;K;6;$classD;K;6;CP$UIDd;2;20E;K;24;CibObjectRecordParentKeyD;K;6;CP$UIDd;1;0E;K;26;CibObjectRecordChildrenKeyD;K;6;CP$UIDd;2;62E;K;24;CibObjectRecordObjectKeyD;K;6;CP$UIDd;2;63E;K;23;CibObjectRecordLabelKeyD;K;6;CP$UIDd;1;0E;E;D;K;6;$classD;K;6;CP$UIDd;2;20E;K;24;CibObjectRecordParentKeyD;K;6;CP$UIDd;2;42E;K;26;CibObjectRecordChildrenKeyD;K;6;CP$UIDd;2;64E;K;24;CibObjectRecordObjectKeyD;K;6;CP$UIDd;2;48E;K;23;CibObjectRecordLabelKeyD;K;6;CP$UIDd;2;54E;E;D;K;6;$classD;K;6;CP$UIDd;2;20E;K;24;CibObjectRecordParentKeyD;K;6;CP$UIDd;1;0E;K;26;CibObjectRecordChildrenKeyD;K;6;CP$UIDd;2;65E;K;24;CibObjectRecordObjectKeyD;K;6;CP$UIDd;2;66E;K;23;CibObjectRecordLabelKeyD;K;6;CP$UIDd;1;0E;E;D;K;6;$classD;K;6;CP$UIDd;2;20E;K;24;CibObjectRecordParentKeyD;K;6;CP$UIDd;1;0E;K;26;CibObjectRecordChildrenKeyD;K;6;CP$UIDd;2;67E;K;24;CibObjectRecordObjectKeyD;K;6;CP$UIDd;2;68E;K;23;CibObjectRecordLabelKeyD;K;6;CP$UIDd;1;0E;E;D;K;6;$classD;K;6;CP$UIDd;2;20E;K;24;CibObjectRecordParentKeyD;K;6;CP$UIDd;2;42E;K;26;CibObjectRecordChildrenKeyD;K;6;CP$UIDd;2;69E;K;24;CibObjectRecordObjectKeyD;K;6;CP$UIDd;2;47E;K;23;CibObjectRecordLabelKeyD;K;6;CP$UIDd;2;54E;E;D;K;6;$classD;K;6;CP$UIDd;2;20E;K;24;CibObjectRecordParentKeyD;K;6;CP$UIDd;1;0E;K;26;CibObjectRecordChildrenKeyD;K;6;CP$UIDd;2;70E;K;24;CibObjectRecordObjectKeyD;K;6;CP$UIDd;2;71E;K;23;CibObjectRecordLabelKeyD;K;6;CP$UIDd;1;0E;E;D;K;6;$classD;K;6;CP$UIDd;2;20E;K;24;CibObjectRecordParentKeyD;K;6;CP$UIDd;1;0E;K;26;CibObjectRecordChildrenKeyD;K;6;CP$UIDd;2;72E;K;24;CibObjectRecordObjectKeyD;K;6;CP$UIDd;2;73E;K;23;CibObjectRecordLabelKeyD;K;6;CP$UIDd;1;0E;E;D;K;6;$classD;K;6;CP$UIDd;2;20E;K;24;CibObjectRecordParentKeyD;K;6;CP$UIDd;2;42E;K;26;CibObjectRecordChildrenKeyD;K;6;CP$UIDd;2;74E;K;24;CibObjectRecordObjectKeyD;K;6;CP$UIDd;2;46E;K;23;CibObjectRecoLine truncated