kosmos/akkounts
kosmos/akkounts
8
1
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Releases 12 Activity

BTCPay settings, admin page, and new Lightning balance API #147

Merged
raucao merged 12 commits from feature/btcpay_configs into master 2023-09-26 10:13:09 +00:00
Conversation 5 Commits 12 Files Changed 22 +313 -140
raucao commented 2023-09-04 14:08:29 +00:00
Owner
Copy Link

Please see commits for review/changes.

This PR contains the following breaking changes:

  • The BTCPay configuration has all been moved to env vars/settings
  • The LndHub admin token has been moved from the credentials file to an env var/setting
  • The public API for BTCPay balances has been renamed from "api/kredits" to "api/btcpay"
  • The amounts of the onchain balances are now sats instead of BTC

refs #31

Please see commits for review/changes. This PR contains the following breaking changes: * The BTCPay configuration has all been moved to env vars/settings * The LndHub admin token has been moved from the credentials file to an env var/setting * The public API for BTCPay balances has been renamed from "api/kredits" to "api/btcpay" * The amounts of the onchain balances are now sats instead of BTC refs #31
Screenshot from 2023-09-04 15-18-40.png
622 KiB
Screenshot from 2023-09-04 15-18-40.png
raucao added the
feature
kredits-2
 labels 2023-09-04 14:08:29 +00:00
raucao added 6 commits 2023-09-04 14:08:29 +00:00
Refactor BTCPay service and API, add lightning balance
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
5a5f62e98a
raucao requested review from bumi 2023-09-04 14:08:33 +00:00
bumi reviewed 2023-09-06 09:20:21 +00:00
bumi left a comment
Owner
Copy Link

utACK.

utACK.
app/models/setting.rb Outdated
@ -41,0 +46,4 @@
default: ENV["BTCPAY_API_URL"].presence
field :btcpay_enabled, type: :boolean,
default: (ENV["BTCPAY_API_URL"].present?.to_s || false)
bumi commented 2023-09-06 09:16:54 +00:00
Owner
Copy Link

the default is here either a string or a boolean? can it handle both?

the default is here either a string or a boolean? can it handle both?
raucao commented 2023-09-07 17:16:51 +00:00
Author
Owner
Copy Link

This just got copypasta'd across the whole file, for some reason that I'm sure is now forgottten. I have removed the silliness just now.

This just got copypasta'd across the whole file, for some reason that I'm sure is now forgottten. I have removed the silliness just now.
raucao marked this conversation as resolved
app/services/btcpay_manager_service.rb
@ -0,0 +5,4 @@
def initialize
@base_url = Setting.btcpay_api_url
@store_id = Setting.btcpay_store_id
@auth_token = Setting.btcpay_auth_token
bumi commented 2023-09-06 09:15:46 +00:00
Owner
Copy Link

I'd use attr_readers here then it is a bit clearer that those are also potentially used from the outside/from inheriting classes

I'd use attr_readers here then it is a bit clearer that those are also potentially used from the outside/from inheriting classes
raucao marked this conversation as resolved
config/routes.rb
@ -55,3 +55,3 @@
namespace :api do
get 'kredits/onchain_btc_balance', to: 'kredits#onchain_btc_balance'
get 'btcpay/onchain_btc_balance', to: 'btcpay#onchain_btc_balance'
bumi commented 2023-09-06 09:20:12 +00:00
Owner
Copy Link

where do we use those again?

where do we use those again?
raucao commented 2023-09-06 10:18:06 +00:00
Author
Owner
Copy Link

https://kredits.kosmos.org/budget

https://kredits.kosmos.org/budget
raucao marked this conversation as resolved
raucao reviewed 2023-09-06 17:31:34 +00:00
app/services/btcpay_manager_service.rb Outdated
@ -0,0 +1,22 @@
#
# API Docs: https://docs.btcpayserver.org/API/Greenfield/v1/
#
class BtcpayManagerService < LdapService
raucao commented 2023-09-06 17:31:34 +00:00
Author
Owner
Copy Link

< LdapService

Oops.

> < LdapService Oops.
raucao marked this conversation as resolved
raucao added 1 commit 2023-09-07 17:15:34 +00:00
Fix code being silly
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
2c2ddabdff
raucao added 1 commit 2023-09-07 17:17:53 +00:00
Fix wrong inheritance
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
2ba0116ca6
raucao added 1 commit 2023-09-07 17:22:18 +00:00
Use attr_reader instead of shared instance variables
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
1949f1876f
raucao commented 2023-09-07 17:24:53 +00:00
Author
Owner
Copy Link

@bumi Thanks! Addressed all comments.

@bumi Thanks! Addressed all comments.
raucao commented 2023-09-15 09:16:03 +00:00
Author
Owner
Copy Link

@bumi Can you review the latest changes and approve the PR if they're good to go?

@bumi Can you review the latest changes and approve the PR if they're good to go?
raucao added 2 commits 2023-09-20 16:37:10 +00:00
Make publishing of BTCPay wallet balances optional
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
69fffb29d8
raucao added 1 commit 2023-09-20 17:12:36 +00:00
Merge branch 'master' into feature/btcpay_configs
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
Release Drafter / Update release notes draft (pull_request) Successful in 4s
Details
d939f5d649
galfert approved these changes 2023-09-25 12:26:00 +00:00
galfert left a comment
Owner
Copy Link

LGTM

LGTM
raucao merged commit 14ff0c0e16 into master 2023-09-26 10:13:09 +00:00
raucao deleted branch feature/btcpay_configs 2023-09-26 10:13:09 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
galfert
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
feature
kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#147
No description provided.
Delete Branch "feature/btcpay_configs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?