Editable content #229

Merged

greg merged 15 commits from feature/186-content_editing into master 2025-05-30 11:14:51 +00:00

Conversation 1 Commits 15 Files Changed 54

+349 -163

raucao commented 2025-05-29 10:26:44 +00:00

Owner

Copy link

Copy source

Make some of the content editable.

• Add new table and model for editable contents. Contents are defined by a context and key, with the context ideally being a path (but not required) and the key identifying the unique piece of content. A rich_text boolean determines if content is editable and rendered as either a string or (GitHub-flavored) Markdown. A lang field is set to "en" by default, for future i18n.
• A new EditableContentComponent can be used to render editable content
• A new EditContentButtonComponent can be used for showing an edit button, which will open a modal with the correct content editing UI
• Only admins can edit content (quelle surprise!)
• The first editable contents are the title/menu and body text of "contributions/other" (ex "projects")
• This PR removes the special ks-text-link class, so that links in editable content render with the default link style, without having to add classes to the Markdown source
• Markdown content can contain arbitrary HTML, not just plain text
• The best editing is no editing at all, so this PR also removes all Kosmos-specific language from service pages
• Add a Pages controller, Privacy and ToS pages, and a footer menu to reach them (sticks to the bottom of either the screen or the content, whichever is taller)

closes #186
refs #222

Note: I initially added ActionText, only to find out that it's not the right solution for the problems solved in this PR. I left the commit, so it can easily be re-added in the future from that, if necessary.

Make some of the content editable. * Add new table and model for editable contents. Contents are defined by a `context` and `key`, with the context ideally being a path (but not required) and the key identifying the unique piece of content. A `rich_text` boolean determines if content is editable and rendered as either a string or (GitHub-flavored) Markdown. A `lang` field is set to "en" by default, for future i18n. * A new `EditableContentComponent` can be used to render editable content * A new `EditContentButtonComponent` can be used for showing an edit button, which will open a modal with the correct content editing UI * Only admins can edit content (quelle surprise!) * The first editable contents are the title/menu and body text of "contributions/other" (ex "projects") * This PR removes the special `ks-text-link` class, so that links in editable content render with the default link style, without having to add classes to the Markdown source * Markdown content can contain arbitrary HTML, not just plain text * The best editing is no editing at all, so this PR also removes all Kosmos-specific language from service pages * Add a Pages controller, Privacy and ToS pages, and a footer menu to reach them (sticks to the bottom of either the screen or the content, whichever is taller) closes #186 refs #222 Note: I initially added ActionText, only to find out that it's not the right solution for the problems solved in this PR. I left the commit, so it can easily be re-added in the future from that, if necessary.

Screenshot from 2025-05-29 15-47-33.png

157 KiB

Screenshot from 2025-05-29 15-47-47.png

329 KiB

Screenshot from 2025-05-29 15-52-33.png

539 KiB

raucao added the ui/uxfeature labels 2025-05-29 10:26:44 +00:00

raucao added 11 commits 2025-05-29 10:26:45 +00:00

Add ActionText configs, update spec helpers/configs c9d23f829d

Fix navbar current link 57246ea76d

Revert "Add ActionText configs, update spec helpers/configs" ... 252b0f1792

This reverts commit c9d23f829d.

Add top margin to h3 within content c7a21c7a69

Add editable contents table 5c8ffc2630

Memoize instance variable 55c63be9e2

Add admin/editable_contents controller 2f86b3c16f

Add editable content helpers 315cf4dd9f

WIP Rename "projects" page, make content editable 6713665a61

Finish MVP for content editing 6014134396

Remove Kosmos name from wording ... ab1490f472

refs #222

raucao added 1 commit 2025-05-29 11:44:56 +00:00

Remove special link class ... 843bcd8cb9

This cleans up the code quite a bit, but also allows links in editable
content to be rendered with the default style.

raucao added the kredits-2 label 2025-05-29 11:46:46 +00:00

raucao force-pushed feature/186-content_editing from 843bcd8cb9 to 29a67ff870 2025-05-29 12:07:34 +00:00 Compare

raucao force-pushed feature/186-content_editing from 29a67ff870 to f1d9cf1e3d 2025-05-29 12:10:41 +00:00 Compare

raucao added 1 commit 2025-05-29 12:24:41 +00:00

Fix tab links 67c450860a

raucao added 1 commit 2025-05-29 13:26:48 +00:00

Fix link color for Devise links 32cd4d896d

raucao marked the pull request as ready for review 2025-05-29 13:35:20 +00:00

raucao added 1 commit 2025-05-30 09:27:34 +00:00

Add Privacy and ToS pages, footer menu f2e8ca790c

greg approved these changes 2025-05-30 11:13:03 +00:00

greg left a comment

Owner

Copy link

Copy source

Looking good 👍

Looking good 👍

greg merged commit eefdc88a47 into master 2025-05-30 11:14:51 +00:00

greg deleted branch feature/186-content_editing 2025-05-30 11:14:51 +00:00

greg referenced this issue from a commit 2025-05-30 11:14:52 +00:00

Merge pull request 'Editable content' (#229) from feature/186-content_editing into master

Sign in to join this conversation.

Reviewers

No Reviewers

greg

Labels

Clear labels

integration

btcpay

integration

discourse

integration

ejabberd

integration

email

integration

ldap

integration

lndhub

integration

mastodon

integration

nostr

integration

remotestorage

bug

Something is not working

design

Graphic/visual design

dev environment

Config, builds, CI, deployment, etc.

docs

Documentation

duplicate

This issue or pull request already exists

enhancement

Improving existing functionality

feature

New functionality

good first issue

Dive in, and start contributing

idea

Something to consider

invalid

Not a bug

kredits-1

Small contribution

kredits-2

Medium contribution

kredits-3

Large contribution

on hold

Currently not actionable

ops

Manual IT ops activities

question

Looking for an answer

security

All your base are belong to us

ui/ux

User interface, process design, etc.

wontfix

This won't be fixed

release

major

release

minor

release

patch

No labels feature kredits-2 ui/ux

Milestone

No items

No Milestone

Assignees

Clear assignees

bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/akkounts#229