kosmos/akkounts
8
1
Fork 0
Code Issues 25 Pull Requests 1 Actions Packages Releases 12 Activity

Fix password validation during password reset #83

Merged
raucao merged 4 commits from bugfix/28-password_reset into master 2023-02-19 14:01:25 +00:00
Conversation 1 Commits 4 Files Changed 3
+63 -7
raucao commented 2023-02-19 07:52:04 +00:00
Owner
Copy Link
Copy Source

See new specs.

fixes #28

See new specs. fixes #28
raucao added the kredits-1 label 2023-02-19 07:52:04 +00:00
raucao added 2 commits 2023-02-19 07:52:05 +00:00
Improve layout of password reset form 832d1e3bd7
Add spec to prove issue #28
continuous-integration/drone/push Build is passing
Details
b9259958f4
raucao force-pushed bugfix/28-password_reset from 48b01ad5a8 to 7dae66959e 2023-02-19 07:55:11 +00:00 Compare
bumi approved these changes 2023-02-19 13:29:07 +00:00
bumi left a comment
Owner
Copy Link
Copy Source

code looks good.

with ldap I still struggle locally - because some Docker issue.

code looks good. with ldap I still struggle locally - because some Docker issue.
app/models/user.rb
@@ -40,0 +37,4 @@
self.password_confirmation = new_password_confirmation
return false unless valid?
Devise::LDAP::Adapter.update_password(login_with, new_password)
bumi commented 2023-02-19 13:28:27 +00:00
Owner
Copy Link
Copy Source

can this fail somehow? do we need to catch some error here?

can this fail somehow? do we need to catch some error here?
raucao commented 2023-02-19 14:00:32 +00:00
Author
Owner
Copy Link
Copy Source

Hopefully never, but we have #14 and kosmos/chef#436 open to set up exception tracking.

Hopefully never, but we have #14 and kosmos/chef#436 open to set up exception tracking.
raucao merged commit aa0ba18763 into master 2023-02-19 14:01:25 +00:00
raucao deleted branch bugfix/28-password_reset 2023-02-19 14:01:26 +00:00
raucao added the bug label 2023-03-28 14:42:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels bug kredits-1
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#83