remoteStorage OAuth #109

Merged

raucao merged 24 commits from feature/rs-oauth into master 2023-08-04 08:55:29 +00:00

Conversation 3 Commits 24 Files Changed 29

+1156 -8

galfert commented 2023-03-27 23:32:31 +00:00

Owner

Copy link

Copy source

Refs #92

Example OAuth URL: http://localhost:3000/rs/oauth/admin@kosmos.org?redirect_uri=https://webmarks.5apps.com/archive&scope=bookmarks:rw&client_id=https://webmarks.5apps.com&response_type=token

Left to do

• Persist tokens in Redis
• Specs
  • workers/jobs
  • RemoteStorageAuthorization model specs
  • OAuth controller/feature/request specs
• Finish UI

Refs #92 Example OAuth URL: http://localhost:3000/rs/oauth/admin@kosmos.org?redirect_uri=https://webmarks.5apps.com/archive&scope=bookmarks:rw&client_id=https://webmarks.5apps.com&response_type=token ### Left to do * [x] Persist tokens in Redis * [x] Specs * [x] workers/jobs * [x] RemoteStorageAuthorization model specs * [x] OAuth controller/feature/request specs * [x] Finish UI

galfert added 3 commits 2023-03-27 23:32:31 +00:00

Basic RemoteStorage settings 20c014607c

RemoteStorage OAuth dialog 7acc3b2106

Add RemoteStorageAuthorization model ee42d68471

galfert marked the pull request as work in progress 2023-03-27 23:32:45 +00:00

raucao added 1 commit 2023-04-13 13:05:07 +00:00

Merge branch 'master' into feature/rs-oauth eeabbdb7df

raucao commented 2023-04-13 13:09:01 +00:00

Owner

Copy link

Copy source

@galfert FYI, I merged master into this branch and resolved a couple of conflicts. So you should pull before working on it again...

@galfert FYI, I merged master into this branch and resolved a couple of conflicts. So you should pull before working on it again...

raucao added 1 commit 2023-04-13 14:22:22 +00:00

Improve RS OAuth UI dabd892a25

raucao commented 2023-04-13 14:23:03 +00:00

Owner

Copy link

Copy source

I have pushed UI improvements for the OAuth dialog. Good to go!

I have pushed UI improvements for the OAuth dialog. Good to go!

Screenshot from 2023-04-13 16-12-27.png

941 KiB

Screenshot from 2023-04-13 16-20-27.png

244 KiB

galfert added 2 commits 2023-06-20 12:10:50 +00:00

Persist RS auth tokens in Redis 42af148168

Merge branch 'master' into feature/rs-oauth ... 716d4b944a

# Conflicts:
#	app/models/user.rb
#	config/routes.rb
#	db/schema.rb

galfert added 1 commit 2023-06-27 13:07:43 +00:00

Add Redis service to Drone config 5c2df3df07

raucao added 2 commits 2023-07-04 14:44:31 +00:00

Merge branch 'master' into feature/rs-oauth e1e83386a8

Add Redis config in CI a68825493f

raucao added 1 commit 2023-07-04 15:00:27 +00:00

Add Redis config for dev with Redis on localhost e5a5633e44

raucao added 1 commit 2023-07-13 13:31:35 +00:00

Merge branch 'master' into feature/rs-oauth d9b39b36fb

raucao self-assigned this 2023-07-13 17:24:58 +00:00

raucao added 7 commits 2023-07-14 13:31:40 +00:00

Add separate config for RS Redis 4d88a40109

Fix typo 4c6c81171b

Refactor code for newer Redis b0bfc290c4

Fix typo 12b24337e7

Indentation e11be727a1

Rename RS token expiry job 645abac810

Add specs for RemoteStorageAuthorization model ec9bcacd46

raucao added 1 commit 2023-07-14 13:56:39 +00:00

Fix specs fcf9a065e1

raucao added 3 commits 2023-08-01 11:01:51 +00:00

Support pre-filling of username in login form a2d27bf575

RS OAuth pre-fills username for login 5f921f1b53

Add feature spec for RS OAuth dialog ba0cbba96b

raucao added 1 commit 2023-08-01 12:29:49 +00:00

Add RS OAuth controller specs 353b55fe1a

raucao marked the pull request as ready for review 2023-08-01 12:30:07 +00:00

raucao requested review from greg 2023-08-01 12:30:18 +00:00

raucao added the feature label 2023-08-01 12:43:49 +00:00

galfert was assigned by raucao 2023-08-01 12:43:59 +00:00

raucao added the kredits-2 label 2023-08-01 12:44:12 +00:00

galfert commented 2023-08-04 08:21:05 +00:00

Author

Owner

Copy link

Copy source

I think everything's looking good now 🙌

I think everything's looking good now 🙌

👍 1

raucao merged commit 852e2fea1e into master 2023-08-04 08:55:29 +00:00

raucao deleted branch feature/rs-oauth 2023-08-04 08:55:29 +00:00

raucao referenced this issue from a commit 2023-08-04 08:55:30 +00:00

Merge pull request 'remoteStorage OAuth' (#109) from feature/rs-oauth into master

Sign in to join this conversation.

Reviewers

No Reviewers

greg

Labels

Clear labels

integration

btcpay

integration

discourse

integration

ejabberd

integration

email

integration

ldap

integration

lndhub

integration

mastodon

integration

nostr

integration

remotestorage

bug

Something is not working

design

Graphic/visual design

dev environment

Config, builds, CI, deployment, etc.

docs

Documentation

duplicate

This issue or pull request already exists

enhancement

Improving existing functionality

feature

New functionality

good first issue

Dive in, and start contributing

idea

Something to consider

invalid

Not a bug

kredits-1

Small contribution

kredits-2

Medium contribution

kredits-3

Large contribution

on hold

Currently not actionable

ops

Manual IT ops activities

question

Looking for an answer

security

All your base are belong to us

ui/ux

User interface, process design, etc.

wontfix

This won't be fixed

release

major

release

minor

release

patch

No labels feature kredits-2

Milestone

No items

No Milestone

Assignees

Clear assignees

bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)

No Assignees galfert raucao

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/akkounts#109