kosmos/akkounts
8
1
Fork 0
Code Issues 25 Pull Requests 1 Actions Packages Releases 12 Activity

Integrate Discourse Connect (SSO) #129

Closed
raucao wants to merge 9 commits from feature/126_discourse_sso into feature/123-display_names
pull from: feature/126_discourse_sso
merge into: :feature/123-display_names
Conversation 3 Commits 9 Files Changed 25
+272 -19
raucao commented 2023-05-29 21:09:12 +00:00
Owner
Copy Link
Copy Source

Works like a charm, but only after disabling Turbo for sign-ins when the post-sign-in URL is a redirect to an external URL.

The relevant implementation is all in cd913abf111860f5a56e227be758b997b5c77333, the rest are drive-by refactorings.

Tested with a local Discourse installation. No need for reviewers to do that IMO.

closes #126

Works like a charm, but only after disabling Turbo for sign-ins when the post-sign-in URL is a redirect to an external URL. The relevant implementation is all in cd913abf111860f5a56e227be758b997b5c77333, the rest are drive-by refactorings. Tested with a local Discourse installation. No need for reviewers to do that IMO. closes #126
raucao added the feature label 2023-05-29 21:09:12 +00:00
raucao marked the pull request as ready for review 2023-05-30 21:20:36 +00:00
raucao added the kredits-2 label 2023-05-30 21:20:42 +00:00
raucao requested review from greg 2023-05-30 21:21:05 +00:00
raucao commented 2023-05-30 21:22:07 +00:00
Author
Owner
Copy Link
Copy Source

Ready for review/merge. Ideally review #128 first, then merge this, then #128.

Ready for review/merge. Ideally review #128 first, then merge this, then #128.
greg closed this pull request 2023-05-31 09:13:50 +00:00
greg commented 2023-05-31 09:14:49 +00:00
Owner
Copy Link
Copy Source

Huh, this one got closed when I merged #128

Edit: Got it, it wanted to get merged into feature/123-display_names

Huh, this one got closed when I merged #128 Edit: Got it, it wanted to get merged into feature/123-display_names
greg commented 2023-05-31 09:23:50 +00:00
Owner
Copy Link
Copy Source

I misread your message and merged #128 first

I misread your message and merged #128 first
raucao removed the featurekredits-2 labels 2023-05-31 09:37:11 +00:00
raucao removed review request for greg 2023-05-31 09:37:18 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#129