kosmos/akkounts
kosmos
/
akkounts
8
1
Fork 0
Code Issues 21 Pull Requests 1 Actions Packages Releases 11 Activity

Hide unsuccessful outgoing lndhub txs in list #132

Merged
raucao merged 1 commits from bugfix/lndhub_tx_list into master 2023-06-06 15:43:39 +00:00
Conversation 0 Commits 1 Files Changed 1 +4
raucao commented 2023-06-05 10:08:48 +00:00
Owner
Copy Link

Handles an edge case I stumbled upon, where lndhub.go records an outgoing tx even though it failed to send. In which case the preimage property is empty.

(It doesn't book the transaction to affect the balance. Upstream issue here.)

Handles an edge case I stumbled upon, where lndhub.go records an outgoing tx even though it failed to send. In which case the preimage property is empty. (It doesn't book the transaction to affect the balance. Upstream issue [here](https://github.com/getAlby/lndhub.go/issues/381).)
raucao added the
kredits-1
 label 2023-06-05 10:08:48 +00:00
raucao added 1 commit 2023-06-05 10:08:49 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
Release Drafter / Update release notes draft (pull_request) Successful in 4s Details
259e72167b
Hide unsuccessful outgoing lndhub txs in list
raucao requested review from bumi 2023-06-05 10:09:57 +00:00
raucao merged commit c0b1112e49 into master 2023-06-06 15:43:39 +00:00
raucao deleted branch bugfix/lndhub_tx_list 2023-06-06 15:43:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
bumi
Labels
Clear labels   
integration
discourse

  
integration
ejabberd

  
integration
ldap

  
integration
lndhub

  
integration
nostr

  
bug

Something is not working

  
design

Graphic/visual design

  
dev environment

Config, builds, CI, deployment, etc.

  
docs

Documentation

  
duplicate

This issue or pull request already exists

  
enhancement

Improving existing functionality

  
feature

New functionality

  
good first issue

Dive in, and start contributing

  
idea

Something to consider

  
invalid

Not a bug

  
kredits-1

Small contribution

  
kredits-2

Medium contribution

  
kredits-3

Large contribution

  
on hold

Currently not actionable

  
ops

Manual IT ops activities

  
question

Looking for an answer

  
release
major

  
release
minor

  
release
patch

  
security

All your base are belong to us

  
ui/ux

User interface, process design, etc.

  
wontfix

This won't be fixed

No Label
integration
discourse
integration
ejabberd
integration
ldap
integration
lndhub
integration
nostr
bug
design
dev environment
docs
duplicate
enhancement
feature
good first issue
idea
invalid
kredits-1
kredits-2
kredits-3
on hold
ops
question
release
major
release
minor
release
patch
security
ui/ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/akkounts#132
No description provided.
Delete Branch "bugfix/lndhub_tx_list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?