kosmos/akkounts
8
1
Fork 0
Code Issues 25 Pull Requests 1 Actions Packages Releases 12 Activity

Fix docker volume mappings for node_modules, improve docker-compose usage #138

Merged
raucao merged 6 commits from bugfix/fix-docker-mapping into master 2023-06-23 15:38:31 +00:00
Conversation 1 Commits 6 Files Changed 3
+61 -57
slvrbckt commented 2023-06-23 15:25:57 +00:00
Owner
Copy Link
Copy Source

This simplifies the docker-compose.yml management, by leaving it uncommented as devs can selectively start any of the services defined by name, eg. docker compose up ldap, while new users can start up everything with docker compose up.

Additionally, I added a mapping to the web volumes list, /akkounts/node_modules will exclude node_modules from being mounted, ensuring it is defined as a docker-only directory within the mounted directory.

Added PRIMARY_DOMAIN: kosmos.org env to both the web and sidekiq docker compose directives.

This simplifies the `docker-compose.yml` management, by leaving it uncommented as devs can selectively start any of the services defined by name, eg. `docker compose up ldap`, while new users can start up everything with `docker compose up`. Additionally, I added a mapping to the web volumes list, `/akkounts/node_modules` will *exclude* `node_modules` from being mounted, ensuring it is defined as a docker-only directory within the mounted directory. Added `PRIMARY_DOMAIN: kosmos.org` env to both the `web` and `sidekiq` docker compose directives.
slvrbckt added the bug label 2023-06-23 15:25:57 +00:00
slvrbckt added 3 commits 2023-06-23 15:25:58 +00:00
copy files as list 652ed5f7e3
leave services uncommented, add /akkounts/node_modules to volume mapping as a directory to explicitly exclude fdf3218f88
Update readme with simplified usage
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
ee7769c8c7
slvrbckt added 2 commits 2023-06-23 15:30:04 +00:00
use PRIMARY_DOMAIN for both web and sidekiq directives e4406bf6ff
formatting
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
c7925f132e
slvrbckt added 1 commit 2023-06-23 15:32:47 +00:00
improve sentence
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
Release Drafter / Update release notes draft (pull_request) Successful in 4s
Details
96a4db5bae
raucao added the kredits-1 label 2023-06-23 15:36:28 +00:00
raucao approved these changes 2023-06-23 15:37:12 +00:00
raucao left a comment
Owner
Copy Link
Copy Source

👍

:+1:
raucao changed title from Fix docker volume mappings for `node_modules`, leave docker-compose.yml uncommented to Fix docker volume mappings for `node_modules`, improve docker-compose.yml usage 2023-06-23 15:38:12 +00:00
raucao changed title from Fix docker volume mappings for `node_modules`, improve docker-compose.yml usage to Fix docker volume mappings for `node_modules`, improve docker-compose usage 2023-06-23 15:38:20 +00:00
raucao merged commit b32e2fcb7b into master 2023-06-23 15:38:31 +00:00
raucao deleted branch bugfix/fix-docker-mapping 2023-06-23 15:38:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels bug kredits-1
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#138