kosmos/akkounts
kosmos
/
akkounts
8
1
Fork 0
Code Issues 21 Pull Requests 1 Actions Packages Releases 11 Activity

Fix/improve local ActiveStorage backend usage and handling of WebApp icons #162

Merged
greg merged 10 commits from bugfix/local_web_app_icons into chore/update_dependencies 2024-02-27 16:07:55 +00:00
Conversation 4 Commits 10 Files Changed 13 +63 -19
raucao commented 2024-02-08 12:06:58 +00:00
Owner
Copy Link

Also fixes RS auth for apps without proper origin, e.g. localhost ones or browser extensions. It will just use the default app icon for those now.

See commit messages for details

Also fixes RS auth for apps without proper origin, e.g. `localhost` ones or browser extensions. It will just use the default app icon for those now. See commit messages for details
Screenshot from 2024-02-08 13-13-04.png
185 KiB
Screenshot from 2024-02-08 13-13-04.png
raucao added the
enhancement
bug
kredits-1
 labels 2024-02-08 12:06:58 +00:00
raucao added 6 commits 2024-02-08 12:06:58 +00:00
a7cbd8ce36
Allow disabling S3 explicitly, disable in Docker Compose 
For example when there is a .env.development for running the app on a
host machine directly, but as a developer you also want to run it with
Docker Compose from time to time.
70ac3b0a70
Fix RS dashboard for auths without Web App 
RS auths without a valid domain name will not fetch any metadata and
therefore not create a WebApp record. This fixes icons being looked up
anyway, resulting in exceptions
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
3f110995a4
Add timestamp to icon filenames 
There can be race condition when a background job is supposed to delete
an icon while there is a new one being attached. Also, this encodes the
date/time when the icon has been added, for inspection and convenience.
raucao added a new dependency 2024-02-08 12:07:47 +00:00
#160 Upgrade Rails to 7.1, update dependencies, require Ruby 3.x
raucao requested review from Core 2024-02-08 12:08:25 +00:00
raucao added 1 commit 2024-02-08 12:36:40 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
bd1b177993
Rescue all icon download/upload errors, send to Sentry
raucao changed title from Fix/improve local AS backend usage and handling of WebApp icons to Fix/improve local ActiveStorage backend usage and handling of WebApp icons 2024-02-12 11:35:27 +00:00
raucao added 1 commit 2024-02-22 14:13:34 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
de1f234c15
Merge branch 'chore/update_dependencies' into bugfix/local_web_app_icons
raucao commented 2024-02-22 14:14:49 +00:00
Author
Owner
Copy Link

Just merged the fix for Apple Silicon into this branch, so it's ready to try out on newer MacBooks now.

Just merged the fix for Apple Silicon into this branch, so it's ready to try out on newer MacBooks now.
raucao added 1 commit 2024-02-23 18:25:24 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
4a4a222973 Merge branch 'chore/update_dependencies' into bugfix/local_web_app_icons
greg commented 2024-02-26 17:39:36 +00:00
Owner
Copy Link

I've been able to get the Docker compose set up working on my old Intel Mac. Everything looks good, except for this error (see screenshot). The template actually exists. @raucao was able to reproduce it on his Docker set up too.

I've been able to get the Docker compose set up working on my old Intel Mac. Everything looks good, except for this error (see screenshot). The template actually exists. @raucao was able to reproduce it on his Docker set up too.
Screenshot 2024-02-26 at 18-35-11 Action Controller Exception caught.png
340 KiB
Screenshot 2024-02-26 at 18-35-11 Action Controller Exception caught.png
raucao added 1 commit 2024-02-27 13:33:52 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
Release Drafter / Update release notes draft (pull_request) Successful in 3s Details
b33b8104a8
Fix typo
raucao commented 2024-02-27 13:34:46 +00:00
Author
Owner
Copy Link

@greg Amazing that we both didn't see it: there was a simple typo introduced at some point, namely "kebab" vs "kebap".

@greg Amazing that we both didn't see it: there was a simple typo introduced at some point, namely "kebab" vs "kebap".
😆 1
greg commented 2024-02-27 16:05:32 +00:00
Owner
Copy Link

@greg Amazing that we both didn't see it: there was a simple typo introduced at some point, namely "kebab" vs "kebap".

Hahaha, I didn't blink on this one, as both spellings are valid! Will merge after running the containers again.

> @greg Amazing that we both didn't see it: there was a simple typo introduced at some point, namely "kebab" vs "kebap". Hahaha, I didn't blink on this one, as both spellings are valid! Will merge after running the containers again.
greg approved these changes 2024-02-27 16:07:23 +00:00
greg left a comment
Owner
Copy Link

👍

👍
greg merged commit 87f09c94d0 into chore/update_dependencies 2024-02-27 16:07:55 +00:00
greg deleted branch bugfix/local_web_app_icons 2024-02-27 16:07:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
greg
Labels
Clear labels   
integration
discourse

  
integration
ejabberd

  
integration
ldap

  
integration
lndhub

  
integration
nostr

  
bug

Something is not working

  
design

Graphic/visual design

  
dev environment

Config, builds, CI, deployment, etc.

  
docs

Documentation

  
duplicate

This issue or pull request already exists

  
enhancement

Improving existing functionality

  
feature

New functionality

  
good first issue

Dive in, and start contributing

  
idea

Something to consider

  
invalid

Not a bug

  
kredits-1

Small contribution

  
kredits-2

Medium contribution

  
kredits-3

Large contribution

  
on hold

Currently not actionable

  
ops

Manual IT ops activities

  
question

Looking for an answer

  
release
major

  
release
minor

  
release
patch

  
security

All your base are belong to us

  
ui/ux

User interface, process design, etc.

  
wontfix

This won't be fixed

No Label
integration
discourse
integration
ejabberd
integration
ldap
integration
lndhub
integration
nostr
bug
design
dev environment
docs
duplicate
enhancement
feature
good first issue
idea
invalid
kredits-1
kredits-2
kredits-3
on hold
ops
question
release
major
release
minor
release
patch
security
ui/ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#160 Upgrade Rails to 7.1, update dependencies, require Ruby 3.x
kosmos/akkounts
Reference: kosmos/akkounts#162
No description provided.
Delete Branch "bugfix/local_web_app_icons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?