kosmos/akkounts
kosmos/akkounts
8
1
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Releases 12 Activity

Add basic donation records #18

Merged
raucao merged 6 commits from feature/donation_records into master 2020-12-21 14:46:51 +00:00
Conversation 6 Commits 6 Files Changed 30 +419 -10
raucao commented 2020-12-19 14:03:11 +00:00
Owner
Copy Link

This changeset adds the basic building blocks for account donation/payment tracking.

Admins can manually add and edit donation records for now. And Users can see their own donations on the (as-of-yet unlinked) /donations page.

This changeset adds the basic building blocks for account donation/payment tracking. Admins can manually add and edit donation records for now. And Users can see their own donations on the (as-of-yet unlinked) `/donations` page.
Screenshot from 2020-12-19 13-27-33.png
79 KiB
Screenshot from 2020-12-19 13-27-33.png
raucao requested review from bumi 2020-12-19 14:03:19 +00:00
raucao requested review from galfert 2020-12-19 14:03:19 +00:00
raucao requested review from greg 2020-12-19 14:03:21 +00:00
raucao added the
kredits-2
 label 2020-12-19 14:03:29 +00:00
bumi approved these changes 2020-12-21 09:07:38 +00:00
bumi left a comment
Owner
Copy Link

looks good to me.

not sure if we need all the scaffold API/jbuilder stuff for the Admin panel?

looks good to me. not sure if we need all the scaffold API/jbuilder stuff for the Admin panel?
app/controllers/donations_controller.rb
@ -0,0 +4,4 @@
# GET /donations
# GET /donations.json
def index
@donations = current_user.donations.completed
bumi commented 2020-12-21 09:01:56 +00:00
Owner
Copy Link

hmmm. we could show uncompleted for user to finish them. 🤔
but I guess showing only the completed ones keeps the page clean and shows the relevant information. - they can just start a new donation procss instead of finishing a not-completed one.

hmmm. we could show uncompleted for user to finish them. 🤔 but I guess showing only the completed ones keeps the page clean and shows the relevant information. - they can just start a new donation procss instead of finishing a not-completed one.
raucao commented 2020-12-21 12:55:19 +00:00
Author
Owner
Copy Link

This is only a PR for the basic/manual donation records. Any payment-related questions have to be solved when integrating tracking for live donations.

This is only a PR for the basic/manual donation records. Any payment-related questions have to be solved when integrating tracking for live donations.
raucao marked this conversation as resolved
app/models/user.rb Outdated
@ -3,6 +3,7 @@ class User < ApplicationRecord
# Relations
has_many :invitations, dependent: :destroy
has_many :donations
bumi commented 2020-12-21 08:59:36 +00:00
Owner
Copy Link

maybe add a dependent: :nullify?

maybe add a `dependent: :nullify`?
raucao commented 2020-12-21 12:58:33 +00:00
Author
Owner
Copy Link

Good hint!

Good hint!
raucao marked this conversation as resolved
app/views/donations/index.html.erb
@ -0,0 +12,4 @@
<% @donations.each do |donation| %>
<li>
<h3>
<%= donation.paid_at.strftime("%B %d, %Y") %>
bumi commented 2020-12-21 09:04:06 +00:00
Owner
Copy Link

isn't that something like l donation.paid_at, format: :short ?

isn't that something like `l donation.paid_at, format: :short` ?
raucao commented 2020-12-21 13:01:19 +00:00
Author
Owner
Copy Link

I haven't done any localization or i18n anywhere in the app, but we should do that soon! We have a nice bonus of being able to deploy in multiple languages from the start.

I haven't done any localization or i18n anywhere in the app, but we should do that soon! We have a nice bonus of being able to deploy in multiple languages from the start.
raucao marked this conversation as resolved
bumi commented 2020-12-21 09:10:24 +00:00
Owner
Copy Link

Do we want to directly connect the akkounts app with the lightning node (to get new payment requests) or do you want to to have the BTCPay Server's invoice managment?

Do we want to directly connect the akkounts app with the lightning node (to get new payment requests) or do you want to to have the BTCPay Server's invoice managment?
galfert commented 2020-12-21 12:04:42 +00:00
Owner
Copy Link

In the screenshot, the fiat amount has a "$" prefix and a "EUR" suffix.

In the screenshot, the fiat amount has a "$" prefix and a "EUR" suffix.
raucao commented 2020-12-21 12:52:43 +00:00
Author
Owner
Copy Link

In the screenshot, the fiat amount has a “$” prefix and a “EUR” suffix.

The screenshot is outdated.

> In the screenshot, the fiat amount has a “$” prefix and a “EUR” suffix. The screenshot is outdated.
raucao commented 2020-12-21 12:53:11 +00:00
Author
Owner
Copy Link

Do we want to directly connect the akkounts app with the lightning node (to get new payment requests) or do you want to to have the BTCPay Server’s invoice managment?

Good question. But not one for this PR. (I think using BTCPay for everything is easier, unless we want to track on-chain transactions with custom code.)

> Do we want to directly connect the akkounts app with the lightning node (to get new payment requests) or do you want to to have the BTCPay Server’s invoice managment? Good question. But not one for this PR. (I think using BTCPay for everything is easier, unless we want to track on-chain transactions with custom code.)
raucao commented 2020-12-21 14:46:44 +00:00
Author
Owner
Copy Link

Thanks for the reviews!

Thanks for the reviews!
raucao merged commit bcf5172956 into master 2020-12-21 14:46:51 +00:00
raucao deleted branch feature/donation_records 2020-12-21 14:46:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
greg
bumi
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#18
No description provided.
Delete Branch "feature/donation_records"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?