kosmos/akkounts
8
1 Fork 0
Code Issues 25 Pull Requests 2 Actions Packages Releases 14 Activity

Refactor ejabberd API integration #226

Merged
greg merged 1 commits from core/refactor_ejabberd_integration into master 2025-05-28 09:22:39 +00:00
Conversation 1 Commits 1 Files Changed 19
+307 -167
raucao commented 2025-05-26 10:14:22 +00:00
Owner
Copy link
Copy source

This is pure grunt work to eliminate future technical debt, except for adding content types when fetching ejabberd avatars, so they could be imported to our storage later (relevant for ejabberd-only to akkounts+ejabberd migrations, or if we want to import the rest of the avatars from XMPP users who aren't Mastodon users).

It makes everything consistent with the other REST API integrations, inherits from the same REST service, and decouples the XMPP jobs from the specific ejabberd implementation. So if one adds e.g. Prosody support, it's easy to just call a different integration service.

This is pure grunt work to eliminate future technical debt, except for adding content types when fetching ejabberd avatars, so they could be imported to our storage later (relevant for ejabberd-only to akkounts+ejabberd migrations, or if we want to import the rest of the avatars from XMPP users who aren't Mastodon users). It makes everything consistent with the other REST API integrations, inherits from the same REST service, and decouples the XMPP jobs from the specific ejabberd implementation. So if one adds e.g. Prosody support, it's easy to just call a different integration service.
raucao added the kredits-1 label 2025-05-26 10:14:22 +00:00
raucao added 1 commit 2025-05-26 10:14:23 +00:00
Refactor ejabberd API integration
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
Release Drafter / Update release notes draft (pull_request) Successful in 2s
Details
d737d9f6b8
raucao requested review from greg 2025-05-28 07:07:10 +00:00
greg approved these changes 2025-05-28 09:22:12 +00:00
greg left a comment
Owner
Copy link
Copy source

Looking good 👍

Looking good 👍
greg merged commit 0778f29a8e into master 2025-05-28 09:22:39 +00:00
greg deleted branch core/refactor_ejabberd_integration 2025-05-28 09:22:39 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
greg
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
 security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
release
major
release
minor
release
patch
No labels kredits-1
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#226