kosmos/akkounts
8
1 Fork 0
Code Issues 25 Pull Requests 2 Actions Packages Releases 14 Activity

Various UI improvements #43

Merged
raucao merged 5 commits from ui/misc into master 2021-11-24 02:41:55 +00:00
Conversation 2 Commits 5 Files Changed 4
+43 -17
raucao commented 2021-11-24 02:10:37 +00:00
Owner
Copy link
Copy source
  • Add the wallet to the dashboard as a service
  • Make the wallet balance look a bit nicer
  • Add explanatory intro to invitations page
  • Hide section headings
* Add the wallet to the dashboard as a service * Make the wallet balance look a bit nicer * Add explanatory intro to invitations page * Hide section headings
raucao added the kredits-1 label 2021-11-24 02:10:37 +00:00
raucao added 4 commits 2021-11-24 02:10:38 +00:00
Hide headings 7ab107b689 
The main nav entry above is enough context.
Add explanatory intro to invitations page 46c7affd1f
Make the wallet balance look a bit nicer 669b163814
Add the wallet to the dashboard as a service
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
1af8e068c5
bumi approved these changes 2021-11-24 02:26:32 +00:00
galfert approved these changes 2021-11-24 02:26:32 +00:00
galfert left a comment
Owner
Copy link
Copy source

Found some oversights with the balances. The rest looks ok to me.

Found some oversights with the balances. The rest looks ok to me.
app/views/wallet/index.html.erb Outdated
@@ -6,0 +8,4 @@
<div class="md:col-span-4 mt-4 md:mt-0">
<p class="font-mono md:text-right p-4 bg-gray-50 shadow rounded-lg overflow-hidden">
<% if @balance %>
<span class="text-xl">48590<%= @balance %> sats</span><br>
galfert commented 2021-11-24 02:22:59 +00:00
Owner
Copy link
Copy source

There is a hardcoded number in front of the actual balance.

There is a hardcoded number in front of the actual balance.
raucao marked this conversation as resolved
app/views/wallet/index.html.erb Outdated
@@ -6,0 +11,4 @@
<span class="text-xl">48590<%= @balance %> sats</span><br>
<span class="text-sm text-gray-500">Available balance</span>
<% else %>
<span class="text-xl">n/a<%= @balance %> sats</span><br>
galfert commented 2021-11-24 02:22:12 +00:00
Owner
Copy link
Copy source

Looks like a copy/paste error. The <%= @balance %> should be removed.

Looks like a copy/paste error. The `<%= @balance %>` should be removed.
raucao marked this conversation as resolved
raucao added 1 commit 2021-11-24 02:41:20 +00:00
Fix a couple of oversights
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
12a9d4674b
raucao merged commit 18c7c54403 into master 2021-11-24 02:41:55 +00:00
raucao deleted branch ui/misc 2021-11-24 02:42:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
galfert
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
 security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
release
major
release
minor
release
patch
No labels kredits-1
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#43