Various UI improvements #43

raucao · 2021-11-24T02:10:37Z

raucao commented

2021-11-24 02:10:37 +00:00

Add the wallet to the dashboard as a service
Make the wallet balance look a bit nicer
Add explanatory intro to invitations page
Hide section headings

* Add the wallet to the dashboard as a service * Make the wallet balance look a bit nicer * Add explanatory intro to invitations page * Hide section headings

raucao added the

kredits-1

label 2021-11-24 02:10:37 +00:00

raucao added 4 commits 2021-11-24 02:10:38 +00:00

7ab107b689 Hide headings

The main nav entry above is enough context.

46c7affd1f Add explanatory intro to invitations page

669b163814 Make the wallet balance look a bit nicer

continuous-integration/drone/push Build is failing Details

continuous-integration/drone/pr Build is failing Details

1af8e068c5

Add the wallet to the dashboard as a service

bumi approved these changes 2021-11-24 02:26:32 +00:00

galfert approved these changes 2021-11-24 02:26:32 +00:00

galfert left a comment

Found some oversights with the balances. The rest looks ok to me.

app/views/wallet/index.html.erb Outdated

						
				@ -6,0 +8,4 @@

				  <div class="md:col-span-4 mt-4 md:mt-0">

				    <p class="font-mono md:text-right p-4 bg-gray-50 shadow rounded-lg overflow-hidden">

				    <% if @balance %>

				      <span class="text-xl">48590<%= @balance %> sats</span><br>

galfert commented

2021-11-24 02:22:59 +00:00

There is a hardcoded number in front of the actual balance.

raucao marked this conversation as resolved

app/views/wallet/index.html.erb Outdated

						
				@ -6,0 +11,4 @@

				      <span class="text-xl">48590<%= @balance %> sats</span><br>

				      <span class="text-sm text-gray-500">Available balance</span>

				    <% else %>

				      <span class="text-xl">n/a<%= @balance %> sats</span><br>

galfert commented

2021-11-24 02:22:12 +00:00

Looks like a copy/paste error. The <%= @balance %> should be removed.

Looks like a copy/paste error. The `<%= @balance %>` should be removed.

raucao marked this conversation as resolved

raucao added 1 commit 2021-11-24 02:41:20 +00:00

continuous-integration/drone/push Build is failing Details

continuous-integration/drone/pr Build is failing Details

12a9d4674b

Fix a couple of oversights

raucao merged commit 18c7c54403 into master

2021-11-24 02:41:55 +00:00

raucao referenced this issue from a commit

2021-11-24 02:41:55 +00:00

Merge pull request 'Various UI improvements' (#43) from ui/misc into master

raucao deleted branch ui/misc

2021-11-24 02:42:05 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/akkounts#43