kosmos/akkounts
8
1
Fork 0
Code Issues 25 Pull Requests 1 Actions Packages Releases 12 Activity

Add button for copying lndhub setup code #55

Merged
raucao merged 2 commits from feature/37-copy_setup_code into master 2021-12-16 14:23:14 +00:00
Conversation 2 Commits 2 Files Changed 2
+30 -16
raucao commented 2021-12-15 13:55:45 +00:00
Owner
Copy Link
Copy Source

Adds a button for copying the code to the clipboard. Also refactors the text links to be buttons instead.

closes #37

Adds a button for copying the code to the clipboard. Also refactors the text links to be buttons instead. closes #37
raucao added the kredits-1 label 2021-12-15 13:55:45 +00:00
raucao added 1 commit 2021-12-15 13:55:45 +00:00
Add button for copying lndhub setup code
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
f1d3e3d8ec 
closes #37
raucao requested review from Core 2021-12-15 13:55:53 +00:00
galfert approved these changes 2021-12-16 13:39:43 +00:00
galfert left a comment
Owner
Copy Link
Copy Source

Tailwind has the classes visible and invisible (https://tailwindcss.com/docs/visibility).

Using those might be a little cleaner than inline styles and toggling the display values between none, block and inline-block.

Other than that all looks good to me.

Tailwind has the classes `visible` and `invisible` (https://tailwindcss.com/docs/visibility). Using those might be a little cleaner than inline styles and toggling the display values between `none`, `block` and `inline-block`. Other than that all looks good to me.
raucao added 1 commit 2021-12-16 14:19:20 +00:00
Use Tailwind classes to hide/show elements
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
78aea5d608
raucao commented 2021-12-16 14:22:58 +00:00
Author
Owner
Copy Link
Copy Source

@galfert Thanks for the suggestion! I switched it to use the "hidden" class, which the same amount of code, but a bit nicer indeed. 👍

@galfert Thanks for the suggestion! I switched it to use the "hidden" class, which the same amount of code, but a bit nicer indeed. 👍
👍 1
raucao merged commit 0f0f296a5e into master 2021-12-16 14:23:14 +00:00
raucao deleted branch feature/37-copy_setup_code 2021-12-16 14:23:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels kredits-1
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#55