Switch from Webpacker to cssbundling-rails, upgrade Tailwind CSS to version 3 #59
greg
bumi
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "dev/cssbundling"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The new way to run the server in development is via
bin/dev, which will automatically install/start foreman, which in turn manages both the Rails server as well as runs Tailwind compilation with Tailwind JIT and PostCSS enabled.The old stylesheets (that are built via the normal asset pipeline) are now bundled in a 'legacy.css' file.
Switch from Webpacker to cssbundling-rails, upgrade Tailwind CSSto Switch from Webpacker to cssbundling-rails, upgrade Tailwind CSS to version 3@ -8,4 +8,1 @@<link href="https://assets.kosmos.org/fonts/open-sans/open-sans.css" rel="stylesheet"><%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track': 'reload' %><%= stylesheet_pack_tag 'application', media: 'all', 'data-turbolinks-track': 'reload' %><%= javascript_pack_tag 'application', 'data-turbolinks-track': 'reload' %>is the JS here still used? do we use turbolinks and such?
We use turbolinks still, but never added any JavaScript to the folders/templates in
app/javascript. The only custom JS we currently use is a little bit of vanilla inline JS in the wallet view.My response was wrong, removing JS obviously also removed Turbolinks. I upgraded everything to Rails 7, and it builds everything without Webpacker now, including Turbolinks.
Just FYI, since our Gitea webhooks go to a local IP for Drone CI, the builds weren't triggered anymore since the recent upgrade (needed a new config value). I just fixed that (Chef PR incoming), and also enabled branch protection for master here.
Switch from Webpacker to cssbundling-rails, upgrade Tailwind CSS to version 3to WIP: Switch from Webpacker to cssbundling-rails, upgrade Tailwind CSS to version 334425ba133toff3013f9177369503c7cto908809bc48b95fbbaeb7to1a9b47ceee@bumi I'm having a mean issue with Drone CI. Everything works fine locally, but for some reason, which I was unable to find, it won't load bundled gems anymore in CI.
It works just fine on my machine, and I can't see anything wrong in the various boot-related files. It's all just standard Rails boilerplate. Could you verify that it runs on your machine? And do you perhaps have an idea what the problem could be?
@greg Maybe you have an idea about #59 (comment)?
@bumi The Gitea was down shortly after I asked this, so you may have missed the question, too. Just pinging in case you didn't see it.
hmm.. it works well for me locally. all assets seem to load and the app runs.
I don't know what the two
bundle configin the drone.yml mean. Is thre something maybe not quite right?That was just to ensure that it installs
--with development testand viadeploymentinto the./vendordirectory so that gems are cached. The flags are deprecated, so I thought changing it tobundle configjust removed those deprecation warnings. (I had changed them to fix the issue in the first place, so something underneath must have changed either way.)However, I have now adjusted the config to just explicitly enable caching and tell it a cache path (instead of using
deployment), and now it works! \o/@bumi Want to approve the PR now?
WIP: Switch from Webpacker to cssbundling-rails, upgrade Tailwind CSS to version 3to Switch from Webpacker to cssbundling-rails, upgrade Tailwind CSS to version 3