kosmos/akkounts
kosmos/akkounts
8
1
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Releases 12 Activity

Add keysend support for Lightning Addresses, specs for address/lnurlp responses #84

Merged
raucao merged 7 commits from feature/ln_address_keysend into master 2023-03-03 13:29:02 +00:00
Conversation 5 Commits 7 Files Changed 6 +157 -4
raucao commented 2023-02-23 09:49:07 +00:00
Owner
Copy Link
No description provided.
raucao added the
kredits-2
 label 2023-02-23 09:49:07 +00:00
raucao added 3 commits 2023-02-23 09:49:08 +00:00 
Allow keysend payments to user addresses. Useful for Podcasting 2.0/v4v.
Add specs for Lightning Address and lnurlpay requests
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
e580cc9991
raucao requested review from bumi 2023-02-23 09:49:13 +00:00
raucao added 1 commit 2023-02-23 09:54:48 +00:00
Prevent double render
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
b87b9c2437
raucao added 1 commit 2023-02-23 09:57:00 +00:00
Add ln node public key to test env
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
dc63506102
greg added 1 commit 2023-03-02 15:49:14 +00:00
Merge branch 'master' into feature/ln_address_keysend
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
cca44d7542
greg reviewed 2023-03-02 16:02:17 +00:00
spec/requests/lnurlpay_spec.rb Outdated
@ -0,0 +68,4 @@
end
context "amount too low" do
it "retuns an error" do
greg commented 2023-03-02 16:02:17 +00:00
Owner
Copy Link

small typo (returns)

small typo (returns)
raucao marked this conversation as resolved
greg reviewed 2023-03-02 16:02:23 +00:00
spec/requests/lnurlpay_spec.rb Outdated
@ -0,0 +80,4 @@
end
context "comment too long" do
it "retuns an error" do
greg commented 2023-03-02 16:02:23 +00:00
Owner
Copy Link

small typo (returns)

small typo (returns)
raucao marked this conversation as resolved
greg requested changes 2023-03-02 16:03:20 +00:00
greg left a comment
Owner
Copy Link

Small typo in specs

Small typo in specs
bumi approved these changes 2023-03-03 08:55:58 +00:00
bumi left a comment
Owner
Copy Link

should we show th details on the UI, too?

should we show th details on the UI, too?
raucao commented 2023-03-03 13:09:25 +00:00
Author
Owner
Copy Link

should we show th details on the UI, too?

Not sure I'm clear on which details you are referring to. Could you clarify perhaps?

> should we show th details on the UI, too? Not sure I'm clear on which details you are referring to. Could you clarify perhaps?
raucao added 1 commit 2023-03-03 13:27:35 +00:00
Fix typos
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
f2c7aa2f09
raucao merged commit 1142a4e2d5 into master 2023-03-03 13:29:02 +00:00
raucao deleted branch feature/ln_address_keysend 2023-03-03 13:29:03 +00:00
raucao added the
feature
 label 2023-03-28 14:42:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
greg
bumi
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
feature
kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#84
No description provided.
Delete Branch "feature/ln_address_keysend"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?