kosmos/akkounts
kosmos/akkounts
8
1
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Releases 12 Activity

Add user page to admin panel, improve other admin pages #88

Merged
raucao merged 15 commits from feature/admin_user_details into master 2023-02-26 14:16:41 +00:00
Conversation 1 Commits 15 Files Changed 26 +267 -130
raucao added 11 commits 2023-02-25 07:34:57 +00:00
Rename admin users controller/route
All checks were successful
continuous-integration/drone/push Build is passing
Details
1a2482434c 
Started out as a simple helper page to list LDAP users, but turning into
proper user management now.
Add lndhub info to admin user page
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
6d20ac9a1c
raucao changed title from WIP: Add user page to admin panel, improve other admin pages to Add user page to admin panel, improve other admin pages 2023-02-26 02:41:29 +00:00
raucao added the
kredits-2
 label 2023-02-26 02:41:35 +00:00
raucao requested review from greg 2023-02-26 02:41:43 +00:00
raucao requested review from galfert 2023-02-26 02:41:44 +00:00
raucao requested review from bumi 2023-02-26 02:41:44 +00:00
raucao added 3 commits 2023-02-26 03:33:23 +00:00
Improve admin donation pages
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
5f74212603
raucao changed title from Add user page to admin panel, improve other admin pages to WIP: Add user page to admin panel, improve other admin pages 2023-02-26 09:39:52 +00:00
raucao added 1 commit 2023-02-26 10:41:35 +00:00
Fix inline tailwind styles not being applied
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
c8e405d93a
raucao changed title from WIP: Add user page to admin panel, improve other admin pages to Add user page to admin panel, improve other admin pages 2023-02-26 10:41:51 +00:00
galfert approved these changes 2023-02-26 12:00:23 +00:00
galfert left a comment
Owner
Copy Link

Looks very good. I haven't railsed in a while, so I'm not quite sure if the DB question/suggestion makes sense :D

Looks very good. I haven't railsed in a while, so I'm not quite sure if the DB question/suggestion makes sense :D
app/controllers/admin/users_controller.rb
@ -0,0 +10,4 @@
@stats = {
users_confirmed: User.where(ou: @ou).confirmed.count,
users_pending: User.where(ou: @ou).pending.count
galfert commented 2023-02-26 11:47:11 +00:00
Owner
Copy Link

Isn't this creating a new DB COUNT query? Since the @users are already there, wouldn't a @users.pending.size be more performant?

Isn't this creating a new DB `COUNT` query? Since the `@users` are already there, wouldn't a `@users.pending.size` be more performant?
raucao commented 2023-02-26 14:15:12 +00:00
Author
Owner
Copy Link

@users is not filtered by pending at that point, so .pending would actually create a query that selects all fields from the table using that filter, and then .size would convert the results into an array and count the contained items I believe. So .count should be more performant if that is correct.

`@users` is not filtered by pending at that point, so `.pending` would actually create a query that selects all fields from the table using that filter, and then `.size` would convert the results into an array and count the contained items I believe. So `.count` should be more performant if that is correct.
config/routes.rb
@ -40,3 +40,3 @@
namespace :admin do
root to: 'dashboard#index'
get 'ldap_users', to: 'ldap_users#index'
resources 'users', param: 'address', only: ['index', 'show'], constraints: { address: /.*/ }
galfert commented 2023-02-26 11:55:59 +00:00
Owner
Copy Link

What's the constraints for? Doesn't the regex basically allow anything?

What's the `constraints` for? Doesn't the regex basically allow anything?
raucao commented 2023-02-26 14:11:58 +00:00
Author
Owner
Copy Link

It's to prevent Rails from parsing out the part behind the dot character as a format type. It would otherwise regard e.g. the "org" in "user@kosmos.org" as format "org".

It's to prevent Rails from parsing out the part behind the dot character as a format type. It would otherwise regard e.g. the "org" in "user@kosmos.org" as format "org".
raucao merged commit 7fd564726f into master 2023-02-26 14:16:41 +00:00
raucao deleted branch feature/admin_user_details 2023-02-26 14:16:41 +00:00
raucao added the
feature
 label 2023-03-28 14:41:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
greg
bumi
galfert
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
feature
kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#88
No description provided.
Delete Branch "feature/admin_user_details"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?