kosmos/chef
8
3
Fork 0
Code Issues 39 Pull Requests Projects 2 Activity

Enable LDAP for the XMPP 5apps.com vhost #132

Manually merged
raucao merged 7 commits from feature/123-ejabberd_5apps into master 2020-02-17 14:41:05 +00:00
Conversation 4 Commits 7 Files Changed 4
+135 -93
greg commented 2020-02-12 17:04:36 +00:00
Owner
Copy Link
Copy Source
  • Refactor the ejabberd config file to remove hardcoded values about the vhosts
  • Move each vhost's config to its own file

Refs #123

* Refactor the ejabberd config file to remove hardcoded values about the vhosts * Move each vhost's config to its own file Refs #123
raucao requested changes 2020-02-13 23:42:38 +00:00
site-cookbooks/kosmos-ejabberd/recipes/default.rb Outdated
@@ -81,0 +125,4 @@
admin_users = [
"greg@5apps.com",
"sebastian@5apps.com",
"garret@5apps.com",
raucao commented 2020-02-13 23:41:03 +00:00
Owner
Copy Link
Copy Source

I don't think any other pro customer would have their users get global admin accounts for the entire Kosmos XMPP server.

I also think that these should come from an encrypted data bag, because I don't see any benefits to publishing admin account data, but only drawbacks.

I don't think any other pro customer would have their users get global admin accounts for the entire Kosmos XMPP server. I also think that these should come from an encrypted data bag, because I don't see any benefits to publishing admin account data, but only drawbacks.
greg commented 2020-02-14 13:03:26 +00:00
Author
Owner
Copy Link
Copy Source

Good point, I have moved the admin users to an encrypted data bag

Good point, I have moved the admin users to an encrypted data bag
site-cookbooks/kosmos-ejabberd/templates/ejabberd.yml.erb Outdated
@@ -26,0 +28,4 @@
ldap_base: "ou=<%= host[:name] %>,<%= @ldap_base %>"
ldap_filter: "(nsRole=cn=xmpp_role,ou=<%= host[:name] %>,<%= @ldap_base %>)"
<% end -%>
<% end -%>
raucao commented 2020-02-13 23:40:07 +00:00
Owner
Copy Link
Copy Source

Why should we add content to the main config file instead of adding separate files for every vhost?

Why should we add content to the main config file instead of adding separate files for every vhost?
greg commented 2020-02-14 09:11:33 +00:00
Author
Owner
Copy Link
Copy Source

I was considering using different files for the vhosts, but then I could not find a way to define the hosts all at once (https://docs.ejabberd.im/admin/configuration/#host-names), so it didn't seem to make much sense to split the config. I'm going to look into what's possible

I was considering using different files for the vhosts, but then I could not find a way to define the hosts all at once (https://docs.ejabberd.im/admin/configuration/#host-names), so it didn't seem to make much sense to split the config. I'm going to look into what's possible
raucao commented 2020-02-14 16:07:11 +00:00
Owner
Copy Link
Copy Source

So just because of a single additional line per host it doesn't make sense to split out all the rest?

I don't quite follow to be honest.

So just because of a single additional line per host it doesn't make sense to split out all the rest? I don't quite follow to be honest.
greg commented 2020-02-17 12:54:20 +00:00
Author
Owner
Copy Link
Copy Source

I have moved each vhost's config to its own file

I have moved each vhost's config to its own file
greg marked the pull request as ready for review 2020-02-17 13:37:51 +00:00
greg commented 2020-02-17 13:38:20 +00:00
Author
Owner
Copy Link
Copy Source

This has been executed on andromeda, ready to merge

This has been executed on andromeda, ready to merge
greg marked the pull request as work in progress 2020-02-17 13:59:16 +00:00
greg commented 2020-02-17 13:59:27 +00:00
Author
Owner
Copy Link
Copy Source

Do not merge for now, I found an issue in my VM

Edit: fixed the issue in the last commit

Do not merge for now, I found an issue in my VM Edit: fixed the issue in the last commit
greg marked the pull request as ready for review 2020-02-17 14:12:48 +00:00
raucao changed title from Enable LDAP on the XMPP 5apps.com vhost to Enable LDAP for the XMPP 5apps.com vhost 2020-02-17 14:40:46 +00:00
raucao closed this pull request 2020-02-17 14:41:04 +00:00
raucao closed this pull request 2020-02-17 14:41:05 +00:00
raucao deleted branch feature/123-ejabberd_5apps 2020-02-17 14:41:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
service
discourse
Kosmos Community Forums
monitoring
Infrastructure metrics, alerts, notifications, etc.
service
accounts
Kosmos Accounts
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
lightning
Lightning address, lndhub, etc.
service
mastodon
kosmos.social
service
nostr
Relays, Blossom server, etc.
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#132