Fix the invalid ACIs on initial creation (for real) #165

greg · 2020-05-15T12:11:52Z

greg commented

2020-05-15 12:11:52 +00:00

Follow-up to #156

I found another issue with the initial ACI creation, while creating a
fresh VM. I thought I had fixed it in #156 but I was wrong. This time
the ACIs are really set and the code runs successfully.

The ACIs are set on the suffix, so modifying it is needed

This won't be executed on a server that is already running, this is only
done on the initial setup

As I already got Kredits for the merged fix that did not work I have intentionally left this one without a Kredits label

Follow-up to #156 I found another issue with the initial ACI creation, while creating a fresh VM. I thought I had fixed it in #156 but I was wrong. This time the ACIs are really set and the code runs successfully. The ACIs are set on the suffix, so modifying it is needed This won't be executed on a server that is already running, this is only done on the initial setup As I already got Kredits for the merged fix that did not work I have intentionally left this one without a Kredits label

raucao commented

2020-05-15 14:42:22 +00:00

LGTM

greg closed this pull request

2020-05-15 15:22:09 +00:00

greg closed this pull request

2020-05-15 15:22:09 +00:00

greg deleted branch bugfix/dirsrv_acis_really_fix

2020-05-15 15:22:17 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/chef#165