kosmos/chef
kosmos/chef
8
3
Fork 0
Code Issues 28 Pull Requests 4 Projects 2 Activity

Fix the invalid ACIs on initial creation (for real) #165

Manually merged
greg merged 1 commits from bugfix/dirsrv_acis_really_fix into master 2020-05-15 15:22:09 +00:00
Conversation 1 Commits 1 Files Changed 3 +18 -8
greg commented 2020-05-15 12:11:52 +00:00
Owner
Copy Link

Follow-up to #156

I found another issue with the initial ACI creation, while creating a
fresh VM. I thought I had fixed it in #156 but I was wrong. This time
the ACIs are really set and the code runs successfully.

The ACIs are set on the suffix, so modifying it is needed

This won't be executed on a server that is already running, this is only
done on the initial setup

As I already got Kredits for the merged fix that did not work I have intentionally left this one without a Kredits label

Follow-up to #156 I found another issue with the initial ACI creation, while creating a fresh VM. I thought I had fixed it in #156 but I was wrong. This time the ACIs are really set and the code runs successfully. The ACIs are set on the suffix, so modifying it is needed This won't be executed on a server that is already running, this is only done on the initial setup As I already got Kredits for the merged fix that did not work I have intentionally left this one without a Kredits label
raucao commented 2020-05-15 14:42:22 +00:00
Owner
Copy Link

LGTM

LGTM
greg closed this pull request 2020-05-15 15:22:09 +00:00
greg closed this pull request 2020-05-15 15:22:09 +00:00
greg deleted branch bugfix/dirsrv_acis_really_fix 2020-05-15 15:22:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
service
accounts
Kosmos Accounts
service
discourse
Kosmos Community Forums
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
mastodon
kosmos.social
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#165
No description provided.
Delete Branch "bugfix/dirsrv_acis_really_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?