kosmos/chef
kosmos/chef
8
3
Fork 0
Code Issues 30 Pull Requests 3 Projects 2 Activity

Fix comet icon on maintenance page #198

Merged
raucao merged 1 commits from bugfix/61-maintenance_page_logo into master 2020-08-02 19:05:19 +00:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
raucao commented 2020-08-02 19:02:24 +00:00
Owner
Copy Link

The data URI declares an SVG source, but this was actually a PNG. Hence the failure in Chrome.

This change turns it into an actual inline SVG and uses UTF8 encoding instead of base64, because SVG is just text anyway.

fixes #61

The data URI declares an SVG source, but this was actually a PNG. Hence the failure in Chrome. This change turns it into an actual inline SVG and uses UTF8 encoding instead of base64, because SVG is just text anyway. fixes #61
raucao changed title from Bugfix/61 Maintenance Page Logo to Fix comet icon on maintenance page 2020-08-02 19:02:53 +00:00
raucao added the
kredits-1
 label 2020-08-02 19:03:24 +00:00
raucao requested review from greg 2020-08-02 19:04:02 +00:00
raucao removed review request for greg 2020-08-02 19:04:59 +00:00
raucao merged commit f235aee17a into master 2020-08-02 19:05:18 +00:00
raucao deleted branch bugfix/61-maintenance_page_logo 2020-08-02 19:05:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
service
accounts
Kosmos Accounts
service
discourse
Kosmos Community Forums
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
mastodon
kosmos.social
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
kredits-1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#198
No description provided.
Delete Branch "bugfix/61-maintenance_page_logo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?