Move wormhole from barnard to nodejs-2 #278

raucao · 2021-01-05T17:05:05Z

raucao commented

2021-01-05 17:05:05 +00:00

Fixed two small bugs in the recipe:

hubot user wasn't created when necessary
systemd template always included redis service dependency

Edit: also removes application_javascript now. See comment.

Fixed two small bugs in the recipe: * hubot user wasn't created when necessary * systemd template always included redis service dependency Edit: also removes `application_javascript` now. See comment.

raucao added the

kredits-1

ops

labels 2021-01-05 17:05:05 +00:00

raucao requested review from galfert 2021-01-05 17:05:09 +00:00

raucao removed review request for galfert 2021-01-05 17:05:09 +00:00

raucao requested review from greg 2021-01-05 17:05:10 +00:00

raucao commented

2021-01-06 18:15:09 +00:00

I just added another commit, where I have rewritten the recipe to not use the deprecated application_javascript resource anymore, and which also uses the systemd_unit Chef resource.

I just added another commit, where I have rewritten the recipe to not use the deprecated `application_javascript` resource anymore, and which also uses the `systemd_unit` Chef resource.

greg approved these changes 2021-01-07 10:40:49 +00:00

greg left a comment

👍

greg referenced this issue from a commit

2021-01-07 10:42:41 +00:00

Merge pull request 'Move wormhole from barnard to nodejs-2' (#278) from chore/move_wormhole into master Reviewed-on: https://gitea.kosmos.org/kosmos/chef/pulls/278

greg merged commit 6db296a7f1 into master

2021-01-07 10:42:41 +00:00

greg deleted branch chore/move_wormhole

2021-01-07 10:42:48 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/chef#278