Add new SMTP config for akkounts #480

greg · 2023-03-24T15:58:10Z

greg commented

2023-03-24 15:58:10 +00:00

This is not running on akkounts-1

closes #479
refs kosmos/akkounts#107

This is not running on akkounts-1 closes #479 refs kosmos/akkounts#107

greg added the

enhancement

service

accounts

labels 2023-03-24 15:58:10 +00:00

greg self-assigned this 2023-03-24 15:58:10 +00:00

greg added 1 commit 2023-03-24 15:58:11 +00:00

4f1fb347a8 Add new SMTP config for akkounts

This is not running on akkounts-1

closes #479
refs kosmos/akkounts#107

greg requested review from raucao 2023-03-24 15:58:21 +00:00

greg added the

kredits-1

label 2023-03-24 15:58:30 +00:00

raucao requested changes 2023-03-24 23:20:04 +00:00

raucao left a comment

Cool. Left a few suggestions.

environments/production.json Outdated

						
				@ -5,0 +7,4 @@

				        "domain": "kosmos.org",

				        "auth_method": "plain",

				        "enable_starttls": "auto"

				      },

raucao commented

2023-03-24 23:15:36 +00:00

Why override the default values with the same values?

greg marked this conversation as resolved

site-cookbooks/kosmos-akkounts/attributes/default.rb Outdated

						
				@ -10,4 +10,9 @@ node.default['akkounts']['lndhub']['public_url'] = nil

				node.default['akkounts']['lndhub']['public_key'] = nil

				node.default['akkounts']['lndhub']['postgres_db'] = 'lndhub'

				node.default['akkounts']['smtp']['from_address']    = 'accounts <accounts@kosmos.org>'

raucao commented

2023-03-24 23:19:49 +00:00

I think just a lowercase "accounts" without context would probably be a bit weird in an email inbox. How about "Kosmos Accounts" for example?

greg marked this conversation as resolved

site-cookbooks/kosmos-akkounts/recipes/default.rb Outdated

						
				@ -43,0 +50,4 @@

				env[:smtp_domain]          = node['akkounts']['smtp']['domain']

				env[:smtp_auth_method]     = node['akkounts']['smtp']['auth_method']

				env[:smtp_enable_starttls] = node['akkounts']['smtp']['enable_starttls']

raucao commented

2023-03-24 23:18:18 +00:00

I think the template supports automatic namespacing. I.e. we should be able to do this:

env[:smtp] = {
  server: smtp_server,
  port: smtp_port,
  login: smtp_credentials[:user_name]
}

... and it should expand to uppercase keys like SMTP_SERVER.

I think the template supports automatic namespacing. I.e. we should be able to do this: ```ruby env[:smtp] = { server: smtp_server, port: smtp_port, login: smtp_credentials[:user_name] } ``` ... and it should expand to uppercase keys like `SMTP_SERVER`.

greg marked this conversation as resolved

greg added 3 commits 2023-03-27 08:49:40 +00:00

3873ebaac2 Don't override the SMTP config with the same values

34970fe3cf Set a better name for the from address

0c4466b040 Namespace the smtp attributes

greg requested review from raucao 2023-03-27 08:49:58 +00:00

raucao commented

2023-03-27 09:55:48 +00:00

Tested/running on akkounts-1 now.

Tested/running on `akkounts-1` now.

raucao self-assigned this 2023-03-27 09:56:00 +00:00

raucao added the