kosmos/chef
kosmos/chef
8
3
Fork 0
Code Issues 27 Pull Requests 2 Projects 2 Activity

Add new SMTP config for akkounts #480

Merged
raucao merged 4 commits from feature/479-akkounts_smtp_config into master 2023-03-27 09:56:16 +00:00
Conversation 2 Commits 4 Files Changed 2 +23 -5
greg commented 2023-03-24 15:58:10 +00:00
Owner
Copy Link

This is not running on akkounts-1

closes #479
refs kosmos/akkounts#107

This is not running on akkounts-1 closes #479 refs kosmos/akkounts#107
greg added the
enhancement
service
accounts
 labels 2023-03-24 15:58:10 +00:00
greg self-assigned this 2023-03-24 15:58:10 +00:00
greg added 1 commit 2023-03-24 15:58:11 +00:00 
This is not running on akkounts-1

closes #479
refs kosmos/akkounts#107
greg requested review from raucao 2023-03-24 15:58:21 +00:00
greg added the
kredits-1
 label 2023-03-24 15:58:30 +00:00
raucao requested changes 2023-03-24 23:20:04 +00:00
raucao left a comment
Owner
Copy Link

Cool. Left a few suggestions.

Cool. Left a few suggestions.
environments/production.json Outdated
@ -5,0 +7,4 @@
"domain": "kosmos.org",
"auth_method": "plain",
"enable_starttls": "auto"
},
raucao commented 2023-03-24 23:15:36 +00:00
Owner
Copy Link

Why override the default values with the same values?

Why override the default values with the same values?
greg marked this conversation as resolved
site-cookbooks/kosmos-akkounts/attributes/default.rb Outdated
@ -10,4 +10,9 @@ node.default['akkounts']['lndhub']['public_url'] = nil
node.default['akkounts']['lndhub']['public_key'] = nil
node.default['akkounts']['lndhub']['postgres_db'] = 'lndhub'
node.default['akkounts']['smtp']['from_address'] = 'accounts <accounts@kosmos.org>'
raucao commented 2023-03-24 23:19:49 +00:00
Owner
Copy Link

I think just a lowercase "accounts" without context would probably be a bit weird in an email inbox. How about "Kosmos Accounts" for example?

I think just a lowercase "accounts" without context would probably be a bit weird in an email inbox. How about "Kosmos Accounts" for example?
greg marked this conversation as resolved
site-cookbooks/kosmos-akkounts/recipes/default.rb Outdated
@ -43,0 +50,4 @@
env[:smtp_domain] = node['akkounts']['smtp']['domain']
env[:smtp_auth_method] = node['akkounts']['smtp']['auth_method']
env[:smtp_enable_starttls] = node['akkounts']['smtp']['enable_starttls']
raucao commented 2023-03-24 23:18:18 +00:00
Owner
Copy Link

I think the template supports automatic namespacing. I.e. we should be able to do this:

env[:smtp] = {
  server: smtp_server,
  port: smtp_port,
  login: smtp_credentials[:user_name]
}

... and it should expand to uppercase keys like SMTP_SERVER.

I think the template supports automatic namespacing. I.e. we should be able to do this: ```ruby env[:smtp] = { server: smtp_server, port: smtp_port, login: smtp_credentials[:user_name] } ``` ... and it should expand to uppercase keys like `SMTP_SERVER`.
greg marked this conversation as resolved
greg added 3 commits 2023-03-27 08:49:40 +00:00
greg requested review from raucao 2023-03-27 08:49:58 +00:00
raucao commented 2023-03-27 09:55:48 +00:00
Owner
Copy Link

Tested/running on akkounts-1 now.

Tested/running on `akkounts-1` now.
raucao self-assigned this 2023-03-27 09:56:00 +00:00
raucao added the
ops
 label 2023-03-27 09:56:06 +00:00
raucao merged commit 0fbba8baa8 into master 2023-03-27 09:56:16 +00:00
raucao deleted branch feature/479-akkounts_smtp_config 2023-03-27 09:56:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
service
accounts
Kosmos Accounts
service
discourse
Kosmos Community Forums
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
mastodon
kosmos.social
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
service
accounts
enhancement
kredits-1
ops
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees greg raucao
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#480
No description provided.
Delete Branch "feature/479-akkounts_smtp_config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?