kosmos/ngx_http_upload
8
0
Fork 0
mirror of https://github.com/weiss/ngx_http_upload.git synced 2025-07-01 18:29:39 +00:00
Code Releases Activity

Don't respect "umask" while setting permissions

Browse Source
This commit is contained in:
Holger Weiss 2018-07-18 21:21:31 +02:00
parent b9141ef899
commit 3cc33e81a6
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
upload.pm
View File

@ -38,8 +38,8 @@ package upload;
#### CONFIGURATION #### CONFIGURATION
my $external_secret = 'it-is-secret'; my $external_secret = 'it-is-secret';
my $file_mode = 0640; # Modified by "umask". my $file_mode = 0640;
my $dir_mode = 0750; # Modified by "umask". my $dir_mode = 0750;
my $uri_prefix_components = 0; my $uri_prefix_components = 0;
my %custom_headers = ( my %custom_headers = (
'Access-Control-Allow-Origin' => '*', 'Access-Control-Allow-Origin' => '*',
@ -122,7 +122,7 @@ sub handle_put_body {
my $file_path = substr($r->filename, 0, -length($r->uri)) . $safe_uri; my $file_path = substr($r->filename, 0, -length($r->uri)) . $safe_uri;
my $dir_path = dirname($file_path); my $dir_path = dirname($file_path);
make_path($dir_path, {mode => $dir_mode, error => \my $error}); make_path($dir_path, {chmod => $dir_mode, error => \my $error});
if (@$error) { if (@$error) {
$r->log_error($!, "Cannot create directory $dir_path"); $r->log_error($!, "Cannot create directory $dir_path");
return HTTP_FORBIDDEN; # Assume EACCES. return HTTP_FORBIDDEN; # Assume EACCES.
@ -167,14 +167,14 @@ sub handle_put_body {
$r->log_error($!, "Cannot move data to $file_path"); $r->log_error($!, "Cannot move data to $file_path");
return HTTP_INTERNAL_SERVER_ERROR; return HTTP_INTERNAL_SERVER_ERROR;
} }
if (chmod($file_mode, $file_path) < 1) {
$r->log_error($!, "Cannot change permissions of $file_path");
return HTTP_INTERNAL_SERVER_ERROR;
}
} else { # Huh? } else { # Huh?
$r->log_error(0, "Got no data to write to $file_path"); $r->log_error(0, "Got no data to write to $file_path");
return HTTP_BAD_REQUEST; return HTTP_BAD_REQUEST;
} }
if (chmod($file_mode, $file_path) < 1) {
$r->log_error($!, "Cannot change permissions of $file_path");
return HTTP_INTERNAL_SERVER_ERROR;
}
return HTTP_CREATED; return HTTP_CREATED;
} }