Re-connect XMPP when disconnected #2
No reviewers
Labels
No Label
bug
design
dev environment
docs
duplicate
enhancement
feature
good first issue
idea
invalid
kredits-1
kredits-2
kredits-3
on hold
ops
question
release
major
release
minor
release
patch
security
ui/ux
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: kosmos/wormhole#2
Loading…
Reference in New Issue
No description provided.
Delete Branch "feature/1-reconnect_xmpp"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Long-term we should switch to the new XMPP lib, which does continuous reconnects until you tell it to stop. But this should at least fix normal disconnects.
Left one comment, the rest looks good to me.
@ -9,0 +16,4 @@
xmpp.on('online', function(data) {
robot.logger.info('XMPP connected with JID: ' + data.jid.toString());
xmppRooms.forEach(room => xmpp.join(`${room}/wormholedev`));
Is this supposed to use the hardcoded name "wormholedev"?
Good catch. Thanks!
Looking all good now 👍
Released as 1.1.0 and deployed in production.