kosmos/wormhole
kosmos/wormhole
8
0
Fork 0
Code Issues Pull Requests Releases 2 Activity

Re-connect XMPP when disconnected #2

Merged
raucao merged 4 commits from feature/1-reconnect_xmpp into master 2020-11-27 11:22:32 +00:00
Conversation 3 Commits 4 Files Changed 2 +29 -11
raucao commented 2020-11-26 17:45:29 +00:00
Owner
Copy Link

Long-term we should switch to the new XMPP lib, which does continuous reconnects until you tell it to stop. But this should at least fix normal disconnects.

Long-term we should switch to the new XMPP lib, which does continuous reconnects until you tell it to stop. But this should at least fix normal disconnects.
raucao added the
kredits-1
enhancement
 labels 2020-11-26 17:45:29 +00:00
raucao requested review from slvrbckt 2020-11-26 19:37:57 +00:00
raucao requested review from galfert 2020-11-26 19:37:58 +00:00
galfert requested changes 2020-11-26 20:55:28 +00:00
galfert left a comment
Owner
Copy Link

Left one comment, the rest looks good to me.

Left one comment, the rest looks good to me.
scripts/xmpp-muc-bridge.js
@ -9,0 +16,4 @@
xmpp.on('online', function(data) {
robot.logger.info('XMPP connected with JID: ' + data.jid.toString());
xmppRooms.forEach(room => xmpp.join(`${room}/wormholedev`));
galfert commented 2020-11-26 20:54:15 +00:00
Owner
Copy Link

Is this supposed to use the hardcoded name "wormholedev"?

Is this supposed to use the hardcoded name "wormholedev"?
raucao commented 2020-11-27 00:52:38 +00:00
Author
Owner
Copy Link

Good catch. Thanks!

Good catch. Thanks!
raucao marked this conversation as resolved
raucao requested review from galfert 2020-11-27 00:56:04 +00:00
galfert approved these changes 2020-11-27 11:19:52 +00:00
galfert left a comment
Owner
Copy Link

Looking all good now 👍

Looking all good now 👍
raucao merged commit 46eb0452f5 into master 2020-11-27 11:22:32 +00:00
raucao deleted branch feature/1-reconnect_xmpp 2020-11-27 11:22:40 +00:00
raucao removed review request for slvrbckt 2020-11-27 11:22:47 +00:00
raucao commented 2020-11-27 11:45:28 +00:00
Author
Owner
Copy Link

Released as 1.1.0 and deployed in production.

Released as [1.1.0](https://gitea.kosmos.org/kosmos/wormhole/releases/tag/v1.1.0) and deployed in production.
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
Labels
Clear labels
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
enhancement
kredits-1
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/wormhole#2
No description provided.
Delete Branch "feature/1-reconnect_xmpp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?