kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Improve Reimbursement.add validation

Browse Source
This commit is contained in:
Basti 2020-10-01 12:15:48 +02:00
parent 7ad2515b67
commit 15b47dbc42
Signed by untrusted user: basti
GPG Key ID: 9F88009D31D99C72
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/contracts/reimbursement.js
View File

@ -25,10 +25,21 @@ class Reimbursement extends Record {
const token = attrs.token;
const contributorId = attrs.contributorId;
const expenses = attrs.expenses.map( e => new ExpenseSerializer(e) );
let errorMessage;
if (!amount > 0 || !token || token === '' || !contributorId || contributorId === '' || !expenses.length > 0) {
return Promise.reject(new Error('Invalid data. amount, token, expenses is required.'));
if (typeof amount !== 'number' || amount <= 0) {
errorMessage = 'Invalid data: amount must be a positive number.';
}
if (!token || token === '') {
errorMessage = 'Invalid data: token must be a token address.';
}
if (!contributorId || contributorId === '') {
errorMessage = 'Invalid data: contributorId is required.';
}
if (expenses.length === 0) {
errorMessage = 'Invalid data: at least one expense item is required.';
}
if (errorMessage) { return Promise.reject(new Error(errorMessage)); }
return Promise.all(expenses.map(e => e.validate()))
.then(() => {
@ -39,7 +50,7 @@ class Reimbursement extends Record {
const reimbursement = [
amount,
token,
contributorId,
parseInt(contributorId),
ipfsHashAttr.hashDigest,
ipfsHashAttr.hashFunction,
ipfsHashAttr.hashSize,