Improve/fix scripts #114

2019-04-24T12:47:33Z

raucao commented

2019-04-24 12:47:33 +00:00

(Migrated from github.com)

Improve error handling for list-contributors script
Fix function name for total kredits issued/earned

* Improve error handling for list-contributors script * Fix function name for total kredits issued/earned

bumi (Migrated from github.com) reviewed 2019-04-24 12:49:15 +00:00

scripts/list-contributors.js

bumi (Migrated from github.com) commented

2019-04-24 12:48:59 +00:00

can we add this also in the try {} catch block?
if something fails in this line we would also not see it.

can we add this also in the` try {} catch` block? if something fails in this line we would also not see it.

raucao (Migrated from github.com) reviewed 2019-04-24 12:50:57 +00:00

scripts/list-contributors.js

raucao (Migrated from github.com) commented

2019-04-24 12:50:57 +00:00

Feel free to change it. This is just a drive-by improvement, which already fixed an error on my machine.

bumi (Migrated from github.com) reviewed 2019-04-24 12:57:30 +00:00

scripts/list-contributors.js

bumi (Migrated from github.com) commented

2019-04-24 12:57:29 +00:00

fyi: I generally don't like the need for those try/catch blocks everywhere... need to fix the root of the problem and it must be fixed on the truffle level or (as I mentioned what I am working on) that we don't rely on truffle again..

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#114