kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Improve/fix scripts #114

Merged
raucao merged 3 commits from chore/scripts into master 2019-04-24 12:57:44 +00:00
Conversation 3 Commits 3 Files Changed 2 +17 -18
raucao commented 2019-04-24 12:47:33 +00:00 (Migrated from github.com)
Copy Link
  • Improve error handling for list-contributors script
  • Fix function name for total kredits issued/earned
* Improve error handling for list-contributors script * Fix function name for total kredits issued/earned
bumi (Migrated from github.com) reviewed 2019-04-24 12:49:15 +00:00
scripts/list-contributors.js
bumi (Migrated from github.com) commented 2019-04-24 12:48:59 +00:00
Copy Link

can we add this also in the try {} catch block?
if something fails in this line we would also not see it.

can we add this also in the` try {} catch` block? if something fails in this line we would also not see it.
raucao (Migrated from github.com) reviewed 2019-04-24 12:50:57 +00:00
scripts/list-contributors.js
raucao (Migrated from github.com) commented 2019-04-24 12:50:57 +00:00
Copy Link

Feel free to change it. This is just a drive-by improvement, which already fixed an error on my machine.

Feel free to change it. This is just a drive-by improvement, which already fixed an error on my machine.
bumi (Migrated from github.com) reviewed 2019-04-24 12:57:30 +00:00
scripts/list-contributors.js
bumi (Migrated from github.com) commented 2019-04-24 12:57:29 +00:00
Copy Link

fyi: I generally don't like the need for those try/catch blocks everywhere... need to fix the root of the problem and it must be fixed on the truffle level or (as I mentioned what I am working on) that we don't rely on truffle again..

fyi: I generally don't like the need for those try/catch blocks everywhere... need to fix the root of the problem and it must be fixed on the truffle level or (as I mentioned what I am working on) that we don't rely on truffle again..
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#114
No description provided.
Delete Branch "chore/scripts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?