Add script for vetoing via console #122
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "feature/veto_script"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
utACK
@ -0,0 +23,4 @@}).catch(error => {console.log('Failed to veto contribution');callback(inspect(error));why do we have that inspect here - which we do not have in the other scripts? this turns that error into a string.
Because I've never looked into that callback function details? what does it exactly do? is it better to pass in a string than an error object?
@ -0,0 +23,4 @@}).catch(error => {console.log('Failed to veto contribution');callback(inspect(error));This is copied straight from another script I added the first error handling to, and where it's still present:
https://github.com/67P/kredits-contracts/blob/master/scripts/add-contribution.js#L56
@ -0,0 +23,4 @@}).catch(error => {console.log('Failed to veto contribution');callback(inspect(error));ah I see.
I guess we don't need it and also don't use it everywhere.