Add script for vetoing via console #122

2019-04-28T14:08:28Z

raucao commented

2019-04-28 14:08:28 +00:00

(Migrated from github.com)

No description provided.

bumi (Migrated from github.com) approved these changes

2019-04-28 19:58:35 +00:00

bumi (Migrated from github.com) left a comment

utACK

scripts/veto-contribution.js

						
				@@ -0,0 +23,4 @@

				      })

				      .catch(error => {

				        console.log('Failed to veto contribution');

				        callback(inspect(error));

bumi (Migrated from github.com) commented

2019-04-28 19:58:18 +00:00

why do we have that inspect here - which we do not have in the other scripts? this turns that error into a string.
Because I've never looked into that callback function details? what does it exactly do? is it better to pass in a string than an error object?

why do we have that inspect here - which we do not have in the other scripts? this turns that error into a string. Because I've never looked into that callback function details? what does it exactly do? is it better to pass in a string than an error object?

raucao (Migrated from github.com) reviewed

2019-04-28 20:19:26 +00:00

scripts/veto-contribution.js

						
				@@ -0,0 +23,4 @@

				      })

				      .catch(error => {

				        console.log('Failed to veto contribution');

				        callback(inspect(error));

raucao (Migrated from github.com) commented

2019-04-28 20:19:26 +00:00

This is copied straight from another script I added the first error handling to, and where it's still present:

https://github.com/67P/kredits-contracts/blob/master/scripts/add-contribution.js#L56

This is copied straight from another script I added the first error handling to, and where it's still present: https://github.com/67P/kredits-contracts/blob/master/scripts/add-contribution.js#L56

bumi (Migrated from github.com) reviewed

2019-05-01 18:05:16 +00:00

scripts/veto-contribution.js

						
				@@ -0,0 +23,4 @@

				      })

				      .catch(error => {

				        console.log('Failed to veto contribution');

				        callback(inspect(error));

bumi (Migrated from github.com) commented

2019-05-01 18:05:16 +00:00

ah I see.
I guess we don't need it and also don't use it everywhere.

ah I see. I guess we don't need it and also don't use it everywhere.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#122