kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Correct inter-contract associations #199

Closed
bumi wants to merge 3 commits from correct-contract-associations into master
pull from: correct-contract-associations
merge into: :master
Conversation 3 Commits 3 Files Changed 17
+239 -1062
bumi commented 2020-06-13 17:24:12 +00:00 (Migrated from github.com)
Copy Link
Copy Source

So far our contract discovery was wrong.
https://spectrum.chat/aragon/aragonos/how-do-i-get-the-appid-namehash-of-an-app-in-open-aragonpm-eth~50dd2c67-63a2-49cf-bc64-aa033e33f48d

All dependent contract connections that are needed must be passed in and
can not be discovered from the DAO/Kernel/whatever.

So far I have no idea how we upgrade to these new contracts.

So far our contract discovery was wrong. https://spectrum.chat/aragon/aragonos/how-do-i-get-the-appid-namehash-of-an-app-in-open-aragonpm-eth~50dd2c67-63a2-49cf-bc64-aa033e33f48d All dependent contract connections that are needed must be passed in and can not be discovered from the DAO/Kernel/whatever. So far I have no idea how we upgrade to these new contracts.
bumi commented 2020-09-01 09:00:17 +00:00 (Migrated from github.com)
Copy Link
Copy Source

actually not sure how to best proceed with such a change as I am not sure how that change would affect the deployed contracts or how to deploy those changes.

actually not sure how to best proceed with such a change as I am not sure how that change would affect the deployed contracts or how to deploy those changes.
raucao commented 2020-09-01 09:43:22 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Maybe it's easier to first solve bootstrapping/migrating contracts with existing data? This would both help with changing basic architecture on the way, as well as deploying to different chains and keeping our production data.

Maybe it's easier to first solve bootstrapping/migrating contracts with existing data? This would both help with changing basic architecture on the way, as well as deploying to different chains and keeping our production data.
raucao commented 2021-11-14 22:32:22 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing in favor of #213.

Closing in favor of #213.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#199