kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

More consistent contract parameter naming #24

Merged
bumi merged 9 commits from refactor/naming-conventions into master 2018-04-15 18:24:12 +00:00
Conversation 3 Commits 9 Files Changed 3 +38 -57
bumi commented 2018-04-10 14:27:27 +00:00 (Migrated from github.com)
Copy Link

because we all love consistency.

Please comment and mark lines that you think should have different/more descriptive/consistent naming

because we all love consistency. Please comment and mark lines that you think should have different/more descriptive/consistent naming
fsmanuel (Migrated from github.com) reviewed 2018-04-15 13:25:03 +00:00
fsmanuel (Migrated from github.com) left a comment
Copy Link

I would replace all recipient with contributor.

I would replace all `recipient` with `contributor`.
contracts/Operator.sol
fsmanuel (Migrated from github.com) commented 2018-04-15 13:18:27 +00:00
Copy Link

What about recipientId -> contributorId?

What about `recipientId` -> `contributorId`?
contracts/Operator.sol
fsmanuel (Migrated from github.com) commented 2018-04-15 13:24:04 +00:00
Copy Link

Why the change from contributorId -> voterId?

Why the change from `contributorId` -> `voterId`?
bumi (Migrated from github.com) reviewed 2018-04-15 13:35:11 +00:00
contracts/Operator.sol
bumi (Migrated from github.com) commented 2018-04-15 13:35:11 +00:00
Copy Link

yeah...hmmm.. thought it is more descriptive.. but I see your point.

yeah...hmmm.. thought it is more descriptive.. but I see your point.
bumi (Migrated from github.com) reviewed 2018-04-15 13:40:17 +00:00
contracts/Operator.sol
bumi (Migrated from github.com) commented 2018-04-15 13:40:16 +00:00
Copy Link

In these events we have two different "contributors"
one is the recipient and one is the voter - that's why I'd use voterId and recipientId.
?

In these events we have two different "contributors" one is the recipient and one is the voter - that's why I'd use voterId and recipientId. ?
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#24
No description provided.
Delete Branch "refactor/naming-conventions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?