More consistent contract parameter naming #24

2018-04-10T14:27:27Z

bumi commented

(Migrated from github.com)

because we all love consistency.

Please comment and mark lines that you think should have different/more descriptive/consistent naming

because we all love consistency. Please comment and mark lines that you think should have different/more descriptive/consistent naming

fsmanuel (Migrated from github.com) reviewed 2018-04-15 13:25:03 +00:00

fsmanuel (Migrated from github.com) left a comment

I would replace all recipient with contributor.

I would replace all `recipient` with `contributor`.

fsmanuel (Migrated from github.com) commented

What about recipientId -> contributorId?

What about `recipientId` -> `contributorId`?

fsmanuel (Migrated from github.com) commented

Why the change from contributorId -> voterId?

Why the change from `contributorId` -> `voterId`?

bumi (Migrated from github.com) reviewed 2018-04-15 13:35:11 +00:00

bumi (Migrated from github.com) commented

yeah...hmmm.. thought it is more descriptive.. but I see your point.

bumi (Migrated from github.com) reviewed 2018-04-15 13:40:17 +00:00

bumi (Migrated from github.com) commented

In these events we have two different "contributors"
one is the recipient and one is the voter - that's why I'd use voterId and recipientId.
?

In these events we have two different "contributors" one is the recipient and one is the voter - that's why I'd use voterId and recipientId. ?

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#24