Don't run npm install on bootstrap #86

Merged
raucao merged 1 commits from dev/bootstrap into master 2019-04-09 07:50:52 +00:00
raucao commented 2019-04-09 06:45:56 +00:00 (Migrated from github.com)

When one wants to install, they can install. When one wants to bootstrap, they should be able to only bootstrap.

When one wants to install, they can install. When one wants to bootstrap, they should be able to only bootstrap.
bumi commented 2019-04-09 07:41:42 +00:00 (Migrated from github.com)

we should probably remove the postinstall script also?
@fsmanuel as you have recently done the setup with out much additional explanation, what do you think is the best and easiest setup flow?

we should probably remove the `postinstall` script also? @fsmanuel as you have recently done the setup with out much additional explanation, what do you think is the best and easiest setup flow?
raucao commented 2019-04-09 07:42:48 +00:00 (Migrated from github.com)

Can we merge this first? I have another PR coming for postinstall.

Can we merge this first? I have another PR coming for postinstall.
bumi commented 2019-04-09 07:49:21 +00:00 (Migrated from github.com)

my thoughts when making bootstrap were that this runs once to set everything up.
after that one can use reset:* to get fresh DAOs and seeds to fill it optionally with basic data.

The alternative to manually cd into every directory and install the dependencies would then be to remove the package.json and the need to run npm i in every app?

my thoughts when making `bootstrap` were that this runs once to set everything up. after that one can use `reset:*` to get fresh DAOs and seeds to fill it optionally with basic data. The alternative to manually cd into every directory and install the dependencies would then be to remove the package.json and the need to run `npm i` in every app?
bumi (Migrated from github.com) approved these changes 2019-04-09 07:50:23 +00:00
raucao commented 2019-04-09 07:50:31 +00:00 (Migrated from github.com)

The alternative to manually cd into every directory and install the dependencies would then be to remove the package.json and the need to run npm i in every app?

No, you can simply use a command for that. It doesn't have to be automatic as postinstall.

> The alternative to manually cd into every directory and install the dependencies would then be to remove the package.json and the need to run `npm i` in every app? No, you can simply use a command for that. It doesn't have to be automatic as postinstall.
Sign in to join this conversation.
No description provided.