kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Don't run npm install on bootstrap #86

Merged
raucao merged 1 commits from dev/bootstrap into master 2019-04-09 07:50:52 +00:00
Conversation 5 Commits 1 Files Changed 1
+1 -1
raucao commented 2019-04-09 06:45:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source

When one wants to install, they can install. When one wants to bootstrap, they should be able to only bootstrap.

When one wants to install, they can install. When one wants to bootstrap, they should be able to only bootstrap.
bumi commented 2019-04-09 07:41:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

we should probably remove the postinstall script also?
@fsmanuel as you have recently done the setup with out much additional explanation, what do you think is the best and easiest setup flow?

we should probably remove the `postinstall` script also? @fsmanuel as you have recently done the setup with out much additional explanation, what do you think is the best and easiest setup flow?
raucao commented 2019-04-09 07:42:48 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Can we merge this first? I have another PR coming for postinstall.

Can we merge this first? I have another PR coming for postinstall.
bumi commented 2019-04-09 07:49:21 +00:00 (Migrated from github.com)
Copy Link
Copy Source

my thoughts when making bootstrap were that this runs once to set everything up.
after that one can use reset:* to get fresh DAOs and seeds to fill it optionally with basic data.

The alternative to manually cd into every directory and install the dependencies would then be to remove the package.json and the need to run npm i in every app?

my thoughts when making `bootstrap` were that this runs once to set everything up. after that one can use `reset:*` to get fresh DAOs and seeds to fill it optionally with basic data. The alternative to manually cd into every directory and install the dependencies would then be to remove the package.json and the need to run `npm i` in every app?
bumi (Migrated from github.com) approved these changes 2019-04-09 07:50:23 +00:00
raucao commented 2019-04-09 07:50:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

The alternative to manually cd into every directory and install the dependencies would then be to remove the package.json and the need to run npm i in every app?

No, you can simply use a command for that. It doesn't have to be automatic as postinstall.

> The alternative to manually cd into every directory and install the dependencies would then be to remove the package.json and the need to run `npm i` in every app? No, you can simply use a command for that. It doesn't have to be automatic as postinstall.
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#86