Store kredits tokens as wei with 18 decimals #91
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "feature/store-balance-as-wei"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This stores the tokens with 18 decimals as most other tokens and as
assumed by a potential future token standard EIP 777.
This changes the return value of the balance of contributors which would need to be converted to "ether" in the client.
I think we need more than one letter for a symbol tho.
what do you suggest?
so far it was empty and not used.
I don't think a single person's suggestion is enough to decide this. We need options and ask everyone which one they like best I guess.
we could add a method in the future to update it. so we can leave that right now and deploy, what do you think?
in the UI we don't use that entry anyway. it would be used in wallet apps that display token balances, but those entries are also mostly customizable.
Adding a method vs. just coming up with a decent one now: is there really a difference in time investment?
it is doing nothing now and later adding a method to change the name if we want, or looking for options and asking everyone now. :)
if we like to store the amount as that standard suggests, then we should do that before deploying and not require some data migration later.
Oh, you mean add a method later. Got it.
Then let's just change it to what we have in the Web UI right now: K$ (as in kredits). Or KS without the dollar sign. WDYT?
👍
that's
₭S
?https://github.com/67P/kredits-web/pull/100/files#diff-816a93e6bfad9d8ac961b7e0174dcf7dR8
Oh, right. (Although it may actually be different between that list and the toplist, in which case I'd prefer this one.)