Store kredits tokens as wei with 18 decimals #91

2019-04-10T11:59:59Z

bumi commented

2019-04-10 11:59:59 +00:00

(Migrated from github.com)

This stores the tokens with 18 decimals as most other tokens and as
assumed by a potential future token standard EIP 777.

This changes the return value of the balance of contributors which would need to be converted to "ether" in the client.

This stores the tokens with 18 decimals as most other tokens and as assumed by a potential future token standard EIP 777. This changes the return value of the balance of contributors which would need to be converted to "ether" in the client.

raucao (Migrated from github.com) reviewed 2019-04-10 12:02:51 +00:00

apps/token/contracts/Token.sol

raucao (Migrated from github.com) commented

2019-04-10 12:02:51 +00:00

I think we need more than one letter for a symbol tho.

bumi (Migrated from github.com) reviewed 2019-04-10 12:04:08 +00:00

apps/token/contracts/Token.sol

bumi (Migrated from github.com) commented

2019-04-10 12:04:08 +00:00

what do you suggest?
so far it was empty and not used.

what do you suggest? so far it was empty and not used.

raucao (Migrated from github.com) reviewed 2019-04-10 12:06:40 +00:00

apps/token/contracts/Token.sol

raucao (Migrated from github.com) commented

2019-04-10 12:06:39 +00:00

I don't think a single person's suggestion is enough to decide this. We need options and ask everyone which one they like best I guess.

bumi (Migrated from github.com) reviewed 2019-04-10 12:21:03 +00:00

apps/token/contracts/Token.sol

bumi (Migrated from github.com) commented

2019-04-10 12:21:03 +00:00

we could add a method in the future to update it. so we can leave that right now and deploy, what do you think?
in the UI we don't use that entry anyway. it would be used in wallet apps that display token balances, but those entries are also mostly customizable.

we could add a method in the future to update it. so we can leave that right now and deploy, what do you think? in the UI we don't use that entry anyway. it would be used in wallet apps that display token balances, but those entries are also mostly customizable.

raucao (Migrated from github.com) reviewed 2019-04-10 12:33:23 +00:00

apps/token/contracts/Token.sol

raucao (Migrated from github.com) commented

2019-04-10 12:33:23 +00:00

Adding a method vs. just coming up with a decent one now: is there really a difference in time investment?

bumi (Migrated from github.com) reviewed 2019-04-10 13:18:09 +00:00

apps/token/contracts/Token.sol

bumi (Migrated from github.com) commented

2019-04-10 13:18:08 +00:00

it is doing nothing now and later adding a method to change the name if we want, or looking for options and asking everyone now. :)

if we like to store the amount as that standard suggests, then we should do that before deploying and not require some data migration later.

it is doing nothing now and later adding a method to change the name if we want, or looking for options and asking everyone now. :) if we like to store the amount as that standard suggests, then we should do that before deploying and not require some data migration later.

raucao (Migrated from github.com) reviewed 2019-04-10 13:32:30 +00:00

apps/token/contracts/Token.sol

raucao (Migrated from github.com) commented

2019-04-10 13:32:30 +00:00

Oh, you mean add a method later. Got it.

Then let's just change it to what we have in the Web UI right now: K$ (as in kredits). Or KS without the dollar sign. WDYT?

Oh, you mean add a method later. Got it. Then let's just change it to what we have in the Web UI right now: K$ (as in **k**redit**s**). Or KS without the dollar sign. WDYT?