kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Handle errors in contributor list script #109

Merged
raucao merged 1 commits from dev/list_contributors_error_handling into master 2019-04-19 11:22:39 +00:00
Conversation 3 Commits 1 Files Changed 1 +8 -2
raucao commented 2019-04-19 11:02:59 +00:00 (Migrated from github.com)
Copy Link
No description provided.
bumi commented 2019-04-19 11:22:34 +00:00 (Migrated from github.com)
Copy Link

fyi. errors might happen also in the toString() function.
the general problem needs to be globally addressed - maybe with a truffle update or with removing truffle's web3 in the scripts and only using the wrapper.

fyi. errors might happen also in the `toString()` function. the general problem needs to be globally addressed - maybe with a truffle update or with removing truffle's web3 in the scripts and only using the wrapper.
bumi commented 2019-04-20 00:11:25 +00:00 (Migrated from github.com)
Copy Link

I think I merged this too fast and without actually running the code.
you set the const contributors variable inside a try block, so the variable is not available further down? or am I missing something?

I think I merged this too fast and without actually running the code. you set the `const contributors` variable inside a try block, so the variable is not available further down? or am I missing something?
raucao commented 2019-04-20 07:51:44 +00:00 (Migrated from github.com)
Copy Link

That could be the actual reason why I wasn't able to list contributors anymore. Sorry! 😳

That could be the actual reason why I wasn't able to list contributors anymore. Sorry! :flushed:
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#109
No description provided.
Delete Branch "dev/list_contributors_error_handling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?