Add contract calls for total contribution balances #110
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "feature/contribution-balances"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Those methods return the total kredits amounts of contributions.
Unfortunately, I still cannot test anything locally, because the scripts still hang for me (which looks like ipfs can't get the data, but could be something else, too).Yay, after waiting a while, it finally got the docs this time!
I think this is mixing up "count" and "balance". If it's returning the number of contributions, then it should be "count", but if it's returning the amount of kredits that have been created, then it should be something different. "Balance" also doesn't apply in this case, because that word means an amount per person/account.
Thus, I'd propose to call it something like
totalKreditsAmountortotalKreditsSupplytotalKreditsEarnedor simplytotalKredits.yeah, naming sucks.. especially because the standard method names are misleading.
totalKreditsdoes not work imo because we might sell kredits tokens - thus the tokens could be more than the ones eared.from your ideas I think
totalKreditsEarnedworks best I think?that then would be
totalKreditsEarnedandcontributorTotalKreditsEarned?What's
contributorTotalKreditsEarned? Maybe you meanContributor.totalKreditsEarned?if we were not in a smart contract world then maybe.
but that is a view method on a contract.
we can define a
totalKreditsEarnedon the Contributor wrapper class.Sorry, but I still don't understand what it returns in
Contributionthen.the total numbers of kredits for that contributor.
it counts the kredits of all the contributor's contributions.
OK, thanks. I think the helper function should be in the contributor contract, not the wrapper, but it would at least be necessary as a function in the contribution contract still. Reason being that the contributor contract can then deliver toplists sorted by kredits earned and such. Same for list of core team members etc., saving the client from having to load the entirety of the data every time.
Missing kredits label btw.
try to implement it, you will see that this not possible as you imagine.
also it would again increase the coupling of the two different contracts.
In a normal object oriented world I'd agree, but not in that contract world which also makes it hard to read and work with data. (I also think the smart contracts are not made for that and we would need to do such things rather on a different level).
If it's easy to do like this in the contribution contract, then I don't see why the contributor contract cannot use those functions, as it does for other functions as well. I'm not talking about object orientation at all. Not sure where that's coming from.
But that's not a discussion for this PR anyway.
PRs welcome :)