kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Fix it #123

Closed
bumi wants to merge 1 commits from bugfix/fix-me into master
pull from: bugfix/fix-me
merge into: kredits:master
Conversation 2 Commits 1 Files Changed 4 +17 -2
bumi commented 2019-05-03 21:20:44 +00:00 (Migrated from github.com)
Copy Link

seems we did not test it properly and didn't do a good review :)

seems we did not test it properly and didn't do a good review :)
raucao commented 2019-05-03 23:05:56 +00:00 (Migrated from github.com)
Copy Link

Both the commit title and description as well as the PR title and description don't explain what is being fixed here. Which makes it very hard to review...

Both the commit title and description as well as the PR title and description don't explain what is being fixed here. Which makes it very hard to review...
bumi commented 2019-05-03 23:10:32 +00:00 (Migrated from github.com)
Copy Link

two missing dots: https://github.com/67P/kredits-contracts/pull/124/files

two missing dots: https://github.com/67P/kredits-contracts/pull/124/files

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#123
No description provided.
Delete Branch "bugfix/fix-me"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?