kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Test setup #141

Merged
haythem96 merged 4 commits from setup-tests into master 2019-06-26 15:05:24 +00:00
Conversation 5 Commits 4 Files Changed 10 +6084 -34087
haythem96 commented 2019-06-17 11:15:17 +00:00 (Migrated from github.com)
Copy Link

This PR setup test suite

This PR setup test suite
haythem96 commented 2019-06-17 11:39:54 +00:00 (Migrated from github.com)
Copy Link

should we change the port for the development network to 8545 as ganache-cli.sh script use that port? or just not use that script ?

should we change the port for the development network to `8545` as `ganache-cli.sh` script use that port? or just not use that script ?
bumi commented 2019-06-17 22:05:50 +00:00 (Migrated from github.com)
Copy Link

we intentionally used a different port than the production RPC port.
is this the ganache-cli.sh script? cb9b20c144/shared/test-helpers/ganache-cli.sh (L17)

so the port is configurable as environment variable? and defaults to 8555?

we intentionally used a different port than the production RPC port. is this the ganache-cli.sh script? https://github.com/aragon/aragon-apps/blob/cb9b20c144a5670c8ee3e4bf1f0898897a8de35f/shared/test-helpers/ganache-cli.sh#L17 so the port is configurable as environment variable? and defaults to 8555?
👍 1
haythem96 commented 2019-06-17 22:29:03 +00:00 (Migrated from github.com)
Copy Link

@bumi cool! didn't check that the port is configurable...
the default port is 8545 cb9b20c144/shared/test-helpers/ganache-cli.sh (L24) as 8555 when running coverage

@bumi cool! didn't check that the port is configurable... the default port is 8545 https://github.com/aragon/aragon-apps/blob/cb9b20c144a5670c8ee3e4bf1f0898897a8de35f/shared/test-helpers/ganache-cli.sh#L24 as 8555 when running coverage
haythem96 commented 2019-06-18 17:15:10 +00:00 (Migrated from github.com)
Copy Link

can we merge this one ?

can we merge this one ?
bumi commented 2019-06-19 12:16:16 +00:00 (Migrated from github.com)
Copy Link

yes, looks good to me. sadly we have that merge conflict in the package-lock files because of the recent aragon update. maybe you can rebase this on master again?

yes, looks good to me. sadly we have that merge conflict in the package-lock files because of the recent aragon update. maybe you can rebase this on master again?
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#141
No description provided.
Delete Branch "setup-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?