kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Fix package script command deploy:kit #160

Merged
fsmanuel merged 1 commits from bugfix/packages-install-scripts into master 2019-08-04 17:42:43 +00:00
Conversation 8 Commits 1 Files Changed 1 +1 -1
fsmanuel commented 2019-08-04 17:38:32 +00:00 (Migrated from github.com)
Copy Link
No description provided.
bumi (Migrated from github.com) reviewed 2019-08-05 07:45:06 +00:00
package.json
@ -18,3 +18,3 @@
"reset:hard": "npm run deploy:apps && npm run reset",
"deploy:kit": "npm run compile-contracts && aragon contracts exec scripts/deploy-kit.js",
"deploy:kit": "aragon contracts exec scripts/deploy-kit.js",
"deploy:dao": "aragon contracts exec scripts/new-dao.js",
bumi (Migrated from github.com) commented 2019-08-05 07:44:59 +00:00
Copy Link

what was actually broken? are the contracts still compiled?

what was actually broken? are the contracts still compiled?
raucao (Migrated from github.com) reviewed 2019-08-05 08:54:44 +00:00
package.json
@ -18,3 +18,3 @@
"reset:hard": "npm run deploy:apps && npm run reset",
"deploy:kit": "npm run compile-contracts && aragon contracts exec scripts/deploy-kit.js",
"deploy:kit": "aragon contracts exec scripts/deploy-kit.js",
"deploy:dao": "aragon contracts exec scripts/new-dao.js",
raucao (Migrated from github.com) commented 2019-08-05 08:54:44 +00:00
Copy Link
  • The command fails both on @fsmanuel's an my machine.
  • Compiling the contracts isn't the same as deploying something.
  • In the bootstrap, the contracts are compiled before this step.
* The command fails both on @fsmanuel's an my machine. * Compiling the contracts isn't the same as deploying something. * In the bootstrap, the contracts are compiled before this step.
bumi (Migrated from github.com) reviewed 2019-08-05 08:58:01 +00:00
package.json
@ -18,3 +18,3 @@
"reset:hard": "npm run deploy:apps && npm run reset",
"deploy:kit": "npm run compile-contracts && aragon contracts exec scripts/deploy-kit.js",
"deploy:kit": "aragon contracts exec scripts/deploy-kit.js",
"deploy:dao": "aragon contracts exec scripts/new-dao.js",
bumi (Migrated from github.com) commented 2019-08-05 08:58:01 +00:00
Copy Link

ok, but then we need to fix the compile-contracts command?

at which step are the contracts compiled?

ok, but then we need to fix the `compile-contracts` command? at which step are the contracts compiled?
raucao (Migrated from github.com) reviewed 2019-08-05 09:28:18 +00:00
package.json
@ -18,3 +18,3 @@
"reset:hard": "npm run deploy:apps && npm run reset",
"deploy:kit": "npm run compile-contracts && aragon contracts exec scripts/deploy-kit.js",
"deploy:kit": "aragon contracts exec scripts/deploy-kit.js",
"deploy:dao": "aragon contracts exec scripts/new-dao.js",
raucao (Migrated from github.com) commented 2019-08-05 09:28:18 +00:00
Copy Link

I guess so. Frankly, I don't know what is needed and what isn't, but this one was consistently failing and nobody fixed it. So this change is more of a hotfix to get the bootstrap to work, because most people don't change the kit contract or other such contracts.

I guess so. Frankly, I don't know what is needed and what isn't, but this one was consistently failing and nobody fixed it. So this change is more of a hotfix to get the bootstrap to work, because most people don't change the kit contract or other such contracts.
bumi (Migrated from github.com) reviewed 2019-08-05 09:42:20 +00:00
package.json
@ -18,3 +18,3 @@
"reset:hard": "npm run deploy:apps && npm run reset",
"deploy:kit": "npm run compile-contracts && aragon contracts exec scripts/deploy-kit.js",
"deploy:kit": "aragon contracts exec scripts/deploy-kit.js",
"deploy:dao": "aragon contracts exec scripts/new-dao.js",
bumi (Migrated from github.com) commented 2019-08-05 09:42:19 +00:00
Copy Link

is there an issue for that? compile-contracts works fine for me (just tested it again)
even though people won't change the kit, I assumed the kit still needs to be compiled to run the deploy script.

is there an issue for that? `compile-contracts` works fine for me (just tested it again) even though people won't change the kit, I assumed the kit still needs to be compiled to run the deploy script.
bumi (Migrated from github.com) reviewed 2019-08-05 09:44:46 +00:00
package.json
@ -18,3 +18,3 @@
"reset:hard": "npm run deploy:apps && npm run reset",
"deploy:kit": "npm run compile-contracts && aragon contracts exec scripts/deploy-kit.js",
"deploy:kit": "aragon contracts exec scripts/deploy-kit.js",
"deploy:dao": "aragon contracts exec scripts/new-dao.js",
bumi (Migrated from github.com) commented 2019-08-05 09:44:46 +00:00
Copy Link

if you have a fresh clone (without the build directory) you'll now get a:
Error: ENOENT: no such file or directory, scandir '[...]/build/contracts' error.
so contracts need to be deployed, it probably works for you now because you had deployed contracts in the build directory.

I can not reproduce any compile error here. :(

if you have a fresh clone (without the `build` directory) you'll now get a: `Error: ENOENT: no such file or directory, scandir '[...]/build/contracts'` error. so contracts need to be deployed, it probably works for you now because you had deployed contracts in the `build` directory. I can not reproduce any compile error here. :(
raucao (Migrated from github.com) reviewed 2019-08-05 10:49:43 +00:00
package.json
@ -18,3 +18,3 @@
"reset:hard": "npm run deploy:apps && npm run reset",
"deploy:kit": "npm run compile-contracts && aragon contracts exec scripts/deploy-kit.js",
"deploy:kit": "aragon contracts exec scripts/deploy-kit.js",
"deploy:dao": "aragon contracts exec scripts/new-dao.js",
raucao (Migrated from github.com) commented 2019-08-05 10:49:43 +00:00
Copy Link

I can not reproduce any compile error here. :(

Then we need to add the complete install and bootstrap on Travis, because @fsmanuel and I both have the same compilation errors on two different operating systems with different environments.

> I can not reproduce any compile error here. :( Then we need to add the complete install and bootstrap on Travis, because @fsmanuel and I both have the same compilation errors on two different operating systems with different environments.
bumi (Migrated from github.com) reviewed 2019-08-05 13:28:36 +00:00
package.json
@ -18,3 +18,3 @@
"reset:hard": "npm run deploy:apps && npm run reset",
"deploy:kit": "npm run compile-contracts && aragon contracts exec scripts/deploy-kit.js",
"deploy:kit": "aragon contracts exec scripts/deploy-kit.js",
"deploy:dao": "aragon contracts exec scripts/new-dao.js",
bumi (Migrated from github.com) commented 2019-08-05 13:28:36 +00:00
Copy Link

good idea. can you create an issue with the error you've seen? thanks

good idea. can you create an issue with the error you've seen? thanks
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#160
No description provided.
Delete Branch "bugfix/packages-install-scripts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?